Christian Hopps
cfa0facbf9
mgmtd: fully implement debug flags for mgmtd and clients
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-05-01 13:47:12 -04:00
Donatas Abraitis
13c426150f
Merge pull request #13368 from Keelan10/nhrpd-memory-leak
...
nhrpd: Fix nhrpd memory leak
2023-04-26 08:57:52 +03:00
Mark Stapp
b38aed324d
Merge pull request #13374 from opensourcerouting/build-fix-rmap-yang
...
build: fix frr-if-rmap.yang model embedding
2023-04-25 15:26:19 -04:00
Russ White
257fddaeb6
Merge pull request #13246 from opensourcerouting/rip-bfd
...
ripd: support BFD integration
2023-04-25 11:54:32 -04:00
Russ White
0ed5c87cfe
Merge pull request #13326 from opensourcerouting/feature/rip_topotest_distribute_list
...
ripd: Create non default passive interface if defined so
2023-04-25 11:07:31 -04:00
Russ White
4855ca5e56
Merge pull request #13310 from opensourcerouting/feature/bgpd_node_target_extended_community
...
bgpd: Add Node Target Extended Communities support
2023-04-25 11:06:23 -04:00
Donald Sharp
3ba6373eef
Merge pull request #13375 from LabNConsulting/chopps/fix-style-issues
...
lib: fix style warns and get rid of "!" for success
2023-04-25 07:28:46 -04:00
Donald Sharp
6ff098088b
Merge pull request #13373 from LabNConsulting/chopps/fix-pytestconfig
...
fix missed passing pytestconfig arg.
2023-04-24 18:02:49 -04:00
Christian Hopps
7f6b20074f
lib: fix style warns and get rid of "!" for success
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-24 11:20:48 -04:00
David Lamparter
edaee5461d
build: fix frr-if-rmap.yang model embedding
...
This was missed somewhere along the line, causing ripd to not start.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-04-24 17:02:34 +02:00
Christian Hopps
9b96394d05
Merge pull request #13149 from pushpasis/mgmt_cleanup_zlog
...
mgmtd, lib: Cleanup zlog_err()
2023-04-24 11:00:08 -04:00
Donatas Abraitis
76cd90fb4e
Merge pull request #13330 from chiragshah6/fdev1
...
zebra: EVPN handle duplicate detected local mac delete event
2023-04-24 16:51:10 +03:00
Christian Hopps
1a68b13867
tests: fix missed passing pytestconfig arg
...
Remove the local ConfigOptionProxy and actually use the munet one.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-24 09:48:26 -04:00
Christian Hopps
7d12017bd8
tests: import munet 0.13.2
...
fixed ConfigOptionsProxy bug
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-24 09:48:26 -04:00
Donald Sharp
ea4163ce49
Merge pull request #13365 from LabNConsulting/chopps/add-perf-option
...
Add ability to profile daemons in topotest with --perf
2023-04-24 07:38:45 -04:00
Donatas Abraitis
766fcb6056
Merge pull request #13361 from LabNConsulting/chopps/munet-cfgopt-and-native
...
cfgopt in munet and native config support and example
2023-04-24 13:50:36 +03:00
Keelan10
e15ca73e5a
nhrpd: Fix nhrpd memory leak
...
Free NHRP peers associated with an interface when NHS is deleted on shutdown
Signed-off-by: Keelan Cannoo <keelan.cannoo@icloud.com>
2023-04-24 11:18:39 +04:00
Christian Hopps
a3e8e1aacb
doc: document --perf and --perf-options, and a bit of cleanup
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 21:56:38 -04:00
Christian Hopps
e6079f4fa4
tests: add --perf and --perf-options for profiling daemons
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 21:53:44 -04:00
Donald Sharp
3eefea9249
Merge pull request #13350 from opensourcerouting/typesafe-fixes-20230421
...
lib: typesafe shenanigans
2023-04-23 15:06:59 -04:00
Christian Hopps
a929d94ff5
tests: add an example of using munet native config
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 15:02:46 -04:00
Christian Hopps
0def198cd3
tests: enable using munet native configs
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 09:52:39 -04:00
Christian Hopps
d9de3cc48b
tests: munet now supports cfgopt directly
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 09:52:39 -04:00
Christian Hopps
67afd9293d
tests: import munet version 0.13.1
...
- adds more generic config option handling than pytestconfig
- Change to search order for kinds.yaml
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 09:51:46 -04:00
Donald Sharp
97ed21a546
Merge pull request #13358 from zmw12306/ignore_nonzero_flags
2023-04-23 07:25:30 -04:00
Donald Sharp
51108db198
Merge pull request #13360 from LabNConsulting/chopps/munet-fixes
2023-04-23 07:18:07 -04:00
Christian Hopps
9001ae5a67
tests: import munet version 0.12.16
...
Fixes bad fixed path use and rootcmd functionality to run things
in the root namespace (all but pid at least).
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-23 01:29:49 -04:00
Donald Sharp
2da3174115
Merge pull request #13332 from LabNConsulting/chopps/new-opts
2023-04-22 19:51:05 -04:00
zmw12306
673f1d4d57
babeld: ignore nonzero flag bits in Hello TLVs
...
Ignore all other bits(except U) in Hello TLVs, according to RFC8966
Signed-off-by: zmw12306 <zmw12306@gmail.com>
2023-04-22 15:11:13 -04:00
Christian Hopps
c45ef001ab
doc: document new pytest options and cli commands
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-22 13:10:52 -04:00
Christian Hopps
c510a9e451
munet: import 0.12.15
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-22 13:10:52 -04:00
Christian Hopps
449e25552b
tests: fix ASAN file cleanup and --asan-abort option
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-22 13:10:52 -04:00
Donald Sharp
f662a4194d
Merge pull request #13349 from opensourcerouting/pim6-mld-coverity-20230421
...
pimd: address some static analysis complaints
2023-04-22 11:02:51 -04:00
Christian Hopps
346374b04f
tests: will need new pid_exists if using pid namespaces
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:13:04 -04:00
Christian Hopps
2b62abe441
tests: restore per-node logging functionality
...
After the munet switch we weren't passing the logger on to low-level
LinuxNamespace and thus Commander parent classes, so the lowest-level
`cmd_status` logs were missing from more specific log files in the run
directory.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:54 -04:00
Christian Hopps
260268c45c
tests: fix check for daemon startup, remove sleep hack
...
- Remove the .pid and .vty files and then wait for them to show back up.
- Fix broken BGP GR test to not fail now that it's bug is exposed. It
only worked b/c when starting a daemon the pid file still existed and
blocked the bogus second BGP launch from happening.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:54 -04:00
Christian Hopps
ff28990ee4
tests: add --logd option
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:54 -04:00
Christian Hopps
773fd82ed5
tests: add --pcap and --pause-at-end options
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:54 -04:00
Christian Hopps
249ac6f0f2
tests: cleanup access to pytest config
...
Rather than create a new global dict and copy all the config into it, just
expose the pytest config globally and use it directly.
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:54 -04:00
Christian Hopps
7592b2ccae
tests: blacken re-format
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-04-21 22:10:48 -04:00
David Lamparter
c53ab57b79
Merge pull request #13347 from donaldsharp/bgp_before_light
2023-04-21 18:23:17 +02:00
David Lamparter
3c034cb342
Merge pull request #13345 from donaldsharp/pim_after_dark
2023-04-21 18:22:39 +02:00
David Lamparter
6cfef15385
Merge pull request #13348 from donaldsharp/dplane_before_after
2023-04-21 18:22:22 +02:00
David Lamparter
5523a505f4
lib: fix _hash_member() crash w/ empty hash
...
The typesafe hash _member() didn't check tabshift/count before
proceeding to look at the hash table, leading it to dereference a NULL
pointer when the hash table is in fact empty.
Test case added to tests/lib/test_typelist.
Note this function is not currently used anywhere. Only lib/cspf.c uses
_member(), but it does so on a RB-tree rather than a hash.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-04-21 16:30:32 +02:00
David Lamparter
ae19023b8e
lib: typesafe hash table breadcrumbs
...
Looking at the coverity report, it complains that tabshift could be
zero, resulting in a uint32_t shifted by 33 (which is undefined.)
As I was confused by the "+ 1", in addition to the SA assume(), leave
some breadcumbs for next time this comes up.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-04-21 16:27:21 +02:00
Donald Sharp
de35b3c29a
Merge pull request #13327 from opensourcerouting/fix/rip_status_align
...
ripd: Align show ip rip status output for sources
2023-04-21 09:41:00 -04:00
David Lamparter
54c037a187
pimd: annotate some pointers as non-null
...
... make static analysis happy.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-04-21 15:30:43 +02:00
David Lamparter
ac4304d0fa
pimd: harden MLD code loop boundaries
...
Coverity complains about these being tainted/untrusted loop boundaries.
The way the code works, it's counting up groups/sources, but keeps
checking against remaining data length in the packet - which is
perfectly fine IMHO. Except Coverity doesn't understand it :(
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-04-21 15:30:43 +02:00
Donald Sharp
a7209c2dbc
lib: Make coverity happy about close
...
The error condition handled both failure to open
and a fstat failure. Just double check that the close
is appropriate to call.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-04-21 09:12:08 -04:00
Donald Sharp
6f99cfcd89
zebra: ctx has to be non NULL at this point
...
Remove the pointer check for ctx. At this point in the
function it has to be non null since we deref'ed it.
Additionally the alloc function that creates it cannot
fail.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-04-21 08:54:51 -04:00