proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 00:42:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
8,292 Commits 4 Branches 191 Tags 125 MiB
c7d3895eb1
Commit Graph

8292 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
05a38c0c8b bgpd: Fix nexthop comparison for v6 
When we have both a LL and a Global address,
use what the attribute wants for comparison
instead of assuming Global than LL.

This was causing BGP to install v6 routes
that used the LL as the nexthop, where
the global address was different and
being used as the basis for comparison.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-26 14:18:30 -04:00
Donald Sharp
647450524c bgpd: Set the ifindex to DELETED after we notify zebra 
The code path for a deleted interface was calling
zebra with a IFINDEX_DELETED, which caused zebra
to bitch and moan about the issue.  Since the
only thing this function does is call zebra
to deregister the RA stuff, don't set the
ifindex to DELETED till afterwords.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-26 14:17:35 -04:00
Daniel Walton
6f4d6a15a9 Merge branch 'master' of https://github.com/dwalton76/frr into zebra-debug-packet-detail 
Conflicts:
	zebra/debug.c
 2017-07-26 18:17:33 +00:00
Daniel Walton
8eeb033552 bgpd: attribute-unchanged issues with peer-groups 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-26 17:49:20 +00:00
Daniel Walton
e386c1d575 bgpd: UPDATE may be larger than 4096 if addpath is used 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-26 16:33:39 +00:00
David Lamparter
0d510865ec Merge pull request #842 from qlyoung/update-style-guide 
Update COMMUNITY.md
 2017-07-26 18:20:17 +02:00
Brian Rak
bf0526b919 redhat: Update documentation about frr-reload 2017-07-26 11:47:07 -04:00
Renato Westphal
163076686e bgpd/ospfd: fix json leaks and blank output 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 12:28:56 -03:00
Renato Westphal
66a43eb221 babeld: remove redundant startup message 
The frr_run() function already logs a startup message (and after reading
the config so the "log" commands are honored).

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 11:54:52 -03:00
Renato Westphal
dd8765cad5 babel: fix crashes and improve the redistribute command 
Fixes the following crashes:
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute pim"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute eigrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute nhrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute table"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute vnc"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute pim"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute eigrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute nhrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute table"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute vnc"

While here, add an option to chose if we want to redistribute IPv4 or
IPv6 routes (e.g. we might want static IPv4 routes only). Also, join the
"no" version of the command in the same DEFUN (Yes We Can).

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 11:51:44 -03:00
Renato Westphal
493c8ac787 eigrpd: minor fix in the redistribute command 
Commands like "redistribute stati" and "redistribute osp" were being
silently ignored.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 11:51:00 -03:00
Daniel Walton
1ac79ce8df zebra: static route cleanup 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

- The 'reject' keyword was being lost
- Hide the "ip route A.B.C.D A.B.C.D" config options since these will be
  displayed as "ip route A.B.C.D/X"
 2017-07-25 13:24:45 -07:00
Quentin Young
f1423462b1
COMMUNITY.md: rewrap paragraphs, update PR section 
* Wrap paragraphs at 80 lines
* Update Github PR section to remove mention of develop branch

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:53:05 -04:00
Brian Rak
651db60ff4 redhat: Make the init script flush routes for all associated protocols on stop 2017-07-25 15:51:30 -04:00
Quentin Young
4b8ac525ff COMMUNITY.md: minor grammatical fixes 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:46:00 -04:00
Quentin Young
a03e352668 COMMUNITY.md: document documentation 
Add guidelines for documentation to COMMUNITY.md

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:45:55 -04:00
Quentin Young
b0ff7312a4 COMMUNITY.md: miscellaneous documentation 
Also:
- Add documentation on mailing list
- Update mentions of unit tests
- Update process description

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:37:21 -04:00
Quentin Young
c545559d4a COMMUNITY.md: s/PROJECT/FRRouting 
Also:
* Make headers consistently capitalized
* Some extra backticks where needed

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:37:21 -04:00
Quentin Young
6058ea8cb1 COMMUNITY.md: update style guide 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-25 15:37:21 -04:00
Daniel Walton
ba9d46ff14 zebra: debug cleanup 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-25 12:07:07 -07:00
Donald Sharp
9fb302f41d pimd: Setup hash names appropriately 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-25 14:22:15 -04:00
Donald Sharp
7c59195031 pimd: NHT upstream list is inefficient 
The NHT upstream list at scale is horribly inefficient due to keeping
a sorted list of upstream entries.  The attempting to find
the upstream and the insertion of it into the upstream_list
was consuming a large amount of cpu cycles.

Convert to a hash, allow add/deletions to effectively become
O(1) events.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-25 14:18:57 -04:00
Donald Sharp
6e1ef388f3 pimd: Clean PNC cache handling on shutdown 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-25 14:18:57 -04:00
Renato Westphal
9b86009a38 bgpd/eigrpd: fix crashes found by the CLI fuzzer 
Fixes the following crashes:
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1 json"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1 json"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 2001:db8::1/128 json"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 2001:db8::1/128 json"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show vnc responses 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show vnc responses 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show vnc responses 11:11:11:11:11:11"
* bgpd aborted: vtysh  -c "show vnc responses"
* eigrpd aborted: vtysh -c "configure terminal" -c "no router eigrp 65535"

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-25 13:58:23 -03:00
Donald Sharp
c6413dd394 Merge pull request #848 from opensourcerouting/rb-tree-fix 
Fix corrupted RB trees
 2017-07-25 11:11:33 -04:00
David Lamparter
d5eb795965 Merge pull request #847 from donaldsharp/cmd_success 
Cmd success
 2017-07-25 16:23:48 +02:00
David Lamparter
4ff218ac39 Merge pull request #838 from dwalton76/lib-copy-nexthops 
lib: copy_nexthops() only copies the first nexthop
 2017-07-25 16:20:08 +02:00
David Lamparter
533450e4b9 Merge pull request #837 from qlyoung/fix-eigrp-routemap-cli 
eigrpd, vtysh: add dummy route-map cli
 2017-07-25 16:15:54 +02:00
David Lamparter
c8ac4457c0 Merge pull request #836 from dwalton76/zebra-debug-packet-send-detail 
zebra: "debug zebra packet" config display
 2017-07-25 16:01:40 +02:00
Donald Sharp
f5da2cc2d8 pimd: Use JSON_STR 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-25 08:19:57 -04:00
Renato Westphal
145b205177 lib: fix corrupted RB trees 
Commit 8f942af90 introduced a bug while silencing a clang warning. Silence
the warning in a different way to fix our red-black tree implementation.

Fixes #841.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-24 18:50:45 -03:00
Renato Westphal
52535beec1 lib: revert reindent of files imported from OpenBSD 
We should preserve the original indentation to make it easier to keep
these files in sync with the upstream.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-24 18:40:24 -03:00
Donald Sharp
9c9d843baa ripd: Fix debug config failures 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 16:00:20 -04:00
Donald Sharp
40e344cc4b ripngd: Fix failure returned with some debug commands 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 15:59:36 -04:00
Donald Sharp
d5c5e362b2 pimd: Warn to stderr in failure case for test_igmpv3_join 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:57:51 -04:00
Donald Sharp
467c85f730 pimd: Cleanup unused assignment 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
bd4d05c577 pimd: Fix missing docstring in 'no debug pim trace detail' 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
49fde801fa pimd: Fix linux build on older kernels 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
1b5f8a1a21 pimd: Stop looking when we find a matching nexthop 
When we receive a new ecmp path and the old nexthop is still
valid.  There existed some cases where we would continue looking
for a nexthop( and thus loose the fact that we had found it )
after found.

Ticket: CM-16983
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
aabb9a2f07 pimd: Allow installation of NULL mroute in some situations 
When we receive a S,G,RPT prune as part of a *,G tree, install
the NULL oil S,G mroute.  This will cause the traffic to stop
flowing for this particular S,G as we expect.

Ticket: CM-16978
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
5c3aac90d9 pimd: Fix 'show ip mroute vrf all count' crash 
'show ip mroute vrf all count' crashes currently

This commit fixes that issue

Ticket: CM-17052
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
bd8b9272b4 zebra: Convert get_stats to use new kernel interface 
Convert the XXX_get_stats functions to use the new
kernel interface.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:57 -04:00
Donald Sharp
a25de56b58 pimd: Add 'vrf all' commands where needed 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:52:55 -04:00
Donald Sharp
74d1799ae6 pimd: Fix unininitialized data usage found by clang 
clang 5.0 to the rescue!

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
d3a551b952 pimd: Fix pim not recognizing itself as an RP in some cases 
During normal course of operations, zebra sends the ZEBRA_INTERFACE_VRF_UPDATE
call up into all connected zclients.  In the case of PIM the
zlookup was expecting a min length of 10, but ZEBRA_INTERFACE_VRF_UPDATE
was sending of size 6.  This min length check makes no sense,
so just remove.

Ticket: CM-16976
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
5cef40fcb7 pimd: Fixup NHT debugging to be a bit more coherent 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
40f1f31be6 pimd: Add debug pim nht command 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
862756ff85 pimd: Ensure that we properly shutdown threads on start failure 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
64c8653095 pimd: Put 'struct pim_instance *' as the first function parameter 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:41 -04:00
Donald Sharp
1e7a3a2a53 pimd: Fix some small crashes in pim 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 13:51:40 -04:00