Kaushik
35769de430
ospf6d: support for nssa in ospfv3
...
Fix for the routes which is not classified as best routes.
Signed-off-by: Kaushik <kaushiknath.null@gmail.com>
2021-06-04 07:23:10 -03:00
Kaushik
ad500b22b5
ospf6d: Support for nssa in ospfv3
...
The following is implemented.
1. Configuring area as NSSA.
2. Generating Type 7 LSA.
3. Conversion of Type 7 to Type 5 ( Default Behavior).
4. NSSA ABR selection.
Reviewed-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Co-authored-by: Kaushik <kaushiknath.null@gmail.com>
Co-authored-by: Soman K.S <somanks@gmail.com>
Signed-off-by: Kaushik <kaushiknath.null@gmail.com>
2021-06-04 07:23:10 -03:00
Igor Ryzhov
10ddcc321a
Merge pull request #8776 from anlancs/fix-ospf-cli-passive-interface
...
ospfd: remove ospf interface config: passive-interface
2021-06-04 11:06:51 +03:00
Quentin Young
d6ba203d2f
doc: use add_css_file(); not deprecated
...
add_stylesheet() is deprecated and removed in Sphinx 4.x
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2021-06-03 16:32:00 -04:00
Quentin Young
826186eab2
doc: add requirements.txt
...
Add a minimum sphinx version requirement for the docs; RTD needs this to
know what version of sphinx to install.
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2021-06-03 13:35:34 -04:00
Renato Westphal
0940d2bddc
Merge pull request #8771 from volta-networks/fix_pathd_bandwidth
...
pathd: fix render candidate-path bandwidth
2021-06-03 11:33:56 -03:00
anlancs
1113a2fb27
ospfd: if destroy the whole ospf, then remove ospf's interface config: passive-interface
...
Signed-off-by: anlancs <anlan_cs@tom.com>
2021-06-03 13:06:34 +08:00
Igor Ryzhov
cc2a89dba0
doc: remove varnames from command descriptions
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-03 02:19:36 +03:00
Igor Ryzhov
5b96d81c86
lib: fix output of "list" and "find" commands
...
Currently, we output the command exactly how it is defined in DEFUN.
We shouldn't output varnames and excessive whitespace.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-03 02:03:20 +03:00
Igor Ryzhov
c22789620d
lib, vtysh: reduce code duplication
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-03 02:03:15 +03:00
Donald Sharp
d64162ce84
Merge pull request #8210 from LabNConsulting/chopps/always-batch
...
northbound: KISS always batch yang config, it's faster.
2021-06-02 18:13:42 -04:00
Igor Ryzhov
03e3333b11
bfdd: fix bfd key structure
...
There's a padding byte between "mhop" and "peer" fields in this structure.
This structure is sometimes passed by value to functions and used in
assignments. The standard doesn't guarantee that the padding bytes are
copied on assignments. As this structure is used as a hash key, having
this padding byte with unspecified value can lead to unwanted behavior.
Fix the possible issue by making the "mhop" field to be 2 bytes. Also
make the struct packed as a precaution for future changes.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-02 20:58:35 +03:00
Igor Ryzhov
a090c2dab9
doc: add separate section for nexthop tracking
...
"ip nht resolve-via-default" is currently placed in "Link Parameters
Commands" section. Add a separate section and missing IPv6 counterpart.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-02 17:52:26 +03:00
Igor Ryzhov
e33dbe08bd
doc: fix link-params commands
...
Remove redundant prefix.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-02 17:52:26 +03:00
Hiroki Shirokura
2ba6be5b24
bgpd,sharpd,zebra: fix code style
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
c60c1ade86
*: delete ZEBRA_FLAG_SEG6*_ROUTE and add ZAPI_NEXTHOP_FLAG_SEG6*
...
https://github.com/FRRouting/frr/pull/5865#discussion_r597670225
As this comment says. ZEBRA_FLAG_XXX should not have been used.
To communicate SRv6 Route Information. A simple Nexthop Flag would
have been sufficient for SRv6 information. And I fixed the whole
thing that way.
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
0a543b7929
zebra: early return on seg6local nlmsg crafting
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
eab0f8f0a2
lib,sharpd,zebra: update nexthop object with nh_srv6
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
4ccd40339c
doc: update srv6 cli guide
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
e2a5888d7c
tests: update sharpd srv6 route command
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
1cb131eec3
sharpd: split srv6 route install command
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
f463eac768
zebra: fill_seg6ipt_encap func with boundary check
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
a2df1e4f9a
sharpd: follow the practice on cli design for json output
...
The "show sharp segment-routing srv6" command was a
json output command, but it did not follow the common
practice of the other commands.
It follows the review and outputs the json format by
using the json keyword. Otherwise, it produces human
readable output.
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
52026569ca
zebra: error check for nl_attr_xxx
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
8a18a7c0c9
zebra: use const on fill_seg6ipt_encap func
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
b9596f139b
zebra: fix implicit conversion
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
0548592691
*: eliminate redundant info from srv6 locator zapi
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
04d43dbd02
tests: fix json style on srv6_locator test
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
7b778857f8
zebra: drop un-needed info in locator-zapi
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
a9510347aa
zebra: delete unneeded zebra_srv6_manager_connect
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
4c6a567d72
lib: erase wrong comments by copy-paste
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
8dcb27e6d9
lib: eliminate odd line-break
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
fbaa42f744
lib: integrate srv6-nexthop-cmp functions
...
I agree with the PR review from mstap and merged
the following two functions into one.
- zapi_nexthop_seg6_cmp
- zapi_nexthop_seg6local_cmp
[note]
If both of them have more complex extensions in the future,
I think it will be less confusing to remove the integration
of these functions and make them as separate functions as
before.
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
1bda3e627d
*: use one line init instead of memset and format it
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
326591dcdb
lib: fix json style to camel-case instead of underscores
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
9f900cda30
zebra: fix typo
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
90dbd3b85c
bgpd: fix build error for NetBSD8
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
1d5f59a235
zebra: fix Dereference of null pointer
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
f29aed7480
*: fix code format accourding to checkpatch
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
7f8c7d9166
bgpd: ignore nexthop validation for srv6-vpn
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
3a0220e46a
bgpd: use zapi_srv6_locator_chunk_decode
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
ac6a9479af
zebra: add zapi_srv6_locator_chunk_{en,de}code
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
6e9e223327
doc: fix srv6 section according to review
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
537b608a3d
bgpd: fix vrf route-leaking crash around srv6
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
96db4340b7
bgpd: fix compile error for BSD platforms
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
361a62ac9d
zebra: fix compile error of missing-braces
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
124f7236fb
bgpd: fix crash when bgp_delete found by unit-test
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
daedb8b3cf
zebra: rewrite locator_prefix_cmd with DEFPY
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
7de4c88525
*: fix code format accourding to checkpatch
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00
Hiroki Shirokura
7c653fc53e
topotests: bgp_srv6l3vpn_to_bgp_vrf (step4)
...
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-06-02 10:24:48 -04:00