proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-03 21:50:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,876 Commits 4 Branches 191 Tags 114 MiB
c29e9d23bf
Commit Graph

2739 Commits

Author SHA1 Message Date
Russ White
11f13d2333
Merge pull request #2578 from pacovn/Coverity_1453455_Dereference_null_return_value 
bgpd: null check (Coverity 1453455)
 2018-06-29 13:28:28 -04:00
Russ White
33bce37947
Merge pull request #2573 from pacovn/Coverity_23065_Explicit_null_dereferenced 
bgpd: null check (Coverity 23065)
 2018-06-29 13:27:04 -04:00
Donald Sharp
798ad23151
Merge pull request #2575 from pacovn/Coverity_1399219_Copy-paste_error 
bgpd: copy-paste error (Coverity 1399219)
 2018-06-29 11:17:52 -04:00
F. Aragon
0866cdaf3e
bgpd: null check (Coverity 1453455) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 11:03:06 +02:00
paco
d4f8b53750
bgpd: null check (Coverity 23065) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 10:48:31 +02:00
Quentin Young
d55c2456e8
Merge pull request #2576 from pacovn/Coverity_1399228_Logically_dead_code 
bgpd: dead code (Coverity 1399228)
 2018-06-28 12:55:25 -04:00
paco
b684aedac8
bgpd: dead code (Coverity 1399228) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:56:29 +02:00
paco
f86285ffef
bgpd: copy-paste error (Coverity 1399219) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:39:59 +02:00
paco
da3b87f8b0
bgpd: return value (Coverity 1399203) 
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 12:41:52 +02:00
Russ White
4bca4c6f0c
Merge pull request #2540 from LabNConsulting/working/master/bgp-twice-leaked-nht 
bgpd: don't nexthop-track twice-leaked routes that came from zebra
 2018-06-26 11:17:32 -04:00
Russ White
f1b5eeea03
Merge pull request #2545 from pacovn/Coverity_1468413_Explicit_null_dereferenced 
bgpd: null check (Coverity 1468413)
 2018-06-26 11:14:39 -04:00
Quentin Young
f07e1c4fe4 bgpd: remove DEFUN_DEPRECATED usage 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-25 16:38:48 +00:00
paco
867f0ccaec
bgpd: null check (Coverity 1468413) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 15:03:17 +02:00
G. Paul Ziemba
f46d45c17f bgpd: don't nexthop-track twice-leaked routes that came from zebra 
Issue 2381: interface based routes not marked "up" when they originate
in zebra, redistributed to bgp vrf, then imported to vpn and then
imported by another vrf.

Routes that are redistributed into BGP from zebra should not get
nexthop tracking (the assumption is that the originating protocol
is responsible to export or withdraw the route according to its own
notion of nexthop status).

The vpn-vrf route-leaking code checks the source route sub_type to
decide whether to use nexthop tracking on the resulting leaked route.

A route that is redistributed from zebra into bgp will have
sub_type==BGP_ROUTE_REDISTRIBUTE. If it is leaked to the vpn RIB,
the resulting vpn RIB route will have sub_type==BGP_ROUTE_IMPORTED.
If THAT vpn route is leaked to another vrf, the original code will
examine only the leak-source route sub_type and, since it is
not BGP_ROUTE_REDISTRIBUTE, will wrongly try to use nexthop tracking
on the new route in the final vrf.

This change modifies the leak function to track back up the
parent links to the ultimate parent of the leak source route
and look at that route's sub_type instead.

Signed-off-by: G. Paul Ziemba <paulz@labn.net>
 2018-06-24 13:04:05 -07:00
Quentin Young
0a8990d5f8
Merge pull request #2501 from pacovn/infer_unused1 
bgpd isisd ldpd lib ospfd pimd: redundancy (infer, grouped)
 2018-06-21 15:12:33 -04:00
Quentin Young
277781a778
Merge pull request #2518 from pacovn/Coverity_23106_Explicit_null_dereferenced 
bgpd: null check (Coverity 23106)
 2018-06-21 14:24:11 -04:00
Quentin Young
dfc5d40e91
Merge pull request #2519 from pacovn/Coverity_1399238_Logically_dead_code 
bgpd: dead code (Coverity 1399238)
 2018-06-21 14:20:48 -04:00
paco
990f4f9112
bgpd: null check (Coverity 1455380) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 18:51:52 +02:00
paco
d87ff2ddf4
bgpd: dead code (Coverity 1399238) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:22:55 +02:00
paco
e8a3a0a030
bgpd: null check (Coverity 23106) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 15:58:51 +02:00
Donald Sharp
50f08ff26a
Merge pull request #2507 from pacovn/Coverity_1436344_1451361_Dereference_after_null_check 
bgpd, lib: null check (Coverity 1436344, 1451361)
 2018-06-21 07:29:51 -04:00
Donald Sharp
07caaf613a
Merge pull request #2506 from pacovn/Coverity_1221453_1461297_Dereference_after_null_check 
bgpd ospf6d: null check (Coverity 1221453 1461297)
 2018-06-21 07:26:47 -04:00
paco
a2b6e694b1
bgpd isisd ldpd lib ospfd pimd: redundancy (infer) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 22:25:28 +02:00
paco
fa3016309b
bgpd, lib: null check (Coverity 1436344, 1451361) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 19:14:01 +02:00
paco
cac84a1611
bgpd ospf6d: null check (Coverity 1221453 1461297) 2018-06-20 18:57:16 +02:00
Donald Sharp
76cd18c9dd
Merge pull request #2498 from pacovn/Coverity_1470098_Logically_dead_code 
bgpd: json output fix (Coverity 1470098)
 2018-06-20 11:39:07 -04:00
paco
06e8964464
bgpd: json output fix (Coverity 1470098) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 15:43:19 +02:00
Russ White
480f71f6a8
Merge pull request #2461 from pacovn/Coverity_1399380_Untrusted_value_as_argument 
bgpd: Untrusted argument (Coverity 1399380)
 2018-06-20 07:41:06 -04:00
Russ White
96be948bcd
Merge pull request #2495 from pacovn/fixme_all_digit 
bgpd, lib, ospfd, zebra: all_digit moved to frrstr
 2018-06-20 07:38:19 -04:00
Donald Sharp
46a69f10c0 bgpd, lib, zebra: Remove unnecessary return 
The route_map_walk_update_list callback function
never uses the return code, so just remove it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 21:22:46 -04:00
Donald Sharp
7096e93875 bgpd, lib, pimd: Remove unused variable. 
route_map_mark_updated has a `int del_later` variable
that is passed in but never used.  Just remove it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 20:44:15 -04:00
paco
5d5ba0185d
bgpd, lib, ospfd, zebra: all_digit moved to frrstr 
This solves a pending FIXME

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 17:59:53 +02:00
paco
f96f689940
bgpd: Untrusted argument (Coverity 1399380) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 15:00:25 +02:00
Russ White
05d7e026c8
Merge pull request #2445 from ppmathis/feature/bgp-pg-overrides 
bgpd: Improve peer-group override implementation
 2018-06-19 08:20:31 -04:00
Russ White
4a1f626570
Merge pull request #2450 from ppmathis/bugfix/bgp-filtered-routes 
bgpd: Fix crash when showing filtered routes
 2018-06-19 07:37:42 -04:00
Russ White
fc89ac9846
Merge pull request #2470 from chiragshah6/mdev 
zebra: Hide default vrf instance of l3vni cmd
 2018-06-19 07:29:13 -04:00
Russ White
e3ea4f7acb
Merge pull request #2478 from pacovn/Coverity_1408766_Dereference_after_null_check 
bgpd: null check (Coverity 1408766)
 2018-06-19 07:21:42 -04:00
Russ White
f071d8b36a
Merge pull request #2481 from pacovn/security_vpn_null_check 
bgpd: vpn null check
 2018-06-19 07:19:00 -04:00
Russ White
9635a16a36
Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref 
bgpd: null check (Clang scan-build)
 2018-06-19 07:18:13 -04:00
Lou Berger
ed892e530d
Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced 
bgpd: null check (Coverity 1433544, 1433543, 1433542)
 2018-06-18 16:59:26 -04:00
Donald Sharp
b5e3687b1d
Merge pull request #2482 from pacovn/clang_scan_bgpd_bgp_rpki_deref 
bgpd: null check (Clang scan-build)
 2018-06-18 16:09:56 -04:00
paco
d3e51db069
bgpd: null check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 21:37:35 +02:00
Donald Sharp
c0662bb478
Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code 
bgpd: dead code (Coverity 1399373)
 2018-06-18 14:29:27 -04:00
paco
18b91526fa
bgpd: null check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 16:27:02 +02:00
paco
c37a11ad72
bgpd: null chk (Coverity 1433544 1433543 1433542) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 16:07:43 +02:00
paco
73aed5841a
bgpd: vpn null check 
Can be reproduced with following vtysh sequence (an intentionaly wrong
sequence):

['configure terminal\n router bgp 255 vrf l3vrf-6\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\nbgp router-id 10.255.255.1\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nlabel vpn export 45000\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrd vpn export 255:5\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute isis\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute ospf\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute connected\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nimport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nexport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn import 255:1\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn export 255:1\n'
]

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 15:52:57 +02:00
Lou Berger
2868e293e7
Merge pull request #2466 from pacovn/clang_scan_bgpd_dereference1 
bgpd: null check (Clang scan-build)
 2018-06-18 08:16:01 -04:00
Lou Berger
f0380e0468
Merge pull request #2456 from pacovn/Coverity_1399306_Out-of-bounds_access 
bgpd: out-of-bounds access (Coverity 1399306)
 2018-06-18 08:12:04 -04:00
paco
e105d90456
bgpd: null check (Coverity 1408766) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 12:51:33 +02:00
Chirag Shah
99b4e972b5 bgpd: fix default RD value in running-cfg 
When bgp vrf is configured with non-default
RD value, config flag is set.
Upon removing non-default RD value the flag was not reset,
thus displayed default RD value in running-config.

router bgp 5550 vrf vrf1
 rd 45.0.2.2:5

Unset the RD configuration flag under bgp_vrf instance.

Ticket:CM-20206

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2018-06-15 22:19:08 -07:00