Commit Graph

7679 Commits

Author SHA1 Message Date
Martin Winter
6491e6303e Merge pull request #370 from donaldsharp/as_path_fix
bgpd: Fix 'set as-path prepend last-as 10'
2017-04-17 14:46:28 -07:00
Quentin Young
9ea49d61d2 pimd: fix 'show ip msdp sa ...'
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-04-17 19:24:28 +00:00
Donald Sharp
be81f27278 eigrpd: Save whether or not a interface is passive.
Save whether or not a interface is passive in EIGRP.
More work is needed to actual respect that.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-17 10:01:51 -04:00
Quentin Young
6cbc63316b lib: add removal by item to pqueue
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-04-17 00:06:02 +00:00
Donald Sharp
dbc56a10d4 eigrpd: Cleanup cli
The eigrp cli was using a define that was causing some issues
surrounding interface names and detailed information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 14:20:57 -04:00
Donald Sharp
7abc04e686 zebra: Add some more checks to fec [un]registration
Be a bit more rigoruous about what we can receive
from another protocol and attempt to make the code
less likely to crash and to just safely bail
out when an error is received.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Donald Sharp
9fbea8d56d bgpd: Fix up several issues in bgp_route.c
1) Some commands were installed in the wrong node
2) Fix output to show labeled information to correctly display
3) Whitespace issue in route-map command

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Donald Sharp
9db2da6c59 zebra: Fix whitespace issue with if statement
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Donald Sharp
bf995813b2 zebra: Allow explicit-null as a label option
When entering 'mpls label bind ...' command
allow the explicit-null as an option.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Donald Sharp
95169c2f78 zebra: Fix crash with dereference of NULL pointer
We only create the v4 and v6 mpls fec tables currently.
Follow the code pattern for the rest of the code and
ensure that the table exists before we attempt to access it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Donald Sharp
b3b3879c3e lib, bgpd: Remove UNDEFINED_NODE
Remove the UNDEFINED_NODE as that it's implementation breaks
our ability in BGP to figure out where we are by allowing
default: in the switch statement.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-15 13:26:56 -04:00
Martin Winter
178b92ceb1 redhat: /etc/frr/daemons needs to be marked as no replace config to be save from overwriting
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 03:29:34 -07:00
Martin Winter
c2953ac5d6 redhat: Add (combined) init.d script for FRR with daemon selection based on /etc/frr/daemons
- Provide new frr init script
- Remove separate per-deamon init.d scripts

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 03:13:07 -07:00
Martin Winter
36d85ca8e3 watchfrr: Remove the HAVE_CUMULUS around the watchfrr.started file. It's always useful
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-15 02:00:15 -07:00
Quentin Young
529aa94e24 pimd: fix off-by-one in no ip pim rp ...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-04-15 06:23:22 +00:00
Donald Sharp
5260e25d20 bgpd: 'show .... bgp regexp WORD' fixed
The command was always just returning as part of the
bgp_regexp_show function.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-14 20:39:56 -04:00
Donald Sharp
b6ab29296f bgpd: Fix 'set as-path prepend last-as 10'
1) Fix missing newline in help string
2) Make the ability to have 10 be consistent with the stable/2.0 branch.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-14 20:13:26 -04:00
Donald Sharp
5cf5f2033b bgpd: Fix 'set as-path prepend last-as 10'
The route-map compilation function was comparing < 10
instead of <= 10.  While the cli was accepting 1-10.

Fix:
!
route-map FOO permit 44
 set as-path prepend last-as 10
!

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-14 20:05:48 -04:00
Martin Winter
4d3bac5b14 redhat: Add python2 build requirement to pythontools sub package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 02:21:44 -07:00
Martin Winter
df1a7ae4ce redhat: Fix previously added centos6/redhat6 check
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 02:20:31 -07:00
Martin Winter
33fdbd5efb redhat: Fix install (daemon selection) and make postun scripts compatible with fedora
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-14 01:28:13 -07:00
Martin Winter
41b86ba421 redhat: Always disable PIMd on CentOS 6 and RedHat 6 systems as they are too old to correctly support the protocol
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 18:54:58 -07:00
Martin Winter
386fcd12a4 redhat: Move frr-reload python script to it's own sub package to avoid the python2 requirement for main frr package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 17:34:26 -07:00
Martin Winter
a88f3f42f9 redhat: Don't set file attributes for symlinks
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 17:33:24 -07:00
Martin Winter
1b2b123042 redhat: Fix ospf6d typo in frr.spec.in
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-13 15:00:16 -07:00
Martin Winter
6e38a83973 Merge pull request #366 from pichuang/fixed_add_group
Fixed some document typo
2017-04-13 14:52:16 -07:00
Phil Huang
be9665641d Clean installation guide with Debian/Ubuntu
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-13 21:20:53 +08:00
Phil Huang
7caef08c84 Add user frr into group frrvty
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-13 19:16:11 +08:00
Martin Winter
58f20b90ee redhat: Fix dependencies for rpm package
- Add bison, flex & autoconf
- Remove systemd for systems without it (i.e. CentOS 6)
- Update doc to reflect dependencies

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 20:23:18 -07:00
Martin Winter
9a581ae412 redhat: Remove tab's with spaces in frr.spec.in to make it better readable
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 19:10:35 -07:00
Martin Winter
94c0033565 redhat: Replace tab's with spaces in README
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 18:54:40 -07:00
Donald Sharp
81a37d8911 Merge pull request #365 from opensourcerouting/snap-doc-fixes
snapcraft: Improve README.usage.md based on feedback received
2017-04-12 21:12:26 -04:00
Martin Winter
2a3a819a9c snapcraft: Improve README.usage.md based on feedback received
- Fix snap connect (it's now called core, not ubuntu-core)
- Add section on MPLS configuration
- Add FAQ topic on ospfd/ospf6d crashing before privs are assigned to snap
- Add pointer to official webpage

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-12 16:00:43 -07:00
Donald Sharp
64919312d2 Merge pull request #359 from opensourcerouting/bgpd_largecomm_fix
bgpd: fixes for the "show bgp large-community" command
2017-04-10 19:21:05 -04:00
Renato Westphal
5ea207372b Merge pull request #351 from donaldsharp/ospf_fix
Some Issues fixed
2017-04-10 19:06:17 -03:00
Renato Westphal
d536095fd3 bgpd: fixes for the "show bgp large-community" command
* Fix a segfault when the "show bgp large-community" command is given
  without any optional large communities;
* Fix parsing of optional large communities. Without this fix a
  "Large-community malformed" error is shown even for valid large
  communities.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-10 18:49:38 -03:00
Jafar Al-Gharaibeh
b43d5ea330 Merge pull request #304 from donaldsharp/pim_5549
Pim 5549 Additions
2017-04-10 11:07:58 -05:00
Renato Westphal
2caafa8c6f ripd: fix argv index numbers in the redistribute command
Fixes Issue#350

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-08 17:37:05 -04:00
Donald Sharp
f9e5c9ca06 eigrpd: Cleanup tab/spacing of the *.c files
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-08 14:44:58 -04:00
Donald Sharp
08c08a35c6 lib: Fix debugs to be guarded.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-08 08:55:40 -04:00
Donald Sharp
6be4da3dfa ospfd: Fix the 'show ip ospf int ...' command
Fixed output:

robot.cumulusnetworks.com# show ip ospf int
enp0s3 is up
  ifindex 2, MTU 1500 bytes, BW 0 Mbit <UP,BROADCAST,RUNNING,MULTICAST>
  Internet Address 10.0.2.15/24, Broadcast 10.0.2.255, Area 0.0.0.0
  MTU mismatch detection:enabled
  Router ID 192.168.0.1, Network Type BROADCAST, Cost: 10
  Transmit Delay is 1 sec, State Waiting, Priority 1
  No backup designated router on this network
  Multicast group memberships: OSPFAllRouters
  Timer intervals configured, Hello 10s, Dead 40s, Wait 40s, Retransmit 5
    Hello due in 9.611s
  Neighbor Count is 0, Adjacent neighbor count is 0
enp0s10 is up
  ifindex 7, MTU 1500 bytes, BW 0 Mbit <UP,BROADCAST,RUNNING,MULTICAST>
  Internet Address 192.168.201.146/24, Broadcast 192.168.201.255, Area 0.0.0.0
  MTU mismatch detection:enabled
  Router ID 192.168.0.1, Network Type BROADCAST, Cost: 10
  Transmit Delay is 1 sec, State Waiting, Priority 1
  No backup designated router on this network
  Multicast group memberships: OSPFAllRouters
  Timer intervals configured, Hello 10s, Dead 40s, Wait 40s, Retransmit 5
    Hello due in 7.241s
  Neighbor Count is 0, Adjacent neighbor count is 0

robot.cumulusnetworks.com# show ip ospf int enp0s3
enp0s3 is up
  ifindex 2, MTU 1500 bytes, BW 0 Mbit <UP,BROADCAST,RUNNING,MULTICAST>
  Internet Address 10.0.2.15/24, Broadcast 10.0.2.255, Area 0.0.0.0
  MTU mismatch detection:enabled
  Router ID 192.168.0.1, Network Type BROADCAST, Cost: 10
  Transmit Delay is 1 sec, State Waiting, Priority 1
  No backup designated router on this network
  Multicast group memberships: OSPFAllRouters
  Timer intervals configured, Hello 10s, Dead 40s, Wait 40s, Retransmit 5
    Hello due in 2.915s
  Neighbor Count is 0, Adjacent neighbor count is 0

robot.cumulusnetworks.com# show ip ospf int enp0s10 json
{
  "enp0s10":{
    "ifUp":true,
    "ifIndex":7,
    "mtuBytes":1500,
    "bandwidthMbit":0,
    "ifFlags":"<UP,BROADCAST,RUNNING,MULTICAST>",
    "ospfEnabled":true,
    "ipAddress":"192.168.201.146",
    "ipAddressPrefixlen":24,
    "ospfIfType":"Broadcast",
    "localIfUsed":"192.168.201.255",
    "area":"0.0.0.0",
    "routerId":"192.168.0.1",
    "networkType":"BROADCAST",
    "cost":10,
    "transmitDelayMsecs":1000,
    "state":"Waiting",
    "priority":1,
    "mcastMemberOspfAllRouters":true,
    "timerMsecs":100,
    "timerDeadMsecs":25,
    "timerWaitMsecs":25,
    "timerRetransmit":200,
    "timerHelloInMsecs":2106,
    "nbrCount":0,
    "nbrAdjacentCount":0
  }
}
robot.cumulusnetworks.com#

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-08 08:47:59 -04:00
Donald Sharp
962251aeff eigrpd: Only install up to eigrp->max_paths into rib.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-07 18:59:06 -04:00
Renato Westphal
73a9e6d2a5 Merge pull request #347 from qlyoung/ignore-flex-sign-error
lib: add #pragma to ignore flex sign cmp error
2017-04-07 18:48:14 -03:00
Donald Sharp
902726b81f doc: Cleanup 'Build the Software'
The frrouting.org web page:
https://frrouting.org/manual/Build-the-Software.html#Build-the-Software
is built from doc/install.texi.  The output on this page is a bit
missleading, let's clean it up some.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-07 17:20:32 -04:00
Quentin Young
073845da5e lib: add #pragma's to ignore flex sign cmp error
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-04-07 19:18:57 +00:00
Donald Sharp
5326da0c5c zebra: Experimental commit to see if this fixes snap builds
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-07 13:56:41 -04:00
Donald Sharp
dad9e527fc Merge remote-tracking branch 'origin/stable/3.0' 2017-04-07 13:37:01 -04:00
Donald Sharp
ccddeb994b bgpd: Switch u_int64_t -> uint64_t
Apparently u_int64_t is not available( or we don't pull the
right headers in for solaris based systems).

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-07 13:34:01 -04:00
Donald Sharp
4390fb9991 pimd: Fix various sizeof and buffer length issues
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-06 17:57:24 -04:00
Donald Sharp
95f40dbe21 zebra: Get mpls building across multiple platforms.
The build system for mpls is a bit convoluted.  We need
a way to handle builds across multiple platforms.  This,
I believe addresses this issue.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-06 14:40:19 -04:00