Quentin Young
c25c61370f
vtysh: fix stack buffer overflow
...
VARIABLE accepts arbitrary input
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-19 20:37:43 +00:00
David Lamparter
2dc1ef552b
Merge pull request #725 from donaldsharp/vrf_completion
...
Vrf completion
2017-06-16 21:59:23 +02:00
Quentin Young
430000deee
Merge pull request #702 from opensourcerouting/ldpd-cli-rewrite
...
ldpd: convert cli and get rid of the xml interface
2017-06-16 15:53:50 -04:00
Renato Westphal
180fc2cd70
ldpd: update copyright information
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-06-16 14:43:55 -03:00
Renato Westphal
c740f7d367
ldpd: convert cli and get rid of the xml interface
...
The xml2cli.pl script was useful years ago when the vty code was very
rudimentary. This is not the case anymore, so convert all ldpd CLI
commands to use DEFUNs directly and get rid of the XML interface.
The benefits are:
* Consistency with the other daemons;
* One less build dependency (the LibXML perl module);
* Easier to add new commands.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-06-16 14:43:42 -03:00
Donald Sharp
23312e7173
bgpd: Fix as per Code Review comment
...
Add ending value in the array.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-16 13:12:42 -04:00
Donald Sharp
d7a75a6ca6
lib, vtysh, zebra: Fix per CR comments
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-16 13:09:37 -04:00
Donald Sharp
18c5703710
bgpd: Add view/vrf auto completion to commands
...
Modify the '<view|vrf> NAME' commands to allow auto-completion
of available choices.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-16 13:01:51 -04:00
Donald Sharp
d617d5febf
*: Add vrf autocompletion for commands
...
Switch NAME to VRFNAME and add vrf autocompletion
to commands that have them
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-16 13:01:51 -04:00
David Lamparter
62e4232010
Merge pull request #718 from qlyoung/fix-vtysh-shit
...
lib: allow 'do' commands in ENABLE_NODE
2017-06-16 18:25:48 +02:00
David Lamparter
44d7e121fd
Merge pull request #726 from chiragshah6/pim_dev
...
pimd: move variable declartion outside of switch
2017-06-16 18:24:38 +02:00
David Lamparter
0817c157df
Merge pull request #620 from qlyoung/termtable
...
lib: add table generator
2017-06-16 18:23:14 +02:00
Quentin Young
b170d66a78
lib: allow 'do' commands in ENABLE_NODE
...
'do' is syntax sugar that allows the user to execute a command under
ENABLE_NODE when in another CLI node. If the user is already in
ENABLE_NODE, use of 'do' was previously disallowed. This patch allows it
because it makes it easier for us to hack around certain instances of
the node synchronization problem with vtysh.
Also included is a fix for one of these problems.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-16 14:46:08 +00:00
Quentin Young
0f2b0a3893
lib: termtable MTYPE_TMP -> MTYPE_TTABLE
...
And some style nits.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-16 02:10:34 +00:00
Quentin Young
f051edd156
lib: add table generator
...
Allows for easy preparation of tabular output.
Supports:
-- Padding
-- Alignment
-- Styling
2017-06-16 02:02:42 +00:00
Chirag Shah
925574ba66
pimd: move variable declartion outside of switch
...
To Address ICC (intel CC) warning, moving variables
declaration out of switch statement.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-06-15 12:20:59 -07:00
David Lamparter
f43cd318b2
Merge pull request #711 ("Coverity munging")
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-15 16:22:42 +02:00
David Lamparter
68fc8f1f26
ospfd: fix typo in error message
...
... and print the invalid input value
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-15 16:21:58 +02:00
Lou Berger
ffef22509f
Merge pull request #705 from dwalton76/bgpd-show-neighbor-community
...
bgpd: "no neighbor x.x.x.x send-community" not displayed correctly
2017-06-15 09:21:44 -04:00
David Lamparter
4f138a3e82
lib: fix protocol name array size
...
Oops. Fixes #715 .
Reported-by: Daniel Walton <dwalton@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-14 15:56:14 -04:00
David Lamparter
1c2596c15f
Merge pull request #716 from dwalton76/show-route-map
...
lib: "show route-map" is missing from the parser
2017-06-14 21:07:24 +02:00
Daniel Walton
6d2729e3d7
lib: "show route-map" is missing from the parser
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-06-14 18:21:17 +00:00
Donald Sharp
03793b7abb
zebra: Remove unused testzebra and ancillary files
...
The testzebra command was unused as well as unmaintained.
The NS and VRF changes never made into testzebra so when
you actually ran testzebra it would just crash due to
uninitialized assumptions.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 14:23:52 -04:00
Donald Sharp
8089cd1062
eigrpd: Fix integer overflow possibility
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:33:25 -04:00
Donald Sharp
71007eab71
pimd: Cleanup ifp->info setup
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:28:20 -04:00
Donald Sharp
5125997a8a
ospfclient: Free up leaked resources in error path
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:15:01 -04:00
Donald Sharp
e6fda497d3
*: Clean up call into inet_aton
...
In the few places where we were not checking the return code
for inet_aton, do so.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:10:32 -04:00
David Lamparter
645bb0b10e
Merge branch 'stable/3.0'
...
Dropped:
redhat/README.rpm_build.md
redhat/daemons
redhat/frr.init
redhat/frr.logrotate
redhat/frr.spec.in
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:37:58 +02:00
David Lamparter
98f65fda88
Merge pull request #681 (ASAN warnings)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:16:24 +02:00
David Lamparter
fb82c3dbb2
Merge pull request #687 (nexthop refactoring)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:22:29 +02:00
David Lamparter
e885ed85bb
Merge pull request #624 "Babel"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:11:32 +02:00
David Lamparter
e763afa507
babeld/eigrpd: flip VTY ports & fix rpm
...
babeld was 2609 previously, and this was still marked in SERVICES.
Let's flip it back before we have a release out with it.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 14:36:55 +02:00
David Lamparter
5da670a08b
Merge pull request #703 from donaldsharp/nl_pid
...
zebra: When calling netlink, set the nl_pid as appropriate
2017-06-13 10:08:43 +02:00
David Lamparter
063221b5ad
Merge pull request #700 "Coverity high"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:05:51 +02:00
David Lamparter
ea00fb03f0
Merge pull request #678
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:03:01 +02:00
David Lamparter
3565d9ac83
babeld: install directly connected IPv4 as such
...
babeld would install "1.2.3.4 on eth0" as "1.2.3.4 via 1.2.3.4 on eth0".
Remove the superfluous nexthop and send to zebra as directly-connected
route.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 09:45:16 +02:00
David Lamparter
97bd5c48de
Merge remote-tracking branch 'frr/master' into pull-624
2017-06-13 09:18:14 +02:00
Daniel Walton
62d8f9a842
bgpd: "no neighbor x.x.x.x send-community" not displayed correctly
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
We would only diplay one "no neighbor 2.2.2.2 send-community XYZ" but
there might be multiple that need to be displayed.
2017-06-12 20:09:09 +00:00
Donald Sharp
a55ba23ff7
zebra: When calling netlink, set the nl_pid as appropriate
...
This will allow us to further know that we originated the message.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-12 13:38:51 -04:00
Donald Sharp
d722f26e09
zebra: Fix memory leak
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:39:41 -04:00
Donald Sharp
43cb4d1106
zebra: Fix uninitialized memory access with src_p
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:36:32 -04:00
Donald Sharp
4dfa484627
eigrpd: Correctly size the dump data
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:31:49 -04:00
Donald Sharp
73d11e2ec1
eigrpd: Use correct memory operation
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:18:54 -04:00
Donald Sharp
d52ecaa1de
eigrpd: Fix leak of ep
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:13:51 -04:00
Donald Sharp
60805e322e
eigrpd: Cleanup leaked dest_addr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:09:29 -04:00
Donald Sharp
4af0ab6d7d
eigrpd: Fix use after free
...
Signed-off-by: Donald Sharp <sharpd@Cumulusnetworks.com>
2017-06-10 15:53:27 -04:00
Donald Sharp
6201488ab3
zebra: Fix possible buffer overrun
...
Use the correct size of the string.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 15:42:13 -04:00
Donald Sharp
29c60afb6b
bgpd: Free allocated stream in error code
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 15:37:02 -04:00
Quentin Young
47332bd02b
bgpd: fix memleak with 'show ip bgp vrf ...'
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-09 20:18:56 +00:00
Russ White
ad2e2470f6
Merge pull request #679 from dslicenc/cm16513
...
bgpd: add "set label-index" route-map option
2017-06-09 14:01:36 -04:00