Donald Sharp
03793b7abb
zebra: Remove unused testzebra and ancillary files
...
The testzebra command was unused as well as unmaintained.
The NS and VRF changes never made into testzebra so when
you actually ran testzebra it would just crash due to
uninitialized assumptions.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 14:23:52 -04:00
Donald Sharp
e6fda497d3
*: Clean up call into inet_aton
...
In the few places where we were not checking the return code
for inet_aton, do so.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-13 13:10:32 -04:00
David Lamparter
645bb0b10e
Merge branch 'stable/3.0'
...
Dropped:
redhat/README.rpm_build.md
redhat/daemons
redhat/frr.init
redhat/frr.logrotate
redhat/frr.spec.in
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:37:58 +02:00
David Lamparter
98f65fda88
Merge pull request #681 (ASAN warnings)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 17:16:24 +02:00
David Lamparter
fb82c3dbb2
Merge pull request #687 (nexthop refactoring)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:22:29 +02:00
David Lamparter
e885ed85bb
Merge pull request #624 "Babel"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 16:11:32 +02:00
David Lamparter
5da670a08b
Merge pull request #703 from donaldsharp/nl_pid
...
zebra: When calling netlink, set the nl_pid as appropriate
2017-06-13 10:08:43 +02:00
David Lamparter
063221b5ad
Merge pull request #700 "Coverity high"
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-13 10:05:51 +02:00
David Lamparter
97bd5c48de
Merge remote-tracking branch 'frr/master' into pull-624
2017-06-13 09:18:14 +02:00
Donald Sharp
a55ba23ff7
zebra: When calling netlink, set the nl_pid as appropriate
...
This will allow us to further know that we originated the message.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-12 13:38:51 -04:00
Donald Sharp
d722f26e09
zebra: Fix memory leak
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:39:41 -04:00
Donald Sharp
43cb4d1106
zebra: Fix uninitialized memory access with src_p
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 16:36:32 -04:00
Donald Sharp
6201488ab3
zebra: Fix possible buffer overrun
...
Use the correct size of the string.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-10 15:42:13 -04:00
Russ White
991da9b149
Merge pull request #694 from qlyoung/event-loop
...
*: remove THREAD_BACKGROUND
2017-06-09 13:54:43 -04:00
Jafar Al-Gharaibeh
ce7fce36bd
Merge pull request #692 from donaldsharp/meta_queue_fix
...
zebra: Fix the metaq to be aware of all routing protocols we could see
2017-06-08 10:41:57 -05:00
Jafar Al-Gharaibeh
b61246cacf
Merge pull request #697 from donaldsharp/rt_proto_fixes
...
tools, zebra: Fix netlink notification of who owns the routes
2017-06-08 10:28:35 -05:00
Donald Sharp
cea34723da
zebra: In which RTPROT_BABEL is hard
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 09:33:54 -04:00
Donald Sharp
fb533f22b5
zebra: For older distributions RTPROT_BABEL might not be defined
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 09:16:28 -04:00
Donald Sharp
40078ccb05
tools, zebra: Allow zebra to insert babel routes as babel
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 08:56:36 -04:00
Donald Sharp
1f047d8d2c
tools, zebra: Fix netlink notification of who owns the routes
...
For NHRP, EIGRP and LDP( This is for consistency as opposed to correctness )
assign some new values to routes to be installed into the kernel
so we can know who owns them later.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 08:51:25 -04:00
Alex Couloumbis
9c3bf1cee7
zebra: Fix --disable-rtadv to actually compile
...
Signed-off-by: Alex Couloumbis <alex@ozo.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-08 07:57:25 -04:00
Quentin Young
a587d00bac
*: remove THREAD_BACKGROUND
...
it's just an alias for a millisecond timer used in exactly nine places
and serves only to complicate
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-08 01:53:50 +00:00
Donald Sharp
8dab78d7d4
zebra: Add babel routes to the proper meta-Q for processing
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 15:57:25 -04:00
Donald Sharp
43cf4ba452
zebra: Fix the metaq to be aware of all routing protocols we could see
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 15:43:23 -04:00
Renato Westphal
c4c8dec041
zebra: fix uninstallation of mpls lsps in openbsd
...
While here, fix a warning in kernel_lsp_cmd().
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-06-07 10:33:31 -03:00
Donald Sharp
c87bdd2b0f
zebra: Clean up indentation level in nexthop_active
...
Clean up the while loop indentation level to be a bit more
readable.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 07:39:35 -04:00
Donald Sharp
4491a88f9e
zebra: Refactor nexthop_active to remove duplicate code
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-07 07:34:16 -04:00
Quentin Young
f4e77d9731
zebra: fix misc zebra leaks
...
Fix #669
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-07 00:55:00 +00:00
Quentin Young
31c6fa450a
zebra: remove extraneous help string
...
caused tag to display null0 helpstr
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-04 21:01:52 +00:00
Renato Westphal
247e6469da
Merge pull request #657 from donaldsharp/rompapotamus
...
Rompapotamus
2017-06-03 18:52:59 -03:00
Renato Westphal
e91163e78c
Merge pull request #647 from qlyoung/zebra-mpls-error-messages
...
zebra: more informative error messages & help strings for mpls labels
2017-06-02 22:53:53 -03:00
Renato Westphal
2cfaf92bc8
Merge pull request #652 from donaldsharp/miscapotamus
...
Miscapotamus
2017-06-02 22:40:56 -03:00
Donald Sharp
1da2945621
lib, zebra: Pass up kernel table_id for vrf's
...
pim controls the vrf table creation for due to the way that
pim must interact with the kernel. In order to match the
table_id for unicast <-> multicast( not necessary but a
real nice to have ) we need to pass up from zebra the
table_id associated with the vrf.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-02 13:43:15 -04:00
Donald Sharp
58f1b7ccbd
zebra: Fix help string ordering
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-02 07:35:38 -04:00
Donald Sharp
f0f77c9a59
zebra: Refactor 'struct rib' to be 'struct route_entry'
...
The 'struct rib' data structure is missnamed. It really
is a 'struct route_entry' as part of the 'struct route_node'.
We have 1 'struct route_entry' per route src. As such
1 route node can have multiple route entries if multiple
protocols attempt to install the same route.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-06-01 08:00:05 -04:00
Quentin Young
6feb1a21af
zebra: define mpls label helpstr
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-31 21:50:20 +00:00
Quentin Young
8062bf1c6b
zebra: more informative error messages for mpls labels
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-31 21:31:55 +00:00
Donald Sharp
241a2f5603
zebra: Fix 'show ip route babel'...
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-30 14:05:46 -04:00
Donald Sharp
c0619fdb86
Merge pull request #630 from opensourcerouting/zebra-lbl-unicast-issues
...
Zebra labeled unicast issues
2017-05-30 09:13:04 -04:00
David Lamparter
9ad245006d
Merge pull request #605 from dwalton76/show-ip-route-vrf-main
...
zebra: one "show ip route" to rule them all
2017-05-30 14:55:27 +02:00
David Lamparter
68b2595ec9
Merge pull request #576 from chiragshah6/pim_dev
...
pimd: pim bfd support
2017-05-30 14:37:08 +02:00
Renato Westphal
6a2ef37ad0
zebra: fix installation of ipv4 labeled unicast routes
...
Rearrange the _netlink_route_build*() functions so the labels of the
nexthops are always installed, even for IPv4 routes with IPv6 nexthops.
Fixes Labeled Unicast with BGP Unnumbered.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-29 19:59:48 -03:00
Renato Westphal
4038e8046d
zebra: fix processing of labeled ipv6 routes
...
We're incrementing nh_count twice for the same nexthop.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-29 19:58:35 -03:00
Renato Westphal
cf4e348abb
Merge pull request #615 from dslicenc/cm16531
...
zebra: add bgp unnumbered labeled-unicast to zserv
2017-05-29 19:32:38 -03:00
Renato Westphal
8ae2631740
Merge pull request #625 from donaldsharp/show_zebra
...
zebra: Fix 64 bit number printf issues
2017-05-29 12:58:21 -03:00
Donald Sharp
a1579fd393
zebra: Fix 64 bit number printf issues
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-26 14:06:37 -04:00
Donald Sharp
66d4272752
zebra: Remove string operations from non-debug path
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:22:03 -04:00
Donald Sharp
8755598a08
zebra: Store commonly used values instead of regenerating
...
the ipv4_ll address used for 5549 routes does not need
to be figured out every single time that we attempt
to install/remove a route of that type.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:11:24 -04:00
Don Slice
79878cf73e
zebra: add bgp unnumbered labeled-unicast to zserv
...
Prior to the fix, labels weren't getting installed in zebra nor were the
ifindex values correctly set if labeled-unicast was used in conjunction
with bgp unnumbered.
Ticket: CM-16531
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-6276
2017-05-25 04:19:10 -07:00
Daniel Walton
acb25e73f4
zebra: one "show ip route" to rule them all
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-22 19:56:11 +00:00