Igor Ryzhov
36d3fcccb4
Merge pull request #8944 from opensourcerouting/ospf6-mtu-revert
...
ospf6d: revert PR #8622
2021-07-27 16:06:40 +03:00
Russ White
b6dcdc0291
Merge pull request #8897 from gpnaveen/ospfv3_base_cases
...
tests: adding ospfv3 basic cases
2021-07-27 08:49:51 -04:00
Mobashshera Rasool
96cad17163
ospf6d: Type-7 LSA originated with wrong sequence number
...
RCA: When Type-7 LSA is updated, the LSDB is searched, if the
LSA is present in the LSDB then the LSA is updated with next
sequence number and if not then it is originated with the
INITIAL sequence number.
Here while originating Type-7 LSA Process Level LSDB is searched
for instead of area level LSDB.
Fix: Search in the area level LSDB and not in the process level.
Fixes #9099
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-27 05:39:37 -07:00
David Lamparter
631fce38ff
Merge pull request #9107 from donaldsharp/label_destruction
...
zebra: On client shutdown cleanup any vrf labels associated with it
2021-07-27 14:28:13 +02:00
Donatas Abraitis
5eefffd64e
Merge pull request #9190 from donaldsharp/join_prune_smaller
...
Join prune smaller
2021-07-27 15:26:52 +03:00
David Lamparter
9c9d8a6129
Merge pull request #9088 from donaldsharp/zebra_redistribute_wrong_tables
...
zebra: Do not allow redistribution for non-vrf tables
2021-07-27 14:14:23 +02:00
Donald Sharp
cb01669fe6
Merge pull request #9090 from opensourcerouting/ospfv3-fixes-20210720
...
ospf6d: small batch of random fixes/improvements
2021-07-27 08:06:54 -04:00
Igor Ryzhov
bb38b3681c
Merge pull request #9162 from ton31337/fix/use_strcmp_for_match_alias
...
bgpd: Use strcmp comparing BGP alias with an actual entered alias
2021-07-27 12:15:32 +03:00
Mobashshera Rasool
88ea79ad94
pimd: Validate the fields before accessing it
...
This commit is to correct the order in which the fields are
accessed while verifying it. First the fields should be
verified, and if it is valid then access it.
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-27 02:12:30 -07:00
Igor Ryzhov
e748f180f5
pimd: fix incorrect bool returns
...
-1 is true when casted to bool.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-27 11:41:36 +03:00
Igor Ryzhov
b5b4f44eb3
ripd: fix authentication key length
...
We were overwriting the last byte of the key when it's exactly 16 bytes.
Fixes #8151 .
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-27 11:23:36 +03:00
Donald Sharp
11190f169a
tests: Reduce pim join/prune interval to 5 seconds
...
Tests should have low enough overhead that sending
the join/prune every 5 seconds should be sufficient
also it should allow us to converge faster in case of
dropped packets.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26 11:57:25 -04:00
Donald Lee
84c92002d2
lib: formatting
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26 23:48:23 +08:00
Donald Lee
78f1ac2574
lib: Add new MTYPE for script results
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26 23:27:56 +08:00
Donald Lee
6ffeb9f79f
bgpd: Comment for included
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26 22:47:50 +08:00
Donald Sharp
1b6b002623
doc: Modify documentation for timer change
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26 10:04:39 -04:00
Donald Sharp
53dc1b16aa
pimd: Allow join prune intervals to be as small as 5 seconds
...
Allow the join-prune interval to be as small as 5 seconds instead
of limiting the value to 60.
This can and will come at a price of being able to converge less
mroutes.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26 10:02:21 -04:00
Mobashshera Rasool
8a86be272f
tests: Adding ospfv3 asbr summarisation
...
Total cases 9.
Authored-by: nguggarigoud <nguggarigoud@vmware.com>
Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-26 12:05:31 +00:00
Donald Sharp
53d7080980
Merge pull request #9166 from idryzhov/vtysh-enable
...
vtysh: another take at "enable" in vtysh user mode
2021-07-26 07:22:03 -04:00
Donatas Abraitis
66aa87d03e
Merge pull request #8637 from opensourcerouting/pim-vrf-acl-fixes
...
Pim vrf acl fixes
2021-07-26 12:20:54 +03:00
Igor Ryzhov
c54796288e
vtysh: don't install "enable" command in user mode
...
Recent change in d1b287e
only fixed the problem for 3-letter words.
We were still displaying error for longer words starting with "ena":
```
nfware> enac
% Command not allowed: enable
nfware> enad
% Command not allowed: enable
nfware> enaena
% Command not allowed: enable
```
If we don't allow "enable" command in user mode, why add it at all?
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-25 13:08:04 +03:00
Donald Lee
36cf58c785
lib: Rename decode_int
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 03:41:40 +08:00
Donald Lee
4093300ee8
lib: zlog err in error cases during lua loading
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 03:40:57 +08:00
Donald Lee
6d28552d2d
lib: comment typo
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 03:35:09 +08:00
Donald Lee
fe80e6019b
doc: typo
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 03:35:09 +08:00
Donald Lee
26693b3afc
lib: typo in tests
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 03:35:09 +08:00
Donald Lee
8be973f5c2
lib: Add function name to script command
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 00:45:22 +08:00
Donald Lee
1da9c4bdbb
lib: Use negative indices and add comments
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 00:45:22 +08:00
Donald Lee
1763ed2655
lib: Cap script_name length
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-24 00:45:22 +08:00
Donald Lee
67b64027b2
lib: parens around macro args
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23 20:48:16 +08:00
Donald Lee
08bf2b41b8
lib: formatting
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23 20:43:24 +08:00
Donald Lee
70d995abd4
lib: Comment on how macro works
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23 20:43:24 +08:00
Donald Lee
59a35b667d
bgpd: Use enum as input to Lua script
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23 20:43:24 +08:00
Donald Lee
bca62fe045
bgpd: fix typo
...
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23 20:43:24 +08:00
Donatas Abraitis
35a45e8070
bgpd: Use strcmp comparing BGP alias with an actual entered alias
...
It might be a case when a partial match is hit and this needs to be fixed.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-23 15:14:54 +03:00
Donatas Abraitis
c48ebbdb20
Merge pull request #9120 from taspelund/remove_rmac_seq
...
zebra: Remove MM seq from evpn rmac json output
2021-07-23 08:39:56 +03:00
Donatas Abraitis
09bc61f691
Merge pull request #9116 from donaldsharp/vtysh_enable
...
vtysh: Handle `en` better when in -u for vtysh
2021-07-23 08:33:02 +03:00
Donatas Abraitis
5400465334
Merge pull request #9126 from donaldsharp/rpki_spacing
...
bgpd: Fix rpki spacing to be 1 for indentation
2021-07-23 08:27:37 +03:00
Donald Sharp
7dc7fb9327
bgpd: Fix rpki spacing to be 1 for indentation
...
The rpki sub-node was outputting 2 spaces instead
of 1 space. Let's fix that to be consistent with
the rest of our code.
Fixes : #2738
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-22 16:55:51 -04:00
Trey Aspelund
fb0b54b361
zebra: Remove MM seq from evpn rmac json output
...
Currently 'show evpn rmac vni .. mac .. json' includes fields for
localSequence and remoteSequence, which are misleading since they
aren't applicable to a macs in the IP-VRF mac table (RMAC).
This removes the localSequence + remoteSequence fields from the output.
Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
2021-07-22 20:23:56 +00:00
rgirada
be418160a7
ospfd: OSPF hello packets not sent with configured hello timer
...
Description :
ospf hello timer is not getting refelcted upon
changing the hello interval.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-07-22 10:22:07 -07:00
Donald Sharp
d1b287e172
vtysh: Handle en
better when in -u for vtysh
...
vtysh was unable to distinguish between end and ena. The
code can now do so:
sharpd@eva ~/frr5 (master)> sudo vtysh/vtysh -u sharpd
Hello, this is FRRouting (version 8.1-dev).
Copyright 1996-2005 Kunihiro Ishiguro, et al.
eva> e
% Ambiguous command: e
eva> en
% Command not allowed: enable
eva> ena
% Command not allowed: enable
eva> enab
% Command not allowed: enable
eva> enabl
% Command not allowed: enable
eva> enable
% Command not allowed: enable
eva> enb
% Unknown command: enb
eva> enc
% Unknown command: enc
eva> end
% Unknown command: end
eva> ene
% Unknown command: ene
eva> quit
Fixes : #2296
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-22 12:00:58 -04:00
Donald Sharp
6afa0b137a
Merge pull request #8983 from mobash-rasool/pim-upstreaming-activity
...
pimd: Minor fixes for BSM Show CLI and Hold Timer CLI
2021-07-22 08:35:06 -04:00
Donald Sharp
d5b8e04651
Merge pull request #8986 from mobash-rasool/pim-upst-2
...
pimd: To print querierIP address on the querier and nonQuerier IGMP e…
2021-07-22 08:33:24 -04:00
Donald Sharp
0775caa958
Merge pull request #9082 from ton31337/feature/bgp_alias_route-map_match
...
bgpd: `match alias` for route-map
2021-07-22 08:30:15 -04:00
Donald Sharp
9fbbcbeb1f
Merge pull request #9091 from gord1306/remove_lst_vlan
...
zebra: trigger remove all access vlans info for access port
2021-07-22 07:04:20 -04:00
Renato Westphal
b9ff9be452
doc: document ospf6d's "area ... range" command
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-07-21 23:25:52 -03:00
Donald Sharp
918af5a40b
Merge pull request #9102 from opensourcerouting/autoconf-fix-gcov
...
build: fix LDFLAGS confusion & gcov
2021-07-21 19:26:15 -04:00
Donald Sharp
9a549c4fbf
Merge pull request #9105 from idryzhov/vtysh-ls-pw
...
vtysh, lib, zebra: fix exit from link-params and pseudowire nodes
2021-07-21 19:20:07 -04:00
Donald Sharp
06302ecb88
zebra: On client shutdown cleanup any vrf labels associated with it
...
When a vrf label is created by a client and the client disconnects
we should clean up any vrf labels associated with that client.
eva# show mpls table
Inbound Label Type Nexthop Outbound Label
-----------------------------------------------
1000 SHARP RED -
eva# exit
sharpd@eva ~/f/zebra (label_destruction)> ps -ef | grep frr
root 4017793 1 0 13:57 ? 00:00:00 /usr/lib/frr/watchfrr -d -F datacenter --log file:/var/log/frr/watchfrr.log --log-level debug zebra bgpd ospfd isisd pimd eigrpd sharpd staticd
frr 4017824 1 0 13:57 ? 00:00:00 /usr/lib/frr/zebra -d -F datacenter --log file:/tmp/zebra.log -r --graceful_restart 60 -A 127.0.0.1 -s 90000000
frr 4017829 1 0 13:57 ? 00:00:00 /usr/lib/frr/bgpd -d -F datacenter -M rpki -A 127.0.0.1
frr 4017836 1 0 13:57 ? 00:00:00 /usr/lib/frr/ospfd -d -F datacenter -A 127.0.0.1
frr 4017839 1 0 13:57 ? 00:00:00 /usr/lib/frr/isisd -d -F datacenter -A 127.0.0.1
frr 4017842 1 0 13:57 ? 00:00:00 /usr/lib/frr/pimd -d -F datacenter -A 127.0.0.1
frr 4017865 1 0 13:57 ? 00:00:00 /usr/lib/frr/eigrpd -d -F datacenter -A 127.0.0.1
frr 4017869 1 0 13:57 ? 00:00:00 /usr/lib/frr/sharpd -d -F datacenter -A 127.0.0.1
frr 4017888 1 0 13:57 ? 00:00:00 /usr/lib/frr/staticd -d -F datacenter -A 127.0.0.1
sharpd 4018624 3938423 0 14:02 pts/10 00:00:00 grep --color=auto frr
sharpd@eva ~/f/zebra (label_destruction)> sudo kill -9 4017869
sharpd@eva ~/f/zebra (label_destruction)> sudo vtysh -c "show mpls table"
sharpd@eva ~/f/zebra (label_destruction)>
Fixes : #1787
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-21 14:04:36 -04:00