proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-04 00:59:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: Use negative indices and add comments

Browse Source 
Signed-off-by: Donald Lee <dlqs@gmx.com>
This commit is contained in:
Donald Lee 2021-07-24 00:17:33 +08:00
parent 1763ed2655
commit 1da9c4bdbb
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/frrscript.c
View File

@ -208,10 +208,14 @@ void *frrscript_get_result(struct frrscript *fs, const char *function_name,
if (lfs == NULL)
return NULL;
/* results table is idx 1 on the stack, getfield pushes our item to idx
* 2
/* At this point, the Lua state should have only the returned table.
* We will then search the table for the key/value we're interested in.
* Then if the value is present (i.e. non-nil), call the lua_to*
* decoder.
*/
lua_getfield(lfs->L, 1, name);
assert(lua_gettop(lfs->L) == 1);
assert(lua_istable(lfs->L, -1) == 1);
lua_getfield(lfs->L, -1, name);
if (lua_isnil(lfs->L, -1)) {
lua_pop(lfs->L, 1);
zlog_warn(
@ -221,6 +225,11 @@ void *frrscript_get_result(struct frrscript *fs, const char *function_name,
}
p = lua_to(lfs->L, 2);
/* At the end, the Lua state should be same as it was at the start
* i.e. containing soley the returned table. */
assert(lua_gettop(lfs->L) == 1);
assert(lua_istable(lfs->L, -1) == 1);
return p;
}