Mark Stapp
31015c3ad9
lib,vtysh: add per-daemon log file config
...
Add a config that specifies per-deamon log file names.
Move the handy generated list of daemon names from vtysh to lib;
edit the gitignore files to match.
Signed-off-by: Mark Stapp <mjs@labn.net>
2024-01-17 16:15:07 -05:00
Donald Sharp
5eb2ddaa10
Merge pull request #15162 from opensourcerouting/fix/aspath4_set_flag
...
bgpd: Set capability received flag only after sanity checks
2024-01-17 08:19:34 -05:00
Christian Hopps
a197107dbc
tests: fix munet accessing missing attribute
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-17 09:18:21 +00:00
Donatas Abraitis
90254e7bc2
tests: Adopt tests for AS4 handling
...
When received malformed AS4 capability, it should return -1 (notification send),
and the received flag SHOULD NOT be set.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 16:28:41 +02:00
Donatas Abraitis
02a5da440b
bgpd: Send notification if AS4 capability failed to parse (malformed)
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 15:29:32 +02:00
Donatas Abraitis
722195d4ec
bgpd: Set role capability received flag only if parsed correctly
...
If we receive a malformed packet, we might end-up with a bad state.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 14:37:51 +02:00
Donatas Abraitis
0c74220c6e
bgpd: Set hostname capability received flag only if parsed correctly
...
If we receive a malformed packet, we might end-up with a bad state.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 14:37:16 +02:00
Donatas Abraitis
9b178d246e
bgpd: Set ADD-PATH capability received flag only if parsed correctly
...
If we receive a malformed packet, we might end-up with a bad state.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 14:36:20 +02:00
Donatas Abraitis
b571176aea
bgpd: Set AS4 capability received flag only if parsed correctly
...
If we receive a malformed packet, we might end-up with a bad state.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-16 14:35:10 +02:00
Donatas Abraitis
18257b521a
Merge pull request #15160 from vjardin/doc_typo
...
doc: typo, fix end of line
2024-01-16 09:44:41 +02:00
Donatas Abraitis
9cb45a10d4
Merge pull request #15161 from LabNConsulting/chopps/munet-0-13-12
...
import munet 0.13.12
2024-01-16 09:44:04 +02:00
Christian Hopps
48ed48b5f9
tests: import munet 0.13.12
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-15 22:43:06 +00:00
Christian Hopps
37f26046f4
tests: set environment variable munet 0.13.12 will use
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-15 22:25:41 +00:00
Vincent Jardin
4654995915
doc: typo, fix end of line
...
Signed-off-by: Vincent Jardin <vjardin@free.fr>
2024-01-15 22:51:09 +01:00
Christian Hopps
f2bb687426
Merge pull request #15154 from idryzhov/mgmt-get-data
...
mgmtd get-data request expansion
2024-01-15 07:03:34 -05:00
Donatas Abraitis
bd9174f424
Merge pull request #15156 from LabNConsulting/chopps/yang-mtu-32
...
yang: lib: interface MTUs can be larger than uint16
2024-01-15 11:27:15 +02:00
Donatas Abraitis
563c2cd95c
Merge pull request #15034 from louis-6wind/topotest-rpki
...
bgpd, topotests: add bgp_rpki_topo1 and RPKI fixes
2024-01-15 11:26:43 +02:00
Igor Ryzhov
2764344bcb
tests: add tests for mgmt get-data exact node request
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-15 10:27:33 +02:00
Igor Ryzhov
9859f308d2
lib, mgmtd: add ability to request the exact node in get-data request
...
RESTCONF expects to receive the exact node as a result, not the whole
data tree.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-15 10:27:33 +02:00
Igor Ryzhov
10eac0a54d
lib: fix oper data leaf creation
...
When creating an initial tree trunk for oper data walk, if the xpath
represents a leaf, the leaf is created with an incorrect empty value.
If it doesn't actually exist in daemon's oper data, its value is not
overwritten later and an empty value is returned in the result.
For example, when requesting
`/frr-interface:lib/interface[name='eth0']/description`, the result is:
```
{
"frr-interface:lib": {
"interface": [
{
"name": "eth0",
"description": ""
}
]
}
}
```
instead of an empty JSON that it should be.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-15 10:27:33 +02:00
Igor Ryzhov
05c6081099
tests: add tests for mgmt get-data with config
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-15 10:27:33 +02:00
Igor Ryzhov
e1cdb38ee6
lib, mgmtd: add ability to set content type in get-data request
...
Like in RESTCONF GET request and NETCONF get-data request, make it
possible to request state-only, config-only, or all data.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-15 10:27:33 +02:00
Donatas Abraitis
49cacc3184
Merge pull request #15150 from LabNConsulting/chopps/config-file-integrated
...
doc: update config file doc for integrated requirement
2024-01-15 08:43:44 +02:00
Igor Ryzhov
25d79af957
lib, mgmtd: add separate get-data request for the frontend
...
Currently it's the same as get-tree request for the backend, but it is
going to be expanded in the following commits.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-14 20:00:22 +02:00
Igor Ryzhov
88275d392a
vtysh, mgmtd: send interface commands to mgmtd
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-14 20:00:22 +02:00
Igor Ryzhov
b507ad54b4
mgmtd: add option to specify netns as the vrf backend
...
mgmtd has to know if netns is used as the vrf backend to correctly
process interface names in northbound.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-14 20:00:22 +02:00
Igor Ryzhov
2b7d9532c8
lib: fix yang_lyd_trim_xpath
...
We should traverse all top-level siblings, not only the first one.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-14 19:08:15 +02:00
Christian Hopps
d9d5f79610
Merge pull request #15151 from idryzhov/mgmtd-vrf
...
mgmtd: remove full vrf initialization
2024-01-14 12:04:46 -05:00
Christian Hopps
c68246c069
yang: lib: interface MTUs can be larger than uint16
...
Technically changing a leaf from uint16 to uint32 is a NBC change; however,
increasing this to uint32 should not break anyone in reality.
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-14 12:38:25 +00:00
Donald Sharp
ef0ae6e815
Merge pull request #15152 from LabNConsulting/chopps/doc-mgmtd-convert-update
...
doc: mgmtd: update mgmtd conversion doc to be current.
2024-01-13 20:46:36 -05:00
Christian Hopps
3b1998061c
doc: update config file doc for integrated requirement
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-13 21:05:36 +00:00
Donatas Abraitis
4eafe41546
Merge pull request #15149 from donaldsharp/pim_vxlan_issues_2
...
Some code realignment in pim
2024-01-13 21:10:07 +02:00
Donatas Abraitis
fd690b9bc4
Merge pull request #15135 from idryzhov/mgmt-unused
...
mgmtd: remove unused/redundant variables
2024-01-13 21:08:24 +02:00
Donatas Abraitis
bbe239036a
Merge pull request #15137 from spmzt/master
...
build: make buildtest.sh BSD compatible
2024-01-13 21:07:25 +02:00
Christian Hopps
a9dc7e9cc0
doc: mgmtd: update mgmtd conversion doc to be current.
...
Also change `be_client_xpaths` to `be_client_config_xpaths` referred in the doc
to make much clearer it's use (since there's a separate `be_client_oper_xpaths`.
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-13 14:26:55 +00:00
Igor Ryzhov
fe55bb15be
mgmtd: remove full vrf initialization
...
We don't really need full VRF infrastructure in mgmtd. We only need to
register vty commands.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-13 15:51:59 +02:00
Donatas Abraitis
9a042e0ba7
Merge pull request #15144 from LabNConsulting/chopps/cov-issue-2
...
lib: fix coverity issue
2024-01-12 23:38:23 +02:00
Donald Sharp
22427b5392
pimd: Use vrf name instead of id in some debugs
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2024-01-12 15:04:59 -05:00
Donald Sharp
413c0ebe5b
pimd: Re-align pim_msg_get_jp_group_size
...
This function was/is heavily indented, let's refactor
this a bit.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2024-01-12 15:04:59 -05:00
Donald Sharp
8006207a92
Merge pull request #15138 from opensourcerouting/fix/drop_unused_var_bgp_damp
...
bgpd: Drop dampening `tmax` variable from struct
2024-01-12 14:34:46 -05:00
Donatas Abraitis
945318802e
Merge pull request #15121 from routingrocks/rajesh/bgp_peer_ttl
...
bgpd: Set correct TTL for the dynamic neighbor peers
2024-01-12 20:26:34 +02:00
Donatas Abraitis
ef85d4f5c3
Merge pull request #15130 from donaldsharp/pim_vxlan_issues
...
Pim vxlan issues
2024-01-12 20:26:10 +02:00
Christian Hopps
008ba3e3fb
lib: fix coverity issue
...
** CID 1575595: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-01-12 16:37:30 +00:00
Donatas Abraitis
d2c275a793
Merge pull request #15133 from LabNConsulting/chopps/coverity-fixes
...
lib: fix coverity issues
2024-01-12 16:06:26 +02:00
Igor Ryzhov
64d9f2f70d
mgmtd: remove redundant next_phase variable
...
next_phase is always curr_phase + 1. It's not necessary to maintain it
separately. Also rename curr_phase to phase.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-01-12 13:29:15 +02:00
Christian Hopps
20d0d475cb
Merge pull request #14542 from idryzhov/nb-op-cb-split
...
Add more northbound operation types
2024-01-12 06:07:57 -05:00
Seyed Pouria Mousavizadeh Tehrani
17eb8599c5
build: make buildtest.sh BSD compatible
...
Signed-off-by: Seyed Pouria Mousavizadeh Tehrani <p.mousavizadeh@protonmail.com>
2024-01-12 14:08:10 +03:30
Donatas Abraitis
0f5a79af96
Merge pull request #15136 from idryzhov/ignore-cbs
...
lib, mgmtd: rename ignore_cbs to ignore_cfg_cbs
2024-01-12 11:56:59 +02:00
Donatas Abraitis
a3ad0d21fb
bgpd: Drop dampening tmax
variable from struct
...
Not used anywhere.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-01-12 11:29:43 +02:00
Christian Hopps
e1ec5b74a2
Merge pull request #15127 from opensourcerouting/fix/doc_libyang_artifacts
...
doc: libyang nits
2024-01-12 03:32:37 -05:00