proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-06 09:00:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Set ADD-PATH capability received flag only if parsed correctly

Browse Source 
If we receive a malformed packet, we might end-up with a bad state.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2024-01-16 14:36:20 +02:00
parent b571176aea
commit 9b178d246e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_open.c
View File

@ -662,8 +662,6 @@ static int bgp_capability_addpath(struct peer *peer,
struct stream *s = BGP_INPUT(peer);
size_t end = stream_get_getp(s) + hdr->length;
SET_FLAG(peer->cap, PEER_CAP_ADDPATH_RCV);
/* Verify length is a multiple of 4 */
if (hdr->length % CAPABILITY_CODE_ADDPATH_LEN) {
flog_warn(
@ -673,6 +671,8 @@ static int bgp_capability_addpath(struct peer *peer,
return -1;
}
SET_FLAG(peer->cap, PEER_CAP_ADDPATH_RCV);
while (stream_get_getp(s) + CAPABILITY_CODE_ADDPATH_LEN <= end) {
afi_t afi;
safi_t safi;