Igor Ryzhov
b8c01bba53
Merge pull request #9486 from slankdev/slankdev-srv6-no-cli-1
...
CLI to delete SRv6 locator
2021-09-14 19:04:03 +03:00
Hiroki Shirokura
0249b8b612
bgpd: add no-cli for srv6 on bgpd-side
...
(1) Implement zapi wrapper func to release srv6-locator-chunk
(2) Implement no locator NAME command
router bgp 1
segment-routing srv6
no locator loc1
(3) Implement no segment-routing srv6 command
router bgp 1
no segment-routing srv6
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2021-09-13 22:38:25 +00:00
Donatas Abraitis
565e9ddded
bgpd: Do not strip peer's description by whitespace in show bgp summary
...
```
~/frr# vtysh -c 'show run' | grep description
neighbor 192.168.0.2 description test 1 2 3
~/frr# vtysh -c 'show ip bgp summary' | grep -E "Desc|192.168.0.2"
Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc
192.168.0.2 4 0 0 0 0 0 0 never Connect 0 test 1 2 3
```
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-09-09 14:15:48 +03:00
Russ White
dd786181cc
Merge pull request #9539 from ton31337/fix/floating_point_cli
...
bgpd: Replace `Enable` to `Disable` for floating-point bw encoding CLI
2021-09-07 10:57:24 -04:00
Donatas Abraitis
53ca9cc9d9
Merge pull request #9561 from idryzhov/bgp-no-router-vrf-default
...
bgpd: fix "no router bgp X vrf default"
2021-09-06 12:41:20 +03:00
Igor Ryzhov
5c2ef87104
Merge pull request #9547 from ton31337/fix/addpath_non_json_broken
...
bgpd: Drop afi/safi duplicate string notation for AddPath capability
2021-09-06 12:33:01 +03:00
Igor Ryzhov
1ca42c8d84
bgpd: fix "no router bgp X vrf default"
...
Currently, "vrf default" modifier is not processed correctly and we get
the `% Can't find BGP instance` error.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-09-03 19:39:53 +03:00
Donatas Abraitis
7c0e43123d
bgpd: Add disable-addpath-rx
knob
...
The idea is to disable addpath-rx capability to avoid unnecessary additional
routes installed.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-09-03 15:05:02 +03:00
Donatas Abraitis
34c71a4da8
bgpd: Drop afi/safi duplicate string notation for AddPath capability
...
Before:
```
AddPath:
IPv4 Unicast: TX advertised IPv4 Unicast and received
IPv4 Unicast: RX advertised IPv4 Unicast and received
IPv6 Unicast: TX advertised IPv6 Unicast
IPv6 Unicast: RX advertised IPv6 Unicast
```
After:
```
AddPath:
IPv4 Unicast: TX advertised and received
IPv4 Unicast: RX advertised and received
IPv6 Unicast: TX advertised
IPv6 Unicast: RX advertised
```
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-09-03 14:01:44 +03:00
Donatas Abraitis
7ab294ea05
bgpd: Replace Enable
to Disable
for floating-point bw encoding CLI
...
At the begining there was a command to enable floating-point encoding,
but now it's default and can be disabled. Documentation was updated, but
CLI - missed, sorry, fixing.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-09-02 09:16:14 +03:00
Russ White
8811ce0beb
Merge pull request #9469 from ton31337/fix/extcommunity_bandwidth_floating_to_hex
...
bgpd: Use IEEE-754 Floating Point for storing extcommunity bandwidth
2021-09-01 12:56:45 -04:00
Donatas Abraitis
e5fbfe01ae
Merge pull request #9318 from Prerana-GB/ibgp_knob
...
bgp: BGP knob for faster convergence of bgp sessions
2021-09-01 10:45:27 +03:00
Donatas Abraitis
419db184af
Merge pull request #9397 from tkms1122/master
...
bgpd: minimum-holdtime knob to prevent session establishment with BGP peer with low holdtime.
2021-09-01 10:33:59 +03:00
Donatas Abraitis
294d842565
bgpd: Drop redundand WORD
for no_neighbor_interface_cmd
...
Just to be consistent with neighbor_interface_cmd.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-30 19:07:47 +03:00
Donatas Abraitis
27aa23a43b
bgpd: Add neighbor PEER link-bw-encoding-ieee
...
This is to avoid breaking changes between existing deployments of
extended community for bandwidth encoding. By default FRR uses uint32
to encode bandwidth, which is not as the draft requires (IEEE floating-point).
This switch enables the required encoding per-peer.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-30 14:21:49 +03:00
Sri Mohana Singamsetty
8930d8d75b
Merge pull request #9473 from ton31337/fix/BGP_STR_unified
...
bgpd: Use BGP_STR for CLI definitions everywhere for BGP CLI
2021-08-27 13:28:57 -07:00
Donatas Abraitis
e92739870d
bgpd: Use BGP_STR for CLI definitions everywhere for BGP CLI
...
Just have some cleanup.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-24 17:38:39 +03:00
Prerana-GB
f852eb9833
bgpd: BGP knob to teardown session immediately when peer is unreachable
...
When BGP is notified by RIB that peer address is unreachable then BGP session must be brought
down immediately and not wait for the hold-timer expiry. Today single-hop EBGP already behaves
this way but need to change for iBGP and multi-hop EBGP sessions.
Signed-off-by: Prerana G.B <prerana@vmware.com>, Pushpasis Sarkar <spushpasis@vmware.com>
2021-08-24 12:23:38 +00:00
Igor Ryzhov
07679ad98a
*: explicitly print "exit" at the end of every node config
...
There is a possibility that the same line can be matched as a command in
some node and its parent node. In this case, when reading the config,
this line is always executed as a command of the child node.
For example, with the following config:
```
router ospf
network 193.168.0.0/16 area 0
!
mpls ldp
discovery hello interval 111
!
```
Line `mpls ldp` is processed as command `mpls ldp-sync` inside the
`router ospf` node. This leads to a complete loss of `mpls ldp` node
configuration.
To eliminate this issue and all possible similar issues, let's print an
explicit "exit" at the end of every node config.
This commit also changes indentation for a couple of existing exit
commands so that all existing commands are on the same level as their
corresponding node-entering commands.
Fixes #9206 .
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-23 22:08:20 +03:00
Ryoga Saito
53970de3c2
bpgd: add missing sid setting in address-family
...
current bgpd doesn't write sid setting, resulting to fail to save
configuration correctly.
Signed-off-by: Ryoga Saito <contact@proelbtn.com>
2021-08-19 05:59:32 +00:00
Ryoga Saito
ff7c3ee1cc
bpgd: add "exit" at the end of bgp srv6 setting
...
without "exit", when frr is starting up, frr fails to load
address-family setting correctly.
Signed-off-by: Ryoga Saito <contact@proelbtn.com>
2021-08-19 05:47:20 +00:00
Takemasa Imada
b042667a3d
bgpd: minimum-holdtime knob to prevent session establishment with BGP peer with low holdtime.
...
Signed-off-by: Takemasa Imada <takemasa.imada@gmail.com>
2021-08-15 06:08:08 +09:00
Donatas Abraitis
225096bcd1
bgpd: Auto-complete for community lists
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-10 10:56:26 +03:00
Donald Sharp
883da9f5ec
Merge pull request #9256 from idryzhov/dampening-revert
...
BGP per-peer dampening revert
2021-08-06 10:46:09 -04:00
Igor Ryzhov
1ca2fd1175
Revert "bgpd: convert global config to transactional cli"
...
This reverts commit ff8a8a7ac1
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 23:36:31 +03:00
Igor Ryzhov
66d2a8553b
Revert "bgpd: correct bgp global context"
...
This reverts commit 87ce25646b
.
2021-08-03 23:36:31 +03:00
Igor Ryzhov
56648eab39
Revert "bgpd: move router bgp nb callback"
...
This reverts commit 5e42cb2fb0
.
2021-08-03 23:36:31 +03:00
Igor Ryzhov
8382083a8f
Revert "bgpd: no router bgp check candidate config"
...
This reverts commit 4b63e358bc
.
2021-08-03 23:36:31 +03:00
Igor Ryzhov
31acf04aa4
Revert "bgpd: Use default VRF name if using router bgp
command"
...
This reverts commit 5ce106b72b
.
2021-08-03 23:36:31 +03:00
Igor Ryzhov
2fc82a12fb
Revert "bgpd: fix crash in bgp instance creation"
...
This reverts commit a5ab756f24
.
2021-08-03 23:36:31 +03:00
Igor Ryzhov
585f1adc4f
Revert "bgpd: convert addr-family clis to transactional clis"
...
This reverts commit 37a87b8f98
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 23:36:30 +03:00
Igor Ryzhov
28c6e24701
Revert "bgpd: neighbor peergrp config to transactional cli"
...
This reverts commit f4b8ec0721
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 22:29:13 +03:00
Igor Ryzhov
7e62b79286
Revert "bgpd: convert max prefix clis to transactional"
...
This reverts commit 04261decb9
.
2021-08-03 22:20:53 +03:00
Igor Ryzhov
c36bc05fcd
Revert "bgpd: convert neighbor peer config to transactional"
...
This reverts commit 8611c7f3b6
.
2021-08-03 22:20:53 +03:00
Igor Ryzhov
56ceae8462
Revert "bgpd: fix compiler warnings in nbr cmd"
...
This reverts commit 555c8ab7ad
.
2021-08-03 22:20:52 +03:00
Igor Ryzhov
1d80f243b4
Revert "bgpd: convert to yang modeled nbr cmds"
...
This reverts commit 232c75cd03
.
2021-08-03 22:20:52 +03:00
Igor Ryzhov
642ef66443
Revert "bgpd: convert neighbor plist to transactional cli"
...
This reverts commit d9986d26c0
.
2021-08-03 22:20:52 +03:00
Igor Ryzhov
0ea8d871c5
Revert "bgpd: convert nbr rmap transactional cli"
...
This reverts commit c668557533
.
2021-08-03 22:20:52 +03:00
Igor Ryzhov
2373db75f7
Revert "bgpd: Temp fix to allow numbered peers to be part of a peer group"
...
This reverts commit 2a059a5448
.
2021-08-03 22:20:52 +03:00
Igor Ryzhov
d6d7ed37c9
Revert "bgpd: Remove hidden neighbor X route-map Y <in|out>
command"
...
This reverts commit 4c3e9f072a
.
2021-08-03 22:20:51 +03:00
Igor Ryzhov
f63d4054d1
Revert "bgpd: convert send-community to transactional cli"
...
This reverts commit e48a9a90e0
.
2021-08-03 22:20:51 +03:00
Igor Ryzhov
4fd9919ecf
Revert "bgpd: remove duplicated checks from CLI"
...
This reverts commit 45d1d7c9a2
.
2021-08-03 22:20:51 +03:00
Igor Ryzhov
1abef40fb3
Revert "bgpd: don't use operational state in "router bgp" command"
...
This reverts commit 4062b455a6
.
2021-08-03 22:14:19 +03:00
Igor Ryzhov
cfb37710bc
Revert "bgpd: forbid modification of bgp instance type"
...
This reverts commit d3e3677096
.
2021-08-03 22:14:06 +03:00
Igor Ryzhov
9c605264e9
Revert "bgpd: don't return error for GR no-op commands"
...
This reverts commit 895b0d0ad6
.
2021-08-03 22:14:06 +03:00
Igor Ryzhov
6c75f4b3c7
Revert "bgpd: vtysh commands for peer/group dampening profiles"
...
This reverts commit 0221327c75
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
5979fde0d8
Revert "bgpd: Do not output peer doppleganger dampened output"
...
This reverts commit 783492c7cd
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Igor Ryzhov
75caa18cef
Revert "bgpd: Consolidate dampening show run output with the rest of that code"
...
This reverts commit 39d8dd2d17
.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-03 21:54:47 +03:00
Donald Sharp
a17cfb3fda
bgpd: Mark the node as the correct type for bgp ipv6 unicast
...
The bgp ipv6 unicast node should be called `bgp ipv6 unicast`
to make it consistent with other nodes where we list the afi/safi
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28 10:56:48 -04:00
Donald Sharp
b4ad2fae54
bgpd: Allow for auto-completion of community alias's created
...
Add a bit of code to allow for auto-completion of the community
alias command when attempting to use it for show commands.
example:
eva(config)# bgp community alias 11:22 FOO
eva(config)# end
eva# show bgp ipv4 uni alias
ALIAS_NAME BGP community alias
FOO
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-16 09:52:53 -04:00