Commit Graph

11304 Commits

Author SHA1 Message Date
Martin Winter
b4c554e24f redhat: Fix RPKI RPM build option
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2018-05-20 07:13:02 -07:00
Rafael Zalamena
a44ed5bd8c
Merge pull request #2260 from qlyoung/fix-docs-distclean
doc: fix distclean
2018-05-19 22:30:18 -03:00
Renato Westphal
72a8513e64
Merge pull request #2261 from qlyoung/fix-missing-doc
Fix missing dist files
2018-05-19 10:30:32 -03:00
Quentin Young
ecbe4344af tests: add missing file to Makefile.am
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-05-18 19:45:10 +00:00
Quentin Young
037089f83b doc: add missing file to Makefile.am
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-05-18 19:44:58 +00:00
Quentin Young
9eb51ce361 doc: fix distclean
Apparently Automake has some undocumented logic somewhere that makes it
so any Makefile generated from an Automake Makefile.am is removed from
its secret list of things to delete that it deletes when performing a
recursive distclean before actually performing the recursive distclean
and since the secret list is automatically generated from the list of
things that Autoconf should generate in configure.ac we can't remove the
Makefile from that list or it will break Automake's list of things to
automatically generate that it generates from Autoconf's list of things
to automatically generate.

Thus, to prevent Automake from deleting Makefiles and then immediately
trying to use the Makefiles it just deleted to delete said Makefiles, we
must remove ourselves from the secret list, which is accomplished by
changing the file extension to '.am' instead of '.in'.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-05-18 19:35:24 +00:00
Donald Sharp
29be7d92cc
Merge pull request #2198 from LabNConsulting/working/master/bgpd-nht-crash
bgpd: fix NHT free when nht_info is null (fixes crash)
2018-05-18 07:51:06 -04:00
Russ White
1cbbd4950b
Merge pull request #2231 from ppmathis/fix/clear-bgp-afi
bgpd: Respect AFI/SAFI when hard-clearing a peer
2018-05-18 02:48:59 -04:00
Russ White
4ae3a2de37
Merge pull request #2252 from donaldsharp/instance_rm_match
Instance routemap match
2018-05-18 02:41:23 -04:00
Russ White
eeb1b4ed89
Merge pull request #2253 from chiragshah6/ospfv3_dev
ospf6d: Fix ECMP for asbr external routes
2018-05-18 02:39:28 -04:00
Russ White
c66932f7e7
Merge pull request #2255 from donaldsharp/rt_netlink_dirty_bits
Some Valgrind issues found
2018-05-18 02:37:54 -04:00
Donald Sharp
987d819873 bgpd: Clean up some evpn memory leaks
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 18:54:25 -04:00
Donald Sharp
5605ecfc1f zebra: memset buf to prevent uninited writes into kernel
Setup the buf used for extra data passed into kernel such
that we are cleaning it out before writing data to it,
so we can avoid writing uninited data.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 18:46:14 -04:00
Chirag Shah
804a329410 ospf6d: Fix ECMP for asbr external routes
Use brouter table to fetch nexthops for
asbr prefix (external) routes.
Change adv. router of the router's path once
the DB/FIB is updated with effective nexthops.
Cleanup of nexthop update when route's adv
router changes cost.

Ticket:CM-16139
Testing Done:
Tested ASBR external routes in CLOS topology with
multiple paths asbr originator at tor to spine.
Validated external route's nexthop within
area and inter area.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2018-05-17 11:10:09 -07:00
Quentin Young
21c84871cf
Merge pull request #2221 from rodnymolina/vtysh_extension
vtysh: Extending vtysh to allow question-mark cmds
2018-05-17 13:03:11 -04:00
Donald Sharp
af21c68244 doc: Add some doc for source-instance
Add the documentation for match source-instance.
I also noticed that 'match source-protocol' was missing
add that in too.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 11:05:08 -04:00
Donald Sharp
ae252c027f sharp: Allow the specification of instance when adding/deleting routes
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 10:59:17 -04:00
Donald Sharp
808afce955 sharpd: Add some ability to ignore route-map commands
Add some ability for sharpd to ignore the route-map commands
when using a integrated config.

signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 10:59:17 -04:00
Donald Sharp
3b83faf238 zebra: Add sharp to protocols that you can match source-protocol on
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 10:59:17 -04:00
Donald Sharp
633a66a586 zebra: Add 'match source-instance' to allow finer grained control
Add to zebra route-maps the ability to match on a source-instance

route-map FOO deny 55
 match source-instance 5
route-map FOO permit 60

ip protocol any route-map FOO

This will match any protocol route installation with a source-instance of 5.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-17 10:57:59 -04:00
Rafael Zalamena
7bed0c42d5
Merge pull request #2200 from qlyoung/docuser-gettingstarted
doc: add "Getting Started" section
2018-05-16 18:24:36 -03:00
Lou Berger
cb0fd829f3
Merge pull request #2247 from donaldsharp/sa_sa_sa
3 SA issues fixed.
2018-05-16 16:59:50 -04:00
Quentin Young
3a7177f0fe doc: remove notes about ipv6 packages
Kernel 2.2 was released in 1999, I'm pretty sure everybody has it by
now. Plus these links don't even exist anymore.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-05-16 20:24:19 +00:00
Quentin Young
717b48667f doc: add "Getting Started" section
While we have docs on various pieces of the build system we don't have
any docs on how to actually get FRR running once it's installed, nor do
we have comprehensive documentation on the basic procedure for building
from source. This patch remedies both of those.

Also updated the services list in the docs and removed the SERVICES file
from the project root.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-05-16 20:24:15 +00:00
Donald Sharp
51f9d3e70f
Merge pull request #2034 from vincentbernat/fix/rfc8365-auto-rt
bgpd: add an option for RT auto-derivation to use RFC 8635.
2018-05-16 12:13:04 -04:00
Martin Winter
c7e35331e3
Merge pull request #2240 from donaldsharp/ubuntu_bull
Ubuntu 18.04 fixes
2018-05-16 08:36:21 -07:00
Donald Sharp
c7ee6c35cb bgpd: Fix memory leak of ecommunity_ecom2str
The creation of a temporary string for the ecommunity
was being leaked when debugging is enabled.  Write
a bit of code to prevent this.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-16 09:59:06 -04:00
Donald Sharp
4b85140f5a bgpd: remove unnecessary test and allocate a bit earlier
The bgp_info_extra_get call gets the extra pointer, which
is also needed for the setlabels() call, so move the call
to above the setlabels.

Also remove an unnecessary test of a pointer since we
have already dereferenced it by the time we are testing
for it's existence.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-16 09:57:42 -04:00
Donald Sharp
9d1448357e vtysh: Fix leaked memory in error case
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-16 09:56:16 -04:00
Russ White
5d5f37c400
Merge pull request #2226 from ppmathis/feature/bgp-lc-json
bgpd: Improve JSON support for large communities
2018-05-15 21:05:21 -04:00
Quentin Young
f135190086
Merge pull request #2241 from brotherdust/docdev-ubuntu-1804-build-guide
docdev: Ubuntu 1804 build guide
2018-05-15 17:57:08 -04:00
Jarad Olson
b2c8e6f847 Suggested changes by @qlyoung
- Changed hard-linked references to soft-link
- Changed configuration options from code block to ``.. option::`` blocks

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 14:04:54 -06:00
Donald Sharp
053673aea7
Merge pull request #2239 from ppmathis/enhancement/bgp-routemap-afi
bgpd: Improve route-map matching for INET(6) AF
2018-05-15 14:46:12 -04:00
Jarad Olson
d5c8283249 Add more detail around confiugration files
Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 12:25:07 -06:00
Jarad Olson
bd93831438 Re-worded information on MPLS support in 18.04
Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 12:04:48 -06:00
Jarad Olson
d0648b3e67 Fixup code block formatting errors
Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 12:01:11 -06:00
Donald Sharp
430892165e bgpd: Prevent possible uninited variable.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-15 13:57:40 -04:00
Jarad Olson
0beb75be81 Changed apt-get to sudo apt-get
Context should be unpriviliged until explicity stated.

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:52:32 -06:00
Jarad Olson
140b0a5ea2 Split compile section into more granular steps
- Added reference for additional configure options
- Added configure options for 0MQ and Protobuf

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:52:05 -06:00
Donald Sharp
06210d1f40 pbrd: Fix compilation warn -> error
The buffer size was insufficiently sized to hold the
entirety of the data being passed in.

Modify the nht code to use a bit bigger buffer.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-05-15 13:52:02 -04:00
Jarad Olson
47f64e3408 Added optional packages section
Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:51:40 -06:00
Jarad Olson
acdc582fd5 Change 'Install required packages' to 'Install dependencies'
Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:51:14 -06:00
Jarad Olson
07b17fdbf7 Change style of required packages list
The required packages list should be easier to parse. Updated the style so it's more similar to the ``./configure`` style later in the document.

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:50:34 -06:00
Jarad Olson
6d30cb199c MPLS kernel module name change
Names of the MPLS kernel modules changed slightly in recent kernel. Uses underscore instead of dash.

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:50:00 -06:00
Jarad Olson
a500c91ad5 Change order of MPLS configuration
MPLS kernel modules should be initialized *before* enabling forwarding. Otherwise, errors.

Signed-off-by: Jarad Olson <brotherdust+github@gmail.com>
2018-05-15 11:49:18 -06:00
Pascal Mathis
09cd98ebee
bgpd: Improve route-map matching for INET(6) AF
While the current implementation does pay attention to the AF
(inet/inet6) when comparing the IPv4/v6 address against an address-list
/ prefix-list inside a route-map, the AF check is being done rather
late, which leads to CPU cycles being wasted due to unnecessary list
lookups / address matching.

This commit checks the address family of a prefix right inside the
`route_match_ip(v6)_` functions before looking up any address- and/or
prefix-list, which should improve performance.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-15 19:44:06 +02:00
Rafael Zalamena
05c6f6a3c2
Merge pull request #2101 from qlyoung/stream-fifo-safe
lib: add mt-safe variants for stream_fifo ops
2018-05-15 12:29:45 -03:00
Renato Westphal
02dd46dabc
Merge pull request #2229 from qlyoung/fix-readme-typo
frr: fix typo in README
2018-05-15 11:58:27 -03:00
Renato Westphal
f403d10280
Merge pull request #2133 from Fredi-raspall/fix_label_manager
Fix broken label manager (proxy-mode) and improve of proxy function
2018-05-15 10:00:12 -03:00
Pascal Mathis
3ae8bfa5d8
bgpd: Respect AFI/SAFI when hard-clearing a peer
The current implementation does not respect the AFI+SAFI combination of
a peer when executing a non-soft (hard) clear. An example would be the
command `clear bgp ipv4 unicast *`, which will clear all BGP peers, even
those that do not have IPv4-Unicast activated.

This commit fixes that behavior by applying the same rules to both soft
and hard clear commands, so that peers without a matching AFI+SAFI
combination will be no longer modified.

Additionally, this commit adds warning messages to all `clear bgp
[<afi>] [<safi>] <target>` commands when no matching peers with the given
AFI+SAFI combination could be found.

Both existing and new warning messages have been extended to also
mention the AFI+SAFI combination that is missing, which is more helpful
to the user than a generic expression 'No peer configured'.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-14 22:52:31 +02:00