Donald Sharp
b46d3a1a42
tests: bgp_srv6_sid_reachability should give more time
...
The test starts right in on check_pings with a 10 second
time out. Any type of delay on startup is going to cause
problems. Give the first check_ping significant time
for the test to be fully brought up.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2025-01-09 10:31:07 -05:00
Jafar Al-Gharaibeh
465d286819
Merge pull request #17798 from mjstapp/fix_remove_clear_thread
...
libs: remove deprecated 'clear thread' cli
2025-01-09 09:01:33 -06:00
Donald Sharp
3d7dbcf6c6
Merge pull request #17795 from gromit1811/bugfix_priv_syscaps_alloc
...
lib: Fix privs syscaps (pset_t) allocation
2025-01-08 10:20:11 -05:00
Mark Stapp
cb119907f0
libs: remove deprecated 'clear thread' cli
...
Remove a deprecated 'clear thread cpu' command.
Signed-off-by: Mark Stapp <mjs@cisco.com>
2025-01-08 10:17:51 -05:00
Donald Sharp
068a637a46
Merge pull request #17778 from enkechen-panw/aggr-fix
...
bgpd: add a debug command for route aggregation
2025-01-08 08:57:54 -05:00
Martin Buck
4ed9147d98
lib: Fix privs syscaps (pset_t) allocation
...
Don't over-allocate syscaps in zcaps2sys(): This is just a single struct
(pset_t) with a count and a pointer to an array of capabilities, not an
array. So only allocate a single pset_t, not num copies of it.
The allocation size of syscaps->caps then needs to be based on the number of
Linux capabilities (count), but that is already handled properly a few lines
below.
Note that this fix is mostly cosmetic and for correctness. There was no
potential for memory corruption, because num is guaranteed to be nonzero. So
at least the one required pset_t was always allocated (but potentially much
more).
Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
2025-01-08 10:38:56 +01:00
Enke Chen
2a19daa830
bgpd: add debugging command for route aggregation
...
Add a new debugging command:
debug bgp aggregate [prefix <A.B.C.D/M|X:X::X:X/M>]
Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
2025-01-07 22:52:41 -08:00
Russ White
21fe1f4d83
Merge pull request #17707 from gromit1811/pr16811_rebased
...
tests: cleanup ospf6 ecmp inter area
2025-01-07 16:14:15 -05:00
Donald Sharp
cc07a4a200
Merge pull request #17772 from LabNConsulting/chopps/fix-oper-walk
...
improve error handling of operational state walk callback
2025-01-07 13:52:37 -05:00
Donald Sharp
96ab6ae32b
Merge pull request #17781 from LabNConsulting/chopps/fix-keyless-list-query
...
fix xpath query on keyless list with positional predicate
2025-01-07 13:17:37 -05:00
Donald Sharp
0a52c233d3
Merge pull request #17782 from LabNConsulting/chopps/new-notify-msg-fmt
...
New YANG notify msg fmt
2025-01-07 13:15:40 -05:00
Donald Sharp
1a7923e7bc
Merge pull request #17783 from LabNConsulting/chopps/new-oper-get-callback
...
Add new oper state get callback
2025-01-07 13:11:26 -05:00
Russ White
8168dd931d
Merge pull request #17725 from opensourcerouting/fix/full_no_form_for_area-password
...
isisd: Allow full `no` form for `domain-password` and `area-password`
2025-01-07 09:41:39 -05:00
Russ White
6060d8b347
Merge pull request #17723 from opensourcerouting/fix/bgpd_metric_worse
...
bgpd: Respect `bgp bestpath missing-as-worst` for `table-map` as well
2025-01-07 09:41:08 -05:00
Russ White
8ed117ae19
Merge pull request #17700 from Andrew-Dickinson/fix-socket-gc
...
ospfclient: fix crash due to streamwriter garbage collect
2025-01-07 09:38:05 -05:00
Martin Buck
a09d98a95e
tests: ospf6_ecmp_inter_area, no shutdown r7/r8 eth3
...
Drop eth3 shutdown from ospf6d.conf - it doesn't do anything there. And it
actually shouldn't do anything: eth3 on r7/r8 are used as loopback-like
interfaces to inject the address on eth2 into OSPFv3. So they need to be up
for eth2 to work as expected.
Based on original PR#16811 commit:
eth3 shutdown is not applied because it is ospf6d.conf.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
2025-01-07 15:22:02 +01:00
Martin Buck
763069cd3b
tests: ospf6_ecmp_inter_area, use router_json_cmp
...
Use router_json_cmp when checking for proper nexthops to get better
diagnostics in case of mismatches. Add step() messages to see which check
failed.
Based on original PR#16811 commit:
expect_num_nexthops() errors are not understandable.
Use router_json_cmp.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
2025-01-07 15:21:58 +01:00
Russ White
2a90c80f49
Merge pull request #17733 from pguibert6WIND/bmp_event_changes
...
BMP handling of BGP configuration changes
2025-01-07 09:06:43 -05:00
Russ White
16d1a880d3
Merge pull request #17771 from opensourcerouting/fix/show_ifindex_bgp
...
bgpd: Show ifindex for every BGP nexthop cache entry
2025-01-07 09:03:33 -05:00
Russ White
5d75339c12
Merge pull request #17773 from LabNConsulting/chopps/more-oper-test-fix
...
tests: improve test reliability
2025-01-07 09:02:41 -05:00
Russ White
ff794c5ffe
Merge pull request #17774 from famfo/doc/alpine
...
doc: fix building for alpine package path
2025-01-07 09:01:29 -05:00
Russ White
88f80328ca
Merge pull request #17779 from anlancs/ospfd/fix-wrong-check-summary
...
ospfd: fix wrong check for two commands
2025-01-07 08:56:36 -05:00
Russ White
1b13705517
Merge pull request #17667 from opensourcerouting/fix/withdraw_routes_regarless_of_coalescing_timer_to_expire_path_info_unusable
...
bgpd: Withdraw routes without waiting for the coalescing timer to expire
2025-01-07 08:54:52 -05:00
Russ White
7f2be9a595
Merge pull request #17474 from sougata-github-nvidia/rib_ip_protocol_cleanup
...
zebra: Fix ip protocol route-map issue.
2025-01-07 08:45:07 -05:00
Russ White
c9c9608c70
Merge pull request #17431 from krishna-samy/bgpd_json_commits
...
bgpd: show json output changes to optimize various show commands
2025-01-07 08:43:55 -05:00
Christian Hopps
e729676cfe
tests: add test for new northbound get function
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 07:01:46 -05:00
Christian Hopps
4379066fdd
lib: if.c use new get() oper callback
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 06:59:15 -05:00
Donatas Abraitis
a92231af4d
Merge pull request #17780 from enkechen-panw/allowas-fix
...
bgpd: fix a bug in peer_allowas_in_set()
2025-01-07 13:13:36 +02:00
Christian Hopps
5755ce395b
tests: fe-client: only pick mgmtd FE notify selectors once
...
- adapt fe_client to new notification message format
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 05:34:11 -05:00
Christian Hopps
0ca710bb5f
lib: add impl of NOTIF message ops (notif, replace, delete, patch)
...
- needed for supporting backend datastore notifications
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 05:34:09 -05:00
Christian Hopps
30777991c0
lib: add NOTIF message ops (notification, replace, delete, patch)
...
- needed for supporting backend datastore notifications
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 05:34:06 -05:00
Christian Hopps
153c06043b
tools: add new-style get operation callback support
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 05:33:32 -05:00
Christian Hopps
36f25da612
lib: northbound: add new get() callback to add lyd_node direclty
...
This allows eliminating the superfluous yang_data object (which
is getting created used to call lyd_new_term then deleted). Instead
just call lyd_new_term() in the callback directly.
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 05:33:28 -05:00
Christian Hopps
bdfb6a3db7
tools: we specifically added %Lu to our sprintfrr so allow it
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 01:34:13 -05:00
Christian Hopps
0ce15fb0f7
tests: add unit test case for keyless list xpath queries
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 01:24:38 -05:00
Christian Hopps
2fb6519c52
lib: northbound oper: fix keyless position predicate queries
...
- i.e., `show /foos/foo[1]`
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-07 01:24:14 -05:00
Enke Chen
bcd1017794
bgpd: fix a bug in peer_allowas_in_set()
...
Fix a bug in peer_allowas_in_set() so that the config takes effect
for peer-group members.
Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
2025-01-06 21:01:14 -08:00
anlan_cs
533d387a7f
ospfd: fix wrong check for two commands
...
The users would know the failure of some case for the two commands, just
return the error ```CMD_WARNING_CONFIG_FAILED```.
Signed-off-by: anlan_cs <anlan_cs@126.com>
2025-01-07 10:58:03 +08:00
Donald Sharp
86fdf0198c
Merge pull request #17770 from opensourcerouting/fix/BGP_NEXTHOP_EVPN_INCOMPLETE
...
bgpd: Use unique value for BGP_NEXTHOP_EVPN_INCOMPLETE flag
2025-01-06 13:25:02 -05:00
famfo
7634db06d9
doc: fix building-for-alpine package path
...
Signed-off-by: famfo <famfo@famfo.xyz>
2025-01-06 16:25:56 +01:00
Christian Hopps
c5a2a65122
tests: improve test reliability
...
Test for presence of IPv6 kernel routes too.
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-06 08:53:12 -05:00
Christian Hopps
9aa2b04874
lib: change and improve walk finish callback function API
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-06 08:07:41 -05:00
Christian Hopps
5ffa10aac1
mgmtd: improve debug statement
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-01-06 08:07:36 -05:00
Donatas Abraitis
f8aa53be30
bgpd: Show ifindex for every BGP nexthop cache entry
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2025-01-06 14:57:58 +02:00
Donatas Abraitis
0313bf98a5
bgpd: Use unique value for BGP_NEXTHOP_EVPN_INCOMPLETE flag
...
This was reused with BGP_NEXTHOP_ULTIMATE by error.
Fixes: 93fd9cbb50
("bgpd: Validate imported routes next-hop that is in a default VRF")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2025-01-06 14:57:14 +02:00
Sougata Barik
86b294698f
zebra: Fix ip protocol route-map issue.
...
"ip/ipv6 protocol any route-map <route map>" cli is setting
wrong route type ( ZEBRA_ROUTE_MAX ), It should set route type
ZEBRA_ROUTE_ALL.
Ticket: #4101560
Signed-off-by: Sougata Barik <sougatab@nvidia.com>
2025-01-06 17:02:21 +05:30
Jafar Al-Gharaibeh
8ca4c3d098
Merge pull request #17752 from raja-rajasekar/rajasekarr/comp_issue
...
zebra: fix dpdk compilation error
2025-01-05 20:15:20 -06:00
Donatas Abraitis
8824c3f025
Merge pull request #17750 from jvoss/vrf_rpki
...
tools: Add missing rpki keyword to vrf in frr-reload
2025-01-04 13:52:40 +02:00
Donatas Abraitis
c5fb0a9867
Merge pull request #17715 from ykholod/master-17413-1
...
babel: Clean babel related config on daemon stop
2025-01-04 13:51:03 +02:00
Donatas Abraitis
3424f22f86
Merge pull request #17762 from anlancs/fix/ospf-minor-word
...
ospfd: Correct one word
2025-01-04 13:49:22 +02:00