Commit Graph

20319 Commits

Author SHA1 Message Date
Chirag Shah
b37e4b282d *: pim igmp yang registery to appropriate makefile
Move pim and igmp yang files registery to appropriate makefiles.

In yang directory makefile move under `PIMD`
Remove pimd yang files from library makefile instead move them
to pimd makefile.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2020-07-22 23:22:23 -07:00
Quentin Young
9d9adc84c7
Merge pull request #6343 from opensourcerouting/watchfrr-n-20200505
watchfrr: add `-N` and `--netns` options
2020-07-22 12:07:14 -04:00
David Lamparter
aa01fe3f49 doc: update watchfrr manpage
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2020-07-22 12:56:04 +02:00
David Lamparter
e2986b1b27 tools: add frr@.service
... for starting an FRR instance.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2020-07-22 12:56:04 +02:00
David Lamparter
a0a7dead0b tools/frr-reload.py: support -N pathspace
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2020-07-22 12:56:04 +02:00
David Lamparter
33606a1547 watchfrr: add (network) namespace support
This adds -N and --netns options to watchfrr, allowing it to start
daemons with -N and switching network namespaces respectively.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2020-07-22 12:56:04 +02:00
Mark Stapp
832d7382c8
Merge pull request #6780 from chiragshah6/evpn_dev2
zebra: vrf disable clean up evpn rmac and nxthp cache
2020-07-21 16:08:13 -04:00
Quentin Young
65b86778c1
Merge pull request #6711 from GalaxyGorilla/bfd_isis_profiles
Add BFD profiles for IS-IS
2020-07-21 14:45:31 -04:00
Quentin Young
807b454043
Merge pull request #6435 from idryzhov/fix-no-vrf
vtysh: return success from "no vrf" when VRF doesn't exist
2020-07-21 11:48:34 -04:00
David Lamparter
a5d68ac07a
Merge pull request #6700 from deastoe/ospf6-interface-decimal-area 2020-07-21 13:42:59 +02:00
David Lamparter
97c8ca8808
Merge pull request #6777 from idryzhov/vtysh-defpy
vtysh: rework DEFPY processing in extract.pl
2020-07-21 13:36:33 +02:00
David Lamparter
eae0446618
Merge pull request #6745 from ton31337/fix/handle_bgp_vrf_all_statistics_crash 2020-07-21 08:01:22 +02:00
David Lamparter
49e5ca8633
Merge pull request #6764 from dslicenc/frr-reload-vrf-static
tools: fix more frr-reload vrf static errors
2020-07-21 07:51:55 +02:00
David Lamparter
b74032388c
Merge pull request #6776 from idryzhov/ospf-vty
ospfd: remove redundant line continuations
2020-07-21 07:49:11 +02:00
David Lamparter
40f75cc4a3
Merge pull request #6754 from mjstapp/stream_warn_backtrace
lib: add a backtrace when stream bounds check fails
2020-07-21 07:48:01 +02:00
David Lamparter
82ee69d95b
Merge pull request #6775 from idryzhov/vtysh-linemarkers
vtysh: suppress linemarkers in vtysh_cmd.c
2020-07-21 07:47:08 +02:00
Chirag Shah
92475ca487 zebra: vrf disable clean up evpn rmac nxthp cache
In networking restart event, l3vni (vxlan) interface followed by
associated vrf interfaces go down/deleted.
L3vni (oper) down event (from zebra to bgp) triggers to
clean up/un-import evpn routes (one-by-one) from the vrf table,
zebra internally removes the route entry from nexthop and RMAC hash.
When all the routes references in nexthop and RMAC db removed,
both (nexthop/rmac) are suppose to be uninstalled from the
bridge fdb and neigh table.
While evpn routes removal in progress, a vrf disable event removes
l3vni to its vrf association.
Subsequent bgp to evpn routes removal does not clean up thus evpn routes
reference to nexthop and RMAC remains in zebra hash.
bridge fdb and neigh tables are flushed out since networking restart brings down
all interfaces which results in flush of fdb and neigh tables.
By product is the zebra does not install nexthop and rmac when routes are re-imported
into vrf in VNI/VRF up event.

The fix is in vrf disable event to flush all l3vni's nexthop and rmac db.

Ticket:CM-30338
Reviewed By:CCR-10489
Testing Done:

Performed multiple networking restart and checked neigh and
bridge fdb tables for respective nexthop and router mac entry
programmed.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2020-07-20 20:58:20 -07:00
Renato Westphal
f1ed7d22d6
Merge pull request #6729 from volta-networks/fix_stale_pw_status
ldpd: Update LDP to process received pw-status in received order.
2020-07-20 12:28:58 -03:00
Igor Ryzhov
dc47ff5c3a vtysh: rework DEFPY processing in extract.pl
Currently, all DEFPY commands are translated into one-liners in
vtysh_cmd.c. After the patch, DEFPY commands are correctly indented just
like DEFUN/ALIAS commands.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-07-20 18:18:55 +03:00
Igor Ryzhov
7e5ee52226 ospfd: remove redundant line continuations
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-07-20 18:18:03 +03:00
Igor Ryzhov
2cd4f6a8ea vtysh: suppress linemarkers in vtysh_cmd.c
Remove lines like this from the vtysh_cmd.c:
```
# 10764 "bgpd/bgp_route.c"
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-07-20 18:17:24 +03:00
Karen Schoener
4272a06426 ldpd: process pw-status in received order
Update LDP to process received pw-status in received order.
Update LDP to save pw-status regardless of whether the PW is configured.
When the PW is configured, LDP checks for any saved PW pw-status.

Signed-off-by: Karen Schoener <karen@voltanet.io>
2020-07-20 09:08:15 -04:00
Mark Stapp
3211b92b8f lib: add a backtrace when stream bounds check fails
Add a backtrace call when the stream code detects a bounds error,
to help with debugging.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-20 07:31:49 -04:00
David Lamparter
67ce4ba19b
Merge pull request #6767 from donaldsharp/compile_issues 2020-07-19 11:36:38 +02:00
Santosh P K
3ab3b0f211
Merge pull request #6446 from chiragshah6/evpn_dev
zebra: rib operational nb add vrf key
2020-07-18 19:44:01 +05:30
Donald Sharp
d76c38ade3 pimd: Prevent Null string %s issues
There are couple spots where group may be NULL and
when we output strings associated with it we should
ensure we are not doing something stupid.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-18 09:46:06 -04:00
Donald Sharp
f177a83efc zebra: Possible write beyond buffer length
Prevent string manipulation where we might have data
passed into that is larger than the buffer we are pushing into.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-18 09:45:08 -04:00
Stephen Worley
55528234ea
Merge pull request #6753 from mjstapp/fix_zebra_backup_sa
zebra: fix SA warnings in backup nexthop code
2020-07-17 17:29:49 -04:00
Mark Stapp
a0f6893193
Merge pull request #6763 from donaldsharp/bgp_zebra_announce
bgpd: Remove memset from bgp_zebra_announce
2020-07-17 15:59:03 -04:00
Chirag Shah
20e310a9b2 zebra: rib operational nb add vrf key
Add vrf as key in Rib operational nexthop list

PR 6296 has added vrf as key in nexthop list.
Rib operational model uses nexthop list, adding
vrf key into northbound callback.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2020-07-17 11:58:25 -07:00
Don Slice
eb9113dfe3 tools: fix more frr-reload vrf static errors
Reported that in certain config changes, a static intended for the
default table would be duplicated into a vrf context.  Determined
that we still weren't keeping or adding the exit-vrf command when
necessary to keep the contexts straight.  Added logic to look for
the failing circumstances and add or remove the delete of the
exit-vrf command as needed.

Signed-off-by: Don Slice <dslice@nvidia.com>
2020-07-17 16:45:54 +00:00
Quentin Young
98145f13e2
Merge pull request #6760 from opensourcerouting/build-assorted-20200717
build & gcc-frr-format: assorted bits batch
2020-07-17 12:42:05 -04:00
Quentin Young
d58258e909
Merge pull request #6296 from vishaldhingra/static
staticd: static route NB configuration code
2020-07-17 12:39:03 -04:00
Donald Sharp
7cc27d418f bgpd: Remove memset from bgp_zebra_announce
During perf testing of receiving and installing 7.5 million
routes into zebra it was noticed that memset in bgp_zebra_announce
was taking ~11% of the runtime.  With this change bgp_zebra_announce
now no longer has any appreciable time spent in memset as reported
by perf.  In addition bgp_zebra_announce run time in perf was
reduced by a composite amount.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-17 10:07:17 -04:00
Mark Stapp
7d4b857955
Merge pull request #6705 from sworleys/PBR-Fixes-More
pbrd: A couple pbr fixes
2020-07-17 08:54:54 -04:00
Mark Stapp
54651eaef9
Merge pull request #6759 from donaldsharp/rules_family
zebra: Silently ignore afi 128/129 for rules
2020-07-17 08:23:46 -04:00
David Lamparter
1a798bcb6b tools/gcc-frr-format: update README
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-07-17 05:56:40 +02:00
David Lamparter
20a236abe3 tools/gcc-frr-format: update debian bits
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-07-17 05:54:54 +02:00
David Lamparter
555cc1001d tools/gcc-frr-format: improve test
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-07-17 05:54:54 +02:00
David Lamparter
05675eb32f tools/gcc-frr-format: update for gcc 10
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-07-17 05:54:54 +02:00
David Lamparter
06852b5b5c build: fix Makefile rule redefinition
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-07-17 05:54:54 +02:00
Donald Sharp
dfbe3a2bd3 zebra: Silently ignore afi 128/129 for rules
We do not need to know anything about rules in afi 128/129
at this point in time.  Just note it with a zebra kernel
debug and move on.  This is not something that a operator
can do anything with and at this point in time FRR
does not care.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-16 20:59:33 -04:00
Donald Sharp
721026f68c
Merge pull request #6752 from xThaid/evpn_neigh_fix
zebra: fix the installation of the evpn neighbor update
2020-07-16 20:09:08 -04:00
Renato Westphal
2d1ddebc8b
Merge pull request #6706 from donaldsharp/router_id_bullshit
Router id vrf subnode configuration
2020-07-16 18:09:38 -03:00
vdhingra
7aa6f9cd47 staticd: Formatting changes
Warning fixes for indentation

Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 09:56:23 -07:00
vdhingra
314825ff91 staticd: Added afi-safi as a key in route-list
To address the ip mroute command there is a need to add
safi as a key. So adding the afi-safi-type identityref
as a key.

Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 08:40:45 -07:00
vdhingra
755100ac89 zebra: Moving afi-safi identity to lib
afi-safi identity handling should be in the common place.

Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 08:40:42 -07:00
vdhingra
88fa5104a0 staticd : Configuration northbound implementation
1. Modifies the data structs to make the distance, tag and table-id
   property of a route, i.e created a hireachical data struct to save
   route and nexthop information.
2. Backend northbound implementation

Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 08:33:00 -07:00
vdhingra
7441ea1afd lib : basic-routing backend configuration northbound code
Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 08:33:00 -07:00
vdhingra
27802d3fee lib : Yang wrappers
1. To get the parent node
2. To auto delete the parent when last node in list gets deleted

Signed-off-by: VishalDhingra <vdhingra@vmware.com>
2020-07-16 08:33:00 -07:00