David Lamparter
aebe076f37
Merge pull request #913 from qlyoung/remove-powl
...
lib: remove last powl()
2017-08-04 18:19:25 +02:00
Quentin Young
61b9e9d6b3
lib: remove last powl()
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-04 10:58:00 -04:00
Donald Sharp
adbbf7f92d
Merge pull request #910 from opensourcerouting/isis-perf2
...
isisd: don't validate dict integrity for regular builds
2017-08-04 10:56:34 -04:00
Renato Westphal
ef8482267d
Merge pull request #908 from donaldsharp/safi
...
bgpd: Fix safi_t confusion wition iana_safi_t
2017-08-04 11:34:23 -03:00
Christian Franke
8955008f72
isisd: don't validate dict integrity for regular builds
...
This method is intended to be only used for debugging as per the author
and profiling shows we are spending a lot of cycles on it. Remove it for
regular builds by guarding it with a define.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-04 15:51:39 +02:00
Donald Sharp
6b36796215
Merge pull request #909 from opensourcerouting/isis-perf
...
IS-IS: improve spf performance
2017-08-04 09:04:12 -04:00
Donald Sharp
05d2cb510d
bgpd: Fix safi_t confusion wition iana_safi_t
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-04 07:45:44 -04:00
David Lamparter
3619938e2f
Merge pull request #891 from Jafaral/portability
...
Portability configurations
2017-08-04 08:52:07 +02:00
David Lamparter
e4f48ace5d
Merge pull request #900 from qlyoung/apply-mask
...
lib: add missed apply_mask()
2017-08-04 08:49:20 +02:00
David Lamparter
f28762d235
Merge pull request #870 from chiragshah6/mdev
...
Fix various memory leaks in OSPFd and OSPF6d
2017-08-04 08:46:38 +02:00
ßingen
820ea5d431
Merge pull request #901 from qlyoung/style-fix
...
lib: minor style fix
2017-08-03 17:27:30 +02:00
Quentin Young
bca37d172a
lib: minor style fixes
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-03 11:25:24 -04:00
Jafar Al-Gharaibeh
63f79759e6
Merge pull request #897 from donaldsharp/pim_memory_leak
...
pimd: Squash some more memory leaks
2017-08-03 10:23:55 -05:00
Quentin Young
c7fcc67369
lib: add missed apply_mask()
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-03 11:12:14 -04:00
Christian Franke
eb919f07ab
isisd: Use a hashtable to speed up lookups during SPF
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 14:30:32 +02:00
Christian Franke
c7d3895eb1
lib: Reformat comment so my eyes don't fall out while reading it
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 14:30:01 +02:00
Christian Franke
7a7761d21c
lib: move prefix hash key to prefix.c to allow global use
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 13:37:58 +02:00
Donald Sharp
28ae32e66e
Merge pull request #854 from opensourcerouting/isis-parser
...
IS-IS: rewrite TLV deserializer/serializer
2017-08-03 06:46:00 -04:00
Christian Franke
02cd317ea0
isisd: make isis_spftree non-public
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:45:58 +02:00
Christian Franke
164066e4d9
isisd: purge LSP correctly on confusion
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
39a275aa0f
isisd: only process overload info from fragment #0
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
bb5c77d708
isisd: Limit number of addresses in IPv4 addr TLV to 63
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
841791b65b
isisd: rework complete, move "tlvs2" to "tlvs"
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
af8ac8f98f
isisd: send/receive LSPs with new parser
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
17c9dcd5f1
isisd: send/receive *SNPs with new parser
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
0c1bd7588b
isisd: send/receive IIHs with new parser
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
88f9d9112a
isisd: Don't use structs to encode/decode PDU header
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
7ef5fefc3c
isisd: add new tlv parser
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
9879e291a4
isisd: add formatter code
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:04 +02:00
Christian Franke
31bfa0624d
lib: add sbuf
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-08-03 11:34:01 +02:00
Donald Sharp
baca8cd4d7
zebra: Missing break statement causes crash in zebra
...
Zebra receiving a macip_del message will automatically call
into the set_master function( a pim function ). Add missing
break statement
Ticket: CM-16841
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>
2017-08-02 20:17:35 -04:00
Donald Sharp
69ccd63e57
pimd: Squash some more memory leaks
...
When a interface is flapped we were leaking some memory
associated with link lists. Especially in the jp_agg
code. If your network was/is stable and you are not
running at any scale you probably would not see this
as impactful at all.
Ticket: CM-16392
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 15:39:10 -04:00
Jafar Al-Gharaibeh
dacb17162a
Merge pull request #895 from qlyoung/flush-ready
...
lib: flush ready queue before poll() again
2017-08-02 14:24:41 -05:00
Jafar Al-Gharaibeh
408647964a
Merge pull request #894 from donaldsharp/sockopt
...
lib: Remove sockopt_cork functionality
2017-08-02 14:22:43 -05:00
Jafar Al-Gharaibeh
30004c2539
Merge pull request #797 from donaldsharp/PIM_VRF
...
Pim vrf
2017-08-02 14:20:33 -05:00
Quentin Young
d764d2cc50
lib: flush ready queue before poll() again
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-08-02 14:29:04 -04:00
Donald Sharp
13221cf2b4
pimd: Clean back pointer upon deletion
...
The channel_oil has a back pointer(up) to the upstream data structure.
If we are planning on keeping the channel oil (due to ref count issues)
longer than keeping the upstream, when we delete the upstream we were
not clearing the back pointer to up. This would result in a situation
where if that memory has started to be used again it will cause a
crash and other fun things.
Ticket: CM-17092
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 12:14:11 -04:00
Jafar Al-Gharaibeh
004174c77f
config: Disable pimd on OpenBSD 6.1
...
OpenBSD dropped support for PIM in 6.1. Error out if the user does not
disable pimd explicitly.
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2017-08-02 10:12:19 -05:00
Jafar Al-Gharaibeh
ea2fd55a65
config: On some platfroms json check fails if we don't link lm, no-op otherwise
...
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2017-08-02 10:02:44 -05:00
Jafar Al-Gharaibeh
f9e755241a
config: If we don't have crypt but we have ssl crypto, use it
...
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2017-08-02 10:01:17 -05:00
Donald Sharp
0ecfe5bf38
Merge branch 'master' into PIM_VRF
2017-08-02 09:39:38 -04:00
Donald Sharp
cc14df1391
pimd: Add ip pim rp keep-alive-time X
...
Ticket: CM-17134
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 08:17:36 -04:00
Donald Sharp
8618a572ae
Merge pull request #893 from opensourcerouting/minor-issues
...
Fix #875 and #889 (minor issues)
2017-08-02 07:59:29 -04:00
Donald Sharp
d62fd596f9
pimd: Add some more vrf debug information
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:57:24 -04:00
Donald Sharp
209a56799b
pimd: Cleanup nht debugs
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:57:24 -04:00
Donald Sharp
08f4f9013c
pimd: Clean up mroute_add_vif debugging
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:57:13 -04:00
Donald Sharp
ad7b74c4f7
pimd: Convert to using a RB tree for the pim_ifp ifchannel_list
...
This patch does two things:
1) Converts the pim_ifp->ifchannel_list to a pim_ifp->ifchannel_rb
2) Removes the hashing to use the RB RB_FIND instead.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:44:00 -04:00
Donald Sharp
86b473a7e8
pimd: Rename pim_ifp->pim_ifchannel_list
...
Remove the redundant information in pim_ifp->pim_ifchannel_list
just call it pim_ifp->ifchannel_list
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:44:00 -04:00
Donald Sharp
1a8a3da8c2
pimd: Remove almost duplicate pim->ifchannel_list
...
The pim->ifchannel_list can be duplicated by iterating
over each vrf and then over each pim_ifp->pim_ifchannel_list
Since list handling is taking allot of time at scale
convert over to using this value.
Additionally clean up pim_cmd.c to have helper functions
to handle the actual encoding of data for output.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-08-02 07:44:00 -04:00
Renato Westphal
2d3ed84004
doc/babeld: small documentation update
...
Fixes Issue #889 .
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-01 22:19:18 -03:00