Russ White
ab40199f00
Merge pull request #15351 from louis-6wind/fix-leak-vrf-interface
...
bgpd: update route leak after vrf interface changes
2024-02-20 10:14:20 -05:00
Donald Sharp
b02d946db1
Merge pull request #15394 from sri-mohan1/srib-24-babel
...
babeld: changes for code maintainability
2024-02-20 07:02:59 -05:00
sri-mohan1
c8287d97db
babeld: changes for code maintainability
...
these changes are for improving the code maintainability and readability
Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2024-02-20 00:25:27 +05:30
Igor Ryzhov
5332e447d9
Merge pull request #15381 from LabNConsulting/chopps/nb-notif
...
lib: mgmtd: add xpath arg to YANG notification message
2024-02-19 16:52:47 +02:00
Christian Hopps
29a0c1c6c3
Merge pull request #15389 from opensourcerouting/fix/add_mgmtd_pytest_marker
...
doc: Add `mgmtd` pytest marker into documentation
2024-02-19 06:36:15 -05:00
Christian Hopps
4a93d171c2
lib: mgmtd: add xpath arg to notification message
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-18 18:53:37 -05:00
Donatas Abraitis
311eac53e8
Merge pull request #15357 from dpward/master
...
github: Replace issue template with issue form
2024-02-18 14:43:21 +02:00
Donatas Abraitis
ce334222ae
doc: Add mgmtd pytest marker into documentation
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-02-17 11:24:29 +02:00
Donatas Abraitis
c872610f7d
Merge pull request #15376 from sri-mohan1/srib-24-babel
...
babeld: changes for code maintainability
2024-02-16 22:29:06 +02:00
Donald Sharp
9aec0d5a18
Merge pull request #15378 from idryzhov/ospf-suppress-fa
...
tests: fix ospf_suppress_fa timing issue
2024-02-16 07:26:24 -05:00
Igor Ryzhov
cb570d87d0
Merge pull request #15382 from donaldsharp/more_sa_failures
...
More sa failures
2024-02-16 13:55:35 +02:00
Donald Sharp
863e6ddf11
bgpd: Fix value stored to group never being read
...
SA Reports:
bgpd/bgp_rpki.c:1085:24: warning: Value stored to 'group' during its initialization is never read [deadcode.DeadStores]
struct rtr_mgr_group *group = get_connected_group(rpki_vrf);
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2024-02-15 23:28:18 -05:00
Donald Sharp
0f7b5fcffb
ospfd: Fix assignment with never being used
...
SA finds this:
error 14-Feb-2024 14:52:24 ospfd/ospf_te.c:3962:2: warning: Value stored to 'sub' is never read [deadcode.DeadStores]
error 14-Feb-2024 14:52:24 sub = 0;
error 14-Feb-2024 14:52:24 ^ ~
error 14-Feb-2024 14:52:24 1 warning generated.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2024-02-15 23:27:38 -05:00
Christian Hopps
1d4ea437e4
lib: always call new notification hooks too
...
- call the new notification hooks when backends call the old notification
posting API.
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-15 13:03:25 -05:00
Igor Ryzhov
fa67c0b91c
Merge pull request #15371 from LabNConsulting/chopps/mgmtd-fixes
...
Fixes for the northbound/mgmtd
2024-02-15 20:02:23 +02:00
Igor Ryzhov
829443fd83
tests: fix ospf_suppress_fa timing issue
...
Set static router-id for OSPF, because otherwise it depends on timing of
router-id updates received from zebra and may differ between test runs.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-02-15 15:38:26 +02:00
Christian Hopps
dff28248c3
lib: actually create the tree for the conversion
...
Before this fix would always return empty results b/c there was no
libyang tree to print to output format.
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-15 06:13:08 -05:00
Christian Hopps
b8e07049a8
lib: fix memleak on success
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-15 06:13:08 -05:00
David Ward
16308917a2
github: Replace issue template with issue form
...
Signed-off-by: David Ward <david.ward@gatech.edu>
2024-02-15 03:16:54 -05:00
Louis Scalbert
1262ee66ad
tests: check route leak update after vrf creation and deletion
...
Ensure that a locally leaked route is updated after a VRF (dis)appears.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:39:51 +01:00
Louis Scalbert
94d12dc490
bgpd: update route leak when vrf appears
...
If the VRF is not yet created and a BGP instance is created for the
VRF, dependent leaked routes are inactive, which is normal. However,
when the VRF interface appears, they remains inactive.
Update route leak when a VRF interface appears. Note that routes to a
deleted VRF are already removed by zebra.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:39:51 +01:00
Louis Scalbert
5709e89f6c
tests: check route leak after changing vrf state
...
Check that local route leaks are set to "inactive" when the VRF
interface is shutdown and, conversely, that they are set to "active"
when the VRF interface is unshut.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:39:51 +01:00
Louis Scalbert
b45c5cd959
bgpd: update route leak when vrf state changes
...
Locally leaked routes remain active after the nexthop VRF interface goes
down.
Update route leaking when the loopback or a VRF interface state change is
received from zebra.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:39:51 +01:00
Louis Scalbert
c102adde30
tests: use check_ping in bgp_vrf_route_leak_basic
...
Use check_ping in bgp_vrf_route_leak_basic
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:39:10 +01:00
Louis Scalbert
71e74df14e
tests: add source_addr in check_ping
...
Allow specifying a source_addr in check_ping library function.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2024-02-14 16:38:58 +01:00
Louis Scalbert
8b5f6ac982
tests: fix duplicates in bgp_vrf_route_leak_basic
...
Test functions were duplicated by mistakes. They were identical.
Fixes: 8af61c8a34
2024-02-14 16:21:35 +01:00
Donatas Abraitis
2fd5e51d4c
Merge pull request #15332 from donaldsharp/nhg_stuffs
...
Nhg stuffs
2024-02-14 16:14:19 +02:00
Donatas Abraitis
4952f23cee
Merge pull request #15288 from donaldsharp/shell_access_removal
...
vtysh: Remove deprecated shell_access code
2024-02-14 11:20:36 +02:00
Igor Ryzhov
cccfedb345
Merge pull request #15359 from LabNConsulting/chopps/reap-unused-phase
...
mgmtd: remove unused commit phase SEND_CFG
2024-02-14 11:15:06 +02:00
Donatas Abraitis
d5bec7b081
build: FRR 10.1 development version
...
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-02-13 21:18:45 +02:00
sri-mohan1
21b7f32a2c
babeld: changes for code maintainability
...
these changes are for improving the code maintainability and readability
Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2024-02-14 00:00:31 +05:30
Donald Sharp
9fd7bf4cbb
Merge pull request #15234 from opensourcerouting/snmp-topotest-fixes
...
topotests: fix snmptrap log OID parsing
2024-02-13 10:59:30 -05:00
Russ White
e74c3b0746
Merge pull request #15320 from donaldsharp/vtysh_limit_fds
...
lib, ospfclient, vtysh: Allow for a minimum fd poll size
2024-02-13 09:50:00 -05:00
Russ White
17a0a625f0
Merge pull request #15284 from opensourcerouting/feature/bgpd_announce_rpki_state_knob
...
bgpd: Add neighbor X send-community extended rpki command
2024-02-13 09:35:10 -05:00
Christian Hopps
7b94a923ae
Merge pull request #15042 from Orange-OpenSource/ospf-te
...
ospfd: Add Opaque LSA decoder for json output
2024-02-13 05:37:29 -05:00
Christian Hopps
60cb834ead
Merge pull request #15361 from idryzhov/fix-be-interested
...
mgmtd: fix be_is_client_interested
2024-02-12 20:11:20 -05:00
Donatas Abraitis
26faf341ef
Merge pull request #15352 from louis-6wind/fix-leak-recursive
...
bgpd: fix route recursion on leaked routes
2024-02-12 21:42:03 +02:00
Igor Ryzhov
745a2bd8b3
mgmtd: fix be_is_client_interested
...
Backend "subscribe" API allows daemons to dynamically register xpaths
they are interested in. Such xpaths are not stored in hardcoded
config/oper xpath arrays so this function fails to understand that a
backend daemon is interested in them. Fix by using dynamic xpath maps
instead which store both hardcoded and dynamic xpaths.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2024-02-12 20:55:34 +02:00
Igor Ryzhov
24ca4f408b
Merge pull request #15358 from LabNConsulting/chopps/doc-update
...
update doc with new more strict protobuf requirements
2024-02-12 19:52:35 +02:00
Olivier Dugeon
b46a1fe826
tests: adapt ospfapiclient test to new json output
...
Following new json decoder for Opaque LSA, this patch adapts the ospfapiclient
test to the new json output.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2024-02-12 17:52:00 +01:00
Olivier Dugeon
6fcc86d37a
ospfd: Decode Extended Link & Prefix TLVs for json
...
When dumping ospf database with json output, decode Extended Link and Extended
Prefix TLVs and sub-TLVs.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2024-02-12 17:52:00 +01:00
Olivier Dugeon
b27d9e4d3b
ospfd: Decode Router Info. TLVs for json output
...
When dumping ospf database with json output, decode Router Information TLVs
and sub-TLVs.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2024-02-12 17:52:00 +01:00
Olivier Dugeon
95c9cb9aa9
ospfd: Decode TE TLVs for json output
...
When dumping ospf database with json output, decode Traffic Engineering TLVs
and sub-TLVs.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2024-02-12 17:52:00 +01:00
Olivier Dugeon
aa2b539bf5
ospfd: Prepare Opaque LSA for json output
...
Instead of output bulk of data with json output, prepare json context to decode
opaque TLVs and sub-TLVs.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2024-02-12 17:52:00 +01:00
Christian Hopps
40e51d2257
mgmtd: remove unused commit phase SEND_CFG
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-12 07:57:28 -05:00
Christian Hopps
8d6e7a350f
tests: fix grpc test
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-12 07:48:50 -05:00
Christian Hopps
6374970cb8
doc: docker: update with new more strict protobuf requirements
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2024-02-12 06:48:12 -05:00
Christian Hopps
d71710a910
Merge pull request #15355 from idryzhov/fix-mgmtd-notif
...
Fix and rework YANG notifications
2024-02-12 06:17:38 -05:00
Donald Sharp
9800590ccc
Merge pull request #15346 from opensourcerouting/fix/memory_optimizations
...
Some more memory optimizations
2024-02-11 21:33:44 -05:00
Donald Sharp
6d3f9bf605
Merge pull request #15356 from idryzhov/configure-sysconfdir
...
build: fix configure output
2024-02-11 21:33:00 -05:00
