Donatas Abraitis
aa6fe908f3
lib: Do not double-assign freed pointer to NULL
...
It's already done by XFREE.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
a454d9ab44
bgpd: Drop return for void bgp_evpn_show_routes_mac_ip_es()
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
e6b457ac06
bgpd: Do not test for bgp_path_info in rfapiCopyUnEncap2VPN()
...
Already checked.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
6198b69489
bgpd: Remove double test against rfapi which is already checked
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
9c73cd41f7
bgpd: Do not check against aspath seg
which is already checked before
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
707bb5a09c
bgpd: Remove redundand check against BGP_EVPNES_EVI_LOCAL flag
...
It's already checked earlier at bgp_evpn_local_es_evi_do_del()
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
eaf8028849
bgpd: Avoid dereferencing EVPN ES if NULL
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
734c6f0953
bgpd: Remove double check against match_packet_length_num
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
63fc789a10
bgpd: Do not test against bdc again since we already validated
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Donatas Abraitis
53048d33d1
bgpd: Remove useless reuselist_node assignment before while loop
...
Seems really not necessary pointing to initial value before while loop, where
it's assigned anyway.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-17 10:14:38 +03:00
Quentin Young
9b1bc4d661
Merge pull request #8856 from LabNConsulting/chopps/topo-valgrind
2021-06-16 18:57:25 +00:00
Russ White
40e5282059
Merge pull request #8770 from gpnaveen/ospfv3_basic_functionality
...
tests: Adding ospfv3 basic functionality test cases
2021-06-16 09:09:57 -04:00
Christian Hopps
e58133a78e
tests: add valgrind memleaks run options and detection
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-16 02:56:15 -04:00
nguggarigoud
2448d00200
tests: Adding ospfv3 basic functionality test cases
...
1. Adding APIs to configure and verify ospfv3.
2. Adding ospfv3 base functionality testcase.
Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
2021-06-15 17:00:17 -07:00
Quentin Young
1bd67ed620
Merge pull request #8851 from opensourcerouting/ospf6-linkstateid-json
...
ospf6d: Link state ID in LSA database JSON output
2021-06-15 15:50:38 +00:00
Russ White
679b4f3bf9
Merge pull request #8833 from donaldsharp/zapi_message_count
...
Zapi message count
2021-06-15 11:05:15 -04:00
Martin Winter
05a7c65a15
Merge pull request #8814 from kuldeepkash/topojson_framework
...
tests: Fixing common pylint error for topojson
2021-06-15 17:03:57 +02:00
Russ White
ecaf7ab9d7
Merge pull request #8821 from anlancs/master-fix-doc-domainname
...
doc: add a note of domainname
2021-06-15 11:03:48 -04:00
Igor Ryzhov
f9fa6ee74c
Merge pull request #8838 from LabNConsulting/chopps/fix-nb-edit-cli
...
lib: do not attempt to create default nodes from NULL tree node
2021-06-15 12:18:29 +03:00
Renato Westphal
994624c48d
Merge pull request #8836 from ton31337/fix/generalize_bgp_dest_locks
...
bgpd: Call bgp_dest_unlock_node() inside bgp_adj_in_remove()
2021-06-14 10:11:17 -03:00
Renato Westphal
60ff22619a
Merge pull request #8844 from sworleys/Term-Default-VRF-Last
...
lib: terminate default vrf last
2021-06-14 10:05:52 -03:00
David Schweizer
2804f2d241
ospf6d: Link state ID in LSA database JSON output
...
Added link state ID to JSON output of LSA database.
Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>
2021-06-14 08:41:10 +02:00
Christian Hopps
4da08e016b
lib: do not attempt to create default nodes from NULL tree node
...
Perform same NULL check for dependent node creation code too.
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-12 09:10:18 +00:00
Stephen Worley
ea0d70b1c4
lib: terminate default vrf last
...
Always terminate default VRF last during FRR shutdown.
On shutdown we were simply looping over the RB tree and terminating
VRFs from the ROOT. This is not guaranteed to be the default last ever.
Instead switch to RB_SAFE and skip the default VRF till the very end.
Signed-off-by: Stephen Worley <sworley@nvidia.com>
2021-06-11 11:48:23 -04:00
Igor Ryzhov
352cc841d8
Merge pull request #8831 from sworleys/Fix-No-Ospf-Func
...
ospf6d: fix undefined function
2021-06-11 11:33:13 +03:00
Donatas Abraitis
6a840fd93f
bgpd: Call bgp_dest_unlock_node() inside bgp_adj_in_remove()
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-11 09:39:23 +03:00
Donald Sharp
9691937d8b
zebra: Move individual lines to table in show zebra client
command
...
Move some individual add/delete lines to the table format in
the `show zebra client` command
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-06-10 20:41:35 -04:00
Donald Sharp
a9d8faf7ab
zebra: Add message counts for show zebra client
...
There were counters FRR was keeping but never displaying. Add them
in.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-06-10 20:24:44 -04:00
Stephen Worley
5c2b86bba9
ospf6d: fix undefined function
...
Some wires got crossed during a couple merges using/changing
this function.
Update it to its new name.
Signed-off-by: Stephen Worley <sworley@nvidia.com>
2021-06-10 17:39:56 -04:00
Rafael Zalamena
ea67959995
Merge pull request #8823 from donaldsharp/ospfv3_coverity
...
Ospfv3 coverity
2021-06-10 15:13:11 -03:00
Donald Sharp
3f56f92b84
Merge pull request #8691 from louis-oui/split-soft-reconfig
...
bgpd: split soft reconfig table task into several jobs to not block vtysh
2021-06-10 12:04:54 -04:00
Donald Sharp
59ec133a03
Merge pull request #8561 from opensourcerouting/msdp-refactor-v2
...
pimd: rework MSDP mesh groups
2021-06-10 09:44:28 -04:00
Rafael Zalamena
0614153799
Merge pull request #8733 from idryzhov/ipv6-ospf6-area
...
ospf6d: fix interface area configuration
2021-06-10 10:34:45 -03:00
Donald Sharp
95b3f03d89
ospf6d: Rename ospf6_is_router_abr to more accurately reflect what it does
...
The ospf6_is_router_abr is checking to see if ospfv3 is an abr router
and also setting values. Let's rename it too `ospf6_check_and_set_router_abr`
to more accurately reflect what it is doing.
Additionally fix coverity #1505176 where we were not checking the return
value of ospf6_is_router_abr like we did every other time. In this
case we don't care about the return value so indicate that we do not.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-06-10 07:59:06 -04:00
Donald Sharp
0d882ec7a3
ospf6d: Fix coverity Possible null deref
...
There exists a code path where ospf6 could be NULL and passing
to a function where it would always be derefed is a bad idea.
Put some small code in place to prevent this and allow this to be debuged
if it happens in the future.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-06-10 07:46:36 -04:00
anlancs
063f44007e
doc: add a note of domainname
...
Signed-off-by: anlancs <anlan_cs@tom.com>
2021-06-10 18:16:33 +08:00
Donatas Abraitis
8d6aca7f21
Merge pull request #8754 from louis-oui/bgp-summary-filter
...
bgpd: improve show bgp summary display
2021-06-10 09:58:31 +03:00
Rafael Zalamena
fb35f654e3
pimd: rename some MSDP functions
...
Rename and shorten function names to make them uniform.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09 12:40:04 -03:00
Rafael Zalamena
1771900c02
topotests: new test topology for MSDP
...
Add basic topology test for MSDP meshed groups.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09 12:32:24 -03:00
Rafael Zalamena
ab59579a12
topotests: support adding hosts
...
Add API to topogen so we can build topology with simple hosts instead
of routers.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09 12:32:24 -03:00
Rafael Zalamena
e2809e618b
pimd: rework MSDP mesh-group code
...
Fully utilize the northbound to hold pointers to our private data
instead of searching for data structures every time we need to change a
configuration.
Highlights:
* Support multiple mesh groups per PIM instance (instead of one)
* Use DEFPY instead of DEFUN to reduce code complexity
* Use northbound private pointers to store data structures
* Reduce callback names size
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09 12:32:24 -03:00
Rafael Zalamena
0213a65800
yang: rework PIM MSDP mesh group
...
Allow PIM MSDP configuration to support multiple MSDP mesh groups per
PIM instance.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09 12:32:24 -03:00
Donald Sharp
c20270787c
Merge pull request #8815 from idryzhov/fix-ospf-aggr
...
ospfd: fix memory leaks in summarization
2021-06-09 09:25:59 -04:00
Donald Sharp
fe673f2fb9
Merge pull request #8808 from ton31337/feature/tracepoints_for_bgp_dest_lock_unlock
...
bgpd: Add tracepoints for bgp_dest_lock_node/bgp_dest_unlock_node
2021-06-09 09:09:15 -04:00
Donald Sharp
6dbaa012be
Merge pull request #8807 from mjstapp/fix_srv6_delete
...
lib,zebra: srv6 cleanup
2021-06-09 09:07:53 -04:00
Russ White
41b5e3d88f
Merge pull request #8817 from donaldsharp/mlag_crash
...
zebra: Give extra space and stop processing if we run out of space
2021-06-09 09:03:41 -04:00
Donald Sharp
010b575b7d
zebra: Give extra space and stop processing if we run out of space
...
When processing bulk messages we need more space to handle more
mroutes. In this case we are doubling the stream size from
16k -> 32k, which should roughly double the number of mroutes
we can handle in one go.
Additionally. If we cannot parse the passed message into
the stream to pass up to pimd then gracefully stop processing
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-06-09 06:43:28 -04:00
Olivier Dugeon
3898a4522f
Merge pull request #8798 from opensourcerouting/ospfd-fixes
...
ospfd: assorted fixes
2021-06-09 09:06:42 +02:00
Igor Ryzhov
cdde8b4bc7
tests: replace "interface IFNAME area" with "ipv6 ospf6 area"
...
Only one test is modified yet, to have both new and deprecated commands
tested by the CI.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-08 21:38:09 +03:00
Igor Ryzhov
aa47a69b32
doc: replace "interface IFNAME area" with "ipv6 ospf6 area"
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-08 21:38:09 +03:00