Commit Graph

9699 Commits

Author SHA1 Message Date
Quentin Young
a90cfb7f71
doc: fixup eigrpd.rst
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-26 12:57:34 -05:00
Quentin Young
fce2ac600e
doc: remove @group / @end group
Don't need these in RST

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-26 12:38:08 -05:00
Quentin Young
c2caa2970b
doc: rename main.rst -> zebra.rst
This name hasn't made sense for a long time.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-26 12:35:52 -05:00
Quentin Young
fd8100976e
doc: set 'release' and 'version' again
accidentally removed in older commit

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-19 17:24:48 -05:00
Quentin Young
f381786082
doc: move routeserver.rst into bgp.rst
This is an incomplete stub of a chapter and goes under BGP docs anyway.
Also fix an include statement for RPKI.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-19 17:09:03 -05:00
Quentin Young
44f2550ef3
doc: clean up overview.rst, installation.rst
Just reading through the docs and fixing bugs as I go.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-19 17:05:13 -05:00
Quentin Young
dc1046f726
doc: Frr -> FRR
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-19 17:05:13 -05:00
Quentin Young
be46d28847
doc: use RST variable substitutions
In conf.py, extract & construct values for inline variables throughout
the docs. In the docs, use these inline variables in RST syntax.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-19 17:05:08 -05:00
Quentin Young
c3c5a71ff6
doc: fixup bgpd.rst
Will probably need more cleanup.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-16 13:11:25 -05:00
Quentin Young
964b36623b
doc: make conf.py know about variable substitutions
The old Texi docs had some Makefile-style variable substitutions they
used to pull in information like release date, configured install path,
etc. Sphinx has this ability as well, we start making use of it here.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-01-12 16:00:24 -05:00
Quentin Young
8d2098618c
doc: fixup basic.rst
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-22 16:30:56 -05:00
Quentin Young
2dd0a0ed1d
doc: fixup babeld.rst
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-20 18:22:17 -05:00
Quentin Young
4652e58cef
doc: fixup ipv6.rst
Manual cleanup from leftover texi -> rst

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-20 18:22:12 -05:00
Quentin Young
42fc5d2669
doc: start translating user manual to rst
Automatically translated all Texinfo files to RST using a script found
on the GCC mailing list[0]. Some formatting manually corrected.

Also created index.rst for building as well as boilerplate Sphinx
conf.py and Makefile.

[0] https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01095.html

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-18 16:29:24 -05:00
Quentin Young
8630065756
doc: re-add .gitignore, Makefile for dev docs
Missed hidden files when shuffling things around. Restore David's
makefiles & gitignore.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-14 16:23:50 -05:00
Quentin Young
ab51ead08e
Revert "doc: add note to document practice changes in docs"
Lou wrote his own clause so we're using that one

This reverts commit 558669e970.
2017-12-14 16:23:50 -05:00
Quentin Young
8ce7861f45
doc: add clause for documenting
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-14 16:23:49 -05:00
Quentin Young
558669e970
doc: add note to document practice changes in docs
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-11 16:12:07 -05:00
Quentin Young
b22ba015ef
doc: more organizing & updating
* Add chapter on BGPD
* Add diagram for git workflow
* Convert next-hop tracking documents to ReST
* Update & organize workflow document
* Move ldpd docs back up to the parent directory

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-08 18:30:14 -05:00
Quentin Young
b30de70968
doc: change section title for modules docs
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-08 17:27:57 -05:00
Quentin Young
a42f781889
doc: clean up CLI docs
Update, embellish, clarify.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-08 16:38:49 -05:00
Quentin Young
d1890d041e
doc: begin developer's manual
* Move doc/code/ -> doc/developer/
* Move disparate code documentation to doc/developer/
* Convert Markdown docs to reStructuredText
* Organize docs into Sphinx tree
* Move build docs -> doc/developer/
* Change build doc titles to fit under Building subsection of manual

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-08 14:08:44 -05:00
Renato Westphal
17473b9a45
Merge pull request #1502 from chiragshah6/ospf_vrf_dev
ospfd: Display all vrf aware ospf interface config
2017-12-05 14:47:53 -02:00
Donald Sharp
7b79bc5cb7
Merge pull request #1494 from opensourcerouting/u1710-master
Fixes to allow Package build on Ubuntu 17.10
2017-12-05 07:03:15 -05:00
Martin Winter
41e4189930 debianpkg: Update Pkg build instructions with Ubuntu 17.10 and fix errors
- plus add pointer for creating new backport
- plus add example for customizing package with WANT_* options

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-12-05 00:30:30 -08:00
Martin Winter
2f29e6d75e debianpkg: Add Debian backport for Ubuntu 17.10
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-12-05 00:30:30 -08:00
Martin Winter
81f810f0f6 debianpkg: Fix lintian warning "command-with-path-in-maintainer-script"
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-12-05 00:30:30 -08:00
Martin Winter
79e68c7c5b lib: Fix gcc 7 warning 'error: ‘fld’ may be used uninitialized in this function'
Warning breaks Debian Package build with gcc 7 which uses -Werror=maybe-uninitialized

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-12-05 00:30:29 -08:00
Martin Winter
176b305080 bgpd: bgp_attr.c GCC 7.0 with --werror needs explicit fall-thru comment
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-12-05 00:30:13 -08:00
Chirag Shah
545f0503ed ospfd: fix crash no router ospf/show running
no router ospf removes default ospf instance,
if there are other non-default vrf instance present
with interface level configuration. Lookup ospf instance
for ifp->vrf_id, if ospf instnace present use that
   to access 'instance id'.

Ticket: CM-19078
Testing Done:
run no router ospf and show running config along with other
non-default vrf aware ospf configurations.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-12-04 16:38:16 -08:00
Chirag Shah
c7fd72d2f7 ospfd: Display all vrf aware interface config
OSPF interface specific configuration can be done independent
of router ospf [vrf x] global config.
In cases where ospf interface non default vrf configuration
is done prior to 'router ospf vrf x', show running-config
would not display such configuration.

To display configuration now walk all vrfs and interface list
and only display where OSPF configure params are set.

Ticket:CM-18952
Testing Done:
Tried ospf interface specific configuration with VRF,
where router ospf vrf x is not present.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2017-12-04 14:54:28 -08:00
Donald Sharp
d17ea5225b
Merge pull request #1518 from opensourcerouting/clippy-issues
*: make clippy usage more consistent
2017-12-04 17:45:05 -05:00
Renato Westphal
2e4c229616 *: make clippy usage more consistent
Fixes #1511.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-12-04 19:46:38 -02:00
Renato Westphal
50a0033c24
Merge pull request #1496 from donaldsharp/install_failure
Additional Southbound API changes
2017-12-04 18:25:16 -02:00
Renato Westphal
ded104de0c
Merge pull request #1507 from donaldsharp/bgp_af_open
bgpd: Allow Address-Family activation to work in certain states
2017-12-04 17:34:19 -02:00
Donald Sharp
0e21e01c4f
Merge pull request #1500 from opensourcerouting/ldpd-fixes
ldpd: small improvements
2017-12-04 09:06:09 -05:00
Rafael Zalamena
6bbda63df7
Merge pull request #1508 from qlyoung/bgpd-fix-lock
bgpd: fix potential deadlock
2017-12-04 11:16:45 -02:00
Donald Sharp
461d84899a
Merge pull request #1472 from opensourcerouting/lintian-warning
debianpkg: Suppress frr-dbg debug-file-with-no-debug-symbols warning
2017-12-04 08:02:16 -05:00
Lou Berger
5b09c50e10
Merge pull request #1510 from qlyoung/ospf-gitignore-clippy
ospfd: remove clippy file, fix .gitignore
2017-12-02 06:06:37 +08:00
Rafael Zalamena
e0973eec67
Merge pull request #1433 from qlyoung/remove-deprecated-stream-macros
*: don't use deprecated stream.h macros
2017-12-01 17:46:02 -02:00
Quentin Young
2e1eecd3a9
ospfd: remove clippy file, fix .gitignore
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-01 14:24:30 -05:00
Quentin Young
2d34fb80b8
*: don't use deprecated stream.h macros
Some of the deprecated stream.h macros see such little use that we may
as well just remove them and use the non-deprecated macros.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-01 13:51:06 -05:00
Quentin Young
8ec586b01b
bgpd: fix potential deadlock
With the way things are set up, this bit of code would never actually
cause a deadlock, but would be highly likely in the future.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-12-01 13:41:27 -05:00
Donald Sharp
64c1a9b59b bgpd: Allow Address-Family activation to work in certain states
If we are in OpenSent or OpenConfirm peer state and we receive a new
address-family activation, we would end up ignoring the new activation
and not tell our peer about it.  You could notice this by seeing
the fact that a 'show bgp neighbor' command returns a 'Not in
any update group' for a particular family.

This modifies the code such that we now notice that we are in
either OpenSent or OpenConfirm state and reset the peer to
allow us to send them the new capability.

Ticket: CM-19021
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-12-01 11:49:13 -05:00
Svata Dedic
493472ba8e ospfd: fix NSSA LSA translation (BZ#493) (BZ#250) 2017-12-01 10:08:36 -05:00
Martin Winter
19465f4e20
Merge pull request #1145 from qlyoung/bgpd-pthreads-frr
Multithreaded BGPD
2017-11-30 23:35:51 -08:00
Quentin Young
6ec98a2f37
bgpd: small optimization with UPDATE generation
After a batch of generated UPDATEs, call bgp_writes_on() once instead of
after generating each packet.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-11-30 17:17:16 -05:00
Quentin Young
c58b0f46dd
bgpd: use FOREACH_AFI_SAFI()
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-11-30 16:58:37 -05:00
Quentin Young
4961a5a2eb
bgpd: intelligently adjust coalesce timer
The subgroup coalesce timer controls how long updates to a particular
subgroup are delayed in order to allow additional peers to join the
subgroup. Presently the timer value is 200 ms. Increase it to 1 second
and adjust up as peers are configured, with an upper cap at 10s.

This cuts convergence time by a factor of 3 at large scale (300+ peers,
1000+ prefixes per peer).

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-11-30 16:47:51 -05:00
Quentin Young
5561f52343
tests: neuter fuzzing frontend for now
Fuzzing hook for BGP packet processing does not map to MT-BGPD. Removing
offending call for now, additional work to fix this in the future.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-11-30 16:18:07 -05:00