Quentin Young
a6275055bf
lib: add cancel point to default pthread loop
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-07-26 00:40:52 +00:00
Renato Westphal
a095cabc6c
Merge pull request #2712 from pacovn/Security_Uninitialized_memory_access
...
pimd: uninitialized memory access fix
2018-07-25 11:07:57 -03:00
Russ White
4dbd617abd
Merge pull request #2704 from sworleys/Netlink-Nexthop-Hang
...
zebra: Add check for nexthop loop to prevent hanging
2018-07-24 19:42:11 -04:00
Russ White
72794b312d
Merge pull request #2706 from chiragshah6/mdev
...
bgpd: Add evpn prefix to debug bgp updates prefix
2018-07-24 19:29:05 -04:00
Russ White
32bf84c1cd
Merge pull request #2714 from qlyoung/fix-unused-variable-zserv
...
zebra: remove unused var in zserv.c
2018-07-24 19:26:13 -04:00
F. Aragon
431f21d38e
pimd: uninitialized memory access fix
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-24 23:51:15 +02:00
Quentin Young
29cb1b24d1
zebra: remove unused var in zserv.c
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-07-24 21:01:29 +00:00
Renato Westphal
5d13cd0a93
Merge pull request #2699 from sworleys/Netlink-MTU-Check
...
zebra: Add check for mtu on netlink RTM_NEWLINK
2018-07-24 17:04:47 -03:00
Russ White
bbc7adf1b4
Merge pull request #2665 from chiragshah6/evpn_dev
...
bgpd: support evpn nd ext community
2018-07-24 11:55:08 -04:00
Donald Sharp
3f95d92258
Merge pull request #2707 from opensourcerouting/fix-srcdest-netlink-read
...
zebra: do not ignore ipv6 srcdest routes
2018-07-24 11:49:49 -04:00
Quentin Young
79d702c130
Merge pull request #2640 from pguibert6WIND/doc_ldp
...
doc: add Ldp user documentation
2018-07-24 11:34:22 -04:00
Chirag Shah
81cf0de50e
bgpd: Add evpn prefix to debug bgp updates prefix
...
Adding EVPN prefix of Type 2, 3 and 5 routes to bgp updates
prefix filters.
Ticket:CM-14476
Testing Done:
Configure multiple evpn options under 'debug bgp updates prefix'.
Below is the running-config output.
MAC-IP route with just MAC:
debug bgp updates prefix l2vpn evpn type macip mac
00:02:00:0a:0a:0a
MAC-IP route with MAC and IP:
debug bgp updates prefix l2vpn evpn type macip mac
00:02:00:00:00:0c ip 45.0.1.9
MAC-IP route with just MAC and IPv6:
debug bgp updates prefix l2vpn evpn type
macip mac 00:02:00:00:00:0a ip 2001:fee1:0:1::8
Type-3:
debug bgp updates prefix l2vpn evpn type multicast ip 27.0.1.19
Type-5:
debug bgp updates prefix l2vpn evpn type prefix
ip 2060:1:1:1::/64
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2018-07-24 06:45:40 -07:00
Donald Sharp
873a9a03d3
Merge pull request #2703 from opensourcerouting/ldpd-missing-command
...
ldpd: add missing command under the ipv6 address-family node
2018-07-24 08:37:52 -04:00
Christian Franke
1f610a1fb3
zebra: do not ignore ipv6 srcdest routes
...
Commit a2ca67d1d2
consolidated IPv4 and IPv6 handling. It also applied
our ignorance for IPv4 srcdest routes onto IPv6.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-07-24 14:09:17 +02:00
Stephen Worley
3c04071d99
zebra: Add check for nexthop loop to prevent hanging
...
Bad nexthop messages from netlink were causing zebra
to hang here. Added a check to verify the length
of the nexthop so it doesn't keep trying to read.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2018-07-23 18:51:26 -04:00
Renato Westphal
3c549c10b0
ldpd: add missing command under the ipv6 address-family node
...
Bug found by Patrick Velder.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-07-23 19:10:57 -03:00
Russ White
af9036b76d
Merge pull request #2698 from sworleys/Netlink-Filter-AFI
...
zebra: Add address family filters
2018-07-23 17:45:44 -04:00
Russ White
59c97d9839
Merge pull request #2697 from mjstapp/routemap_const
...
libs, daemons: use const in route-map apply
2018-07-23 17:42:04 -04:00
Russ White
e7516d1484
Merge pull request #2701 from FRRouting/revert-2670-feature/use_med_if_applied_for_default_route
...
Revert "Use metric for default-originate with route-map if applied"
2018-07-23 17:08:43 -04:00
Russ White
db711a8fb9
Revert "Use metric for default-originate with route-map if applied"
2018-07-23 17:08:24 -04:00
Russ White
4dbfa73b17
Merge pull request #2670 from ton31337/feature/use_med_if_applied_for_default_route
...
Use metric for default-originate with route-map if applied
2018-07-23 17:04:48 -04:00
Russ White
57be6296f3
Merge pull request #2646 from AnuradhaKaruppiah/evpn-fixes
...
zebra: install EVPN gateway MAC as static/sticky
2018-07-23 16:53:34 -04:00
Russ White
b6292a289b
Merge pull request #2641 from donaldsharp/pim_igmp_dr
...
pimd: Do not create upstream state when not DR for igmp request
2018-07-23 16:50:59 -04:00
Stephen Worley
adac720d77
Remove not needed filters and fix typos
...
Some more address family filters we can safely ignore
as well as typos in logger. Added AF_MPLS as filterable.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2018-07-23 15:08:37 -04:00
Renato Westphal
f4f9200dec
Merge pull request #2668 from dslicenc/cm21722-v6-vrf-display
...
zebra: remove default vrf output for kernel vrf ipv6 blackhole default
2018-07-23 14:56:29 -03:00
Renato Westphal
c9bf7f94b3
Merge pull request #2689 from dslicenc/vrf-exit-reload
...
tools: handle exit-vrf as end of context block
2018-07-23 14:46:10 -03:00
Stephen Worley
d23b983bd4
zebra: Add check for mtu on netlink RTM_NEWLINK
...
Zebra needed a check for mtu from the message it
received from the kernel before adding the new link.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2018-07-23 12:17:45 -04:00
Stephen Worley
8a1b681cba
zebra: Add address family filters
...
The zebra netlink socket was attempting to read netlink
messages with invalid address families in a couple areas.
Added filters and warn messages.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2018-07-23 12:11:02 -04:00
Mark Stapp
c886868f64
zebra: clean up const use in bsd build
...
Missed a bsd/routing socket change when enforcing use of const
in some kernel-facing api calls.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2018-07-23 11:22:14 -04:00
Mark Stapp
123214efb8
libs, daemons: use const in route-map apply
...
Use 'const prefix *' in route-map apply apis; led to some
corresponding changes in several daemons.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2018-07-23 10:34:35 -04:00
Donald Sharp
c4aee4fe31
Merge pull request #2652 from LabNConsulting/working/master/confdate_cleanup
...
Simplify deprecation check
2018-07-23 08:46:26 -04:00
Martin Winter
7087ced7ad
Merge pull request #2672 from pcarana/pcarana-add-rpki-rh
...
RedHat spec: Add the rpki module when needed
2018-07-20 22:29:56 +02:00
Quentin Young
d355e53a94
Merge pull request #2692 from manuhalo/module_param_docs
...
doc: add cmd line param section to modules.rst
2018-07-20 12:09:57 -04:00
Donald Sharp
86180eeeeb
Merge pull request #2690 from opensourcerouting/fix-srcdest-route-display
...
zebra: fix do_show_route_helper to include srcdest routes
2018-07-20 01:55:53 -04:00
Donald Sharp
dc7f5a78b5
Merge pull request #2688 from pguibert6WIND/vrf_delete_on_netns_fail
...
zebra: cancel vrf creation if netns activation failed
2018-07-20 01:54:10 -04:00
Donald Sharp
461302049e
Merge pull request #2691 from adharkar/frr-bgp_cli
...
bgpd: Changes to BGP show json commands
2018-07-19 20:05:19 -04:00
Quentin Young
d0b7b3da2f
Merge pull request #2687 from opensourcerouting/fix-cpp-notice-on-old-compilers
...
lib/compiler.h: Always define CPP_NOTICE
2018-07-19 17:10:45 -04:00
Ameya Dharkar
d0086e8e39
bgpd: Changes to BGP show json commands
...
Added localRouterID to "show bgp neighbor json"
Added json O/P to "show bgp [AFI] community <community>"
Signed-off-by: Ameya Dharkar <adharkar@vmware.com>
2018-07-19 13:46:46 -07:00
Christian Franke
c9591045cc
zebra: fix do_show_route_helper to include srcdest routes
2018-07-19 15:16:57 -04:00
Don Slice
cc27402c4d
tools: handle exit-vrf as end of context block
...
Ticket: CM-21048
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2018-07-19 18:38:54 +00:00
Emanuele Di Pascale
9e2f406adb
doc: add cmd line param section to modules.rst
...
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2018-07-19 18:28:25 +02:00
Jafar Al-Gharaibeh
d0597b69f9
Merge pull request #2679 from qlyoung/fix-zapi-fuzzing
...
Fix zapi fuzzing
2018-07-19 10:54:33 -05:00
Philippe Guibert
73899a2f81
zebra: cancel vrf creation if netns activation failed
...
To keep configuration consistent, vrf that have not been able to be
associated with netns are removed.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-07-19 17:52:29 +02:00
Jafar Al-Gharaibeh
96b3001abc
Merge pull request #2635 from donaldsharp/more_pim_neighbor
...
More pim neighbor
2018-07-19 10:47:10 -05:00
Donald Sharp
d244a1a39b
Merge pull request #2686 from opensourcerouting/master-fix-isis-issue-2584
...
isisd: don't crash when isis_sock_init fails
2018-07-19 11:41:23 -04:00
Christian Franke
d4670f515b
isisd: don't crash when isis_sock_init fails
...
When isis_sock_init fails in isis_circuit_up, isis_circuit_down would
be called to cancel timers which were scheduled. However
isis_circuit_down would immediately return, since the state had not been
changed to 'UP' yet.
Fix this by having isis_circuit_down always cancel all the timers.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-07-19 10:11:07 -04:00
Christian Franke
ec40eaf94d
lib/compiler.h: Always define CPP_NOTICE
...
On old compilers CPP_NOTICE should be a macro evaluating to an empty
statement, instead of being undefined.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-07-19 10:10:13 -04:00
Donald Sharp
d1a85fe40d
Merge pull request #2608 from pacovn/PVS-Studio_dead_code_1
...
eigrpd lib pimd zebra: dead code (PVS-Studio)
2018-07-19 08:50:01 -04:00
Donatas Abraitis
b156c65dc0
Use metric for default-originate with route-map if applied
...
Signed-off-by: Donatas Abraitis donatas.abraitis@gmail.com
2018-07-19 11:17:47 +03:00
Donald Sharp
06a5959f10
Merge pull request #2678 from pguibert6WIND/sanity_netns
...
zebra: sometimes, it is not possible to assign a NSID to a vrf
2018-07-18 15:36:53 -04:00