Commit Graph

21928 Commits

Author SHA1 Message Date
Donatas Abraitis
a1477006f9
Merge pull request #7562 from donaldsharp/python_fixes
tests: Fix common_config.py issues
2020-11-20 09:37:58 +02:00
Donald Sharp
e1b89f023b
Merge pull request #7559 from ckishimo/translator
ospfd: fix NSSA translator
2020-11-19 19:33:59 -05:00
Donald Sharp
22d7226542
Merge pull request #7546 from mjstapp/limit_fds
lib: add startup-time option to limit fds used
2020-11-19 19:28:57 -05:00
Donald Sharp
c0b76cfe11
Merge pull request #7568 from idryzhov/fix-naming
lib: fix local variable shadowing global one
2020-11-19 19:25:56 -05:00
Donald Sharp
cf36334c6f
Merge pull request #7544 from andylemin/master
bgpd: added bmp read check to detect broken sessions
2020-11-19 19:24:42 -05:00
Donald Sharp
0f7e34f86c
Merge pull request #7564 from pguibert6WIND/fix_typo_topotest
doc: topotest json typo error
2020-11-19 18:36:48 -05:00
Quentin Young
c14dba6241 Revert "debian: Merge various debian changelogs in debian/changelog"
This reverts commit da3a39ff6a.
2020-11-19 17:12:42 -05:00
Quentin Young
439be082d3 Revert "debian: Adjust tarsource.sh to use native debian/changelog"
This reverts commit 4ffb9a4c9d.
2020-11-19 17:12:41 -05:00
Quentin Young
1b8a899da3 Revert "debian: Update tools/build-debian-package.sh to use git-buildpackage"
This reverts commit 63c0c8ed89.
2020-11-19 17:12:40 -05:00
Quentin Young
fb0b3592ca Revert "debian: Remove the changelog-auto automation in favor of dch"
This reverts commit cace1d9bf1.
2020-11-19 17:12:40 -05:00
Quentin Young
2013e82a89 Revert "debian: Remove now obsolete tarsource.sh script"
This reverts commit bc304e08ea.
2020-11-19 17:12:38 -05:00
Quentin Young
5aa63f6aa6 Revert "debian: Update the tools/build-debian-package.sh to be example build script"
This reverts commit c950a7f214.
2020-11-19 17:12:27 -05:00
Igor Ryzhov
62b439624b lib: fix local variable shadowing global one
start_config and end_config are already used as function names in DEFUN,
so the current naming is a little bit confusing. Let's use different
names for arguments.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-20 00:53:34 +03:00
Ondřej Surý
c950a7f214 debian: Update the tools/build-debian-package.sh to be example build script
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:11 +01:00
Ondřej Surý
bc304e08ea debian: Remove now obsolete tarsource.sh script 2020-11-19 21:30:08 +01:00
Ondřej Surý
cace1d9bf1 debian: Remove the changelog-auto automation in favor of dch
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:06 +01:00
Ondřej Surý
63c0c8ed89 debian: Update tools/build-debian-package.sh to use git-buildpackage
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:02 +01:00
Ondřej Surý
4ffb9a4c9d debian: Adjust tarsource.sh to use native debian/changelog
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:59 +01:00
Ondřej Surý
da3a39ff6a debian: Merge various debian changelogs in debian/changelog
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:45 +01:00
Mark Stapp
38a0ce9146
Merge pull request #7566 from ton31337/fix/topotests_bgp_ebgp_requires_policy
tests: Add more descriptive error messages and increase timeouts
2020-11-19 13:32:56 -05:00
Mark Stapp
b3ec3c3cb9
Merge pull request #7424 from donaldsharp/config_commands
lib, sharpd, vtysh: When reading a file in for config send start/end …
2020-11-19 12:40:50 -05:00
Donald Sharp
cac886dd53
Merge pull request #6145 from patrasar/pim_nb_code_upstream
pimd: northbound backend code
2020-11-19 11:03:00 -05:00
Mark Stapp
e01396e1ea
Merge pull request #7563 from donaldsharp/why_not_cut_n_paste
ospf6d: More lists being leaked
2020-11-19 10:58:21 -05:00
Mark Stapp
001325b696
Merge pull request #7561 from donaldsharp/resources_are_the_life
lib: Stop socket from leaking.
2020-11-19 09:56:51 -05:00
Donald Sharp
16ae941f4a lib: Add information log of how long configuration took to read in
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 09:52:11 -05:00
Donald Sharp
f8e6ada882 lib, sharpd, vtysh: When reading a file in for config send start/end indicators
When reading a file in for configuration, send start and end indicators
to interested parties.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 09:52:11 -05:00
Donatas Abraitis
e9ac289675 tests: Add more descriptive error messages and increase timeouts
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-11-19 16:49:44 +02:00
Philippe Guibert
0dc861fa52 doc: topotest json typo error
fix the typo error.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2020-11-19 13:18:22 +00:00
Donald Sharp
680b8ceb9e ospf6d: More lists being leaked
Apparently the person who wrote this code was big into
cut-n-paste.  Commit 710a61d57c
found the first instance, but upon code inspection this morning
it became evident that 2 other functions had the exact same
problem.

Fix.  Note I have not cleaned up the cut-n-paste code for
two reasons: a) I'm chasing something else b) this code
has been fairly un-maintained for a very long time.  No
need to start up now.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 08:04:51 -05:00
Donald Sharp
a28055a478 tests: Fix common_config.py issues
1) in generate_ips if start_ipaddr does not have a `/` in it
there exists a code path where both mask and step are
null values.  Write a bit of code to ensure this pre-req
is found early and often

2) in verify_rib there exists a code path where static_route
is null when we get to the non static route section.  Change
the code to operate on the advertise_network_dict that
we are iterating over.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 07:40:03 -05:00
Donald Sharp
07d4bb8b9c lib: Stop socket from leaking.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 07:02:15 -05:00
Donatas Abraitis
53a85efa51
Merge pull request #7554 from donaldsharp/sockunion2hostprefix_watch_returns
bgpd, lib, nhrpd, zebra: verify return of sockunion2hostprefix
2020-11-19 11:26:02 +02:00
Donatas Abraitis
6a13ee5644
Merge pull request #7528 from donaldsharp/changelog_update
Changelog update
2020-11-19 10:43:26 +02:00
ckishimo
0124b46b94 ospfd: fix NSSA translator
Having 2 ABR in NSSA area where R3 is the elected translator

R3# show ip ospf
  We are an ABR and the NSSA Elected Translator.
R2# show ip ospf
  We are an ABR, but not the NSSA Elected Translator.

When R3 loses the Border condition by shutting down the interface
to the backbone, we end up with no translator in the NSSA area. It
is expected R2 to take over the translator role

R3# sh ip ospf
  It is not ABR, therefore not Translator.
R2# show ip ospf
   We are an ABR, but not the NSSA Elected Translator.

This PR forces the ABR to reevaluate the translator condition, so
R2 becomes the elected Translator

Signed-off-by: ckishimo <carles.kishimoto@gmail.com>
2020-11-18 23:23:14 -08:00
Sarita Patra
1dac87c88d pimd: fix indentation issues
Signed-off-by: Sarita Patra <saritap@vmware.com>
2020-11-18 23:20:26 -08:00
Donald Sharp
d377cf01e7
Merge pull request #7210 from idryzhov/route-types-disable-daemon
lib: respect --disable-daemon flags in route_types.h
2020-11-18 19:38:14 -05:00
Donald Sharp
b84696e6c0
Merge pull request #7454 from ranjanyash54/dev_8
ospf6d: Json support added for command "show ipv6 ospf6 interface traffic [json]"
2020-11-18 18:37:30 -05:00
Donald Sharp
74c6aba12e
Merge pull request #7455 from ranjanyash54/dev_3
ospf6d: Json support added for command "show ipv6 ospf6 redistribute [json]"
2020-11-18 18:33:09 -05:00
Donald Sharp
db2e92360c
Merge pull request #7467 from ton31337/fix/bgpd_null_dereference
bgpd: Check if peer is not NULL before calling peer_as_change()
2020-11-18 18:13:04 -05:00
Donald Sharp
f2e1528b62
Merge pull request #7558 from opensourcerouting/bfd-v6-same
bfdd: fix multiple links same address
2020-11-18 17:53:42 -05:00
Donald Sharp
c3f5f46868
Merge pull request #7296 from YashRanjanVMWare/dev_1
ospf6d: Json support added for command "show ipv6 ospf6 [json]"
2020-11-18 17:50:42 -05:00
Mark Stapp
abed797ef5
Merge pull request #7556 from donaldsharp/memory_shenanigans
Memory shenanigans
2020-11-18 17:31:03 -05:00
Mark Stapp
1a9f340b6b lib: add startup option to limit fds
Add a startup-time option to limit the number of fds used
by the thread/event infrastructure. If nothing is configured,
the system ulimit is used.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-18 15:34:35 -05:00
Donald Sharp
95bd143ec3
Merge pull request #7552 from volta-networks/fix_reload_l2pvn
tools: fix frr-reload l2vpn delete
2020-11-18 15:27:51 -05:00
Mark Stapp
84c709bc6e
Merge pull request #7555 from idryzhov/cppcheck-fixes
fix a couple of issues found by cppcheck
2020-11-18 14:29:25 -05:00
Rafael Zalamena
4c4faa474e bfdd: fix multiple links same address
Allows users with multiple links using same IPv6 address (same VRF) to
work.

Reported-by: Matti Suuronen
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-11-18 16:06:16 -03:00
Donald Sharp
6a37bfb7e5 bgpd: Prevent ecommunity_ecom2str memory leak
We were allocating but never freeing memory associated with the
ecommunity_ecom2str allocation.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 12:50:48 -05:00
Donald Sharp
b9d4546253 bgpd: Do not leak vname if we find the match
If we are attempting to store the bgp name for route
leaking and we find a match do not leak the memory.

Please note this is probably not really going to happen
ever.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 12:10:22 -05:00
Mark Stapp
410a7b7058
Merge pull request #7553 from donaldsharp/mem_leak_ferr
lib: Cleanup mem-leaks in error case
2020-11-18 11:56:34 -05:00
Donald Sharp
710a61d57c ospf6d: Free up list memory
OSPFv3 snmp code creates a list but never deletes the actual
list.  Do so.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 11:42:50 -05:00