Ruben Kerkhof
9f892cc56c
redhat: remove enable-poll option from specfile
...
It was removed from configure.ac in 16764760
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-21 17:03:29 +02:00
Russ White
cb7b0cbbf8
Merge pull request #2485 from pacovn/cppcheck_ldpd_redundant_condition
...
ldpd: redundant condition (cppcheck)
2018-06-20 07:52:37 -04:00
Russ White
480f71f6a8
Merge pull request #2461 from pacovn/Coverity_1399380_Untrusted_value_as_argument
...
bgpd: Untrusted argument (Coverity 1399380)
2018-06-20 07:41:06 -04:00
Russ White
96be948bcd
Merge pull request #2495 from pacovn/fixme_all_digit
...
bgpd, lib, ospfd, zebra: all_digit moved to frrstr
2018-06-20 07:38:19 -04:00
Russ White
edc5b3e52e
Merge pull request #2496 from pacovn/fixme_group1
...
isisd, zebra: FIXME fixes (grouped)
2018-06-20 07:37:27 -04:00
Russ White
c92a99c30d
Merge pull request #2499 from donaldsharp/routemap_kisses
...
Some route-map prep
2018-06-20 07:19:31 -04:00
Russ White
984c07e449
Merge pull request #2500 from msablic/pim_doc2
...
doc: added parameters to two PIM commands
2018-06-20 07:18:11 -04:00
Russ White
9dbaf129b2
Merge pull request #2446 from pacovn/Coverity_1452454_1452455_1452456_Out-of-bounds_access
...
ospfd: OoB access (Cov 1452454 1452455 1452456)
2018-06-20 07:14:49 -04:00
Mladen Sablic
f93128c139
doc: added parameters to two PIM commands
...
ip igmp join and mtrace have parameters which were missing from
the command spec.
Signed-off-by: Mladen Sablic <mladen.sablic@gmail.com>
2018-06-20 11:48:15 +02:00
Donald Sharp
46a69f10c0
bgpd, lib, zebra: Remove unnecessary return
...
The route_map_walk_update_list callback function
never uses the return code, so just remove it.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-19 21:22:46 -04:00
Donald Sharp
69f0272083
lib: Don't expose a function that is never used
...
route_map_clear_updated is only used by routemap.c,
don't expose it too be used by the outside world.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-19 21:22:46 -04:00
Donald Sharp
75a2b29dd6
zebra: Add initial framework to keep track of changed route-maps
...
Add some basic code for zebra to start to keep track
of route-maps that have changed. At this point we
are not doing anything. As we fix code to handle
route-maps better, code will be shifted around.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-19 21:22:46 -04:00
Donald Sharp
c573cddd2a
pimd: Remove unused code
...
pim does not even use route-maps, remove the
unneded code.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-19 21:21:36 -04:00
Donald Sharp
7096e93875
bgpd, lib, pimd: Remove unused variable.
...
route_map_mark_updated has a `int del_later` variable
that is passed in but never used. Just remove it.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-06-19 20:44:15 -04:00
paco
36228974c2
isisd, zebra: FIXME fixes
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 19:22:13 +02:00
paco
5d5ba0185d
bgpd, lib, ospfd, zebra: all_digit moved to frrstr
...
This solves a pending FIXME
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 17:59:53 +02:00
Quentin Young
6e87c6e8e2
Merge pull request #2459 from pacovn/Coverity_1469898_Uninitialized_scalar_variable
...
lib: uninitialized variable (Coverity 1469898)
2018-06-19 11:15:13 -04:00
Martin Winter
447297f34f
Merge pull request #2373 from rubenk/specfile-cleanups
...
Red Hat spec file cleanup
2018-06-19 07:17:03 -07:00
paco
f96f689940
bgpd: Untrusted argument (Coverity 1399380)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 15:00:25 +02:00
Russ White
05d7e026c8
Merge pull request #2445 from ppmathis/feature/bgp-pg-overrides
...
bgpd: Improve peer-group override implementation
2018-06-19 08:20:31 -04:00
Russ White
4a1f626570
Merge pull request #2450 from ppmathis/bugfix/bgp-filtered-routes
...
bgpd: Fix crash when showing filtered routes
2018-06-19 07:37:42 -04:00
Russ White
8fef257611
Merge pull request #2465 from qlyoung/fix-build-am-cppflags-warning
...
tests: fixup minor autotools nit
2018-06-19 07:31:43 -04:00
Russ White
35169b489d
Merge pull request #2468 from qlyoung/docuser
...
doc: update workflow.rst
2018-06-19 07:31:10 -04:00
Russ White
fc89ac9846
Merge pull request #2470 from chiragshah6/mdev
...
zebra: Hide default vrf instance of l3vni cmd
2018-06-19 07:29:13 -04:00
Russ White
efd1d76673
Merge pull request #2474 from donaldsharp/vty_thread_cancel_writes
...
Add 'show thread poll'
2018-06-19 07:28:18 -04:00
Russ White
e3ea4f7acb
Merge pull request #2478 from pacovn/Coverity_1408766_Dereference_after_null_check
...
bgpd: null check (Coverity 1408766)
2018-06-19 07:21:42 -04:00
Russ White
0ddc9a2d9d
Merge pull request #2479 from dslicenc/zebra-vrf-statics
...
zebra: re-install static routes needed vrf when the vrf intf comes up
2018-06-19 07:19:39 -04:00
Russ White
f071d8b36a
Merge pull request #2481 from pacovn/security_vpn_null_check
...
bgpd: vpn null check
2018-06-19 07:19:00 -04:00
Russ White
9635a16a36
Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref
...
bgpd: null check (Clang scan-build)
2018-06-19 07:18:13 -04:00
Russ White
5e51ae9816
Merge pull request #2491 from pacovn/cppcheck_no_effect
...
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
2018-06-19 07:15:07 -04:00
Russ White
aa13697bb0
Merge pull request #2492 from pacovn/cppcheck_security1
...
eigrpd, lib, tests, vtysh: security (cppcheck)
2018-06-19 07:14:19 -04:00
paco
6d10727ac1
eigrpd, lib, tests, vtysh: security (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 10:40:56 +02:00
paco
5f18adf01b
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
...
Assignment of function parameter has no effect outside the function.
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 10:19:05 +02:00
Ruben Kerkhof
0cff191d5c
redhat: fix else cases in spec file
...
As pointed out during review, disable the options when the macros are
false.
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
2d2ab69937
redhat: spec file: specify file only once
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
07a138ecab
redhat: spec file: no need for custom attr for service file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
95624f7b34
redhat: add missing dependencies on chkconfig in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c88a52f4df
redhat: remove a few superfluous Requires from spec file
...
rpm adds these automatically
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
ccb9b8f6c0
redhat: remove a few superfluous BuildRequires from spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
501c136231
redhat: depend on info package instead of binary in specfile
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
fadbc6e7fe
redhat: install-info is not called from %pre in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
54c059f1cb
redhat: remove wrong comment from spec file
...
systemd support needs watchfrr
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
a999f98cc5
redhat: spec file: all supported Fedora versions use systemd
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
7ca1f62ca9
redhat: use default permissions for logrotate file in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
6ad17a64c1
redhat: spec file: we ship only one logrotate file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c9cad8766e
redhat: be consistent in adding ./configure options in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c410a86130
redhat: use Github for SOURCE0 in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
e1ff824635
redhat: Use https for URL in spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
150e7c7eb3
redhat: remove trailing whitespace from spec file
...
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:52 +02:00
Ruben Kerkhof
fe99b0153a
redhat: fix tabs vs spaces in spec file
...
rpmlint reports:
redhat/frr.spec:282: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 282)
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2018-06-19 09:57:45 +02:00