proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-05 06:34:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
31,335 Commits 4 Branches 191 Tags 125 MiB
9a7d1e7427
Commit Graph

31335 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
9a7d1e7427 zebra: Use zebra_vrf_lookup_by_id when we can 
Let's make this as consistent as is possible.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-28 15:49:50 -04:00
Donatas Abraitis
9b00c0a165
Merge pull request #13113 from sri-mohan1/sri-mohan-ldp 
ldpd: changes for code maintainability
 2023-03-28 19:14:27 +03:00
Russ White
ec563e8bbc
Merge pull request #13118 from opensourcerouting/fix/password_xfer_config 
bgpd: Copy the password from the previous peer on peer_xfer_config()
 2023-03-28 11:21:42 -04:00
Russ White
743c7461e8
Merge pull request #13123 from donaldsharp/fix_route_map_name 
bgpd: Fix debug output for route-map names when using a unsuppress-map
 2023-03-28 11:19:08 -04:00
Russ White
62e239a1cc
Merge pull request #13117 from donaldsharp/assert_unneeded 
Assert unneeded
 2023-03-28 10:17:15 -04:00
Donald Sharp
8e8ed2e1fb bgpd: Fix debug output for route-map names when using a unsuppress-map 
Log is printing this with this config:

2023-03-28 07:36:47.007 [DEBG] bgpd: [Q9J6Z-09HRR] 192.168.119.120 [Update:SEND] 1.2.3.33/32 is filtered by route-map '(null)'

Here's the config:

 address-family ipv4 unicast
  network 1.2.3.33/32
  network 1.2.3.34/32
  aggregate-address 1.2.3.0/24 summary-only
  redistribute table 33 route-map foo
  neighbor 192.168.119.120 route-map DENY in
  neighbor 192.168.119.120 unsuppress-map UNSUPPRESS

ip prefix-list UNSUPPRESS seq 5 permit 1.2.3.4/32
ip prefix-list UNSUPPRESS seq 10 permit 1.2.3.5/32
ip prefix-list UNSUPPRESS seq 15 permit 1.2.3.6/32

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-28 08:34:24 -04:00
Donald Sharp
328b64fcb5
Merge pull request #13119 from mjstapp/fix_mgmt_proto_makefile 
build: clean up mgmtd lib protobuf make syntax
 2023-03-28 06:35:19 -04:00
Mark Stapp
9b8f605bbb build: clean up mgmtd lib protobuf make syntax 
Fix the makefile rules for the new mgmtd lib module that's
generated from a protobuf spec file.

Signed-off-by: Mark Stapp <mjs@labn.net>
 2023-03-27 16:44:27 -04:00
Donatas Abraitis
b5b6f11fcb bgpd: Copy the password from the previous peer on peer_xfer_config() 
We copy the password only if an existing peer structure didn't have it.

But it might be the case when it exists, and we skip here.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2023-03-27 22:20:26 +03:00
Donatas Abraitis
c4e3d5569f
Merge pull request #13086 from donaldsharp/suppress_fib_pending 
bgpd: Ensure suppress-fib-pending works with network statements
 2023-03-27 21:55:58 +03:00
Donald Sharp
4261481c6d mgmtd: Remove unnecessary asserts 
event_add_XXXX functions have no failure path where
if you pass in a double event pointer that it could
return without setting the pointer.  As such these
asserts make no sense and are unnecessary

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-27 08:09:42 -04:00
Donald Sharp
38c57f3f65 lib: Remove unneeded asserts in mgmt code 
event_add_XXXX functions have no failure path where
if you pass in a double event pointer that it could
return without setting the pointer.  As such these
asserts make no sense and are unnecessary

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-27 08:08:36 -04:00
Donatas Abraitis
6bfb662245
Merge pull request #12931 from SaiGomathiN/yang 
pim6d: custom error-message for non-multicast groups
 2023-03-27 13:45:00 +03:00
sri-mohan1
248d33434e ldpd: changes for code maintainability 
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2023-03-27 12:27:01 +05:30
Donald Sharp
fd8044a4fc
Merge pull request #13084 from opensourcerouting/fix/bgp_vrf_md5_password 
bgpd: Set md5 TCP socket option for outgoing connections on listener
 2023-03-26 08:21:31 -04:00
Donald Sharp
35bd38705f
Merge pull request #13101 from opensourcerouting/fix/bindir_for_frr-reload 
tools: Set correct directory of vtysh for frr-reload.py
 2023-03-26 08:20:33 -04:00
Donald Sharp
aa2602bf60
Merge pull request #13108 from opensourcerouting/clippy-string-warn 
lib: improve clippy behavior with invalid input
 2023-03-25 12:57:00 -04:00
David Lamparter
be95afe196 lib/clippy: bail out on newline inside string 
While C compilers will generally process strings across lines, we really
don't want that.  I rather treat this as the indication of the typo it
probably is warn about it than support this odd C edge case.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2023-03-25 12:34:35 +09:00
David Lamparter
9e92984f32 lib/clippy: don't SEGV on invalid tokens in DEFPY 
The token value can be NULL if we run into something that failed to
parse.  Throw a Python exception rather than SEGV.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2023-03-25 12:33:14 +09:00
Jafar Al-Gharaibeh
06f54ff416
Merge pull request #12953 from donaldsharp/struct_event 
Struct event
 2023-03-24 13:48:53 -05:00
Donatas Abraitis
c9bdc0c79e tools: Set correct directory of vtysh for frr-reload.py 
Before it was setting SDIR, which is /usr/lib/frr, but the vtysh binary is put
under bindir (which is /usr/local by default). And running `/usr/lib/frr/frr reload`
failed.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2023-03-24 19:38:46 +02:00
Donald Sharp
d54d0ead76
Merge pull request #13093 from manojvn/ospf_mem_leaks 
ospfd: Fix for memory leak issue in ospf related to flood_reduction tests.
 2023-03-24 10:23:18 -04:00
Donald Sharp
6c8ad437e7
Merge pull request #13100 from opensourcerouting/fix/bgp_cap_llgr_length_check 
bgpd: Check 7 bytes for Long-lived Graceful-Restart capability
 2023-03-24 10:22:48 -04:00
Donatas Abraitis
b1d33ec293 bgpd: Check 7 bytes for Long-lived Graceful-Restart capability 
It's not 4 bytes, it was assuming the same as Graceful-Restart tuples.

LLGR has more 3 bytes (Long-lived Stale Time).

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2023-03-24 15:36:17 +02:00
mobash-rasool
18c9215985
Merge pull request #13088 from donaldsharp/pim_use_after 
pimd: Fix use after free issue for ifp's moving vrfs
 2023-03-24 18:33:05 +05:30
Donald Sharp
970bbd8b89
Merge pull request #13094 from loganaden/master 
mgmtd: Fix fd leak.
 2023-03-24 08:41:11 -04:00
Donald Sharp
02e701e49e *: Fixup formatting issues due to reordering 
All the event changes exposed a bunch of places where
we were not properly following our standards.  Just
clean them up in one big fell swoop.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:37:21 -04:00
Donald Sharp
24a58196dd *: Convert event.h to frrevent.h 
We should probably prevent any type of namespace collision
with something else.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
cd9d053741 *: Convert struct event_master to struct event_loop 
Let's find a better name for it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
ce50d11c4d *: Convert thread_master_XXX functions to event_master_XXX 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
e16d030c65 *: Convert THREAD_XXX macros to EVENT_XXX macros 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
70d4d90c82 lib, zebra: Convert THREAD_TIMER_STRLEN to EVENT_TIMER_STRLEN 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
04ec66797c lib: change cpu_thread_history to cpu_event_history 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
5163a1c560 lib: convert xref_threadsched to xref_eventsched 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
3905fb7393 lib: convert thread internal lists to event internal lists 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
2453d15dbf *: Convert struct thread_master to struct event_master and it's ilk 
Convert the `struct thread_master` to `struct event_master`
across the code base.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
5f6eaa9b96 *: Convert a bunch of thread_XX to event_XX 
Convert these functions:

thread_getrusage
thread_cmd_init
thread_consumed_time
thread_timer_to_hhmmss
thread_is_scheduled
thread_ignore_late_timer

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
70c35c11f2 *: Convert thread_should_yield and thread_set_yield_time 
Convert thread_should_yield and thread_set_yield_time
to event_should_yield and event_set_yield_time

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
4f830a0799 *: Convert thread_timer_remain_XXX to event_timer_remain_XXX 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
8c1186d38e *: Convert thread_execute to event_execute 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
ba7d2705d6 lib: Convert THREAD_YIELD_TIME_SLOT to EVENT_YIELD_TIME_SLOT 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
de2754be3a *: Convert thread_fetch and thread_call to event_fetch and event_call 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
2ccccdf5d0 lib: Convert thread_type to event_type and make an enum 
a) Convert thread types to a enum
b) Convert MTYPES to EVENT instead of THREAD

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
332beb64b8 *: Convert thread_cancelXXX to event_cancelXXX 
Modify the code base so that thread_cancel becomes event_cancel

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
907a2395f4 *: Convert thread_add_XXX functions to event_add_XXX 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
e6685141aa *: Rename struct thread to struct event 
Effectively a massive search and replace of
`struct thread` to `struct event`.  Using the
term `thread` gives people the thought that
this event system is a pthread when it is not

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:17 -04:00
Donald Sharp
cb37cb336a *: Rename thread.[ch] to event.[ch] 
This is a first in a series of commits, whose goal is to rename
the thread system in FRR to an event system.  There is a continual
problem where people are confusing `struct thread` with a true
pthread.  In reality, our entire thread.c is an event system.

In this commit rename the thread.[ch] files to event.[ch].

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-03-24 08:32:16 -04:00
Donald Sharp
173786f6b5
Merge pull request #13065 from rgirada/ospf_abr_summary 2023-03-23 19:57:08 -04:00
Loganaden Velvindron
b69017f455 mgmtd: Fix fd leak. 
Close fd before returning to avoid leaks.

Signed-off-by: Loganaden Velvindron <logan@cyberstorm.mu>
 2023-03-23 23:07:06 +04:00
Manoj Naragund
1746f71bc8 ospfd: Fix for memory leak issue in ospf related to flood_reduction tests. 
Problem:
Multiple memory leaks after pr12366

RCA:
ospf_lsa_unlock was not happening for the few of the LSAs in
ospf_lsa_refresh_walker after pr12366 due to which memory
related to lsas was leaking.

Fix:
Moved the ospf_lsa_unlock outside if check.

Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
 2023-03-23 05:59:38 -07:00