rgirada
9a06f23d0b
ospf6d: GR helper exit scenarios
...
Description:
Changes to cover all the following GR helper exit scenarios.
1. Upon receiving max age grace lsa.( successful graceful restart)
2. Topo change
3. Grace timer expiry.
4. User changes( like config deletion , interface down)
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
rgirada
0d1753a7db
ospf6d: Helper functionality changes
...
Description:
1. changes to process GRACE LSA packet.
2. Validation changes to enter Helper role.
3. Helper functionality during graceful restart.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
rgirada
0694366601
ospf6d: debug command support for helper support.
...
Description:
Adding debug support for helper functionality.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
rgirada
59790f521a
ospf6d: Init/De-init gr helper functionality
...
Description:
Graceful restart helper functionality initialisation and deinit apis.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
rgirada
91c169f7d7
ospf6d: Datastructure modification for GR helper functionality.
...
Description:
Adding GR helper specific datastructures.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
rgirada
6539d9ef45
ospf6d: documentation for ospf6 GR helper functionality
...
Description:
Documentation for ospf6 graceful restart Helper
functionality. Ref RFC : 5187.
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-08-10 02:57:23 -07:00
Igor Ryzhov
bdb7b7c5d9
Merge pull request #9321 from donaldsharp/no_leak_re
...
zebra: Prevent memory leak if route is rejected early
2021-08-10 11:39:30 +03:00
Christian Hopps
cb04c8e906
Merge pull request #9219 from mobash-rasool/ospfv2-bug-fixes
...
tools: Add ospfv2 and ospfv3 commands in support bundle
2021-08-10 03:14:43 -04:00
Mark Stapp
c123e9df54
Merge pull request #9299 from donaldsharp/zebra_should_continue
...
Zebra should continue
2021-08-09 13:16:10 -04:00
Quentin Young
edc6ea2ec5
Merge pull request #9273 from dlqs/luadofilefix
...
lib: Fix dead code from lua_dofile
2021-08-09 09:55:35 -04:00
Donald Sharp
38c764dde4
zebra: Properly note add/update for rib_add_multipath_nhe
...
When calling rib_add_multipath_nhe ensure that we have
well aligned return codes that mean something so that
interersted parties can properly handle the situation.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-09 08:06:33 -04:00
Donald Sharp
f94a7703c0
zebra: Prevent memory leak if route is rejected early
...
When receiving a route via zapi, if the route is rejected
there exists a code path where we would not free the corresponding
re created.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-09 07:55:07 -04:00
Donatas Abraitis
d04e7788c1
Merge pull request #9324 from donaldsharp/bgp_info_cmp
...
bgpd: Store distance received from a redistribute statement
2021-08-09 10:36:43 +03:00
Donatas Abraitis
4de721ee97
Merge pull request #9305 from proelbtn/patch-1
...
bgpd: fix typo in ensure_vrf_tovpn_sid
2021-08-09 10:35:10 +03:00
Donatas Abraitis
e885e97d87
Merge pull request #9325 from anlancs/fix-lib-warning
...
lib: Fix coverity warning of return value
2021-08-09 10:34:38 +03:00
Donald Sharp
2570a9f165
Merge pull request #8262 from reubendowle/fixes/nhrp-misc-fixes
...
nhrp misc fixes
2021-08-08 07:27:41 -04:00
Donald Sharp
a66413a53b
Merge pull request #8870 from anlancs/master-fix-reload-service
...
tools: add "vni" to oneline list
2021-08-08 07:21:10 -04:00
anlan_cs
4b0d126794
lib: Fix coverity warning of return value
...
Suppress coverity warning on unchecked str2sockunion's return value.
Signed-off-by: anlan_cs <anlan_cs@tom.com>
2021-08-07 21:57:55 -04:00
Donald Sharp
957f74c302
bgpd: Store distance received from a redistribute statement
...
When bgp receives the admin distance from a redistribution statement
let's store that distance for later usage.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-07 20:27:45 -04:00
Donald Sharp
62c173755d
Merge pull request #9283 from ton31337/fix/documentation_for_aggregate-address
...
doc: Specify how aggregate-address works for BGP
2021-08-07 16:07:34 -04:00
Donatas Abraitis
7e736c7706
Merge pull request #9253 from donaldsharp/igmp_no
...
pimd: Allow more permisive versions of some no commands
2021-08-07 22:49:25 +03:00
Donald Sharp
f932b4eef3
Merge pull request #9313 from idryzhov/bgp-zebra-opaque
...
BGP opaque data improvements
2021-08-07 15:12:02 -04:00
Donald Sharp
720f165fc9
Merge pull request #9315 from idryzhov/pathd-cli-fixes
...
pathd: a couple of cli/doc fixes
2021-08-07 15:10:05 -04:00
Christian Hopps
2e062fff45
Merge pull request #9312 from opensourcerouting/topo-small-fixes
...
topotests: small fixes for two tests
2021-08-06 13:34:52 -04:00
Igor Ryzhov
b7484ec650
doc: fix pathd example config
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-06 18:47:40 +03:00
Donald Sharp
883da9f5ec
Merge pull request #9256 from idryzhov/dampening-revert
...
BGP per-peer dampening revert
2021-08-06 10:46:09 -04:00
Donald Sharp
2f958e5562
Merge pull request #9280 from idryzhov/bgp-nb-revert-master
...
BGP NB revert
2021-08-06 10:45:59 -04:00
Donald Sharp
b34703d93c
Merge pull request #9294 from anlancs/fix-ospfd-init
...
ospfd: fix coverity warning
2021-08-06 10:33:08 -04:00
Igor Ryzhov
b5bb70e377
bgpd: add protection against too large opaque data structure
...
BGP opaque data shouldn't be larger than zebra's buffer.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-06 17:09:46 +03:00
Igor Ryzhov
a9bf0ff268
bgpd: use longer aspath string in opaque data
...
32 bytes are not enough to carry relatively long AS paths so let's make
the buffer larger.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-06 17:06:39 +03:00
Rafael Zalamena
e17e248b2a
topotests: reduce convergence check frequency
...
Check for convergence less frequently to reduce resources usage.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-08-06 10:38:41 -03:00
Rafael Zalamena
4000805713
topotests: skip daemons without configuration
...
Lets not start daemons without configurations.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-08-06 10:38:36 -03:00
Rafael Zalamena
20ec1f7038
topotests: remove code that checks for version
...
We version the tests with FRR so we no longer need to check for version.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-08-06 10:38:25 -03:00
Rafael Zalamena
0a5b9d7158
topotests: use new OSPFv3 interface area syntax
...
The old one is not VRF aware and is being deprecated.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-08-06 10:38:17 -03:00
Rafael Zalamena
582bf957fd
topotests: reduce MSDP topology
...
Meanwhile we don't get all MSDP features (MSDP route validation via BGP
AS Path as described in RFC 4611 Section 2), kill one of the links of
the topology to avoid intermittent test failures due to different
traffic route.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-08-06 10:35:45 -03:00
Ryoga
f7cafbb717
bgpd: fix typo in ensure_vrf_tovpn_sid
...
In eusure_vrf_tovpn_sid, there is a check to ensure not to select both
SID index and SID auto mode. But, this current check is wrong and not
meaningful.
Signed-off-by: proelbtn <contact@proelbtn.com>
2021-08-06 11:53:42 +09:00
Igor Ryzhov
882bae36a0
pathd: fix indentation and redundant space in index config
...
Before:
```
segment-routing
traffic-eng
segment-list SL1
index 10 mpls label 16010
```
After:
```
segment-routing
traffic-eng
segment-list SL1
index 10 mpls label 16010
```
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-05 23:47:27 +03:00
Igor Ryzhov
dfbabd45f8
pathd: fix indentation for mpls-te config
...
Before:
```
segment-routing
traffic-eng
mpls-te on
mpls-te import ospfv2
```
After:
```
segment-routing
traffic-eng
mpls-te on
mpls-te import ospfv2
```
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-08-05 23:45:44 +03:00
Mark Stapp
6696b16bf0
Merge pull request #9302 from ton31337/fix/comments
...
bgpd: Fix misleading comments for some parts
2021-08-05 14:39:38 -04:00
Donald Sharp
5dbd69cc9f
Merge pull request #9023 from idryzhov/static-nb
...
staticd: simplify the northbound code
2021-08-05 09:38:00 -04:00
Donatas Abraitis
639caccfeb
bgpd: Fix misleading comments for some parts
...
Mostly just retrun => return and misleading comments at all.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-05 16:29:52 +03:00
Donatas Abraitis
9a339b7fc5
doc: Specify how aggregate-address works for BGP
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-08-05 09:08:29 +03:00
anlan_cs
46a8c34324
ospfd: fix coverity warning of one field initialization
...
Add the initialization of prefixlen field in struct prefix.
Signed-off-by: anlan_cs <anlan_cs@tom.com>
2021-08-04 21:20:20 -04:00
Mark Stapp
5f10f7804f
Merge pull request #9050 from LabNConsulting/chopps/reset-parallel
...
Chopps/reset parallel
2021-08-04 16:17:30 -04:00
Sri Mohana Singamsetty
08d7be0f4d
Merge pull request #9261 from vivek-cumulus/fix_evpn_quick_flap
...
bgpd: Handle quick flaps of an EVPN prefix properly
2021-08-04 12:44:37 -07:00
Donald Sharp
6140b3b41b
zebra: prevent crash when nhlfe is NULL
...
There exists a call path where the nhlfe_alloc can return NULL
for blackhole nexthops. In this case we were still trying
to save the nhlfe pointer causing a crash when we attempted
to add it to a self-contained list.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-04 13:38:25 -04:00
Donald Sharp
b7457b40cd
lib: Blackhole nexthops cannot be used as part of label generation
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-04 13:34:03 -04:00
Donald Sharp
10cc80cafd
zebra: don't use default case when switching over enum nexthop
...
Do not use the `default` case when switching over an enumerated
type. This allows the code to fail to compile when we add a
new enumeration. Thus allowing us developers to know all
the places in the code we'll need to touch.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-04 13:34:03 -04:00
Mark Stapp
27649e64f2
Merge pull request #9291 from donaldsharp/fix_long_sleep
...
tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway
2021-08-04 12:54:25 -04:00
Donald Sharp
1ae0e1b315
lib: Convert assert to error and record it instead of aborting
...
When we get a bad value for the opaque data length, instead
of stopping the program, discard the data and move on.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-08-04 11:13:26 -04:00