Russ White
9635a16a36
Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref
...
bgpd: null check (Clang scan-build)
2018-06-19 07:18:13 -04:00
Russ White
5e51ae9816
Merge pull request #2491 from pacovn/cppcheck_no_effect
...
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
2018-06-19 07:15:07 -04:00
Russ White
aa13697bb0
Merge pull request #2492 from pacovn/cppcheck_security1
...
eigrpd, lib, tests, vtysh: security (cppcheck)
2018-06-19 07:14:19 -04:00
paco
6d10727ac1
eigrpd, lib, tests, vtysh: security (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 10:40:56 +02:00
paco
5f18adf01b
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
...
Assignment of function parameter has no effect outside the function.
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-19 10:19:05 +02:00
Lou Berger
ed892e530d
Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced
...
bgpd: null check (Coverity 1433544, 1433543, 1433542)
2018-06-18 16:59:26 -04:00
Donald Sharp
b5e3687b1d
Merge pull request #2482 from pacovn/clang_scan_bgpd_bgp_rpki_deref
...
bgpd: null check (Clang scan-build)
2018-06-18 16:09:56 -04:00
paco
d3e51db069
bgpd: null check (Clang scan-build)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 21:37:35 +02:00
Donald Sharp
e8609f7950
Merge pull request #2484 from pacovn/cppcheck_unused_vars
...
eigrpd, lib: unused vars (cppcheck)
2018-06-18 15:27:11 -04:00
Donald Sharp
6f32955ec3
Merge pull request #2486 from pacovn/cppcheck_fmt_validation
...
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
2018-06-18 15:23:49 -04:00
Donald Sharp
2daa80f0c0
Merge pull request #2489 from pacovn/cppcheck_reduntant_pointer_op
...
ldpd: redundant pointer operation (cppcheck)
2018-06-18 15:16:55 -04:00
Donald Sharp
cfa38db146
Merge pull request #2488 from pacovn/cppcheck_nhrpd_limit_check
...
nhrpd: array limit check (cppcheck)
2018-06-18 15:16:34 -04:00
Donald Sharp
b49bc6b010
Merge pull request #2487 from pacovn/cppcheck_redundant_memset
...
ospfd, pimd: redundant memset (cppcheck)
2018-06-18 15:15:46 -04:00
Donald Sharp
162deb7dfb
Merge pull request #2490 from pacovn/cppcheck_unsigned_check
...
babeld, eigrpd, ospfd: unsigned negative check (cppcheck, grouped)
2018-06-18 15:14:07 -04:00
Donald Sharp
c0662bb478
Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code
...
bgpd: dead code (Coverity 1399373)
2018-06-18 14:29:27 -04:00
paco
d11c6941dc
babeld, eigrpd, ospfd: unsigned negative check
...
After Cppcheck 1.72 feedback
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 19:07:24 +02:00
paco
e83c042a88
ldpd: redundant pointer operation (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 18:41:57 +02:00
paco
0e3d32f1c9
nhrpd: array limit check (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 18:13:41 +02:00
paco
1a36dd60fd
ospfd, pimd: redundant memset (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 18:01:59 +02:00
Donald Sharp
36de1d53b8
Merge pull request #2457 from pacovn/Coverity_1465491_Untrusted_value_as_argument
...
pimd: Untrusted val as argument (Coverity 1465491)
2018-06-18 11:55:53 -04:00
Donald Sharp
7c75247f66
Merge pull request #2464 from pacovn/Coverity_1399309_Out-of-bounds_access
...
isisd: out-of-bounds access (Coverity 1399309)
2018-06-18 11:55:16 -04:00
paco
2ec42b858c
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 17:52:56 +02:00
paco
029a775e43
eigrpd, lib, vtysh: unused vars (cppcheck)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 17:23:38 +02:00
paco
18b91526fa
bgpd: null check (Clang scan-build)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 16:27:02 +02:00
paco
c37a11ad72
bgpd: null chk (Coverity 1433544 1433543 1433542)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-18 16:07:43 +02:00
Lou Berger
2868e293e7
Merge pull request #2466 from pacovn/clang_scan_bgpd_dereference1
...
bgpd: null check (Clang scan-build)
2018-06-18 08:16:01 -04:00
Lou Berger
f0380e0468
Merge pull request #2456 from pacovn/Coverity_1399306_Out-of-bounds_access
...
bgpd: out-of-bounds access (Coverity 1399306)
2018-06-18 08:12:04 -04:00
Lou Berger
f4659d27c6
Merge pull request #2467 from pacovn/Coverity_1399274_Dereference_after_null_check
...
bgpd: null check (Coverity 1399274)
2018-06-16 08:26:26 -04:00
paco
4f9a63adba
bgpd: null check (Coverity 1399274)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 20:09:55 +02:00
paco
cc35bc7c8f
bgpd: null check (Clang scan-build)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 20:02:23 +02:00
Quentin Young
65c4ceac44
Merge pull request #2447 from ajones-rvbd/ajones-issue-2391
...
alpine: add unit tests to build
2018-06-15 12:40:19 -04:00
paco
c28135f38e
isisd: out-of-bounds access (Coverity 1399309)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 18:36:20 +02:00
Quentin Young
97b1dd19a1
Merge pull request #2409 from LabNConsulting/working/master/vtysh-2400
...
vtysh: -u fixes
2018-06-15 12:33:44 -04:00
Donald Sharp
6389e663e9
Merge pull request #2458 from pacovn/Coverity_1221437_Unchecked_return_value
...
ospf6d: unchecked return value (Coverity 1221437)
2018-06-15 10:53:58 -04:00
paco
18e994a043
pimd: Untrusted val as argument (Coverity 1465491)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 14:46:25 +02:00
paco
246879c303
ospf6d: unchecked return value (Coverity 1221437)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 13:08:37 +02:00
paco
5beb290a7b
bgpd: out-of-bounds access (Coverity 1399306)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 12:39:10 +02:00
paco
1d1c0de9f0
bgpd: dead code (Coverity 1399373)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-15 11:55:13 +02:00
Rafael Zalamena
e4a374681d
Merge pull request #2426 from pacovn/Coverity_23089_Buffer_not_null_terminated
...
ospfd: buffer termination (Coverity 23089)
2018-06-14 18:02:34 -03:00
Rafael Zalamena
67f23e08c3
Merge pull request #2438 from pacovn/Coverity_1457300_Dereference_after_null_check
...
ospfd: null check (Coverity 1457300)
2018-06-14 17:58:10 -03:00
Arthur Jones
95bd0d7e05
alpine: add unit tests to build
...
Now that make check works on alpine, add it to the build
Testing done: alpine linux build -- check works
Issue: https://github.com/FRRouting/frr/issues/2391
Signed-off-by: Arthur Jones <arthur.jones@riverbed.com>
2018-06-14 10:27:24 -07:00
Donald Sharp
259952c503
Merge pull request #2422 from pacovn/Coverity_23201_Dereference_before_null_check
...
bgpd: null check (Coverity 23201)
2018-06-14 13:03:50 -04:00
Renato Westphal
0d0ca0bb34
Merge pull request #2435 from pacovn/Coverity_1464993_Buffer_not_null_terminated
...
ospfd: buffer termination (Coverity 1464993)
2018-06-14 13:44:10 -03:00
paco
1f9d4e3d49
ospfd: buffer termination (Coverity 23089)
...
Details:
- INET_ADDRSTRLEN is 16, for xxx.xxx.xxx\0, so 15 is now passed
to the strncpy call instead of 16, ensuring ASCII-z output
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-14 17:43:19 +02:00
paco
a247298087
bgpd: null check (Coverity 23201)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-14 17:18:08 +02:00
paco
e4407ea6d0
ospfd: buffer termination (Coverity 1464993)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-14 16:59:31 +02:00
Rafael Zalamena
c0519af39f
Merge pull request #2430 from pacovn/clang_scan_ospf_dereference
...
ospfd: dereference check (Clang scan-build)
2018-06-14 11:14:52 -03:00
Rafael Zalamena
fbd3d404ae
Merge pull request #2434 from pacovn/Coverity_1457145_Out-of-bounds_access
...
lib: out-of-bounds access (Coverity 1457145)
2018-06-14 11:09:05 -03:00
Donald Sharp
dd52a18493
Merge pull request #2436 from pacovn/Coverity_1143220_Argument_cannot_be_negative
...
tools: return check (Coverity 1143220)
2018-06-14 10:02:25 -04:00
Rafael Zalamena
d17840aa8a
Merge pull request #2437 from pacovn/Coverity_1436343_Dereference_after_null_check
...
lib: null check (Coverity 1436343)
2018-06-14 11:00:57 -03:00