Commit Graph

17423 Commits

Author SHA1 Message Date
Donald Sharp
68a4422da4 lib: vrf lookup may be NULL
The vrf lookup may be NULL, so let's protect against this.
Found in coverity

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-10-24 18:44:48 -04:00
Renato Westphal
f935dca78f
Merge pull request #5203 from qlyoung/fix-vrrp-error-alternations
vrrpd: fix startup error message reporting
2019-10-23 21:16:04 -03:00
Renato Westphal
9951e1c711
Merge pull request #5217 from mjstapp/fix_bgp_evpn_pi
bgpd: clarify evpn datastruct use for SA
2019-10-23 21:02:00 -03:00
Renato Westphal
5d98d948d2
Merge pull request #5214 from donaldsharp/vrrp_doc
doc: Update supported platforms matrix w/ vrrpd
2019-10-23 21:00:25 -03:00
Renato Westphal
a783c421f9
Merge pull request #5202 from Orange-OpenSource/isis-TE
isisd: Correct missing advertisement of TE parameters
2019-10-23 20:59:29 -03:00
Mark Stapp
bd0254af6c bgpd: clarify evpn datastruct use for SA
Clear up an SA report by clarifying a function call in the evpn
code.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2019-10-23 11:56:35 -04:00
Donald Sharp
36d687f6fa doc: Update supported platforms matrix w/ vrrpd
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-10-23 09:11:45 -04:00
Quentin Young
3e6fd94f83
Merge pull request #5204 from ghasemnaddaf/vrrp_updates
doc: vrrp vip must not be on parent interface
2019-10-22 11:27:29 -04:00
Donatas Abraitis
4b0d7efeea
Merge pull request #5193 from qlyoung/doc-release-fixes
Document release procedure
2019-10-22 09:57:12 +03:00
Ghasem Naddaf
9965000665 doc: vrrp vip must not be on parent interface
Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>
2019-10-21 14:58:16 -07:00
Quentin Young
00c3cf9c2a vrrpd: fix startup error message reporting
Due to some extremely shoddy programming on my part, the error messages
for certain errors was pretty much always wrong. We would start with the
correct error message, then on the next check, regardless of whether it
passed or failed, we would null out the error message, then on the next
one set it again (to the wrong message), then null it, and just keep
alternating. So errors were sometimes not being reported, sometimes
being reported correctly (if the condition parity happened to match the
appropriate condition), and sometimes being reported correctly.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-21 19:04:30 +00:00
Olivier Dugeon
9f62f0435e isisd: Correct missing advertisement of TE param.
Traffic Engineering parameters are correctly advertised in LSP when
'mpls-te on' CLI command is present in the startup config file.

However, if IS-IS is started without TE enable at startup and
'mpls-te on' command is issued after, TE link parameters are never
announced. The patch correct this issue.

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
2019-10-21 18:44:20 +02:00
Quentin Young
972d752122 doc: strip ws, shell -> console
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-21 16:11:09 +00:00
Donatas Abraitis
acf061a9ab
Merge pull request #5108 from donaldsharp/sendbuffer_size_bgp
Sendbuffer size bgp
2019-10-20 12:09:42 +03:00
Mark Stapp
0a764122e1
Merge pull request #5184 from sworleys/Kernel-Route-Update
zebra: Rib Update Event Scheduler For Un-managed Routes, etc.
2019-10-19 12:01:47 -04:00
Russ White
12bea6d575
Merge pull request #4850 from lkrishnamoor/show_cli
bgpd: Adding new bgp evpn cli's for ip-prefix lookup
2019-10-18 21:30:37 -04:00
Stephen Worley
2a18114787 zebra: On if down/addr-del, process kernel routes
Since we don't have a daemon who's job is to handle kernel
routes and we don't get an explicit route delete anymore if
nexthops become unreachable from the kernel, zebra must
re-process kernel routes itself to make sure they are still valid.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-10-18 16:59:34 -04:00
Stephen Worley
a8c427ee39 zebra: Check active on OLD system/kernel routes
We can assume that system/kernel routes are valid indeed
if this is our first time procesing them. But since we don't
get explicit deletion events for kernel routes anymore, we
have to be prepared to process them if the nexthop becomes
unreachable for instance. Therefore, if the route is not NEW,
then don't assume its valid.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-10-18 16:59:34 -04:00
Stephen Worley
2a99ab95e6 zebra: Handle rib updates as a thread event
If we need to batch process the rib (all tables or specific
vrf), do so as a scheduled thread event rather than immediately
handling it. Further, add context to the events so that you
narrow down to certain route types you want to reprocess.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-10-18 16:59:25 -04:00
Quentin Young
f4bcc72f99 doc: update release procedure docs
Add a lot of detail and update some outdated stuff.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-18 18:50:10 +00:00
Quentin Young
b41f3f0a21 doc: fix messed up topotests docs
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-18 18:50:10 +00:00
Quentin Young
757c868b4b
Merge pull request #5180 from mjstapp/fix_nhrp_sa
nhrpd: clean up SA warning
2019-10-18 13:16:02 -04:00
Renato Westphal
dfd7b62ddd
Merge pull request #5172 from donaldsharp/sa_clean_and_clean
Sa clean and clean
2019-10-17 23:14:31 -03:00
Renato Westphal
ca83094d26
Merge pull request #5182 from qlyoung/fix-doc-index-read-quanta
doc: fix read-quanta .. index copy-paste err
2019-10-17 23:11:05 -03:00
Quentin Young
2e6c9a1db5
Merge pull request #5181 from ghasemnaddaf/vrrp_updates
vrrpd: use CS2MS instead of constant 10 everywhere
2019-10-17 18:55:08 -04:00
Ghasem Naddaf
de7fe61e10 vrrpd: use CS2MS instead of constant 10 everywhere
Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>

vrrpd: use CS2MS instead of constant 10 everywhere

Signed-off-by: Ghasem Naddaf <ghasem.naddaf@gmail.com>
2019-10-17 15:54:04 -07:00
Mark Stapp
123ea351a4 nhrpd: clean up SA warning
Try to signal to SA/clang more clearly to clean up an SA warning
in the nhrp-specific linkedlist code.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2019-10-17 16:08:47 -04:00
Quentin Young
dad83b6745 doc: fix read-quanta .. index copy-paste err
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-17 19:53:19 +00:00
Donald Sharp
0997ca9669
Merge pull request #5179 from ashish12pant/large_comm
tests: bgp community and bgp large-community
2019-10-17 13:47:20 -04:00
Sri Mohana Singamsetty
03e484aafa
Merge pull request #5165 from donaldsharp/evpn_fixup
bgpd: return created bgp_path_info
2019-10-17 10:15:01 -07:00
Mark Stapp
5b724d424b
Merge pull request #5171 from donaldsharp/remove_getrusage
*: Allow disabling of `getrusage` calls
2019-10-17 12:26:28 -04:00
Mark Stapp
10e75ceb6a
Merge pull request #5150 from qlyoung/bgp-vector-io-4
BGP vector I/O - Redux
2019-10-17 10:57:47 -04:00
Mark Stapp
da1cf7f2e8
Merge pull request #5161 from sworleys/Fix-Rule-Dbl-Free
lib,zebra: Fix PBR Rule Ifp Reference if Interface is Deleted
2019-10-17 10:31:40 -04:00
Mark Stapp
9cd06d69ad
Merge pull request #5175 from opensourcerouting/debug-nb-yang
lib, vtysh: add new libyang option to the "debug northbound" command
2019-10-17 10:07:05 -04:00
Sri Mohana Singamsetty
e75bbefa0e
Merge pull request #5167 from mjstapp/test_nhrp_list_sa
nhrpd: be more careful in linkedlist macro
2019-10-16 22:22:05 -07:00
Donatas Abraitis
5307ffd0fd
Merge pull request #5176 from qlyoung/alpine-update-mpfr-dep
fix alpine 🎿🎿🎿 docker build 🛠️
2019-10-17 08:13:01 +03:00
Ashish Pant
85d4777301 tests: Add test cases for bgp community and large community
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Test cases to check functionality of bgp large community and
bgp community path attribute
2019-10-17 09:19:26 +05:30
Ashish Pant
6d32a6a18a tests: Update cli error list and retry function
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Add cli error returned for invalid bgp-community-list command

Fix retry function to avoid retries when expected is False
2019-10-17 09:17:03 +05:30
Ashish Pant
06e693f11b tests: Update bgp api for community and aggregate address
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Add support for not sending community data in bgp and update
aggregate address configuration code
2019-10-17 09:17:03 +05:30
Ashish Pant
ca2ef9e6ff tests: Add verify community list api
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Api checks if community list is present in the system or not
2019-10-17 09:17:03 +05:30
Ashish Pant
287d692409 tests: Add step api in topojson
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Print messages with a step number to log from test case
2019-10-17 09:17:03 +05:30
Quentin Young
338728fb71 alpine: clean up dep block
Wrap to 80 cols...

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-16 20:38:27 +00:00
Quentin Young
7d29ff567c alpine: update mpfr3 -> mpfr4
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2019-10-16 20:37:44 +00:00
Renato Westphal
07705c8b8a lib: silence compiler warning in the gRPC plugin
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2019-10-16 17:13:28 -03:00
Renato Westphal
62ae9adeef lib, vtysh: add new libyang option to the "debug northbound" command
Guard the libyang debug messages under this command so that only
people interested on those messages will see them.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2019-10-16 17:11:41 -03:00
Renato Westphal
21f5aade3d vtysh: remove DEFPY variable names
Some DEFPY commands were copied to vtysh without being cleaned up
properly. Fix this.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2019-10-16 17:09:09 -03:00
Russ White
718804149e
Merge pull request #5078 from lkrishnamoor/advertise-routes
bgpd: Fix "show bgp l2vpn evpn neighbors x.x.x.x advertised-routes json"
2019-10-16 15:05:23 -04:00
Russ White
b42d15054d
Merge pull request #5118 from lkrishnamoor/routes_json
bgpd: Fix in "show bgp l2vpn evpn neighbors X.X.X.X routes json"
2019-10-16 15:01:13 -04:00
Donald Sharp
401b063670 bgpd: In redistribution aspath cannot be NULL
Coverity has found a path where the attr.aspath may be NULL.

assert that the aspath is non-null so we can make this go away.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-10-16 13:38:29 -04:00
Donald Sharp
8f79e2cf65 zebra: zrt->table cannot crash here
If we have a zrt data structure then we have a table pointer
as well.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-10-16 13:38:29 -04:00