David Lamparter
683f0a1b12
Merge pull request #603 from qlyoung/fix-access-packed-member
...
*: do not take address of packed member
2017-05-30 14:26:03 +02:00
Renato Westphal
cf4e348abb
Merge pull request #615 from dslicenc/cm16531
...
zebra: add bgp unnumbered labeled-unicast to zserv
2017-05-29 19:32:38 -03:00
Renato Westphal
8a74a9d1a5
Merge pull request #614 from qlyoung/fix-ospf6-oa-scope
...
ospf6d: default to dotted quad instead of ret NULL
2017-05-29 17:49:52 -03:00
Renato Westphal
8ae2631740
Merge pull request #625 from donaldsharp/show_zebra
...
zebra: Fix 64 bit number printf issues
2017-05-29 12:58:21 -03:00
Renato Westphal
977c469f87
Merge pull request #629 from donaldsharp/eigrp_network
...
eigrpd: Fix network statement
2017-05-29 11:47:41 -03:00
Renato Westphal
c5fd908903
Merge pull request #618 from donaldsharp/hopola
...
Hopola
2017-05-29 10:21:46 -03:00
Donald Sharp
db215e1f4d
eigrpd: Fix network statement
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-29 07:08:52 -04:00
Donald Sharp
901fda9830
nhrpd: Fix missing include for 'access_list_init' function
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-27 18:18:59 -04:00
Donald Sharp
a1579fd393
zebra: Fix 64 bit number printf issues
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-26 14:06:37 -04:00
Quentin Young
000fe2ca4c
bgpd: remove struct capability_orf_entry
...
virtually unused
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-26 15:22:24 +00:00
Quentin Young
c5f119c06d
*: do not take address of packed member
...
May result in alignment errors on certain platforms
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-26 15:22:23 +00:00
Donald Sharp
66d4272752
zebra: Remove string operations from non-debug path
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:22:03 -04:00
Donald Sharp
8755598a08
zebra: Store commonly used values instead of regenerating
...
the ipv4_ll address used for 5549 routes does not need
to be figured out every single time that we attempt
to install/remove a route of that type.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:11:24 -04:00
Don Slice
79878cf73e
zebra: add bgp unnumbered labeled-unicast to zserv
...
Prior to the fix, labels weren't getting installed in zebra nor were the
ifindex values correctly set if labeled-unicast was used in conjunction
with bgp unnumbered.
Ticket: CM-16531
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-6276
2017-05-25 04:19:10 -07:00
Jafar Al-Gharaibeh
fb13a6d478
Merge pull request #610 from donaldsharp/rpprefixlen
...
pimd: Allow secondary address comparisons to work
2017-05-24 22:10:19 -06:00
Quentin Young
dc207b2760
ospf6d: default to dotted quad instead of ret NULL
...
to fix coverity warning
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-25 04:09:52 +00:00
Donald Sharp
9e962de4b6
Merge remote-tracking branch 'origin/stable/3.0'
2017-05-24 11:22:35 -04:00
Donald Sharp
2d828a0c67
Merge pull request #612 from LabNConsulting/working/master/patch-set/deprecateEncap
...
master: remove support for config & show of encap safi
2017-05-24 11:04:53 -04:00
Donald Sharp
f731a65469
Merge pull request #611 from LabNConsulting/working/3.0/patch-set/deprecateEncap
...
3.0: remove support for config & show of encap safi
2017-05-24 11:04:36 -04:00
Lou Berger
1ec1afd6cb
bgpd: remove encap safi vty related files bgp_encap.h|c
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
eedae49501
bgpd: remove encap_safi rx processing
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
375a2e67ad
bgpd: remove encap safi show commands
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
6c8744af2d
bgpd: remove additional instance of BGP_ENCAP(v6)_NODE
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
2fd1b54aa1
bgpd rfapi: remove ability to configure use of encap-safi (continue to use encap attribute)
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:42:40 -04:00
Lou Berger
5b1f0f29e7
bgpd: remove support for ipv4|6 encap safi config
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:42:32 -04:00
Lou Berger
ddb2927dff
vtysh: remove BGP_ENCAP(V6)_NODE
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:40:23 -04:00
Lou Berger
b1ff4223c7
lib: remove BGP_ENCAP(V6)_NODE
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:40:12 -04:00
Lou Berger
26a4b7c3c3
bgpd: remove encap safi vty related files bgp_encap.h|c
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:34:43 -04:00
Donald Sharp
ad5233c886
pimd: Allow secondary address comparisons to work
...
The secondary address comparison done to determine if we are
an RP for a specified address was comparing A.B.C.D/32 to A.B.C.D/0
because when we created the rp_info we were not setting the prefixlen
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-23 15:31:37 -04:00
Lou Berger
796e5801cf
bgpd: remove encap_safi rx processing
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:15:45 -04:00
Lou Berger
33c0d63f9c
bgpd: remove encap safi show commands
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:11:30 -04:00
Lou Berger
3c6ba3ec02
bgpd rfapi: remove ability to configure use of encap-safi (continue to use encap attribute)
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:02:31 -04:00
Lou Berger
5f69e7a7ac
bgpd: remove support for ipv4|6 encap safi config
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:01:54 -04:00
Lou Berger
b61410ebd5
vtysh: remove BGP_ENCAP(V6)_NODE
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:01:09 -04:00
Lou Berger
93b9c66617
lib: remove BGP_ENCAP(V6)_NODE
...
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:00:53 -04:00
Donald Sharp
4e33d4ef9b
Merge pull request #598 from donaldsharp/to_3.0
...
To 3.0
2017-05-23 11:42:11 -04:00
David Lamparter
92cf703760
Merge pull request #593 from qlyoung/fix-nhrpd-acl-3.0
...
nhrpd: install access-list commands
2017-05-22 17:46:48 +02:00
David Lamparter
33dc0e6643
Merge pull request #591 from qlyoung/ospf-df-areaid-3.0
...
ospfd: remember format for ospf area id
2017-05-22 17:45:55 +02:00
David Lamparter
db64fac494
Merge pull request #582 from qlyoung/ospf6-df-areaid
...
ospf6d: remember format for ospf6 area id
2017-05-22 17:45:29 +02:00
David Lamparter
1aba7c0944
Merge pull request #581 from donaldsharp/zebra
...
Zebra
2017-05-22 17:44:33 +02:00
David Lamparter
0ef0c0505e
Merge pull request #596 from donaldsharp/bgp_vrf_terminate
...
bgpd: Fix crash when going down
2017-05-22 17:40:26 +02:00
David Lamparter
ea58ccf178
Merge pull request #600 from qlyoung/fix-privs-obo
...
lib: fix array sizes for capability map
2017-05-22 17:39:40 +02:00
David Lamparter
572244546c
Merge pull request #599 from qlyoung/fix-ospf6-uaf-3.0
...
ospf6d: fix use-after-free
2017-05-22 17:39:03 +02:00
Quentin Young
fb12f2c75f
lib: fix array sizes for capability map
...
incorrect array sizes causing out of bounds read and potentially
incorrect capability settings
introduced in 1b322039
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-22 02:32:12 +00:00
Quentin Young
8f599166fb
ospf6d: fix use-after-free
...
ospf6_route_remove may free the ospf6_route passed to it if the refcount
reaches zero, in which case zeroing the ->flag field constitutes a uaf
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-22 02:14:29 +00:00
David Lamparter
1d6664e090
vtysh: fix autocompletion API misuse
...
I forgot to update this call when I changed
cmd_variable_handler_register to take an array...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-05-21 20:37:34 -04:00
Renato Westphal
8b93b03839
bgpd: fix sending of invalid nexthops on the wire
...
The bpacket_reformat_for_peer() function rewrites the nexthop of outgoing
route updates on a per-peer basis in order to handle route-maps ("set
ip next-hop") and locally-originated routes missing a nexthop.
In the latter case, RFC 4271 says the following: "When announcing a
locally-originated route to an internal peer, the BGP speaker SHOULD use
the interface address of the router through which the announced network
is reachable for the speaker as the NEXT_HOP".
We were doing this for regular IPv4/IPv6 routes, but not for
VPN/EVPN/ENCAP routes, which were being announced with invalid nexthops
(0.0.0.0 or ::).
This patch fixes this problem.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-20 13:06:45 -04:00
Renato Westphal
e50d0a4857
bgpd: fix display of encap routes in the running configuration
...
Static encap routes don't have an MPLS label. Also, use %u instead of
%d to print the label.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-20 13:06:45 -04:00
Renato Westphal
239b498d3f
bgpd: add network commands for encapv6
...
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-20 13:06:45 -04:00
Renato Westphal
7c4e00e305
bgpd: remove unused str2tag() function
...
This function is not used anymore since commit fb1d2a2d9
.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-20 13:06:45 -04:00