proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-04-28 15:36:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,066 Commits 4 Branches 191 Tags 125 MiB
4a1696818f
Commit Graph

32066 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Ward
4a1696818f ospf6d: Prevent redundant LSA generation before interface goes down 
Commit 76249532fa ("ospf6d: Handle Premature Aging of LSAs") added a
duplicate call to OSPF6_INTRA_PREFIX_LSA_EXECUTE_TRANSIT(), when the
interface state changes to "Down".

Fixes: #1738

Signed-off-by: David Ward <david.ward@ll.mit.edu>
 2023-05-31 16:44:44 -04:00
Donald Sharp
7470509390
Merge pull request #13632 from LabNConsulting/chopps/mgmt-avoid-race 
mgmtd: fix possible race btw read config and backend connection
 2023-05-31 07:28:50 -04:00
Donald Sharp
a53c4891fd
Merge pull request #13639 from opensourcerouting/ospf-timestamp-truncation 
ospfd, ospf6d: fix time_t truncation
 2023-05-31 07:26:06 -04:00
Donatas Abraitis
549f664d39
Merge pull request #13634 from yyuanam/fix_bgp_core 
bgpd: fix bgpd core when unintern attr
 2023-05-31 08:57:40 +03:00
Jafar Al-Gharaibeh
adea8ef308
Merge pull request #13635 from donaldsharp/give_ping_a_chance 
tests: Actually loop if ping fails
 2023-05-30 18:59:44 -05:00
Yuan Yuan
32af4995aa bgpd: fix bgpd core when unintern attr 
When the remote peer is neither EBGP nor confed, aspath is the
shadow copy of attr->aspath in bgp_packet_attribute(). Striping
AS4_PATH should not be done on the aspath directly, since
that would lead to bgpd core dump when unintern the attr.

Signed-off-by: Yuan Yuan <yyuanam@amazon.com>
 2023-05-30 22:49:07 +00:00
Renato Westphal
2882096fad ospfd, ospf6d: fix time_t truncation 
Change timestamp parameter from int to time_t to avoid truncation.

Found by Coverity Scan (CID 1563226 and 1563222)

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2023-05-30 19:47:28 -03:00
Donald Sharp
22c10bbdaa tests: Actually loop if ping fails 
The usage of run_and_expect doesn't work if the function
being called as the run part asserts.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-05-30 15:43:42 -04:00
Donatas Abraitis
147c7a2de3
Merge pull request #13631 from donaldsharp/fix_some_ping_issues 
various issues
 2023-05-30 21:26:24 +03:00
Christian Hopps
3744ad02d9 mgmtd: fix possible race btw read config and backend connection 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 11:52:19 -04:00
Donald Sharp
9be555f8d4
Merge pull request #13601 from opensourcerouting/build-yang-embed-20230525 
build: fix missing YANG model embedding
 2023-05-30 11:34:29 -04:00
mobash-rasool
46d0674da0
Merge pull request #13588 from sri-mohan1/srib-ldpd1 
ldpd: changes for code maintainability
 2023-05-30 21:02:31 +05:30
Donald Sharp
63e04998a7
Merge pull request #13414 from LabNConsulting/chopps/no-mgmtd-nowrite-on-off 
rework messaging, resource handling in mgmtd with bug fix and code hardening
 2023-05-30 10:48:32 -04:00
Christian Hopps
ff6b14a658 zebra: use ifindex vs ifp to avoid use-after-free on shutdown 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 04:09:29 -04:00
Christian Hopps
8cfe36bc7e zebra: avoid unneeded vxlan work on shutdown 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 04:09:29 -04:00
Christian Hopps
7cd87abc5e tests: add unified config tests 
- simple unified test
- unified test with late backend startup test

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 04:09:29 -04:00
Christian Hopps
51941c1916 mgmtd: address review comments 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
8611886d52 mgmtd: fix clang uninit warning 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
e3c4bd2472 tests: add some more mgmtd tests 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
0327be91d1 mgmtd: cleanup BE xpath subscription and matching code 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
52a50ca1d7 lib: mgmtd: fix memleaks 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
5ba5613077 lib: mgmtd: add manual vty server start option and use it 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:20 -04:00
Christian Hopps
e13a5c4165 lib: mgmtd: fixes for startup config file processing 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:10:19 -04:00
Christian Hopps
7a0894b532 mgmtd: Add note to SETCFG_REQ and debug logging 
- convert impossible situation into assert

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:09:51 -04:00
Christian Hopps
acd7aea00e mgmtd: simplify early config build removing unused code 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:09:51 -04:00
Christian Hopps
a1d8c7a36e mgmtd: fix reading of config file[s] 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-30 02:09:44 -04:00
Donald Sharp
46d725f76b lib, zebra: Ensure that the ifp->node exists 
On removal, ensure that the ifp->node is set to a null
pointer so that FRR does not use data after freed.
In addition ensure that the ifp->node exists before
attempting to free it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-05-28 10:13:16 -04:00
Donald Sharp
06504bea79 pimd: When doing json output do not output non-json strings 
When entering some show commands that use json in pimd
when the interface cannot be found do not output non-json
format in that case.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-05-28 07:37:25 -04:00
Donald Sharp
131153ea22 tests: Allow ping to run multiple times before failing 
the bgp_default_originate test brings up the topology and
then immediately pings.  Which sometimes fails.  This is
of course possible since the first ping might actually fail
due to arp going on.  So let's give it a second chance or two.
Especially since the test, at this point, is just installing
a default route.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-05-28 07:37:25 -04:00
Donald Sharp
2fccc9fa10
Merge pull request #13602 from opensourcerouting/fix/reuse_subgroup_process_announce_selected 
bgpd: Refactor subgroup_announce_table() to reuse an existing helpers
 2023-05-28 07:11:43 -04:00
Christian Hopps
edafa64c30 lib: enable short circuit for FE client/adapter connection 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
43f7196f3a staticd: remove connect notify function, not needed 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
218625aa43 mgmtd: lib: cleanup error and debug messages 
- always use IDs not a mix of IDs and pointers.
- always use PRIu64 not a mix of hex and decimal for IDs

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
42f4bb2b1a mgmtd: lib: move INIT to after client registers 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
9405278ef2 mgmtd: send reply to SUBSCR_REQ with success or not 
since we don't actually handle xpath subscriptions, reply with fail
if they are requested.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
5f05ff5821 lib: add short-circuit operation between same process 
- Use a socketpair for connection, and direct (no event loop)
message sending and handling.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
08e8019c65 lib: mgmtd: add a identifying tag to the debug message 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
d6665cf63f lib: dont be tricky with session_id just make it a session_id 
- Previously was substituting a pointer to local allocated session for the
session_id returned from the FE adapter. This complexity isn't needed.
- Get rid of "%llu" format and the casts that came with it, instead use PRIu64
and the actual (uint64_t) type.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
bcc350971f mgmtd: fix cleanup of cleanup in FE adapter code 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
c193194905 mgmtd: eliminate unused state 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
e3cacd9643 mgmtd: cleanup/fix BE adapter deletion code 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
6dad9b53e7 mgmtd: convert BE/FE adapter to use allocated connections 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
99564edc43 lib: mgmtd: add server-side connection code to mgmt_msg 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
070c5e7a91 lib: msg: refactor common connection code from mgmtd 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
528b326616 lib: mgmt msg: add version to messages 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
fff34d7274 lib: remove write-on-off, just requeue to the back of the queue 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Christian Hopps
898499a50f tests: python-foo assure foo[0] is on a list not dict_values object 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2023-05-28 05:13:22 -04:00
Donatas Abraitis
5773954be9
Merge pull request #13611 from donaldsharp/logger_warn 
tests: Convert to using logger.warning
 2023-05-27 20:05:50 +03:00
Donatas Abraitis
607c84f406
Merge pull request #13608 from donaldsharp/pam_wrong 
vtysh: Give actual pam error messages
 2023-05-27 15:35:25 +03:00
Donald Sharp
780a8a10e6 tests: Convert to using logger.warning 
Use the non deprecated format.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2023-05-26 16:00:42 -04:00