Commit Graph

22751 Commits

Author SHA1 Message Date
David Lamparter
494d842022 tests: add unit test for xrefs
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:28:11 +01:00
David Lamparter
87d383171d doc/developer: xrefs
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:28:11 +01:00
David Lamparter
01485adb9d lib/xref: add xrefs for install_element()
Combined with the DEFUN xrefs, this means we can extract the full CLI
tree from a binary file.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:28:11 +01:00
David Lamparter
feb06e7a93 lib/xref: add xrefs for DEFUNs
This allows grabbing a list of all DEFUNs and their help texts through
the xref extraction mechanics.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:28:11 +01:00
David Lamparter
131879fb92 lib/xref: add xrefs on zlog_* calls
This allows extracting a list of all log messages including their ECs
and autogenerated unique IDs for them.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:28:09 +01:00
David Lamparter
60a3efec24 lib/xref: use to transport thread_* file/line/func
Just a better way of doing what was previously the "debugargdef" macro.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:20:41 +01:00
David Lamparter
b2fa8c0fa3 lib/xref: put setup calls in libraries
Our "true" libraries (i.e. not modules) don't invoke neither
FRR_DAEMON_INFO nor FRR_MODULE_SETUP, hence XREF_SETUP isn't invoked
either.  Invoke it directly to get things working.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:18:51 +01:00
David Lamparter
8e427c2938 lib: "xref" identifier infrastructure
This adds the machinery for cross reference points (hence "xref") for
things to be annotated with source code location or other metadata
and/or to be uniquely identified and found at runtime or by dissecting
executable files.

The extraction tool to walk down an ELF file is done and working but
needs some more cleanup and will be added in a separate commit.

Signed-off-by: David Lamparter <equinox@diac24.net>
2021-02-01 17:18:02 +01:00
David Lamparter
3c191fb138 lib: move frr_weak_random to header file
Makes more sense to have this as a static inline.  Also I don't want to
be forced to link network.o into clippy ;)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-02-01 17:08:13 +01:00
Donald Sharp
6968b038eb
Merge pull request #7965 from opensourcerouting/netns-doc
doc: add information about network namespaces
2021-02-01 09:01:25 -05:00
Donald Sharp
1d03b7b88b
Merge pull request #7988 from ton31337/fix/initialize_raw_data
bgpd: Initialize bgp_notify.raw_data before passing to bgp_notify_rec…
2021-02-01 07:42:21 -05:00
Donatas Abraitis
01c949cd5a
Merge pull request #7969 from donaldsharp/more_flags
More flags
2021-02-01 09:12:09 +02:00
Donatas Abraitis
c051ad7054 bgpd: Initialize bgp_notify.raw_data before passing to bgp_notify_receive()
```
2523558-==2523558==
2523558-==2523558== Conditional jump or move depends on uninitialised value(s)
2523558:==2523558==    at 0x47F242: bgp_notify_admin_message (bgp_debug.c:505)
2523558-==2523558==    by 0x47F242: bgp_notify_print (bgp_debug.c:534)
2523558-==2523558==    by 0x4BA9BC: bgp_notify_receive (bgp_packet.c:1905)
2523558-==2523558==    by 0x4BA9BC: bgp_process_packet (bgp_packet.c:2602)
2523558-==2523558==    by 0x4904B7E: thread_call (thread.c:1681)
2523558-==2523558==    by 0x48CAA27: frr_run (libfrr.c:1126)
2523558-==2523558==    by 0x474B1A: main (bgp_main.c:540)
2523558-==2523558==  Uninitialised value was created by a stack allocation
2523558:==2523558==    at 0x4BA33D: bgp_process_packet (bgp_packet.c:2529)
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-31 16:20:36 +02:00
Donatas Abraitis
0f0d30c47b
Merge pull request #7984 from donaldsharp/hidden_command
bgpd: Remove hidden `neighbor X route-map Y <in|out>` command
2021-01-31 11:05:35 +02:00
Donatas Abraitis
127949a9af
Merge pull request #7970 from volta-networks/fix_snmp_topotest_test_oid_walk
tests: update snmp topotest api test_oid_walk
2021-01-30 22:24:11 +02:00
Donald Sharp
4c3e9f072a bgpd: Remove hidden neighbor X route-map Y <in|out> command
This command was put in place to allow upgrades for the
neighbor command from the BGP_NODE and have it put
into the ipv4 uni node instead.  Since this
utterly kills the yang conversion.  I believe we need
to remove this.  Since people upgrading will just loose
the route-map applicatoin( if they are using such an old
config ) and RFC 8212 will come into play.  They'll figure
it out pretty fast.

Fixes: #7983
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-29 21:30:27 -05:00
Donald Sharp
df2a41a9bf bgpd: Add bgp_nexthop_dump_bnc_change_flags function
Allow us to read what the change flags are instead of having
to look them up.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-29 07:54:58 -05:00
Donald Sharp
987a720a11 bgpd: Add bgp_nexthop_dump_bnc_flags
Add a function that allows us to see a string version of the
bnc->flags bit fields.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-29 07:54:58 -05:00
Rafael Zalamena
ecf497baed
Merge pull request #7953 from mjstapp/fix_more_ntoa
libs, ospfd: remove inet_ntoa
2021-01-29 08:01:03 -03:00
Donatas Abraitis
c600e8a52c
Merge pull request #7960 from kishorekunal01/bgp_fix_allowas_in
BGP: "no neighbor <peer-group> allowas-in" is not resetting the peer-group member allowas_in[afi][safi].
2021-01-29 09:17:26 +02:00
Donatas Abraitis
67725010ff
Merge pull request #7974 from donaldsharp/more_if_zero
More if zero
2021-01-29 09:14:49 +02:00
Karen Schoener
d34cf8a75b tests: update snmp topotest api test_oid_walk
Update snmp topotest api test_oid_walk to validate a subset
of rows in a mib walk.

Signed-off-by: Karen Schoener <karen@voltanet.io>
2021-01-28 19:05:42 -05:00
Donald Sharp
79ea62839f
Merge pull request #7955 from volta-networks/fix_isis_lsp_bit_topotest
tests: temporarily remove isis-lsp-bit-topo1 topotest
2021-01-28 16:58:27 -05:00
Donald Sharp
1e1d6a8a22
Merge pull request #7967 from ton31337/feature/show_bgp_summary_wide
bgpd: Add `show bgp summary wide` command
2021-01-28 16:00:58 -05:00
Donald Sharp
0c6ac261df
Merge pull request #7968 from ton31337/feature/doc_ebgp_reset_session
doc: ebgp-requires-policy requires manuall session clearing
2021-01-28 15:41:39 -05:00
Donald Sharp
153bdb3d03 ospfd: ospf_nbr_nbma_lookup_next always returns NULL
The calling function of ospf_nbr_nbma_lookup_next calls
this function and then immediately returns when it
gets the NULL.  Just cleanup a bit more code.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 14:56:11 -05:00
Donald Sharp
d3e3a408d5 pbrd: Remove #if 0 code
I am not even sure what the goal of this code was in any
way shape fashion or form.  But since it's pbr_nht.c
I as the original author should know... But I don't.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 14:04:59 -05:00
Donald Sharp
a2157a13a5 lib: Remove #if 0 code
Just some more dead code that has been sitting unused for
a very long time.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 14:04:02 -05:00
Donald Sharp
054ffe7a8e eigrpd: Remove #if 0 dead code
There is some dead code in eigrpd

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 14:00:45 -05:00
Donald Sharp
74dd7f6da6 bfdd: Remove #if 0
We do have a bunch of old code that is never used.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:58:34 -05:00
Donald Sharp
cadc15cfe2 zebra: Remove #if 0 code
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:57:49 -05:00
Donald Sharp
62e0464d73 bgpd: Remove #if 0 code
Remove all dead #if 0 code from bgpd.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:57:49 -05:00
Donald Sharp
9a290f679a isisd: Remove #if 0 code
Looks like the #if 0 code in this place was for ESI support
on solaris.  We do not support solaris anymore.  So let's
remove with prejudice.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:45:44 -05:00
Donald Sharp
56b7d6bfe9 ripngd: Remove #if 0 code
Remove some more dead code.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:43:46 -05:00
Donald Sharp
94457bc6a8 ripd: #if 0 we know what you are up to.
rip, ripped out the #if 0 code.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:40:05 -05:00
Donald Sharp
af1cc4c84c pimd: Remove #if 0 code from system
Old dead code.
Like a log
jamming your build system

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:37:53 -05:00
lynne
d61731fbe3 tests: temporarily remove isis-lsp-bits-topo1 topotest
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2021-01-28 13:37:52 -05:00
Donald Sharp
8b36526475 ospf6d: Remove #if 0 code that has not been used in a long time
The earliest that some of this code is 2018.  There is not
much point in keeping this code around.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:34:55 -05:00
Donald Sharp
59293b8e70 ospfd: Remove #if 0 code
The #if 0 code in ospfd, has not been compiled since at least
2012.  If we are at least 9 years old at this point with no effort
to use or save, we should just get rid of it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-28 13:21:12 -05:00
Kishore Kunal
e92882c60e bgpd: Removing "neighbor <peer-group> allowas-in"
Unconfig not resetting the peer-group member allowas_in[afi][safi]
This is causing remote route to be accept.

Signed-off-by: Kishore Kunal <kishorekunal01@broadcom.com>
2021-01-28 16:54:35 +00:00
Donatas Abraitis
b3cbe765b8 doc: ebgp-requires-policy requires manuall session clearing
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-28 17:15:02 +02:00
Donald Sharp
e6d17d2fa9
Merge pull request #7933 from deastoe/show-route-header-sep
lib: restore blank line after show route header
2021-01-28 09:55:52 -05:00
Donatas Abraitis
749d0f27ab bgpd: Show NoNeg instead of bad parsing show bgp summary if disabled
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-28 16:36:15 +02:00
Donatas Abraitis
28b25b6b5e doc: Add show bgp summary wide short description
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-28 16:36:15 +02:00
Donatas Abraitis
c854765f97 bgpd: Include local AS for JSON output in show bgp summary json cmd
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-28 16:36:14 +02:00
Donatas Abraitis
85eeb02915 bgpd: Add show bgp summary wide command
Add LocalAS into wide output and extend Desc to 64 chars instead of 20.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-01-28 16:35:16 +02:00
Rafael Zalamena
074286edcb doc: add information about network namespaces
Let user know that there are standardized ways to use network namespaces.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-01-28 08:47:26 -03:00
Donatas Abraitis
04e5b8525a
Merge pull request #7952 from kuldeepkash/documentation
doc: topotests-markers typo error
2021-01-28 10:34:55 +02:00
Donatas Abraitis
218c799eae
Merge pull request #7433 from sudhanshukumar22/bgp-aggregate-member-issue
bgpd:'bgpd' core generated on Leaf device with system-test config
2021-01-28 10:34:22 +02:00
Donald Sharp
776a2f8666 *: Update version string
Update the version string to reflect work towards next release

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-01-27 15:32:52 -05:00