Christian Franke
490a6fc716
isisd: don't add deprecated bfd command
2018-10-09 17:59:46 +02:00
Christian Franke
a5eba4e9a5
isisd: Track BFD state and take down adjacency on failure
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:34 +02:00
Christian Franke
2815f817e5
isisd: Add debugging for BFD
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:23 +02:00
Christian Franke
ab880eaf30
isisd: Implement BFD replay function
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:08:18 +02:00
Christian Franke
20a42f0194
isisd: Register/deregister BFD peers for adjacencies
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:07:51 +02:00
Christian Franke
3015e3d15e
isisd: Write BFD config
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:07:45 +02:00
Christian Franke
d56afe53aa
isisd: Add a hook when writing interface config
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:31 +02:00
Christian Franke
215eccb0b8
isisd: Add BFD configuration commands
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:30 +02:00
Christian Franke
a5b5e946ce
isisd: Replace isis_event_adjacency_state_change with a hook
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:28 +02:00
Christian Franke
52df822874
isisd: Register as BFD client
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:26 +02:00
Christian Franke
ad10378940
isisd: Add forward declaration of struct isis_route_info
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:05:22 +02:00
Christian Franke
a0d5840bb7
zebra_ptm: Add IS-IS and OpenFabric as protocols supporting BFD
...
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:04:27 +02:00
Christian Franke
4943f243b5
zebra_ptm: Introduce IS_BFD_ENABLED_PROTOCOL macro
...
Unify the check if a client supports BFD into one location.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-05 14:04:15 +02:00
Quentin Young
78230371e9
Merge pull request #3098 from opensourcerouting/watchfrr-delay
...
tools/frr + watchfrr spring cleaning (southern hemisphere)
2018-10-04 15:04:56 -04:00
Rafael Zalamena
416f79bf51
Merge pull request #3126 from pacovn/Coverity_1424529_null_check
...
isisd: null check (Coverity 1424529)
2018-10-04 10:37:06 -03:00
Donald Sharp
15007d0053
Merge pull request #3127 from pacovn/Coverity_1472236_Improper_use_of_negative_value
...
zebra: netlink socket check (Coverity 1472236)
2018-10-04 09:26:33 -04:00
David Lamparter
416784e810
Merge pull request #3128 from donaldsharp/cpp_notice_build_failure
...
lib: Include compiler.h as early as is possible in the build
2018-10-04 11:09:48 +02:00
Quentin Young
56f67d6870
Merge pull request #3087 from opensourcerouting/bfd-memleak
...
bfdd: fix memory leak and echo-mode start
2018-10-03 18:43:34 -04:00
Lou Berger
139221f250
Merge pull request #3043 from qlyoung/doc-bgpd-multiple-ass
...
Doc bgpd multiple ASes
2018-10-03 18:03:48 -04:00
Rafael Zalamena
c4345fbf71
lib: refactor thread_execute
...
Don't allocate threads in the stack, but use the standardized
`thread_get` and `thread_add_unused` to avoid creating corner cases in
the thread API.
This fixes a thread mutex memory leak in FreeBSD.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-03 16:32:11 -03:00
Rafael Zalamena
6655966d2c
lib: fix a memory leak in FreeBSD
...
Two important changes:
* Centralize the thread teardown procedure;
* Save and restore thread mutex context to avoid losing the memory
pointer;
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-03 16:32:11 -03:00
F. Aragon
c9f7d10b8a
zebra: netlink socket check (Coverity 1472236)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-10-03 20:28:01 +02:00
Donald Sharp
728806e6f8
lib: Include compiler.h as early as is possible in the build
...
The compiler.h header provides us with some useful macro's
that we are using in the system. We do not know exactly
where the CPP_NOTICE and CPP_WARN macros are used but
they can move around. Place this header early in the
build then.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-03 13:41:21 -04:00
F. Aragon
7968405d87
isisd: null check (Coverity 1424529)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-10-03 16:38:49 +02:00
Quentin Young
195c746165
doc: embellish bgp view docs
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-10-02 20:14:14 +00:00
Quentin Young
edde3ce9c2
doc: add extra information on bgp views and vrfs
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-10-02 20:14:14 +00:00
Quentin Young
c8a5e5e190
doc: clarify documentation on BGP multiple AS
...
Documentation on how to use multiple autonomous systems was inaccurate
and a bit scattered. Clarify usage of VRFs with multiple autonomous
systems, how to configure them, and their distinction from views. Also
moves a block on L3VPN VRFs out of the 'Basic Concepts' section.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-10-02 20:14:14 +00:00
Lou Berger
0a940183d3
Merge pull request #3004 from donaldsharp/other_peer
...
bgpd: Try to notice when configuration changes during startup
2018-10-02 11:40:09 -04:00
Martin Winter
ad6707b564
Merge pull request #3108 from dmbaturin/master
...
Add a script for building a Debian package in one step.
2018-10-02 16:58:12 +02:00
David Lamparter
f712c6b369
Merge pull request #3113 from donaldsharp/uninited_value
...
bgpd: prevent uninited variable from being used.
2018-10-02 16:17:10 +02:00
Lou Berger
e47e908c0d
Merge pull request #3120 from opensourcerouting/remove-list-delete
...
lib: remove deprecated list_delete()/list_free()
2018-10-02 10:03:46 -04:00
Donald Sharp
11ebf4ed88
bgpd: prevent uninited variable from being used.
...
Valgrind reports that temp could be used uninitialized
sometimes.
Signed-off-by: Donald sharp <sharpd@cumulusnetworks.com>
2018-10-02 08:23:11 -04:00
Lou Berger
e239241534
Merge pull request #3116 from opensourcerouting/libfrr-exec
...
lib: print version information in libfrr.so
2018-10-02 07:03:08 -04:00
David Lamparter
442fc69786
tools/frr: remove "watchfrr.started" hack
...
This is no longer neccessary since start-stop-daemon will block until
watchfrr's launch parent has exited.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-02 12:27:51 +02:00
David Lamparter
0a7c7856e3
watchfrr, lib: cleanup & delay detaching
...
This cleans up watchfrr to be more "normal" like the other daemons in
terms of what it does in main(), i.e. using the full frr_*() call set.
Also, this changes the startup behaviour on watchfrr to stay attached on
the daemon's parent process until startup is really complete. This
should allow removing the "watchfrr.started" hack at some point.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-02 12:27:47 +02:00
David Lamparter
11c98954c4
Merge pull request #3117 from pacovn/Coverity_1460436_dead_code
...
eigrpd: dead code (Coverity 1460436)
2018-10-02 12:24:44 +02:00
David Lamparter
9b28b6f8b3
Merge pull request #3118 from pacovn/Coverity_1399231_dead_code
...
ospf6d: dead code (Coverity 1399231)
2018-10-02 12:13:43 +02:00
David Lamparter
6a154c8812
*: list_delete_and_null() -> list_delete()
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-02 11:40:52 +02:00
David Lamparter
b08bb12b9b
lib: remove deprecated list_delete()/list_free()
...
Deprecation time has passed.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-02 11:40:48 +02:00
David Lamparter
a762cf08c0
Merge pull request #3102 from ton31337/feature/match_blackhole_nexthops
...
bgpd: Match routes by type under route-maps
2018-10-02 11:29:59 +02:00
F. Aragon
907f42e634
ospf6d: dead code (Coverity 1399231)
...
The dead code has been disabled with '#if 0', in a similar way to other
disabled logs in the same function.
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-10-02 10:54:50 +02:00
F. Aragon
11b88ecf7e
eigrpd: dead code (Coverity 1460436)
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-10-02 10:46:20 +02:00
David Lamparter
42efb0d43b
lib: print version information in libfrr.so
...
This makes libfrr.so executable to print its version info. This is
useful if you need to check your libfrr.so matches your daemons.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-02 10:26:25 +02:00
Donatas Abraitis
61ad901e57
bgpd: Match routes by type under route-maps
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2018-10-02 10:57:45 +03:00
Daniil Baturin
836ad9fb4e
tools: add a script for building a Debian package in one step.
...
The script simplifies the relatively lengthy procedure.
It should be invoked from the top level source directory, for example:
./tools/build-debian-package.sh
Signed-off-by: Daniil Baturin <daniil@baturin.org>
2018-10-01 20:44:01 +02:00
Lou Berger
024233b6a1
Merge pull request #3097 from opensourcerouting/static-linking
...
build: add --enable-static-bin option
2018-10-01 13:29:18 -04:00
Rafael Zalamena
744f824a73
bfdd: allow timer deactivation on shutdown
...
Peers being shutdown were keeping their timers, so move the cancel code
before the shutdown check.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-01 14:15:25 -03:00
Rafael Zalamena
451eb5a2f8
bfdd: disable echo on neighbor request
...
Don't send echo packets when the neighbor configures echo-interval of 0
(e.g. disabled).
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-01 14:15:25 -03:00
Quentin Young
d236e76b37
Merge pull request #3105 from opensourcerouting/fix/sphinx-stamp
...
doc: Use `mv -f` in Makefile
2018-10-01 12:35:45 -04:00
David Lamparter
6243a7b569
ospfd: fix symbol collision
...
debug_init() was recently added in libfrr, which is now causing a build
error with static linking.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-01 18:18:42 +02:00