proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-10-31 14:57:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
12,858 Commits 4 Branches 191 Tags 125 MiB
2b5773b248
Commit Graph

12858 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
paco
d1f92e454c
lib: null check (Coverity 1399277) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:35:38 +02:00
Donald Sharp
38e72ffa9a sharpd: Does not need any special priv's 
Remove the unnecessary privs that we were requesting
for the sharp daemon.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 11:28:16 -04:00
paco
d87ff2ddf4
bgpd: dead code (Coverity 1399238) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:22:55 +02:00
Donald Sharp
8e04538cae lib: Fix privs when using HAVE_CAPABILITIES 
If your daemon does not need any special privileges
and you are compiling with HAVE_CAPABILIES, the
zprivs->change pointer will end up NULL due
to the way zprivs_caps_init.  So as a check
let's add a NULL check for zprivs->change
and set it to a function that will do nothing.

This change prevents a crash if you raise privileges
when your daemon needs no special privileges.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 11:22:51 -04:00
Renato Westphal
aa74131957
Merge pull request #2510 from donaldsharp/extended_ack 
zebra: Add extended Ack error parsing to FRR
 2018-06-21 12:16:53 -03:00
paco
0cfbff749e
zebra: flow control (Coverity 1462467 1465497) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:09:04 +02:00
Ruben Kerkhof
1a629db7a1 redhat: cleanup %pre snippet a bit 
Based on https://fedoraproject.org/wiki/Packaging:UsersAndGroups

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
0e3daa4df6 redhat: add option to enable Cumulus extensions 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
b8b18c064b redhat: quote %name macro 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
4f20eab14c redhat: replace hardcoded path with variable 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
4aa7422e82 redhat: remove some superflous %attr calls 
These are the default

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
bc1dc4fe04 redhat: remove macro from changelog 
rpmlint warns about this:
macro-in-%changelog %{version}

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
95c16f4c20 redhat: add some newlines between sections 
Makes the spec slightly easier to read

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
1eca28ffdc redhat: more indentation 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
ff00e18d2d redhat: sort options 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
1dc5a0dc3c redhat: quote a few macros 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
d1ef2aafc8 redhat: unversioned libs belong in -devel package 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:41 +02:00
Ruben Kerkhof
5c3ad1d46a redhat: remove support for static builds 
This just doesn't work as RHEL doesn't ship static libs for the
dependencies.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:05:37 +02:00
Ruben Kerkhof
7bd661a2b5 redhat: remove superflous defattr lines 
They are the default since RHEL5:
https://pagure.io/packaging-committee/issue/77

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
35a1688ab9 redhat: remove obsolete %clean section 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
e0c875f1b2 redhat: remove obsolete BuildRoot tag 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
5ebf96721a redhat: use one BuildRequires per line 
Makes for easier diffing

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
7eec5b4c38 redhat: remove BuildRequires for patch 
Nothing seems to need it

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
ec59a1559c redhat: don't Requires initscript on systemd based distros 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
772d418a8b redhat: remove superfluous Requires for json-c 
json-c-devel is already a BuildRequires, and rpm will add the Requires
itself.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
5f371d0bdf redhat: indent some stuff in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
98a2aecb7b redhat: replace hardcoded directory 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
515a8ee8f5 redhat: use 'service' command to restart frr 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
9b9796466b redhat: replace /etc/ with _sysconfdir where we can 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
0bb6861140 redhat: stop overriding _localstatedir 
It is defined by rpm and points at /var

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
e9956ac7e0 redhat: remove some defaults from configure options 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
931e1d6824 redhat: stop overriding _sysconfdir 
This macro is defined by rpm and points at /etc.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
Ruben Kerkhof
9f892cc56c redhat: remove enable-poll option from specfile 
It was removed from configure.ac in 16764760

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-21 17:03:29 +02:00
paco
e8a3a0a030
bgpd: null check (Coverity 23106) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 15:58:51 +02:00
paco
7edb6aa583
spf6d: fix use after free (2) (Coverity 1221459) 
Previous fix was incomplete, as calling ospf6_lsa_unlock() frees 'req' but
it does not put it to zero, so it was called ospf6_lsdb_remove() afterwards
even being 'req' already freed.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 15:18:13 +02:00
Donald Sharp
29516b7cc3 include: add netlink.h to our build system 
For compilation on platforms that do not have the
linux headers installed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 08:07:30 -04:00
Donald Sharp
5d307d5d3a zebra: Add extended Ack error parsing to FRR 
Add code to request and read in extended ack information
to provide a bit more context of what went wrong when
a failure is detected in the kernel.

Example of a failed delete:
Jun 20 21:19:25 robot zebra[11878]: Extended Error: Invalid prefix for given prefix length
Jun 20 21:19:25 robot zebra[11878]: netlink-cmd (NS 0) error: Invalid argument, type=RTM_DELROUTE(25), seq=8, pid=4078403400
Jun 20 21:19:25 robot zebra[11878]: 0:4.3.2.0/24: Route Deletion failure

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 08:07:30 -04:00
paco
0bf75bd5c9
eigrpd: null check (Coverity 1455334 and 4 alike) 
Coverity issues fixed with this commit:

1455334 1455335 1455336 1455337 1455339

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 14:02:33 +02:00
Donald Sharp
eab268594a
Merge pull request #2504 from pacovn/Coverity_23110_Dereference_after_null_check 
ospfd: null check (Coverity 23110)
 2018-06-21 07:30:21 -04:00
Donald Sharp
50f08ff26a
Merge pull request #2507 from pacovn/Coverity_1436344_1451361_Dereference_after_null_check 
bgpd, lib: null check (Coverity 1436344, 1451361)
 2018-06-21 07:29:51 -04:00
Donald Sharp
1cabfbf10e
Merge pull request #2508 from pacovn/Coverity_1470113_Untrusted_array_index_write 
zebra: untrusted array index (Coverity 1470113)
 2018-06-21 07:27:54 -04:00
Donald Sharp
07caaf613a
Merge pull request #2506 from pacovn/Coverity_1221453_1461297_Dereference_after_null_check 
bgpd ospf6d: null check (Coverity 1221453 1461297)
 2018-06-21 07:26:47 -04:00
paco
e59294e2e4
ldpd lib: null check (Coverity 1452287 + 20 alike) 
Coverity issues fixed with this commit:

1452287 1452291 1452307 1452310 1452317 1452321 1452327 1452330 1452331 1452336
1452337 1452340 1452352 1452354 1452358
(originated at ldpd/ldpd_vty_cmds_clippy.c)

1448388 1448390 1448392 1448397 1448404 1448408
(originated at lib/plist_clippy.c)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 12:31:57 +02:00
paco
a2b6e694b1
bgpd isisd ldpd lib ospfd pimd: redundancy (infer) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 22:25:28 +02:00
paco
9b606d6c3d
tools: return check (2) (Coverity 1143220) 
Previous correction (657f9948ed) was incomplete.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 21:26:38 +02:00
paco
7f61ea7bd4
zebra: untrusted array index (Coverity 1470113) 
This is a correction over 32ac96b2ba, so
removing the forced string null termination doesn't involve a worse situation
than before (the underflow check should protect for the case of receiving
an incomplete buffer, which would be the cause of non-zero terminated string)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 19:25:06 +02:00
paco
fa3016309b
bgpd, lib: null check (Coverity 1436344, 1451361) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 19:14:01 +02:00
paco
cac84a1611
bgpd ospf6d: null check (Coverity 1221453 1461297) 2018-06-20 18:57:16 +02:00
paco
ed35fc0593
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-20 18:35:20 +02:00
Donald Sharp
76cd18c9dd
Merge pull request #2498 from pacovn/Coverity_1470098_Logically_dead_code 
bgpd: json output fix (Coverity 1470098)
 2018-06-20 11:39:07 -04:00