F. Aragon
2b5773b248
build: add -Wshadow to the dev build
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-17 18:37:04 +02:00
Donald Sharp
6efca3442f
Merge pull request #3007 from pacovn/static_analysis__shadow_variables2
...
lib vtysh zebra: variable shadowing fixes
2018-09-13 08:38:32 -04:00
Donald Sharp
fc6eb7d827
Merge pull request #3006 from pacovn/static_analysis__shadow_variables1
...
bgpd isisd ospf6d ospfd: variable shadowing fixes
2018-09-13 08:37:22 -04:00
Donald Sharp
38ee5e636d
Merge pull request #3009 from pacovn/static_analysis__shadow_variables3
...
pimd ripd ripngd: variable shadowing fixes
2018-09-13 08:35:47 -04:00
Donald Sharp
f2e946e681
Merge pull request #3013 from pacovn/static_analysis__conditional_omitted_operand1
...
nhrpd: missing operand added
2018-09-13 08:34:31 -04:00
F. Aragon
57b0ac508e
nhrpd: missing operand added
...
Detected using -Wgnu-conditional-omitted-operand
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-13 12:05:20 +02:00
David Lamparter
029270d5f4
Merge branch 'warnings'
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-12 22:00:04 +02:00
David Lamparter
e991eff5b5
Merge remote-tracking branch 'frr/master' into warnings
...
Conflicts:
zebra/if_ioctl_solaris.c
zebra/rtread_getmsg.c
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-12 21:58:39 +02:00
F. Aragon
f7813c7c7f
bgpd isisd ospf6d ospfd: variable shadowing fixes
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-12 16:44:36 +02:00
F. Aragon
dc7204b775
pimd ripd ripngd: variable shadowing fixes
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-12 12:55:31 +02:00
David Lamparter
7aab2afbad
Merge pull request #3005 from patrasar/indentation_warnings
...
pimd: fix indentation warnings
2018-09-12 12:39:26 +02:00
F. Aragon
c683bd446c
lib vtysh zebra: variable shadowing fixes
...
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-12 12:27:38 +02:00
Sarita Patra
eccdcfe2b6
pimd: fix indentation warnings
...
Signed-off-by: Sarita Patra <saritap@vmware.com>
2018-09-11 22:00:15 -07:00
Russ White
88f47ef365
Merge pull request #2944 from thbtcllt/master
...
fix zebra crash when a vrf interface changes with netns implementation for vrf
2018-09-11 11:33:27 -04:00
David Lamparter
5297438f59
Merge branch 'pr2983'
2018-09-11 16:56:30 +02:00
David Lamparter
371bfb5c3e
lib: whitespace/spelling fix
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-11 16:55:56 +02:00
Donald Sharp
4328a933aa
Merge pull request #2985 from patrasar/Fix_1636
...
pimd: create a new command "ip pim" configuring pim sm
2018-09-11 09:16:24 -04:00
root
2f5e937c49
pimd: create a new command "ip pim" configuring pim sm
...
A new command "ip pim" is created to configure pim sm on an
interface, which replaces the existing commands "ip pim sm"
and "ip pim ssm" and make "ip pim sm" and "ip pim ssm" as
hidden commands. The command "ip multicast-routing" is removed
since it is already enabled on FRR by default.
Signed-off-by: Sarita Patra saritap@vmware.com
2018-09-10 22:22:14 -07:00
Martin Winter
c849095aee
Merge pull request #3001 from donaldsharp/bgp_origin_honor
...
bgpd: Honor origin change in bgp aggregates
2018-09-11 12:18:39 +11:00
David Lamparter
99f9c2771c
Merge pull request #2999 from donaldsharp/consistent
...
doc: Fixup to use consistent frrvty group name
2018-09-10 19:51:05 +02:00
David Lamparter
d6dbfb2c79
Merge pull request #2979 from qlyoung/improve-readme
...
Improve readme
2018-09-10 19:50:52 +02:00
Quentin Young
d85cb6b6a6
frr: add README.md to EXTRA_DIST
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-10 15:30:22 +00:00
Quentin Young
f20aafeec0
frr: improve README
...
Friendly READMEs are all the rage!
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-10 15:30:22 +00:00
Quentin Young
d88f11441a
frr: remove stale files, allow non-GNU Automake
...
* Add 'foreign' option to allow Automake to ignore missing GNU standard
files
* Remove AUTHORS
* Remove NEWS
* Remove ChangeLog
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-09-10 15:30:22 +00:00
Donald Sharp
29f7d0232e
bgpd: Honor origin change in bgp aggregates
...
When the origin changed we must honor and update the aggregate
to the peer. This code adds a bit of code to the bgp_aggregate_info_same
code to see if the origin has changed and to indicate that it has.
Fixes : #2993
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-10 10:19:03 -04:00
Donald Sharp
2f62815fed
doc: Fixup to use consistent frrvty group name
...
In some places we were using `frrvt` instead of `frrvty`. Make it consistent
with every other place and use frrvty.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-09-10 08:46:50 -04:00
Donald Sharp
eac04cfd59
Merge pull request #2977 from opensourcerouting/doc-fix
...
build: fix not building docs w/o sphinx
2018-09-09 14:52:38 -04:00
Donald Sharp
5381b930b3
Merge pull request #2965 from opensourcerouting/buildfoo-20180904
...
more build fixes & warning-free build
2018-09-09 14:11:10 -04:00
David Lamparter
a214288c50
build: move SPHINXBUILD= to configure in rpm build
...
Need to pass this on configure now to work properly.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 20:01:08 +02:00
David Lamparter
f4f2f2ccac
build: fix not building docs w/o sphinx
...
Can't build manpages without sphinx-build, oops...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 20:01:08 +02:00
Donald Sharp
55e6c1329f
Merge pull request #2862 from opensourcerouting/non-recursive
...
final non-recursive make
2018-09-09 13:51:58 -04:00
David Lamparter
879fbc3ec8
Merge pull request #2995 from wwijkander/docpatch
...
doc: Update RPM building instructions
2018-09-09 13:38:12 +02:00
Donald Sharp
4bb7d4482d
Merge pull request #2994 from opensourcerouting/sa-warnings
...
fix remaining SA warnings
2018-09-08 21:04:54 -04:00
David Lamparter
7b34167d7d
lib: early-include "config.h" in flex lexers
...
This is neccessary to get _FILE_OFFSET_BITS right.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 01:16:25 +02:00
David Lamparter
01db90cd83
ospf6d: remove extra struct in ospf6_lsa_handler
...
This serves no other purpose than to generate stupid warnings for
overwritten initializers on old gcc versions.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 01:16:25 +02:00
David Lamparter
3009394b3c
*: fix some random warnings
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 01:16:25 +02:00
David Lamparter
e9d938b82a
lib: make pthread_set[_]name_np test OS agnostic
...
FreeBSD supports pthread_set_name_np() too. Also, pthread_set_name_np()
returns void. And NetBSD has pthread_setname_np() with an extra arg...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 01:16:25 +02:00
David Lamparter
324be174d7
build: check {malloc,pthread}_np.h for *BSD
...
FreeBSD has malloc_usable_size() in malloc_np.h
OpenBSD has pthread_set_name_np() in pthread_np.h
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-09 01:16:25 +02:00
Wilhelm Wijkander
a188423597
Update RPM building instructions
2018-09-09 00:27:57 +02:00
David Lamparter
82f9e9b358
build: move RFPLDADD to bgpd/rfp-example/librfp
...
This makes it slightly easier to replace the stub RFP code with an
external implementation.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
0718b5624c
build: use _POSIX_C_SOURCE
...
Need this to get CMSG_SPACE/CMSG_LEN on Solaris.
Also, AC_GNU_SOURCE is deprecated, AC_USE_SYSTEM_EXTENSIONS does that.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
086aec2ad4
vtysh: make RPKI node non-conditional
...
Whether or not RPKI is enabled during build shouldn't really influence
vtysh; the user can always manually install bgpd_rpki.so later and it
should work. This also means that the behaviour of "RPKI module not
loaded" is consistent regardless of whether it was a compile-time or
runtime decision.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
ae9eebcaeb
*: fix some solaris warnings
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
e7c25325cc
*: cleanup .gitignore files
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
b45ac5f5c6
*: fix config.h/zebra.h include order
...
config.h (or, transitively, zebra.h) must be the first include file
listed for autoconf things like _GNU_SOURCE and _POSIX_C_SOURCE to work
correctly.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
dbac691da6
build: fix & clean up *SAN flags
...
ASAN/MSAN/TSAN flags need to be in CFLAGS and LDFLAGS; the latter links
the correct compiler-dependent library. Also, the configure switch was
broken (--disable-... would enable the sanitizer.)
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
1847924159
build: make pkgconfig configure output useful
...
The variable name is not exactly the most helpful thing there.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
2b2f275ee2
build: clean up protobuf build integration
...
We were linking all libs and binaries against libprotobuf-c if the
option was enabled... that makes no sense at all.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
4007e3adf1
build: use -export-dynamic
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:42 +02:00
David Lamparter
b37ccace1e
tests: properly locate files in builddir
...
test_cli.refout is written by configure into the build directory, thus
we need a little special glue to find it correctly.
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-09-08 21:30:19 +02:00