Quentin Young
247dcce2b5
*: fix source file headers & includes for errcodes
...
* Use the correct license header
* Stop headers from including themselves
* Use uniform relative include conventions
* Ensure that sources include what they use
* Turn off clang-format around struct array blocks
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Chirag Shah
313d7993a3
ospfd: zlog_ferr facility
...
Ticket:CM-21333
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b87478cb3e
lib: Convert zlog_err for clippy build
...
The clippy code does not need to log the error messages
as errors as that it is only run as part of the build
itself and as long as we see the notifications we are good.
So convert zlog_err to zlog_notice so that we do not think
we have any zlog_err's in lib anymore
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
30b0312cc1
lib: Remove unnecessary zebra.h include
...
lib_errors.c does not need to include zebra.h, so remove
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
518e377f39
ripd: Add RIP_ERR_XXX to move from zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b647dc2aec
watchfrr: Add WATCHFRR_ERR_XXX for zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
0f41a2628d
lib: Fix Spelling mistake
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
8b0a80f120
eigrpd: Add EIGRP_ERR_XXX for zlog_err to zlog_ferr
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
aed0701124
nhrpd: Add NHRP_ERR_XXXX for zlog_err to zlog_ferr conversion
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
4f3be6672f
bgpd: Add some FLowspec specific Error Codes.
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
02705213b1
bgpd: Convert to using LIB_ERR_XXX where possible
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
43e52561b4
zebra, lib: error references for zebra
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b72002107f
isisd: Cleanup compile issue
...
cleanup compile with missnamed enum usage.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
54ece69899
isisd: Add isis_errors and generate custom Error Codes
...
Generate appropriate error codes for ISIS.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
38937bd540
isisd: Convert to use LIB_ERR_XXX
...
Where an obvious choice could be made about converting
to a LIB_ERR_XXX function do so.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
e33b116cdf
babeld: Convert all zlog_err to zlog_ferr and add appropriate info
...
Convert babeld to use zlog_ferr and add appropriate BABEL_ERR_XXX
information.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
f135ba5272
babeld: Add BABEL_ERR_XXX error messages.
...
Add some BABEL_ERR_XXX error messages and convert over to using
zlog_ferr instead of zlog_err.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
d9ff430273
pimd: Add pim_errors and define some pim specific errors
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
def31c1305
bgpd: Cleanup initialization of bgp_errors.c
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Don Slice
14454c9fdd
bgpd: implement zlog_ferr facility for enhance error messages in bgp
...
Signed-off-by: Don Slice <dslice@cumulusnetworks.com<
2018-08-14 20:02:05 +00:00
Donald Sharp
1e40409931
ldpd: Convert to using LIB_ERR_XXX and zlog_ferr
...
convert ldpd over to using zlog_ferr and LIB_ERR_XXX
where appropriate.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
6ae7ed45ff
eigrpd: Convert to use LIB_ERR_XXX for zlog_err
...
Convert, where appropriate, to using LIB_ERR_XXX for zlog_ferr
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
ad9921dbd8
lib: Update error ranges to include all daemons
...
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
3613d89844
pimd: Convert over to use LIB_ERR_XXX for zlog_err
...
Convert, where appropriate, the zlog_err functions to zlog_ferr
for the LIB_ERR_XXX enums
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
7f9a4fd701
ripngd: Convert over to using LIB_ERR_XXXX for zlog_ferr
...
Convert over those zlog_err functions to zlog_ferr that
are appropriate for the LIB_ERR_XXX.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
77cbe4a1b3
ripd: Convert zlog_err to zlog_ferr for LIB_ERR_XXX
...
For those errors that can be traced to LIB_ERR_XXX
convert to using those in ripd.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
4ba03be5d3
ospf6d: Update OSPFv3 to use new zlog_ferr
...
Update OSPFv3 to use the new zlog_ferr messages
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
8d619fba08
lib: Cleanup some missed LIB_ERR_SYSTEM_CALL
...
libfrr.c had some detection for system call issues.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
357743576d
lib: Add LIB_ERR_ZMQ
...
Add new error event for when we detect an issue within
the ZMQ subsystem.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
472878dc0f
lib: Add LIB_ERR_DEVELOPMENT
...
Sometimes a error state is detected when we have added
new code to FRR, but not updated all the places that
we should have. Consider this a developmental escape
that needs to be fixed.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
674c3ca8a8
lib: Add LIB_ERR_NS to error subsystem
...
Add additional information about NameSpace errors that
may happen.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
4d43f68aeb
lib, zebra: Add LIB_ERR_INTERFACE
...
Add a error type that allows us to track bad interface states.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
174482ef37
bgpd, lib, zebra: Convert LIB_ERR_PRIVILEGES
...
For all the places we zlog_err about raising/lowering privileges, use
zlog_ferr.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
220d736886
lib: Add LIB_ERR_SNMP
...
Add code to indicate a SNMP error of some sort that needs to be
handled and addressed.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
ab99c8e2b8
lib: Add LIB_ERR_VTY
...
Add a error code for when the vty subsystem detects
an error.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
481bc15ffc
lib: Add LIB_ERR_SYSTEM_CALL and convert VRF_SOCKET to SOCKET
...
Add a new error code LIB_ERR_SYSTEM_CALL to the ferr subsystem.
Additionally convert LIB_ERR_VRF_SOCKET to a more generic
LIB_ERR_SOCKET.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
3ec8b5b898
lib: When logging commands do not use zlog_err
...
When we are logging a commands via the `log commands`
cli, use zlog_notice instead of zlog_err, since that
this is not an actual error situation.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.
2018-08-14 20:02:05 +00:00
Donald Sharp
1ca3850c88
lib: Convert to zlog_ferr for zclient.c
...
Convert the zclient.c file to use zlog_ferr.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
b66d022e8d
lib, bgpd: Add code to make lib auto create the ferr infrastructure
...
Add code to auto-create the ferr infrastructure as well as add
some initial error handling for vrf.c
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Donald Sharp
9023454067
lib: Allow adding arrays of ferr's
...
Simplify addition of new messages to the system by allow passage of
arrays of data, instead of one at a time.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Quentin Young
7b526b6168
lib: add error reference system
...
* Add zlog_* function to log with a reference code
* Add ability to track reference cards for errors to ferr.[ch]
* Assign some reference code ranges
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-08-14 20:02:05 +00:00
Martin Winter
efd6292eaa
doc: Add missing flowspec.rst to distribution tar file
...
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2018-08-14 20:02:03 +00:00
Pascal Mathis
89e5e9f028
bgpd: Always show CIDR mask when displaying routes
...
Classful networking has been obsolete for ages and there is currently an
inconsistency between `show ip route` and `show bgp`, where the first
one always displays the CIDR mask while the second one hides classful
network masks.
This commit adjusts the behavior of `show bgp` to always show the CIDR
mask for a route, even when it is classful.
Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-08-14 19:40:42 +02:00
Quentin Young
94cb1f61a4
Merge pull request #2805 from opensourcerouting/malloc-size
...
lib: track total memory per MTYPE if possible
2018-08-14 11:43:39 -04:00
Don Slice
e504cf3b9a
bgpd: issues with vrf imports when switchd or networking restarted
...
Problem reported that when systemctl restart networking or switchd
performed, not all imported prefixes were successfully restored.
Ticket: CM-21684
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2018-08-14 14:33:56 +00:00
Donald Sharp
6c70521823
Merge pull request #2294 from opensourcerouting/bfd-final
...
bfdd: add BFD support
2018-08-14 08:57:44 -04:00
Donald Sharp
d6853655b5
Merge branch 'master' into bfd-final
2018-08-14 08:16:10 -04:00
Donald Sharp
4354a8052c
Merge pull request #2823 from opensourcerouting/snap-staticd
...
Updates to snap package to support staticd
2018-08-14 07:48:15 -04:00
Donald Sharp
067d5028c1
Merge pull request #2833 from opensourcerouting/assorted-fixes
...
Assorted fixes (pre-northbound)
2018-08-13 20:24:57 -04:00
Donald Sharp
3e93c4e3fe
Merge pull request #2832 from opensourcerouting/rm-debug-leftovers
...
zebra: remove unguarded debugging leftovers
2018-08-13 19:05:36 -04:00