Commit Graph

7437 Commits

Author SHA1 Message Date
Quentin Young
2b4dc78f7f lib: free varhandler on exit
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-02 17:24:01 +00:00
Renato Westphal
f0683d2227 Merge pull request #634 from dwalton76/bgp-ipv6-nexthop-ll-and-global-takeII
bgpd: resolve IPv6 LL and Global nexthop issue
2017-05-31 16:07:57 -03:00
David Lamparter
a1e61a923f Merge pull request #645 from qlyoung/nonblocking-fixup
poll() fixup
2017-05-31 20:47:30 +02:00
Quentin Young
16764760f7 frr: remove --enable-poll
vestigial

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-31 17:40:38 +00:00
Quentin Young
8c88ac94fa lib: make writing end of pipe nonblocking
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-31 17:30:53 +00:00
Daniel Walton
f040db8f7a bgpd: resolve IPv6 LL and Global nexthop issue
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-05-30 15:02:34 +00:00
Quentin Young
a772d6eae6 lib: missed AWAKEN in r/w thread scheduler
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-30 10:27:10 -04:00
Quentin Young
3bf2673b30 lib: allow pthreads to poke poll()
When scheduling a task onto a thread master owned by another pthread, we
need to lock the thread master's mutex. However, if the pthread which
owns that thread master is in poll(), we could be stuck waiting for a
very long time. To solve this, we copy all data poll() needs and unlock
during poll(). To break the target pthread out of poll(), thread_master
has gained a pipe whose reading end is passed into poll(). After an event
that requires immediate action by the target pthread, a byte is written
into the pipe in order to wake it up.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
[DL: split off from select() removal]
2017-05-30 10:27:10 -04:00
Quentin Young
75bcb3558d lib: remove select()
poll() is present on every supported platform and does not have an upper
limit on file descriptors.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
[DL: split off from AWAKEN() change]
2017-05-30 10:27:10 -04:00
Renato Westphal
e22ab7727d Merge pull request #617 from donaldsharp/bgp_nexthop
vtysh: Add back some missing bgp commands
2017-05-30 10:27:38 -03:00
Donald Sharp
8f86e04871 Merge pull request #632 from opensourcerouting/bgpd-show-segfaults
bgpd: fix segfault with some show commands
2017-05-30 09:23:56 -04:00
Donald Sharp
c0619fdb86 Merge pull request #630 from opensourcerouting/zebra-lbl-unicast-issues
Zebra labeled unicast issues
2017-05-30 09:13:04 -04:00
David Lamparter
b7218a7903 Merge pull request #563 from qlyoung/enforce-no-pthread-cancellation
lib: enforce thread_cancel() MT-unsafe invariant
2017-05-30 15:10:52 +02:00
David Lamparter
9ad245006d Merge pull request #605 from dwalton76/show-ip-route-vrf-main
zebra: one "show ip route" to rule them all
2017-05-30 14:55:27 +02:00
David Lamparter
68b2595ec9 Merge pull request #576 from chiragshah6/pim_dev
pimd: pim bfd support
2017-05-30 14:37:08 +02:00
Renato Westphal
be1d6e1530 Merge pull request #623 from dslicenc/cm16512
bgpd: labeled-unicast issue changing from no import-check to using im…
2017-05-30 09:31:40 -03:00
David Lamparter
eed6bb1eec Merge pull request #627 from donaldsharp/ripng
Ripng
2017-05-30 14:29:35 +02:00
David Lamparter
683f0a1b12 Merge pull request #603 from qlyoung/fix-access-packed-member
*: do not take address of packed member
2017-05-30 14:26:03 +02:00
Don Slice
4dfee0ce4e bgpd: labeled-unicast issue changing from no import-check to using import-check
Problem seen in testing import-check using labeled-unicast address-family. When
transitioning from "no bgp network import-check" to "bgp network import-check",
previously installed networks were not removed.  This fix resolves this.

Ticket: CM-16512
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2017-05-30 12:16:01 +00:00
Renato Westphal
8282ecff17 bgpd: fix segfault with some show commands
The following commands were causing bgpd to crash when vpnv4/vpnv6 static
routes are configured:

bgpd aborted: vtysh  -c "show ip bgp view all ipv4 vpn json"
bgpd aborted: vtysh  -c "show ip bgp view all ipv4 vpn"
bgpd aborted: vtysh  -c "show ip bgp view all ipv6 vpn json"
bgpd aborted: vtysh  -c "show ip bgp view all ipv6 vpn"
bgpd aborted: vtysh  -c "show ip bgp vrf all ipv4 vpn json"
bgpd aborted: vtysh  -c "show ip bgp vrf all ipv4 vpn"
bgpd aborted: vtysh  -c "show ip bgp vrf all ipv6 vpn json"
bgpd aborted: vtysh  -c "show ip bgp vrf all ipv6 vpn"
bgpd aborted: vtysh  -c "show bgp view all ipv4 vpn json"
bgpd aborted: vtysh  -c "show bgp view all ipv4 vpn"
bgpd aborted: vtysh  -c "show bgp view all ipv6 vpn json"
bgpd aborted: vtysh  -c "show bgp view all ipv6 vpn"
bgpd aborted: vtysh  -c "show bgp vrf all ipv4 vpn json"
bgpd aborted: vtysh  -c "show bgp vrf all ipv4 vpn"
bgpd aborted: vtysh  -c "show bgp vrf all ipv6 vpn json"
bgpd aborted: vtysh  -c "show bgp vrf all ipv6 vpn"

Problem found with the CLI fuzzer.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-30 08:30:57 -03:00
Renato Westphal
6a2ef37ad0 zebra: fix installation of ipv4 labeled unicast routes
Rearrange the _netlink_route_build*() functions so the labels of the
nexthops are always installed, even for IPv4 routes with IPv6 nexthops.

Fixes Labeled Unicast with BGP Unnumbered.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-29 19:59:48 -03:00
Renato Westphal
4038e8046d zebra: fix processing of labeled ipv6 routes
We're incrementing nh_count twice for the same nexthop.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-05-29 19:58:35 -03:00
Renato Westphal
cf4e348abb Merge pull request #615 from dslicenc/cm16531
zebra: add bgp unnumbered labeled-unicast to zserv
2017-05-29 19:32:38 -03:00
Renato Westphal
8a74a9d1a5 Merge pull request #614 from qlyoung/fix-ospf6-oa-scope
ospf6d: default to dotted quad instead of ret NULL
2017-05-29 17:49:52 -03:00
Renato Westphal
8ae2631740 Merge pull request #625 from donaldsharp/show_zebra
zebra: Fix 64 bit number printf issues
2017-05-29 12:58:21 -03:00
Renato Westphal
977c469f87 Merge pull request #629 from donaldsharp/eigrp_network
eigrpd: Fix network statement
2017-05-29 11:47:41 -03:00
Renato Westphal
c5fd908903 Merge pull request #618 from donaldsharp/hopola
Hopola
2017-05-29 10:21:46 -03:00
Donald Sharp
db215e1f4d eigrpd: Fix network statement
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-29 07:08:52 -04:00
Donald Sharp
8f5f09c8a1 ripngd: Let ripng announce interface turned on for usage.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-27 18:48:41 -04:00
Donald Sharp
d911a12a4e ripngd: Fix missing newlines at end of help strings
Found by visual inspection and some squinting

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-27 18:20:51 -04:00
Donald Sharp
901fda9830 nhrpd: Fix missing include for 'access_list_init' function
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-27 18:18:59 -04:00
Donald Sharp
a1579fd393 zebra: Fix 64 bit number printf issues
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-26 14:06:37 -04:00
Quentin Young
000fe2ca4c bgpd: remove struct capability_orf_entry
virtually unused

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-26 15:22:24 +00:00
Quentin Young
c5f119c06d *: do not take address of packed member
May result in alignment errors on certain platforms

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-26 15:22:23 +00:00
Donald Sharp
66d4272752 zebra: Remove string operations from non-debug path
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:22:03 -04:00
Donald Sharp
8755598a08 zebra: Store commonly used values instead of regenerating
the ipv4_ll address used for 5549 routes does not need
to be figured out every single time that we attempt
to install/remove a route of that type.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 21:11:24 -04:00
Donald Sharp
1ac33779aa vtysh: Add back some missing bgp commands
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-05-25 13:53:50 -04:00
Don Slice
79878cf73e zebra: add bgp unnumbered labeled-unicast to zserv
Prior to the fix, labels weren't getting installed in zebra nor were the
ifindex values correctly set if labeled-unicast was used in conjunction
with bgp unnumbered.

Ticket: CM-16531
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-6276
2017-05-25 04:19:10 -07:00
Jafar Al-Gharaibeh
fb13a6d478 Merge pull request #610 from donaldsharp/rpprefixlen
pimd: Allow secondary address comparisons to work
2017-05-24 22:10:19 -06:00
Quentin Young
dc207b2760 ospf6d: default to dotted quad instead of ret NULL
to fix coverity warning

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-05-25 04:09:52 +00:00
Donald Sharp
9e962de4b6 Merge remote-tracking branch 'origin/stable/3.0' 2017-05-24 11:22:35 -04:00
Donald Sharp
2d828a0c67 Merge pull request #612 from LabNConsulting/working/master/patch-set/deprecateEncap
master:  remove support for config & show of encap safi
2017-05-24 11:04:53 -04:00
Donald Sharp
f731a65469 Merge pull request #611 from LabNConsulting/working/3.0/patch-set/deprecateEncap
3.0: remove support for config & show of encap safi
2017-05-24 11:04:36 -04:00
Lou Berger
1ec1afd6cb bgpd: remove encap safi vty related files bgp_encap.h|c
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
eedae49501 bgpd: remove encap_safi rx processing
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
375a2e67ad bgpd: remove encap safi show commands
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
6c8744af2d bgpd: remove additional instance of BGP_ENCAP(v6)_NODE
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:58:50 -04:00
Lou Berger
2fd1b54aa1 bgpd rfapi: remove ability to configure use of encap-safi (continue to use encap attribute)
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:42:40 -04:00
Lou Berger
5b1f0f29e7 bgpd: remove support for ipv4|6 encap safi config
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:42:32 -04:00
Lou Berger
ddb2927dff vtysh: remove BGP_ENCAP(V6)_NODE
Signed-off-by: Lou Berger <lberger@labn.net>
2017-05-23 15:40:23 -04:00