proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 05:18:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
29,754 Commits 4 Branches 191 Tags 125 MiB
272c6d5db1
Commit Graph

29754 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donatas Abraitis
272c6d5db1
Merge pull request #8647 from sworleys/DVNI-Config-Changes 
bgpd: EVPN D-VNI L3 RT Config Enhancements
 2022-10-18 14:17:04 +03:00
Donald Sharp
a654221c70
Merge pull request #12136 from opensourcerouting/fix/drop_leftovers 
tools: Do not try creating /proc with install command
 2022-10-16 15:21:01 -04:00
Donatas Abraitis
6f26cc245c tools: Do not try creating /proc with install command 
Leftovers.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-14 21:30:13 +03:00
Donatas Abraitis
1e75c40c1c
Merge pull request #12126 from cscarpitta/fix/add-missing-debug-guard-bgpd-srv6 
bgpd: Add missing debug guard in SRv6 L3VPN code
 2022-10-14 10:12:56 +03:00
Donatas Abraitis
d37fb926de
Merge pull request #12113 from donaldsharp/network_statement 
bgpd: Allow `network XXX` to work with bgp suppress-fib-pending
 2022-10-14 10:12:18 +03:00
Donald Sharp
e3e3d729c4
Merge pull request #12066 from opensourcerouting/cleanup-cli-xref 
*: clean up various CLI-related bits
 2022-10-13 13:47:04 -04:00
Carmine Scarpitta
a9f75ca33b bgpd: Add missing debug guard in SRv6 L3VPN code 
This commit adds a missing debug guard in `ensure_vrf_tovpn_sid()`.

Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
 2022-10-13 17:26:24 +02:00
Russ White
fd30c2467a
Merge pull request #12115 from donaldsharp/ospf_unnumbered_showdown 
ospfd: Allow unnumbered and numbered addresses to co-exist better
 2022-10-13 11:02:17 -04:00
Russ White
07735ca345
Merge pull request #11980 from isabelladeleon12/set_overload_startup 
isisd: Add support for set-overload on-startup
 2022-10-13 10:59:24 -04:00
Donald Sharp
05139d1026
Merge pull request #12116 from alexclewontin/snapcraft-arch 
snapcraft: fix staging libssh on non-x86 arches
 2022-10-13 09:23:08 -04:00
Donald Sharp
b5864d339b
Merge pull request #12121 from opensourcerouting/feature/tag_prs_with_conflicts 
github: Add `conflicts`/`no_conflicts` labels for PRs
 2022-10-13 09:21:40 -04:00
Donald Sharp
361c80619a
Merge pull request #12122 from opensourcerouting/fix/use_install_instead_of_touch_chown_combination 
tools: Use `install` instead of `touch/chown` combination
 2022-10-13 08:58:25 -04:00
Donatas Abraitis
972cdc560e tools: Use install instead of touch/chown combination 
touch + chown can have a gap between the commands (or the second failed).

This could lead to unexpected permissions (root, instead of frr) for some
.conf files or directories.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-13 11:14:07 +03:00
Donatas Abraitis
1cc861a9c3 github: Add conflicts/no_conflicts labels for PRs 
Just to quickly identify which PRs needs attention on rebasing.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-13 08:18:59 +03:00
Donatas Abraitis
0407bb2dc0
Merge pull request #12108 from donaldsharp/general_mayhem 
General mayhem
 2022-10-13 08:08:27 +03:00
Isabella de Leon
450841fe05 isisd: Add JSON object functions to save overload status between restarts. 
Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
 2022-10-12 16:57:32 -07:00
Alex Lewontin
47cdbea73c
snapcraft: fix staging libssh on non-x86 arches 
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
 2022-10-12 17:20:25 -04:00
Donald Sharp
5136e67294 ospfd: Allow unnumbered and numbered addresses to co-exist better 
When forming a neighbor relationship on an interface, ospf is
currently evaluating unnumbered as highest priority, without
any consideration for if you have /32's and non /32's on the
interface.  Effectively if I have something like this:

int foo0
  ip address 192.168.119.1/24
!
router ospf
  network 0.0.0.0/0 area 0
!

ospf will form a neighbor on foo0 if it exists.  Now
suppose someone does this:

int foo0
  ip address 192.168.120.1/32

This will create the unnumbered interface on foo0 and
the peering will come down immediately.

The problem here is that the original designers of the unnumbered
code for ospf didn't envision end operators mixing and matching
addresses on an interface like this ( for perfectly legitimate
reasons I might add ).

So if ospf has both numbered and unnumbered let's match against
the numbered first and then unnumbered.  This solves the problem

Fixes: #6823
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 16:20:30 -04:00
Russ White
16f88c704c
Merge pull request #12053 from opensourcerouting/feature/accept_own_extended_community_single_rr 
bgpd: Implement ACCEPT_OWN extended community
 2022-10-12 15:58:23 -04:00
Donald Sharp
4801fc4670 bgpd: Allow network XXX to work with bgp suppress-fib-pending 
When bgp is using `bgp suppress-fib-pending` and the end
operator is using network statements, bgp was not sending
the network'ed prefix'es to it's peers.  Fix this.

Also update the test cases for bgp_suppress_fib to test
this new corner case( I am sure that there are going to
be others that will need to be added ).

Fixes: #12112
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 14:56:27 -04:00
Isabella de Leon
4afc783610 isisd: Add expected behavior with set-overload-bit 
Signed-off-by: Isabella de Leon <ideleon@microsoft.com>
 2022-10-12 10:52:27 -07:00
Donatas Abraitis
46dbf9d0c0 bgpd: Implement ACCEPT_OWN extended community 
TL;DR: rfc7611.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-12 17:48:43 +03:00
Russ White
984eb32b58
Merge pull request #11159 from maduri111/bgpd-orr 
bgpd: optimal route reflection
 2022-10-12 09:30:36 -04:00
Donatas Abraitis
87d54383c5
Merge pull request #12059 from achernavin22/fix-max-med-on-startup 
bgpd: fix "bgp max-med on-startup"
 2022-10-12 16:19:06 +03:00
Russ White
b6aa61ba3c
Merge pull request #11981 from proelbtn/add-support-to-change-function-length 
bgpd: Add support to change Segment Routing function length
 2022-10-12 08:44:29 -04:00
Donald Sharp
8460069326
Merge pull request #12105 from opensourcerouting/fix/bgp_list_sequence_handling_frr-reload 
tools: Handle sequence numbers for BGP community (large/ext) in frr-reload.py
 2022-10-12 07:41:56 -04:00
Donald Sharp
54fcc739b8 zebra: Cleanup memory leaks on shutdown 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Donald Sharp
b1d29673ca ripngd: Cleanup memory allocations on shutdown 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Donald Sharp
3d1588d8ed ripd: Cleanup memory allocations on shutdown 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Donald Sharp
823d80d155 zebra: zrouter.mh_info is leaked on shutdown 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Donald Sharp
ca28a0f6fa lib: Free some memory in scripting subsystem at shutdown 
Pre:
staticd: showing active allocations in memory group libfrr
staticd: memstats:  Scripting                     :     16 * (variably sized)
staticd: memstats:  Hash                          :      2 * (variably sized)
staticd: memstats:  Hash Bucket                   :      8 *         32
staticd: memstats:  Hash Index                    :      1 * (variably sized)
staticd: memstats:  Link List                     :      1 *         40
staticd: memstats:  Link Node                     :      1 *         24
staticd: showing active allocations in memory group logging subsystem
staticd: memstats:  log file target               :      1 *         88
staticd: showing active allocations in memory group staticd

Post:
staticd: showing active allocations in memory group libfrr
staticd: showing active allocations in memory group logging subsystem
staticd: memstats:  log file target               :      1 *         88
staticd: showing active allocations in memory group staticd

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Donald Sharp
08040409cc staticd: Clean up zclient on shutdown 
The zclient data structure was not being cleaned up on shutdown.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-10-12 07:39:23 -04:00
Madhuri Kuruganti
80f6ea8b99 bgpd: code review comments addressed 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:48:23 +05:30
Madhuri Kuruganti
bba9435157 bgpd, ospfd: update BGP when routes are removed from OSPF routing table 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
5fcf01c9ae bgpd: fix for crash when no neighbor A.B.C.D remote-as AS_NUM with orr config 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
9f2984d97c ospfd: few fixes in rSPF calc when LSA received from non root node 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
d6b2761134 bgpd, ospfd: BGP ORR CI warning fixes 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
a3d3a14c09 ospfd: rSPF calc and messaging for optimal route reflection 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
70cd87ca02 bgpd: optimal router reflection cli and fsm changes 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:43:55 +05:30
Madhuri Kuruganti
2b55ff400f doc: Add documentation for BGP ORR support 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:29:24 +05:30
Madhuri Kuruganti
a5dd4bf47d lib: BGP registration with IGP for BGP ORR rSPF calc 
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
 2022-10-12 13:29:24 +05:30
Donatas Abraitis
69c736ec06
Merge pull request #12074 from donaldsharp/lib_debugs 
*: Create and use infrastructure to show debugs in lib
 2022-10-12 10:38:21 +03:00
Donatas Abraitis
4b7ad630e0
Merge pull request #12091 from kuldeepkash/update_assert_msg 
tests: [topojson]Update assert messages for better debugging
 2022-10-12 10:37:10 +03:00
Donatas Abraitis
63f99a91c8 tools: Apply black formatting for frr-reload.py 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-11 22:38:30 +03:00
Donatas Abraitis
8bcbee1999 tools: Handle sequence numbers for BGP community (large/ext) in frr-reload.py 
If we add/modify community/large/ext lists without sequence numbers, and
doing frr-reload.py, then rules with sequence numbers (show running-config
always adds sequence numbers) will be deleted and new ones will be re-added.

This could lead to blackholing for some time.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-10-11 22:36:26 +03:00
Donatas Abraitis
9cd8485420
Merge pull request #12090 from patrasar/pimv6_show_bsm_db 
pim6d: Fix RpAddress in "show ipv6 pim bsm-database"
 2022-10-11 21:59:22 +03:00
Donatas Abraitis
656878e513
Merge pull request #12087 from achernavin22/fix-no-match-rpki 
bgpd: fix "no match rpki" in route-map
 2022-10-11 17:05:19 +03:00
Donatas Abraitis
9f03e9b2e5
Merge pull request #12099 from cscarpitta/fix/remove-null-check-before-free 
bgpd: Don't check for `NULL` when removing SRv6 SIDs
 2022-10-11 16:39:16 +03:00
Carmine Scarpitta
944909f4f7 bgpd: Don't check for NULL when removing SRv6 SIDs 
When an SRv6 locator is unset, all the SRv6 SIDs allocated from the
locator are removed. Before freeing the memory allocated for an SRv6
SID, we check if the pointer to the SID is `NULL`.

However, checking for `NULL` before freeing memory is useless.

This PR aims to improve the code's readability by removing the
useless `NULL` checks.

Signed-off-by: Carmine Scarpitta <carmine.scarpitta@uniroma2.it>
 2022-10-11 13:06:39 +02:00
Alexander Chernavin
05ab8ceda4 bgpd: fix "bgp max-med on-startup" 
Currently, if `bgp max-med on-startup` is configured, after BGP session
is established for the first time, a timer for the specified time is
started. When the timer is expired, an UPDATE message should be sent to
reflect changes in the routes' MED value. The problem is that the routes
are being suppressed because based on the attributes they look like they
have not changed. However, in the case of max-med, the value is copied
to the packet directly from `bgp->maxmed_value`, not from the
attributes. Thus, changes in this case cannot be detected by comparing
attributes.

With this fix, avoid route suppressing when the `max-med on-startup`
timer expires and initiates an UPDATE.

Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
 2022-10-11 10:45:06 +00:00