Donatas Abraitis
22a8c40f2a
Merge pull request #8526 from donaldsharp/sysctl_doc
...
doc: Start talking about useful sysctl's for proper zebra operation
2021-04-25 11:54:13 +03:00
Donatas Abraitis
109637ec5f
Merge pull request #8543 from volta-networks/fix_bgp_invalid_nexthop
...
bgpd: fix invalid labeled nexthop check
2021-04-25 11:52:19 +03:00
Igor Ryzhov
2ccc493333
Merge pull request #8495 from opensourcerouting/ospfv3-bfd-rework
...
ospf6d: rework BFD integration and add BFD profiles support
2021-04-24 00:47:31 +03:00
Igor Ryzhov
d06501f3c6
Merge pull request #8462 from opensourcerouting/pim-bfd-refactor
...
pimd: rework BFD integration and add profile support
2021-04-24 00:46:29 +03:00
Igor Ryzhov
646c4a38dc
Merge pull request #8539 from donaldsharp/isis_circuit_warning
...
Isis circuit warning
2021-04-23 22:44:49 +03:00
Donald Sharp
c5b8ce0620
isisd: Remove warnings and add some data to debugs for isis_csm.c
...
When running isis and not running isis on all interfaces results
in a bunch of warn messages to the log about circuit state
changes. These warn messages also didn't bother to inform
the end user what interface was causing the fun. Since
the end operator cannot do anything with these warn messages
and nor should they in the vast array of normal operations
modify the code to use event debugging and turn the warns
to debugs.
Additionally add some information to clue the operator
in on to what actual interface we are talking about.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-23 08:41:41 -04:00
Rafael Zalamena
d5f9847a9e
topotests: test PIM BFD profile integration
...
Test that PIM BFD profile integration works.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:29:00 -03:00
Rafael Zalamena
46e3d00803
doc: document new PIM BFD command variant
...
Tell user he can configure BFD profile for sessions created by PIM.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:29:00 -03:00
Rafael Zalamena
745b8d4a68
pimd: support BFD profiles configuration
...
Allow users to pre configure BFD sessions with a profile.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:29:00 -03:00
Rafael Zalamena
3544d257b7
yang: add PIM BFD profile support
...
Allow users to configure BFD profile for the peers in a interface.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:29:00 -03:00
Rafael Zalamena
0d00ac9cb5
topotests: add new basic PIM topology test
...
Test for PIM (re)convergence and BFD usage.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:29:00 -03:00
Rafael Zalamena
1f3e6bf585
pimd: rework BFD integration
...
Rewrite the BFD integration code to use the new library.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23 09:28:57 -03:00
Emanuele Di Pascale
c3b95419ba
bgpd: fix invalid labeled nexthop check
...
the code processing an NHT update was only resetting the BGP_NEXTHOP_VALID
flag, so labeled nexthops were considered valid even if there was no
nexthop. Reset the flag in response to the update, and also make the
isvalid_nexthop functions a little more robust by checking the number
of nexthops.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-04-23 11:20:52 +02:00
Donald Sharp
9d454ad27f
isisd: Use enum for circuit state
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-22 15:17:20 -04:00
Donald Sharp
61cd5761a3
isisd: use an enum for circuit states
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-22 15:17:20 -04:00
Rafael Zalamena
ac506cb20e
lib: BFD session handling improvement
...
Don't uninstall sessions if the address, interface, VRF or TTL didn't change.
Update the library documentation to make it clear to other developers.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:04 -03:00
Rafael Zalamena
76b512be5e
doc: OSPFv3 BFD profile documentation
...
Let user know he can use BFD profiles with OSPFv3.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:04 -03:00
Rafael Zalamena
7fcb9ef4cc
topotests: test OSPFv3 BFD profiles
...
See if the BFD sessions created by OSPFv3 are using the configured BFD profiles.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:04 -03:00
Rafael Zalamena
1f7be0d242
ospf6d: add support for BFD profiles
...
Allow user to pre configure BFD sessions using profiles.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:04 -03:00
Rafael Zalamena
4a9e802c3c
topotests: converge OSPFv3 faster
...
Tweak OSPFv3 interface configuration to converge faster.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:04 -03:00
Rafael Zalamena
d06cc41644
ospf6d: rework BFD integration
...
Use the new BFD library to integrate with BFD.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 16:10:01 -03:00
Rafael Zalamena
464e6541b1
lib: fix possible crash on BFD notification
...
Allow sessions to remove themselves from the notifications without
risking crashes.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22 15:12:18 -03:00
Rafael Zalamena
b38f1fd03d
Merge pull request #8536 from idryzhov/bfd-enabled
...
lib: remove enabled flag for bfd sessions
2021-04-22 15:06:48 -03:00
Igor Ryzhov
e82acdce22
lib: remove enabled flag for bfd sessions
...
Currently this flag is only helpful in an extremely rare situation when
the BFD session registration was unsuccessful and after that zebra is
restarted. Let's remove this flag to simplify the API. If we ever want
to solve the problem of unsuccessful registration/deregistration, this
can be done using internal flags, without API modification.
Also add the error log to help user understand why the BFD session is
not working.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-04-22 16:39:29 +03:00
Donald Sharp
85e40093a9
Merge pull request #8528 from opensourcerouting/build-cleanup-20210421
...
build: more cleaning
2021-04-21 20:46:02 -04:00
Mark Stapp
7b58ed7295
Merge pull request #8529 from donaldsharp/reload_is_not
...
Reload complaining about using `is not`
2021-04-21 14:02:26 -04:00
David Lamparter
7c2275ac86
build: turn on automake warnings (& symlinks)
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:37 +02:00
David Lamparter
1b636c0ad4
build: run autoupdate
...
AC_TRY_COMPILE is deprecated too. Also configure.ac isn't executable.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:37 +02:00
David Lamparter
19083e4f75
build: remove deprecated AC_WORDS_BIGENDIAN
...
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:37 +02:00
David Lamparter
6fc9987217
build: improve AX_LUA_HEADERS for crosscompile
...
The preprocessor is something configure can invoke.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:36 +02:00
David Lamparter
8b11dfcaec
build: use AC_CONFIG_AUX_DIR
...
aka the "put shit into a subdirectory" option
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:36 +02:00
David Lamparter
0c4285d77e
build: properly split CFLAGS from AC_CFLAGS
...
`CFLAGS` is a "user variable", not intended to be controlled by
configure itself. Let's put all the "important" stuff in AC_CFLAGS and
only leave debug/optimization controls in CFLAGS.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:36 +02:00
David Lamparter
09781197b6
build: make builddir include path consistent
...
... by referencing all autogenerated headers relative to the root
directory. (90% of the changes here is `version.h`.)
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 15:42:33 +02:00
Donald Sharp
61dc17d8cb
tools: Cleanup frr-reload.py by running black on it
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-21 08:59:22 -04:00
Donald Sharp
0ed6a49d90
tools: Fix warning when running frr-reload.py
...
When I run frr-reload.py I am seeing this error:
Apr 21 06:23:51 eva frrinit.sh[3776992]: /usr/lib/frr/frr-reload.py:1094: SyntaxWarning: "is not" with a literal. Did you mean "!="?
Apr 21 06:23:51 eva frrinit.sh[3776992]: if line is not "exit-vrf":
fix
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-21 08:57:29 -04:00
David Lamparter
9219708b13
build: fix protobuf out-of-tree build
...
Otherwise it aborts with "File does not reside within any path specified
using --proto_path (or -I)"
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21 11:13:25 +02:00
Igor Ryzhov
bf6005d5f4
Merge pull request #8516 from patrasar/pim_register_suppress_time_crash
2021-04-21 00:07:36 +03:00
Donald Sharp
cbacd05bf2
doc: Start talking about useful sysctl's for proper zebra operation
...
Add some color to useful sysctl's that are needed for FRR proper operation.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-20 15:52:32 -04:00
Mark Stapp
adb7fb636f
Merge pull request #8505 from mobash-rasool/ospfv3-max-path
...
ospf6d: Do not delete external table when configure max-path
2021-04-20 15:37:00 -04:00
Mark Stapp
fe390fafc5
Merge pull request #8482 from wesleycoakley/docker-prefer-cmd-to-entrypoint
...
docker: prefer CMD to ENTRYPOINT for flexibility
2021-04-20 11:58:44 -04:00
Russ White
2bbf1bd88b
Merge pull request #8361 from rameshabhinay/change_1
...
bgpd: vrf route leaking related fixes
2021-04-20 11:23:49 -04:00
Russ White
8c3d6b8be5
Merge pull request #8455 from achernavin22/ospf_nssa_after_redist2
...
ospfd: install Type-7 when NSSA area is configured after redistribution
2021-04-20 10:28:49 -04:00
Russ White
0ab9f53044
Merge pull request #8456 from donaldsharp/idle_to_active
...
bgpd: Address LL peer not NHT when receiving connection attempt
2021-04-20 10:24:37 -04:00
Donald Sharp
9c95ede706
Merge pull request #8501 from ton31337/fix/replace_community_check
...
bgpd: Check for flag existense for community instead of `if not NULL`
2021-04-20 09:10:30 -04:00
Russ White
7408af70f5
Merge pull request #8373 from mjstapp/fix_ospf_timeval_dump
...
ospfd: show seconds in timeval_dump
2021-04-20 07:39:50 -04:00
Sarita Patra
6f5f05029c
pimd: fix crash pim register-suppress-time command
...
Signed-off-by: Sarita Patra <saritap@vmware.com>
2021-04-20 03:57:50 -07:00
Donald Sharp
117d216ba0
Merge pull request #8503 from opensourcerouting/one-backtrace-is-enough
...
lib: 640k backtraces should be enough for everybody
2021-04-20 06:11:13 -04:00
Donald Sharp
0433e60cb3
Merge pull request #8511 from idryzhov/doc-fix-ospfd-maxpath
...
doc: fix ospfd maximum-paths command
2021-04-20 06:10:37 -04:00
Sri Mohana Singamsetty
97444b25ad
Merge pull request #8500 from ton31337/fix/indentation_for_show_ip_bgp_large_community_list_cmd
...
bgpd: Fix clang-format/indentation for show_ip_bgp_large_community_list_cmd
2021-04-19 17:12:24 -07:00
Igor Ryzhov
25d6c9671b
doc: fix ospfd maximum-paths command
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-04-19 17:51:55 +03:00