Quentin Young
2013e82a89
Revert "debian: Remove now obsolete tarsource.sh script"
...
This reverts commit bc304e08ea
.
2020-11-19 17:12:38 -05:00
Quentin Young
5aa63f6aa6
Revert "debian: Update the tools/build-debian-package.sh to be example build script"
...
This reverts commit c950a7f214
.
2020-11-19 17:12:27 -05:00
Ondřej Surý
c950a7f214
debian: Update the tools/build-debian-package.sh to be example build script
...
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:11 +01:00
Ondřej Surý
bc304e08ea
debian: Remove now obsolete tarsource.sh script
2020-11-19 21:30:08 +01:00
Ondřej Surý
cace1d9bf1
debian: Remove the changelog-auto automation in favor of dch
...
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:06 +01:00
Ondřej Surý
63c0c8ed89
debian: Update tools/build-debian-package.sh to use git-buildpackage
...
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:02 +01:00
Ondřej Surý
4ffb9a4c9d
debian: Adjust tarsource.sh to use native debian/changelog
...
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:59 +01:00
Ondřej Surý
da3a39ff6a
debian: Merge various debian changelogs in debian/changelog
...
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:45 +01:00
Mark Stapp
38a0ce9146
Merge pull request #7566 from ton31337/fix/topotests_bgp_ebgp_requires_policy
...
tests: Add more descriptive error messages and increase timeouts
2020-11-19 13:32:56 -05:00
Mark Stapp
b3ec3c3cb9
Merge pull request #7424 from donaldsharp/config_commands
...
lib, sharpd, vtysh: When reading a file in for config send start/end …
2020-11-19 12:40:50 -05:00
Donald Sharp
cac886dd53
Merge pull request #6145 from patrasar/pim_nb_code_upstream
...
pimd: northbound backend code
2020-11-19 11:03:00 -05:00
Mark Stapp
e01396e1ea
Merge pull request #7563 from donaldsharp/why_not_cut_n_paste
...
ospf6d: More lists being leaked
2020-11-19 10:58:21 -05:00
Mark Stapp
001325b696
Merge pull request #7561 from donaldsharp/resources_are_the_life
...
lib: Stop socket from leaking.
2020-11-19 09:56:51 -05:00
Donald Sharp
16ae941f4a
lib: Add information log of how long configuration took to read in
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 09:52:11 -05:00
Donald Sharp
f8e6ada882
lib, sharpd, vtysh: When reading a file in for config send start/end indicators
...
When reading a file in for configuration, send start and end indicators
to interested parties.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 09:52:11 -05:00
Donatas Abraitis
e9ac289675
tests: Add more descriptive error messages and increase timeouts
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-11-19 16:49:44 +02:00
Donald Sharp
680b8ceb9e
ospf6d: More lists being leaked
...
Apparently the person who wrote this code was big into
cut-n-paste. Commit 710a61d57c
found the first instance, but upon code inspection this morning
it became evident that 2 other functions had the exact same
problem.
Fix. Note I have not cleaned up the cut-n-paste code for
two reasons: a) I'm chasing something else b) this code
has been fairly un-maintained for a very long time. No
need to start up now.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 08:04:51 -05:00
Donald Sharp
07d4bb8b9c
lib: Stop socket from leaking.
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-19 07:02:15 -05:00
Donatas Abraitis
53a85efa51
Merge pull request #7554 from donaldsharp/sockunion2hostprefix_watch_returns
...
bgpd, lib, nhrpd, zebra: verify return of sockunion2hostprefix
2020-11-19 11:26:02 +02:00
Donatas Abraitis
6a13ee5644
Merge pull request #7528 from donaldsharp/changelog_update
...
Changelog update
2020-11-19 10:43:26 +02:00
Sarita Patra
1dac87c88d
pimd: fix indentation issues
...
Signed-off-by: Sarita Patra <saritap@vmware.com>
2020-11-18 23:20:26 -08:00
Donald Sharp
d377cf01e7
Merge pull request #7210 from idryzhov/route-types-disable-daemon
...
lib: respect --disable-daemon flags in route_types.h
2020-11-18 19:38:14 -05:00
Donald Sharp
b84696e6c0
Merge pull request #7454 from ranjanyash54/dev_8
...
ospf6d: Json support added for command "show ipv6 ospf6 interface traffic [json]"
2020-11-18 18:37:30 -05:00
Donald Sharp
74c6aba12e
Merge pull request #7455 from ranjanyash54/dev_3
...
ospf6d: Json support added for command "show ipv6 ospf6 redistribute [json]"
2020-11-18 18:33:09 -05:00
Donald Sharp
db2e92360c
Merge pull request #7467 from ton31337/fix/bgpd_null_dereference
...
bgpd: Check if peer is not NULL before calling peer_as_change()
2020-11-18 18:13:04 -05:00
Donald Sharp
f2e1528b62
Merge pull request #7558 from opensourcerouting/bfd-v6-same
...
bfdd: fix multiple links same address
2020-11-18 17:53:42 -05:00
Donald Sharp
c3f5f46868
Merge pull request #7296 from YashRanjanVMWare/dev_1
...
ospf6d: Json support added for command "show ipv6 ospf6 [json]"
2020-11-18 17:50:42 -05:00
Mark Stapp
abed797ef5
Merge pull request #7556 from donaldsharp/memory_shenanigans
...
Memory shenanigans
2020-11-18 17:31:03 -05:00
Donald Sharp
95bd143ec3
Merge pull request #7552 from volta-networks/fix_reload_l2pvn
...
tools: fix frr-reload l2vpn delete
2020-11-18 15:27:51 -05:00
Mark Stapp
84c709bc6e
Merge pull request #7555 from idryzhov/cppcheck-fixes
...
fix a couple of issues found by cppcheck
2020-11-18 14:29:25 -05:00
Rafael Zalamena
4c4faa474e
bfdd: fix multiple links same address
...
Allows users with multiple links using same IPv6 address (same VRF) to
work.
Reported-by: Matti Suuronen
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-11-18 16:06:16 -03:00
Donald Sharp
6a37bfb7e5
bgpd: Prevent ecommunity_ecom2str memory leak
...
We were allocating but never freeing memory associated with the
ecommunity_ecom2str allocation.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 12:50:48 -05:00
Donald Sharp
b9d4546253
bgpd: Do not leak vname if we find the match
...
If we are attempting to store the bgp name for route
leaking and we find a match do not leak the memory.
Please note this is probably not really going to happen
ever.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 12:10:22 -05:00
Mark Stapp
410a7b7058
Merge pull request #7553 from donaldsharp/mem_leak_ferr
...
lib: Cleanup mem-leaks in error case
2020-11-18 11:56:34 -05:00
Donald Sharp
710a61d57c
ospf6d: Free up list memory
...
OSPFv3 snmp code creates a list but never deletes the actual
list. Do so.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 11:42:50 -05:00
Donald Sharp
f8ca1bb935
pimd: A buffer may be used uninited
...
If we screw up and don't have the right flags we'll print
out garbage. At the very least just print out nothing.
Signed-off-by: Donald Sharp <sharp@nvidia.com>
2020-11-18 11:42:06 -05:00
Igor Ryzhov
65f18319c0
lib: fix macro style
...
We prefer semicolon in the actual code instead of macro elsewhere in the
code.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-18 19:14:03 +03:00
Igor Ryzhov
55b2b5ab99
isisd: fix uninitialized variable
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-18 19:07:49 +03:00
Igor Ryzhov
0db96688aa
ospf6d: fix compilation of debug code
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-18 19:06:10 +03:00
Igor Ryzhov
b0efbc16e4
zebra: fix writing to pointer instead of value
...
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-18 19:05:30 +03:00
Donald Sharp
0154d8ce45
bgpd, lib, nhrpd, zebra: verify return of sockunion2hostprefix
...
The return from sockunion2hostprefix tells us if the conversion
succeeded or not. There are places in the code where we
always assume that it just `works`, since it can fail
notice and try to do the right thing.
Please note that failure of this function for most cases
of sockunion2hostprefix is highly highly unlikely as that
the sockunion was already created and tested elsewhere
it's just that this function can fail.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 11:04:27 -05:00
Donald Sharp
1d06fc711a
lib: Cleanup mem-leaks in error case
...
When we fail to properly lookup an error code, properly cleanup
on return.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-18 08:54:51 -05:00
Mark Stapp
926bc58f78
Merge pull request #7478 from donaldsharp/buffer
...
Buffer
2020-11-18 08:30:47 -05:00
Emanuele Di Pascale
8239db83b0
tools: fix frr-reload l2vpn delete
...
when deleting a whole l2vpn context in ldpd which also had pseudowires
in it, we were first deleting the l2vpn with a 'no l2vpn XXX' command,
and then adding it again by running 'l2vpn XXX\n no member pseudowire YYY'
which obviously was not needed. As a result the l2vpn would be reinstated.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-11-18 11:44:39 +01:00
Rafael Zalamena
4287336cd7
Merge pull request #7549 from vincentbernat/fix/oot-build
...
vtysh: fix out-of-tree build not finding vtysh/daemons.pl
2020-11-18 07:27:47 -03:00
Donatas Abraitis
151c9d9ec6
Merge pull request #7548 from vincentbernat/feature/json-passive
...
bgpd: identify passive connections in JSON summary
2020-11-18 08:39:28 +02:00
Donald Sharp
4abdbea978
Merge pull request #7543 from GalaxyGorilla/fix_refcmp_newline
...
tests: ignore Windows vs Unix style newlines
2020-11-17 15:30:07 -05:00
Renato Westphal
e37ecce6bc
Merge pull request #7534 from chiragshah6/yang_nb1
...
bgpd: convert to yang modeled nbr cmds
2020-11-17 17:13:20 -03:00
Vincent Bernat
dfca5be576
vtysh: fix out-of-tree build not finding vtysh/daemons.pl
...
This is needed to build with:
mkdir build && cd build && ../configure && make
Signed-off-by: Vincent Bernat <vincent@bernat.ch>
2020-11-17 20:51:23 +01:00
Vincent Bernat
266ae3aa53
bgpd: identify passive connections in JSON summary
...
When using non JSON output, passive connections are marked with:
BGP state = Active (passive)
However, such an information is not available in JSON output. This
commit adds that. It also adds "Active (NSF passive)" flag, like the
regular output.
Signed-off-by: Vincent Bernat <vincent@bernat.ch>
2020-11-17 20:29:31 +01:00