proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-04 18:25:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,649 Commits 4 Branches 191 Tags 125 MiB
162deb7dfb
Commit Graph

11649 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
162deb7dfb
Merge pull request #2490 from pacovn/cppcheck_unsigned_check 
babeld, eigrpd, ospfd: unsigned negative check (cppcheck, grouped)
 2018-06-18 15:14:07 -04:00
Donald Sharp
c0662bb478
Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code 
bgpd: dead code (Coverity 1399373)
 2018-06-18 14:29:27 -04:00
paco
d11c6941dc
babeld, eigrpd, ospfd: unsigned negative check 
After Cppcheck 1.72 feedback

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 19:07:24 +02:00
Donald Sharp
36de1d53b8
Merge pull request #2457 from pacovn/Coverity_1465491_Untrusted_value_as_argument 
pimd: Untrusted val as argument (Coverity 1465491)
 2018-06-18 11:55:53 -04:00
Donald Sharp
7c75247f66
Merge pull request #2464 from pacovn/Coverity_1399309_Out-of-bounds_access 
isisd: out-of-bounds access (Coverity 1399309)
 2018-06-18 11:55:16 -04:00
Lou Berger
2868e293e7
Merge pull request #2466 from pacovn/clang_scan_bgpd_dereference1 
bgpd: null check (Clang scan-build)
 2018-06-18 08:16:01 -04:00
Lou Berger
f0380e0468
Merge pull request #2456 from pacovn/Coverity_1399306_Out-of-bounds_access 
bgpd: out-of-bounds access (Coverity 1399306)
 2018-06-18 08:12:04 -04:00
Lou Berger
f4659d27c6
Merge pull request #2467 from pacovn/Coverity_1399274_Dereference_after_null_check 
bgpd: null check (Coverity 1399274)
 2018-06-16 08:26:26 -04:00
paco
4f9a63adba
bgpd: null check (Coverity 1399274) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 20:09:55 +02:00
paco
cc35bc7c8f
bgpd: null check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 20:02:23 +02:00
Quentin Young
65c4ceac44
Merge pull request #2447 from ajones-rvbd/ajones-issue-2391 
alpine: add unit tests to build
 2018-06-15 12:40:19 -04:00
paco
c28135f38e
isisd: out-of-bounds access (Coverity 1399309) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 18:36:20 +02:00
Quentin Young
97b1dd19a1
Merge pull request #2409 from LabNConsulting/working/master/vtysh-2400 
vtysh: -u fixes
 2018-06-15 12:33:44 -04:00
Donald Sharp
6389e663e9
Merge pull request #2458 from pacovn/Coverity_1221437_Unchecked_return_value 
ospf6d: unchecked return value (Coverity 1221437)
 2018-06-15 10:53:58 -04:00
paco
18e994a043
pimd: Untrusted val as argument (Coverity 1465491) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 14:46:25 +02:00
paco
246879c303
ospf6d: unchecked return value (Coverity 1221437) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 13:08:37 +02:00
paco
5beb290a7b
bgpd: out-of-bounds access (Coverity 1399306) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 12:39:10 +02:00
paco
1d1c0de9f0
bgpd: dead code (Coverity 1399373) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-15 11:55:13 +02:00
Rafael Zalamena
e4a374681d
Merge pull request #2426 from pacovn/Coverity_23089_Buffer_not_null_terminated 
ospfd: buffer termination (Coverity 23089)
 2018-06-14 18:02:34 -03:00
Rafael Zalamena
67f23e08c3
Merge pull request #2438 from pacovn/Coverity_1457300_Dereference_after_null_check 
ospfd: null check (Coverity 1457300)
 2018-06-14 17:58:10 -03:00
Arthur Jones
95bd0d7e05 alpine: add unit tests to build 
Now that make check works on alpine, add it to the build

Testing done: alpine linux build -- check works

Issue: https://github.com/FRRouting/frr/issues/2391

Signed-off-by: Arthur Jones <arthur.jones@riverbed.com>
 2018-06-14 10:27:24 -07:00
Donald Sharp
259952c503
Merge pull request #2422 from pacovn/Coverity_23201_Dereference_before_null_check 
bgpd: null check (Coverity 23201)
 2018-06-14 13:03:50 -04:00
Renato Westphal
0d0ca0bb34
Merge pull request #2435 from pacovn/Coverity_1464993_Buffer_not_null_terminated 
ospfd: buffer termination (Coverity 1464993)
 2018-06-14 13:44:10 -03:00
paco
1f9d4e3d49
ospfd: buffer termination (Coverity 23089) 
Details:
- INET_ADDRSTRLEN is 16, for xxx.xxx.xxx\0, so 15 is now passed
 to the strncpy call instead of 16, ensuring ASCII-z output

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 17:43:19 +02:00
paco
a247298087
bgpd: null check (Coverity 23201) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 17:18:08 +02:00
paco
e4407ea6d0
ospfd: buffer termination (Coverity 1464993) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-14 16:59:31 +02:00
Rafael Zalamena
c0519af39f
Merge pull request #2430 from pacovn/clang_scan_ospf_dereference 
ospfd: dereference check (Clang scan-build)
 2018-06-14 11:14:52 -03:00
Rafael Zalamena
fbd3d404ae
Merge pull request #2434 from pacovn/Coverity_1457145_Out-of-bounds_access 
lib: out-of-bounds access (Coverity 1457145)
 2018-06-14 11:09:05 -03:00
Donald Sharp
dd52a18493
Merge pull request #2436 from pacovn/Coverity_1143220_Argument_cannot_be_negative 
tools: return check (Coverity 1143220)
 2018-06-14 10:02:25 -04:00
Rafael Zalamena
d17840aa8a
Merge pull request #2437 from pacovn/Coverity_1436343_Dereference_after_null_check 
lib: null check (Coverity 1436343)
 2018-06-14 11:00:57 -03:00
Renato Westphal
ff9f7454d1
Merge pull request #2428 from donaldsharp/zserv_debug 
zebra: Cleanup code to test for failure once
 2018-06-14 10:43:40 -03:00
Rafael Zalamena
ff456781b7
Merge pull request #2410 from pacovn/Coverity_1448806_Out-of-bounds_access 
lib: Out-of-bounds access (Coverity 1448806, 1448810)
 2018-06-14 10:29:35 -03:00
Lou Berger
447c4754a1
Merge pull request #2439 from chiragshah6/evpn_dev 
bgpd: Fix bgpd crash in evpn vni route-map apply
 2018-06-14 09:21:14 -04:00
Donald Sharp
24614afe1e
Merge pull request #2441 from MasterofJOKers/workflow_pr_info_url 
doc: Correct wiki URL in workflow-documentation
 2018-06-14 06:27:15 -04:00
MasterofJOKers
3f4f5b0437 doc: Correct wiki URL in workflow-documentation 
The organization on github is called "FRRouting".

Signed-off-by: MasterofJOKers <joker@someserver.de>
 2018-06-14 09:33:32 +02:00
paco
4ac99370b0
lib: null check (Coverity 1436343) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 19:53:09 +02:00
Renato Westphal
293c8113bf
Merge pull request #2431 from pacovn/Coverity_1399290_Out-of-bounds_access 
tools: out-of-bounds access (Coverity 1399290)
 2018-06-13 14:49:52 -03:00
Donald Sharp
11b3759359
Merge pull request #2416 from pacovn/Coverity_1399389_Structurally_dead_code 
bgpd: dead code (Coverity 1399389)
 2018-06-13 13:38:03 -04:00
Chirag Shah
80ced71057 bgpd: Fix bgpd crash in evpn vni route-map 
When evpn configured wiht route-map with vni which is not
configured. Upon receiving evpn routes (i.e Type-2, Type-3),
route-map match will be triggered. Since there is no l2vni
exists in db, some of the member fields in bgp_info (i.e.
dummy_info_extra) are passed uninitialized to evpn filter match cb.
This results in inaccessible memory causes crash.

Fix is to memset the bgp_info prior to passing to evpn filter cb.
In evpn vni filter cb, ensure to have NULL check for member filed
of the bgp_info.

memset bgp_info at few places where it is passed to route_match.

Ticket:CM-21335
Reviewed By:
Testing Done:

Configure route-map with not configured l2vni
Simulate to learn l2vpn type-2, 3 route

Restart frr.service with below config
address-family l2vpn evpn
  neighbor fear route-map EVPN_VNI out

route-map EVPN_VNI deny 10
 match evpn vni 140010

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2018-06-13 10:14:24 -07:00
paco
e89ffeee92
ospfd: null check (Coverity 1457300) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 19:04:43 +02:00
paco
cab3b126ca
bgpd: dead code removal (Coverity 1399389) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 18:17:56 +02:00
Donald Sharp
9c96d82fd2
Merge pull request #2424 from pacovn/Coverity_1399270_Dereference_after_null_check 
bgpd: null check (Coverity 1399270)
 2018-06-13 12:13:57 -04:00
paco
657f9948ed
tools: return check (Coverity 1143220) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 18:07:36 +02:00
paco
cc32742c09
bgpd: null check (Coverity 1399270) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 17:15:21 +02:00
paco
9eaec2ae4b
lib: out-of-bounds access (Coverity 1457145) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 17:08:38 +02:00
Donald Sharp
558c7c80bf
Merge pull request #2421 from pacovn/Coverity_1399232_Logically_dead_code 
ospfd: dead code (Coverity 1399232)
 2018-06-13 10:45:48 -04:00
paco
e1be9119f8
tools: out-of-bounds access (Coverity 1399290) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 16:33:51 +02:00
paco
a37befa70b
ospfd: dereference check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 15:49:36 +02:00
Donald Sharp
03f290185b zebra: Cleanup code to test for failure once 
Cleanup the zebra code to test for failure for reading
from stream once instead of once to see if we should
debug and once for the actual failure.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-13 09:19:37 -04:00
paco
92692be16a
ospfd: dead code (Coverity 1399232) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-13 14:30:06 +02:00