proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-25 14:17:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
35,483 Commits 4 Branches 191 Tags 125 MiB
0e040960d7
Commit Graph

35483 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Louis Scalbert
d346d1ac41 Revert "bgpd: fix 6vpe nexthop" 
This reverts commit 0325116a27.

It was causing an issue where a nexthop for IPv6 over an IPv4 session
was always rewritten to an IPv4-mapped IPv6 address even when a valid
IPv6 global address was existing.

Link: https://github.com/FRRouting/frr/issues/15610
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
 2024-04-23 11:26:49 +02:00
Louis Scalbert
3d3a138f5a bgpd: fix show run of network route-distinguisher 
Route-distinguisher (RD) is not printed properly in show run:

>  address-family ipv6 vpn
>   network ff01::/64 rd (null) label 7
>   network ff01::/64 rd (null) label 8

ad151f66aa ("bgpd: Refactor bgp_static_set/bgp_static_set_safi") merged
bgp_static_set_safi into bgp_static_set but inadvertently omitted the
handling of prd_pretty.

Copy the pretty RD string if available.

> address-family ipv6 vpn
>  network ff01::/64 rd 75:5 label 7
>  network ff01::/64 rd 85:5 label 8

Fixes: ad151f66aa ("bgpd: Refactor bgp_static_set/bgp_static_set_safi")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
 2024-04-23 10:39:21 +02:00
Igor Ryzhov
166a82ca6a
Merge pull request #15813 from pguibert6WIND/isis_srv6_backup_endx 
isisd: fix renaming backup define for ENDX SID
 2024-04-23 11:11:08 +03:00
Donatas Abraitis
bb7b0ff01f
Merge pull request #15536 from ak503/bgp_bfd 
bgpd: fix disable bfd profile for neighbors.
 2024-04-23 11:09:11 +03:00
Donatas Abraitis
0a6f661eae
Merge pull request #15717 from pguibert6WIND/vrf_label_allocate_when_necessary 
bgpd: do allocate vrf label only when necessary
 2024-04-23 11:08:21 +03:00
Donatas Abraitis
5738263065
Merge pull request #15750 from piotrsuchy/json_show_ip_prefix_list_fix 
vtysh, lib: fix 'show ip[v6] prefix-list ... json' JSON display by moving it to vtysh to fix formatting issue
 2024-04-23 11:06:44 +03:00
Donatas Abraitis
634d1375fa bgpd: Update IPv6 extended community sub-type for extended link bandwidth 
Already assigned by IANA, just the draft is not yet updated.

https://www.iana.org/assignments/bgp-extended-communities/bgp-extended-communities.xhtml#trans-ipv6

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-23 08:55:00 +03:00
Donatas Abraitis
593a806510 tests: Check if extended link bandwidth can be more than 25gbps 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
4d3e679b04 bgpd: Use snprintfrr() to print PRIu64 for ipv6_ecommunity_lb_str() 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
055cc0488b tests: Check if extended link bandwidth is considered into also 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
0703ae35cc bgpd: Include IPv6 extended community into multipath considerations 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
d92a284523 bgpd: Extract link bandwidth from IPv6 extended community if received 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
a988a0a88a *: Use uint64_t for weight down the path to Zebra 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
e53bd69326 bgpd: Allow sending extended communities between OAD peers 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
09e2a362a3 bgpd: Implement draft-li-idr-link-bandwidth-ext-01 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
b29fdafa3f bgpd: Print IPv6 extended communities for show bgp <prefix> 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:08 +03:00
Donatas Abraitis
c8a2532ab3 bgpd: Add neighbor ... extended-link-bandwidth command 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:50:07 +03:00
Donatas Abraitis
540f81c346 bgpd: Print IPv6 extended community for show bgp attribute-info 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:49:16 +03:00
Donatas Abraitis
c4986af74e bgpd: Adopt ecommunity_linkbw_present for IPv6 extended communities 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:49:16 +03:00
Donatas Abraitis
d9219ee847 bgpd: Drop non ieee encoding parsing for ipv6 extended communities 
Link-bandwidth is encoded into extended community, not ipv6 extended community.

Thus it's not needed here at all.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:49:00 +03:00
Donatas Abraitis
e0b64f2414 bgpd: Convert 32-bit to 64-bit link bandwidth variable (link_bw) 
This is needed to implement and use larger bandwidths rather than limiting only
to theoretical 34Gbps max bandwidth.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:48:37 +03:00
Donatas Abraitis
85292ef926 doc: Add neighbor ... extended-link-bandwidth command 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-22 17:48:37 +03:00
Donald Sharp
29c1ff446e lib, zebra: Check for not being a blackhole route 
In zebra_interface_nhg_reinstall zebra is checking that the
nhg is a singleton and not a blackhole nhg.  This was originally
done with checking that the nexthop is a NEXTHOP_TYPE_IFINDEX,
NEXTHOP_TYPE_IPV4_IFINDEX and NEXTHOP_TYPE_IPV6_IFINDEX.  This
was excluding NEXTHOP_TYPE_IPV4 and NEXTHOP_TYPE_IPV6.  These
were both possible to be received and maintained from the upper
level protocol for when a route is being recursively resolved.
If we have gotten to this point in zebra_interface_nhg_reinstall
the nexthop group has already been installed at least once
and we *know* that it is actually a valid nexthop.  What the
test is really trying to do is ensure that we are not reinstalling
a blackhole nexthop group( Which is not possible to even be
here by the way, but safety first! ).  So let's change
to test for that instead.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2024-04-22 10:44:55 -04:00
Igor Ryzhov
cb88ce132a lib: fix style and add more comments to NB code 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:49:03 +03:00
Igor Ryzhov
3c8336c845 tests: add topotest for mgmtd rpc processing 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:23 +03:00
Igor Ryzhov
6e0e84491b ripngd: convert RPC commands to mgmtd 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:23 +03:00
Igor Ryzhov
dbaf05ae3d ripd: convert RPC commands to mgmtd 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:23 +03:00
Igor Ryzhov
a94f74bc2e lib: add native RPC processing to mgmt frontend client 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:23 +03:00
Igor Ryzhov
cb6c182852 mgmtd: add native RPC processing 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:22 +03:00
Igor Ryzhov
5b219644ae mgmtd: add backend xpath map for RPC 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:22 +03:00
Igor Ryzhov
5c3e95d422 lib: add native RPC processing to mgmt backend client 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:22 +03:00
Igor Ryzhov
03883ee431 tests: add test for NB RPC callback 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:22 +03:00
Igor Ryzhov
58a8ebc1fc lib: rework northbound RPC callback 
Change input/output arguments of the RPC callback from lists of
(xpath/value) tuples to YANG data trees.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2024-04-22 16:36:22 +03:00
Christian Hopps
7f7bcb1ffa
Merge pull request #15468 from idryzhov/mgmt-native-edit 
mgmtd: add support for native 'edit' operation
 2024-04-22 05:42:44 -04:00
Philippe Guibert
ad874c7d3b isisd: fix renaming backup define for ENDX SID 
The define has inheritated from a wrong naming in sr-mpls.
Fix this by renaming ISIS_SRV6_LAN_BACKUP to ISIS_SRV6_ADJ_BACKUP.

Fixes: 2566656a6f ("isisd: Add data structure for SRv6 Adjacency SIDs")

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2024-04-22 10:00:07 +02:00
Piotr Suchy
0a17289a3b vtysh, lib: fix 'show ip[v6] prefix-list ... json' formatting by moving it to vtysh 
Json output is not valid for 'show ip[v6] prefix-list ... json' commands,
as it goes through all the running daemons and for each one it calls
'vty_show_prefix_list' creating a new json object. To aggreagate the output
and create a valid json that can be parsed, the commands were moved to vtysh.

Before:
{
  "ZEBRA":{
    "DEFAULT":{
      "addressFamily":"IPv4",
      "entries":[
        {
          "sequenceNumber":10,
          "type":"permit",
          "prefix":"0.0.0.0/0"
        }
      ]
    }
  }
}
{
  "OSPF":{
    "DEFAULT":{
      "addressFamily":"IPv4",
      "entries":[
        {
          "sequenceNumber":10,
          "type":"permit",
          "prefix":"0.0.0.0/0"
        }
      ]
    }
  }
}
{
  "BGP":{
    "DEFAULT":{
      "addressFamily":"IPv4",
      "entries":[
        {
          "sequenceNumber":10,
          "type":"permit",
          "prefix":"0.0.0.0/0"
        }
      ]
    }
  }
}

After:
{"zebra":{
  "DEFAULT":{
    "addressFamily":"IPv4",
    "entries":[
      {
        "sequenceNumber":10,
        "type":"permit",
        "prefix":"0.0.0.0/0"
      }
    ]
  }
}
,"ospfd":{
  "DEFAULT":{
    "addressFamily":"IPv4",
    "entries":[
      {
        "sequenceNumber":10,
        "type":"permit",
        "prefix":"0.0.0.0/0"
      }
    ]
  }
}
,"bgpd":{
  "DEFAULT":{
    "addressFamily":"IPv4",
    "entries":[
      {
        "sequenceNumber":10,
        "type":"permit",
        "prefix":"0.0.0.0/0"
      }
    ]
  }
}
}

Signed-off-by: Piotr Suchy <piotrsuchy@proton.me>
 2024-04-21 23:40:06 +02:00
Donatas Abraitis
83109e3f66 bgpd: Do not reset the session when toggling dynamic capability 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-21 22:29:32 +03:00
Donald Sharp
7ba58e97ff
Merge pull request #15738 from idryzhov/bfd-cbit 
bfdd: fix BFD_GETCBIT
 2024-04-21 10:59:11 -04:00
Donatas Abraitis
70631acbb8 bgpd: Inherit capability dynamic flag from the peer-group 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-21 14:19:12 +03:00
Donatas Abraitis
9c9f9ce3c1 bgpd: Inherit capability software-version flag from the peer-group 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-21 14:18:39 +03:00
Donatas Abraitis
6486afe8d5 bgpd: Inherit enforce-first-as flag from the peer-group 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-21 14:16:49 +03:00
Igor Ryzhov
99a723e5a8
Merge pull request #15803 from LabNConsulting/chopps/add-missing-zif-type 
yang: add missing `zif-gre` zebra interface type
 2024-04-20 21:25:28 +03:00
Donald Sharp
0ff8034e9a
Merge pull request #15798 from opensourcerouting/fix/show_route_map 
vtysh: Fix `show route-map` command when calling via `do`
 2024-04-20 09:05:39 -04:00
Christian Hopps
74fb4056cb yang: add missing zif-gre zebra interface type 
This was caught by the grpc_basic test which was receiving an invalid error
result, which was returned b/c inside zebra the libyang code was flagging the
value as invalid for a derived zebra interface type.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2024-04-20 08:04:00 -04:00
Christian Hopps
36b7c68111 tests: improve coverage no need to modify source/build dir 
- by using symlinks in the rundir (/tmp) into the source/build directory
we avoid needing to copy the *.gcda stat files into the source/build dir.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2024-04-20 04:31:03 -04:00
Donatas Abraitis
0605ec9f84
Merge pull request #15472 from louis-6wind/ipv6-table-direct 
bgpd: add redistribute table-direct command for ipv6-unicast
 2024-04-20 11:28:04 +03:00
Christian Hopps
44f5916d70 tests: update munet to 0.14.0 release 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2024-04-20 03:29:03 -04:00
Donald Sharp
855fa82f37
Merge pull request #15792 from opensourcerouting/fix/bgp_send_notification_with_data 
bgpd: Include capabilities when sending NOTIFICATION(7)
 2024-04-19 13:25:50 -04:00
Donatas Abraitis
9b8f18a66c vtysh: Fix show route-map command when calling via do 
Before:

```
ton(config)# do sh route-map
% [ZEBRA] Unknown command: show route-map
% [BGP] Unknown command: show route-map
% [ISIS] Unknown command: show route-map
```

Fixes: 570fdc55fd ("lib,vtysh: fix show route map JSON output")

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-04-19 19:17:11 +03:00
Renato Westphal
790c207fa9 tests: fix BFD C-bit topotest 
When a BFD down notification is received and the C-bit is set in both
directions, any ongoing graceful restart should be aborted and stale
routes removed from the RIB.

This commit updates the `bfd_bgp_cbit_topo3` topotest accordingly to
fix the expected outcomes in the `test_bfd_loss_intermediate` test.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2024-04-18 18:28:36 -03:00