Commit Graph

35483 Commits

Author SHA1 Message Date
Mark Stapp
7a28f78ad9 pathd: retry synchronous label-manager zapi connection
Be prepared to retry setting up pathd's synchronous zapi session
that's used for label-manager.

Signed-off-by: Mark Stapp <mjs@cisco.com>
2024-04-30 14:33:13 -04:00
Ruben Kerkhof
9824f07b02
lib: fix error on MacOS
Sections use a different syntax for Mach-O executables.

Fixes:

lib/bfd.c:35:1: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a
      comma
DEFINE_MTYPE_STATIC(LIB, BFD_INFO, "BFD info")
^
./lib/memory.h:140:2: note: expanded from macro 'DEFINE_MTYPE_STATIC'
        DEFINE_MTYPE_ATTR(group, name, static, desc)                           \
        ^
./lib/memory.h:110:26: note: expanded from macro 'DEFINE_MTYPE_ATTR'
                __attribute__((section(".data.mtypes"))) = { {                 \
                                       ^
1 error generated.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
2024-04-30 20:24:17 +03:00
Olivier Dugeon
8deba1e48d
Merge pull request #15791 from zhou-run/202404182042
isisd: When the ISIS instance does not exist, the default metric will not be wide.
2024-04-30 16:33:48 +02:00
Olivier Dugeon
5a373ce912
Merge pull request #15653 from pguibert6WIND/link_state_srv6_capas
Link state srv6 capas
2024-04-30 15:39:11 +02:00
David Lamparter
342400e7c6 build: link libatomic if available
It'll generally exist but be empty on systems that don't need it.
(Some 32bit platforms now need it due to 64bit time_t, and the platform
may not have 64bit atomic ops.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2024-04-30 14:31:07 +02:00
Bing Shui
d733fe2c04 ospfd:fix the bug where ip_ospf_dead-interval_minimal_hello-multiplier did not reset hello timer
Signed-off-by: Bing Shui <652023330037@smail.nju.edu.cn>
2024-04-30 12:07:11 +00:00
Donatas Abraitis
65c3b1e4c8
Merge pull request #15669 from poojarathore30/listen-limit-logging
bgpd : Ensure logging for dynamic neighbor listen limit reached
2024-04-30 14:54:19 +03:00
Donatas Abraitis
9ebdb8e80d bgpd: Apply NOOP when doing negative commands for GR operations
E.g.:

```
% The Graceful Restart command used is not valid at this moment.
zsh: exit 1     vtysh -c configure -c 'router bgp' -c 'no neighbor 127.0.0.1 graceful-restart
1
```

This does not make sense frr-reload to fail.

Instead, just ignore such requests if they are just NOOP.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-30 13:44:18 +03:00
Donatas Abraitis
7b5595b61d bgpd: Print old/new states of graceful restart FSM
To better debug what's going on before/after.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-30 13:44:17 +03:00
Philippe Guibert
f101108e3e bgpd: fix covery ID 1585206
The return value of bgp_getsockname() should always be
checked.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2024-04-29 15:44:24 +02:00
Donald Sharp
65c2593a12
Merge pull request #15619 from opensourcerouting/fix/memory_optimizations
bgpd: Put BGP_DEBUG/CONF_BGP_DEBUG under ulikely() optimization
2024-04-29 09:26:03 -04:00
Donald Sharp
611d6ac0d8
Merge pull request #15834 from pguibert6WIND/alias_path_iproute2
tools: add iproute2 alias for pathd daemon
2024-04-29 09:21:48 -04:00
Donald Sharp
edae839119
Merge pull request #15824 from opensourcerouting/fix/ospf_show_non_default
vtysh: Show `ip ospf network ...` even if it's not the same as the interface type
2024-04-29 09:21:09 -04:00
Donald Sharp
8421f6221a
Merge pull request #15839 from opensourcerouting/ospf6-defun-unwreck
ospf6d: fix DEFUN formatting wrecked by clang
2024-04-29 09:18:32 -04:00
Donald Sharp
edac3efdc5
Merge pull request #15864 from opensourcerouting/fix/graceful_restart_per_neighbor
tests: Check if Graceful Restart per-neighbor works as expected
2024-04-29 09:16:36 -04:00
Donald Sharp
f3720c477e
Merge pull request #15865 from opensourcerouting/fix/drop_duplicate_pytestmark
tests: A bit of housekeeping for topotests
2024-04-29 09:14:52 -04:00
rathorepo
fd8d420999 bgpd : Ensure logging for dynamic neighbor listen limit reached
Dynamic neighbors exceeding the listen limit were rejected without appropriate logging.
Previously, only rejection logs were generated, leaving users unaware of when the limit being reached.
Adding a log message for when the listen limit is reached

Signed-off-by: Pooja Rathore <rathorepo@vmware.com>
2024-04-29 08:33:04 +00:00
Donatas Abraitis
2187b82714
Merge pull request #15670 from poojarathore30/pg-deletion-with-listen-range
bgpd : Prevent deletion of BGP peer groups associated to listen range
2024-04-29 11:29:07 +03:00
Donatas Abraitis
5e9e6bf3ed
Merge pull request #15851 from chiragshah6/fdev2
tools: Handle seq num for BGP as-path in frr-reload.py
2024-04-29 11:28:03 +03:00
Donatas Abraitis
eb769bbc30
Merge pull request #15861 from anlancs/fix-bgpd-dead-code
bgpd: fix the dead code
2024-04-29 11:25:20 +03:00
Philippe Guibert
ce614c2971 tools: add iproute2 alias for pathd daemon
With SRv6 traffic engineering, some ipv6 routes will
be installed by the Pathd daemon.
Populate the iproute2 aliasing table with pathd.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2024-04-29 08:20:37 +02:00
Donatas Abraitis
422e0dd256 tests: Apply black formatting from what frrbot suggested to be happy
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-28 12:51:22 +03:00
Donatas Abraitis
2ea6d2cca0 tests: Add missing check_router_status for bgp_tcp_mss test
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-28 12:51:22 +03:00
Donatas Abraitis
9ca4bbd069 tools: Add black formatting commit to .git-blame-ignore-revs
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-28 12:50:51 +03:00
Donatas Abraitis
1a1c2a9f84 tests: Apply black formatting for all tests/topotests
It's just annoying when the linter tells to apply the formatting for the code
you didn't touch.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-27 23:19:32 +03:00
Donatas Abraitis
086df4bfaa tests: Drop duplicate pytestmark per file
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-27 23:18:15 +03:00
Donatas Abraitis
ede5f5092a tests: Drop debug statements from bgp_gr_restart_retain_routes
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-27 23:09:40 +03:00
Donatas Abraitis
e41012bebe tests: Check if Graceful Restart per-neighbor works as expected
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-27 23:06:19 +03:00
Donatas Abraitis
1c1de46878 tests: Use a single frr.conf for bgp_gr_restart_retain_routes
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2024-04-27 23:00:36 +03:00
Donatas Abraitis
5f059e0c7d
Merge pull request #15854 from mjstapp/dump_outofsync_flag
lib: add ZEBRA_FLAG_OUTOFSYNC to dump_flags function
2024-04-27 21:16:49 +03:00
rathorepo
48faeafe16 bgpd : Prevent deletion of BGP peer groups associated to listen range
Description:
-----
Deleting a peer group also deletes its associated BGP listen range.
This behaviour is undesired as it could cause unintended configuration changes.

Fix :
-----
-Do not allow peer group deletion until they are no longer associated with any listen range.
-Check the count of listen ranges attached to the group.
If any listen ranges are found, returns a configuration warning, preventing the deletion.

Signed-off-by: Pooja Rathore <rathorepo@vmware.com>
2024-04-27 16:44:26 +00:00
anlan_cs
e942d1f6a2 bgpd: fix the dead code
Fixed the Coverity issue 1586018:
Control flow issues (DEADCODE) /bgpd/bgp_ecommunity.c: 1402 in ecommunity_ecom2str()

Signed-off-by: anlan_cs <anlan_cs@tom.com>
2024-04-28 00:05:36 +08:00
Russ White
1a9c3a710d
Merge pull request #15782 from opensourcerouting/fix/drop_srte_color_flag
bgpd: Drop SRTE_COLOR attribute flag
2024-04-27 08:19:09 -04:00
Jafar Al-Gharaibeh
3ab578d504
Merge pull request #15848 from donaldsharp/pim_crash_dnode
pimd: fix crash unconfiguring rp keepalive timer
2024-04-26 22:28:10 -05:00
Donatas Abraitis
24a9f1c9ae
Merge pull request #15796 from LabNConsulting/aceelindem/ospf-ospfapi-options
ospfd: OSPFAPI Server options to limit to local connections and per-instance TCP
2024-04-26 23:31:38 +03:00
Donatas Abraitis
223eda3d00
Merge pull request #15759 from anlancs/doc-isisd-cleanup-1
doc: clean up a few commands for isis
2024-04-26 23:29:58 +03:00
Donatas Abraitis
524e08c4d6
Merge pull request #15737 from vjardin/cmake_install_prefix
cmake install prefix
2024-04-26 23:29:29 +03:00
Donatas Abraitis
03a4765cda
Merge pull request #15841 from pguibert6WIND/dx6_support
zebra, sharpd: add srv6 End.DX6 support
2024-04-26 23:25:34 +03:00
Donatas Abraitis
d3c556652a
Merge pull request #15845 from pguibert6WIND/bmp_improvements
Bmp improvements about statistics
2024-04-26 23:24:54 +03:00
Mark Stapp
c943b71c9f lib: add ZEBRA_FLAG_OUTOFSYNC to dump_flags function
Right where the zapi route flags are defined, there's a comment
asking that the flag-dumper-function also be updated.

Also apply clang-format's preferences, so next person won't have
to.

Signed-off-by: Mark Stapp <mjs@cisco.com>
2024-04-26 14:48:00 -04:00
Russ White
f19817f71d
Merge pull request #15723 from opensourcerouting/feature/extended_link_bw_refactored_v1
bgpd: Implement extended link-bandwidth
2024-04-26 14:41:05 -04:00
Donald Sharp
6a7fadaecc
Merge pull request #15588 from opensourcerouting/sqlite-filename-size
lib: fix SQLite dbfile path length
2024-04-26 10:19:05 -04:00
Vijayalaxmi Basavaraj
0c4b7c1f1f pimd: fix crash unconfiguring rp keepalive timer
pimd crashs while unconfigure of rp ka timer as we are trying to access
a yand dnode(suppress timer) which does not exist at the moment.

User just configured rp keepalive timer and not suppress timer,
the yang dnode would not be present. Instead of directly accessing
yang_dnode_get_unit16, first check the yang node exist using
the xpath.

Ticket: #3874971

Testing:

Before:
------
tor-11(config)# no ip pim rp keep-alive-timer 3000
vtysh: error reading from pimd: Success (0)Warning: closing connection to pimd because of an I/O error!

Broadcast message from root@tor-11 (somewhere) (Mon Apr 22 17:29:12 2024):

cumulus-core: Running cl-support for core files "pimd.25467.1713806952.core"

After:
-----
tor-11(config)# no ip pim rp keep-alive-timer 3000
tor-11(config)#

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Vijayalaxmi Basavaraj <vbasavaraj@nvidia.com>
2024-04-26 10:14:24 -04:00
Mark Stapp
76dbfc148c
Merge pull request #15843 from opensourcerouting/yang-link-netconf-acm
yang: ietf-netconf-acm needs to be in libfrr
2024-04-26 09:31:44 -04:00
Mark Stapp
8d2c255d26
Merge pull request #15850 from donaldsharp/sa_clang_15_some_problems
bgpd: Remove unused addition found in clang
2024-04-26 08:01:26 -04:00
Donald Sharp
f8e9f7fb0e
Merge pull request #15744 from pguibert6WIND/snmp_oid_line73_error
topotests: lib, fix filter out "At line 73 in /usr/share/snmp/mibs/ie…
2024-04-26 07:38:42 -04:00
Donatas Abraitis
d42c4c08e8
Merge pull request #15849 from donaldsharp/redistibute_doc_change
bgpd: Explain Better admin w/ redistribution a bit better.
2024-04-26 12:52:37 +03:00
Philippe Guibert
500227ae76 bgpd: add bmp loc-rib 64 bit gauge value
There is no support for option 8, as per RFC7854.
Add the 64 bit counter in the peer structure.
Add the missing per peer statistic.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2024-04-26 08:12:41 +02:00
Philippe Guibert
7ba991cf96 bgpd: add 'bmp stat send-experimental' command
Some wireshark versions can not decode the experimental
bmp stat code. This may also be the case for some collectors.
Add a vty command to be able to disable bmp to sending
those values.

> [no] bmp stat send-experimental

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2024-04-26 08:12:38 +02:00
Philippe Guibert
e6374a20f3 bgpd: add bmp adj-rib-in 64 bit gauge value
There is no support for option 7, as per RFC7854.
Add the 64 bit counter in the peer structure.
Add the 64 bit bmp value write api.
Add the missing per peer statistic.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2024-04-26 08:11:44 +02:00