mobash-rasool
0cd8bce123
Merge pull request #10813 from opensourcerouting/fix/include_prune_stats_for_pim_traffic_interface
...
pimd: Include pruneTx/pruneRx for `show ip pim interface traffic WORD…
2022-03-17 23:36:30 +05:30
Donald Sharp
f2ad96a2e8
Merge pull request #10801 from mobash-rasool/fixes
...
tests: Adding database info in the script to ease debug
2022-03-17 09:50:03 -04:00
Donald Sharp
79bfe9a1ba
Merge pull request #10812 from opensourcerouting/fix/pim_igmp_statistics_per_group
...
pimd: Show all groups matched by an arbitrary prefix for `pim rp-info`
2022-03-17 08:21:10 -04:00
Donatas Abraitis
7d0bc72987
pimd: Include pruneTx/pruneRx for show ip pim interface traffic WORD json
...
```
exit1-debian-11# sh ip pim interface traffic eth2 json
{
"eth2":{
"name":"eth2",
"state":"up",
"address":"192.168.10.123",
"index":4,
"flagMulticast":true,
"flagBroadcast":true,
"lanDelayEnabled":true,
"helloRx":2,
"helloTx":2,
"joinRx":0,
"joinTx":1,
"pruneRx":0,
"pruneTx":0,
"registerRx":0,
"registerTx":0,
"registerStopRx":0,
"registerStopTx":0,
"assertRx":0,
"assertTx":0,
"bsmRx":0,
"bsmTx":0
}
}
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-03-17 10:00:02 +02:00
Donatas Abraitis
c07ddc3656
pimd: Show all groups matched by an arbitrary prefix for pim rp-info
...
```
r1# show ip pim rp-info
RP address group/prefix-list OIF I am RP Source Group-Type
192.168.10.123 225.0.0.0/24 eth2 yes Static ASM
192.168.10.123 239.0.0.0/8 eth2 yes Static ASM
192.168.10.123 239.4.0.0/24 eth2 yes Static SSM
r1# show ip pim rp-info 239.4.0.0/25
RP address group/prefix-list OIF I am RP Source Group-Type
192.168.10.123 239.0.0.0/8 eth2 yes Static ASM
192.168.10.123 239.4.0.0/24 eth2 yes Static SSM
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-03-17 09:38:22 +02:00
Mobashshera Rasool
a73e89ddbc
tests: Adding database information in ospfv3 testcase
...
Improving the test case to show database info as well
to help narrow down whether its a LSA origination problem or
route calculation problem in case of failures.
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-03-16 23:59:05 -07:00
Jafar Al-Gharaibeh
30ba0aaa7f
Merge pull request #10807 from donaldsharp/wheel_typo
...
lib: wheel's typo fix
2022-03-16 20:40:18 -05:00
Jafar Al-Gharaibeh
d6d0d718b0
Merge pull request #10806 from donaldsharp/dplane_fixup_for_lua
...
zebra: Fixup lua with new dplane ops
2022-03-16 16:38:01 -05:00
Donald Sharp
60cd8d3b14
Merge pull request #10790 from anlancs/zebra-adjust-flag
...
zebra: minor changes on "zebra_evpn_mac_gw_macip_add" function
2022-03-16 16:25:24 -04:00
ron
5e7d0337f6
lib: wheel's typo fix
...
The wheel data structure is a array of list pointers
but the alloc for it is using the sizeof (struct listnode *)
as the amount to allocate. Even though the (struct listnode *)
and (struct list *) sizes are the same, let's list the correct
values.
Signed-off-by: ron <lyq140hf2006@163.com>
2022-03-16 15:32:50 -04:00
Donald Sharp
105271792d
zebra: Fixup lua with new dplane ops
...
Commit: 5d41413833
added 3 new dplane ops:
DPLANE_OP_INTF_INSTALL
DPLANE_OP_INTF_UPDATE
DPLANE_OP_INTF_DELETE
The build system does not build lua so zebra_script.c
was not updated. Update of course!
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-03-16 15:10:54 -04:00
Donald Sharp
335b15ebe0
Merge pull request #10797 from fabioantonini/sysrepo-2.0.41-support
...
support to sysrepo-2.0.41
2022-03-16 14:33:53 -04:00
Donald Sharp
5d056cbf25
Merge pull request #10803 from anlancs/bgpd-remove-dead-l2vpn
...
bgpd: remove dead code
2022-03-16 14:29:42 -04:00
Donald Sharp
b89c8bdc10
Merge pull request #10804 from LabNConsulting/chopps/coverity-1
...
lib: grpc: fix covevrity warnings
2022-03-16 14:29:18 -04:00
Jafar Al-Gharaibeh
51012eb636
Merge pull request #9262 from gpnaveen/ospfv3_basic_tests
...
tests: adding ospfv3 base cases.
2022-03-16 11:06:19 -05:00
Christian Hopps
ad6bd53692
lib: grpc: fix covevrity warnings
...
One uninit warning and one missing lock warning, both were OK but
let's make the tool happy.
Signed-off-by: Christian Hopps <chopps@labn.net>
2022-03-16 11:31:50 -04:00
David Lamparter
b928f0a6b7
Merge pull request #10755 from patrasar/enable_pimv6
2022-03-16 16:13:56 +01:00
Donald Sharp
79f4d05c7a
Merge pull request #10798 from Jafaral/topo-detect-pim
...
topotest: enable pim when detecting `ip pim` using unified config
2022-03-16 10:28:56 -04:00
anlan_cs
d58f056ab7
bgpd: remove dead code
...
`bgp_evpn_import_route_in_vrfs()` is special ( l2vpn ) form of
`install_uninstall_evpn_route() with `AFI_L2VPN` and `SAFI_EVPN` family.
No caller, just remove it.
Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-03-16 21:06:46 +08:00
Donald Sharp
bf1bf09616
Merge pull request #10653 from g-balaji1/pimv6-ssm
...
pim6d: pim_ssmpingd changes to support PIMv6
2022-03-16 08:40:29 -04:00
Donatas Abraitis
f1ea200891
Merge pull request #10763 from donaldsharp/plist_speedup
...
lib: Convert prefix_master->str to a RB Tree
2022-03-16 13:42:18 +02:00
Donald Sharp
c77ae9a943
Merge pull request #10799 from Jafaral/ospf-not-running
...
ospfd: better error messages when not enabled in a vrf
2022-03-16 07:38:28 -04:00
Balaji Gurudoss
1c56018f66
pim6d: Changes done in pim_ssmpingd to support v6
...
Signed-off-by: Balaji Gurudoss <G_Balaji1@dell.com>
2022-03-16 13:54:24 +05:30
sarita patra
8fc3ba676e
pim6d: Enable protocol as VTYSH_PIM6D for pim6_cmd.c
...
Signed-off-by: sarita patra <saritap@vmware.com>
2022-03-15 23:16:41 -07:00
Jafar Al-Gharaibeh
fbaafa0082
ospfd: better error messages when not enabled in a vrf
...
before:
```
r1# show ip ospf vrf blue
% OSPF instance not found
r1# show ip ospf vrf default
% OSPF instance not found
r1# show ip ospf
% OSPF instance not found
```
after:
```
r1# show ip ospf vrf blue
% OSPF is not enabled in vrf blue
r1# show ip ospf vrf default
% OSPF is not enabled in vrf default
r1# show ip ospf
% OSPF is not enabled in vrf default
```
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2022-03-16 00:59:26 -05:00
Jafar Al-Gharaibeh
93a7f236ac
topotest: enable pim when detecting pim using unified config
...
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2022-03-15 22:29:52 -05:00
nguggarigoud
d1b5fa5b9e
tests: adding ospfv3 base cases.
...
Covers basic test case like route map, rte calc.
Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
2022-03-15 19:58:51 -07:00
Russ White
5d97021ba3
Merge pull request #10427 from sworleys/Protodown-Reason-Upstream
...
Add Support for Setting Protodown Reason Code
2022-03-15 19:58:16 -04:00
Donald Sharp
b975463458
Merge pull request #10643 from Jafaral/ospf-multi-vrf
...
tests: add a topotest for ospf, mutli vrf, and route leaking
2022-03-15 18:58:03 -04:00
Jafar Al-Gharaibeh
83e839d6b6
topotests: pytest mark bgpd
...
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2022-03-15 15:55:26 -05:00
Sri Mohana Singamsetty
3d58538a75
Merge pull request #10770 from chiragshah6/evpn_dev3
...
zebra: evpn disable remove l2vni from l3vni list
2022-03-15 12:32:22 -07:00
Donald Sharp
2ea93eb023
Merge pull request #10580 from leonshaw/fix/link-ns
...
zebra: Lookup linked interface in link netns
2022-03-15 15:23:18 -04:00
Donald Sharp
ed03d4d03b
Merge pull request #10791 from opensourcerouting/feature/igmp_stats_total_received_message
...
pimd: Add additional IGMP stats (peak number of groups)
2022-03-15 15:14:37 -04:00
Donald Sharp
30119c81d2
Merge pull request #10794 from opensourcerouting/fix/do_not_print_empty_stats_for_non_existing_interface
...
pimd: Return empty JSON if we query non existing interface for IGMP s…
2022-03-15 15:13:23 -04:00
Fabio Antonini
7b73f3db94
lib: support to sysrepo-2.0.41
...
northbound_sysrepo.c fixed to use the newer APIs from sysrepo 2.0.41
Signed-off-by: Fabio Antonini <f.antonini@tiesse.com>
2022-03-15 16:30:00 +01:00
Donatas Abraitis
42982834d4
pimd: Return empty JSON if we query non existing interface for IGMP stats
...
Now we return all zeroed stats, which seems wrong. Handle the same way, as
with PIM interfaces. Return empty JSON and a warning for VTYSH.
```
exit1-debian-11# sh ip igmp statistics interface belekas
% No such interface
exit1-debian-11# sh ip igmp statistics interface belekas json
{
}
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-03-15 17:08:35 +02:00
Donatas Abraitis
a191345424
Merge pull request #10792 from donaldsharp/pim_blargle
...
Fix up #6058
2022-03-15 16:22:37 +02:00
Donald Sharp
6a68f0ecab
Merge pull request #10796 from anlancs/bgpd-zebra-newline
...
bgpd: add new line for prompt of "no router bgp"
2022-03-15 09:40:44 -04:00
anlan_cs
be125e6fe5
bgpd: add new line for prompt of "no router bgp"
...
Simple prompt issue.
"no router bgp <ASN>" is ok, but "no router bgp" without <ASN> missed "\n".
Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-03-15 09:55:28 -04:00
Donald Sharp
7344eb1f62
Merge pull request #10739 from LabNConsulting/chopps/fixgrpc-reorg
...
grpc, lib: grpc cleanup/reorg
2022-03-15 09:10:03 -04:00
Donald Sharp
d09a7c82c9
Merge pull request #10565 from lyq140/patch-thread
...
lib: not thread off when schedule
2022-03-15 08:40:41 -04:00
Donatas Abraitis
baa57b7282
Merge pull request #10583 from donaldsharp/pim_upstream_timers
...
pimd: Ensure timers are stopped on instance shutdown
2022-03-15 14:35:30 +02:00
Donald Sharp
052b0eee2a
Merge pull request #10693 from anlancs/bgpd-add-check-ns
...
zebra: use "assert" instead of unnecessary check
2022-03-15 08:27:44 -04:00
Donatas Abraitis
3e5d8665f6
pimd: Add additional IGMP stats (peak number of groups)
...
```
exit1-debian-11# sh ip igmp statistics interface eth2
IGMP statistics
Interface : eth2
V1 query : 0
V2 query : 0
V3 query : 25
V2 leave : 0
V1 report : 0
V2 report : 0
V3 report : 34
mtrace response : 0
mtrace request : 0
unsupported : 0
joins failed : 0
joins sent : 13
general queries sent : 2
group queries sent : 24
peak groups : 9
total groups : 4
total source groups : 1
exit1-debian-11# sh ip igmp statistics interface eth2 json
{
"eth2":{
"name":"eth2",
"queryV1":0,
"queryV2":0,
"queryV3":25,
"leaveV2":0,
"reportV1":0,
"reportV2":0,
"reportV3":34,
"mtraceResponse":0,
"mtraceRequest":0,
"unsupported":0,
"peakGroups":9,
"totalGroups":4,
"totalSourceGroups":1,
"joinsFailed":0,
"joinsSent":13,
"generalQueriesSent":2,
"groupQueriesSent":24
}
}
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-03-15 14:08:35 +02:00
Donald Sharp
cde5655bf4
Merge pull request #10793 from opensourcerouting/feature/igmp_stats_total_received_messages
...
pimd: Show total received messages IGMP stats
2022-03-15 07:56:00 -04:00
Donald Sharp
6ec6186af9
Merge pull request #10012 from AbhishekNR/upstream
...
pimd : Handling of Exclude mode IGMPv3 report messages for SSM aware group.
2022-03-15 07:54:04 -04:00
Donatas Abraitis
ca3e7807f6
pimd: Show total received messages IGMP stats
...
```
exit1-debian-11# do sh ip igmp statistics
IGMP statistics
Interface : global
V1 query : 0
V2 query : 0
V3 query : 3
V2 leave : 0
V1 report : 0
V2 report : 0
V3 report : 18
mtrace response : 0
mtrace request : 0
unsupported : 0
total received messages : 21
joins failed : 0
joins sent : 16
general queries sent : 6
group queries sent : 3
total groups : 4
total source groups : 1
exit1-debian-11# do sh ip igmp statistics json
{
"global":{
"name":"global",
"queryV1":0,
"queryV2":0,
"queryV3":4,
"leaveV2":0,
"reportV1":0,
"reportV2":0,
"reportV3":18,
"mtraceResponse":0,
"mtraceRequest":0,
"unsupported":0,
"totalReceivedMessage":22,
"totalGroups":3,
"totalSourceGroups":1,
"joinsFailed":0,
"joinsSent":16,
"generalQueriesSent":6,
"groupQueriesSent":4
}
}
```
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-03-14 22:49:23 +02:00
Christian Hopps
48c93061f5
lib: grpc: rework RPC handlers improve code clarity
...
- split NewRpcState object into 2, a Unary and a Streaming variant, which
then allows for the next.
- move all state machine details inside these new state objects
- use a template arg to allow for Streaming state tracking object
creation and deletion w/o requiring this in each specific RPC
hander.
- Code is more rugged by design now.
Thanks to Rafael Zalamena <rzalamena@opensourcerouting.org> for the cleanup
ideas/motivation.
Signed-off-by: Christian Hopps <chopps@labn.net>
2022-03-14 15:54:25 -04:00
Donald Sharp
1aa3f6b199
pimd: A wrong address family means the register-stop receive fails
...
The current code in pim_register_stop_recv would never fail as
that the code was always returning 0 in all cases, but
if the code parses an incorrect afi then it has failed and
should return as much
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-03-14 15:52:37 -04:00
saravanank
03f9d812f9
pimd: FRR-PIM sending register packet even after receiving (*,G) register stop
...
RCA: (*,G) register stop was not handled
Fix: Loop through all (S,G) under the (*,G) and apply reg stop
Authored-by- Saravanan K <saravanank@vmware.com>
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-03-14 15:48:07 -04:00