Commit Graph

29586 Commits

Author SHA1 Message Date
Russ White
07ab30b5a4
Merge pull request #12006 from opensourcerouting/fix/doc_for_rfc9072
doc: Add `neighbor PEER extended-optional-parameters` command
2022-09-27 11:28:06 -04:00
Russ White
ee42846bea
Merge pull request #12010 from opensourcerouting/fix/logging_for_route_refresh
bgpd: Print hostname for peer as well when marking as stale for route-refresh
2022-09-27 11:27:12 -04:00
Russ White
66a9f669bc
Merge pull request #12016 from opensourcerouting/fix/route_map_show_json
lib: Fix `show route-map NAME json` command and memory leak
2022-09-27 11:26:28 -04:00
Donatas Abraitis
0d8f9f091b
Merge pull request #11989 from maduri111/bgpd-cond-adv-peer-unset
bgpd: conditional advertise-map unset on peer not re-advertising with…
2022-09-27 15:03:58 +03:00
Olivier Dugeon
031561497c
Merge pull request #11910 from fdumontet6WIND/NAI_Adj
pathd: nai adjacency fix query type f for IPV6
2022-09-27 11:24:53 +02:00
Donatas Abraitis
77c5f1b936
Merge pull request #12009 from AbhishekNR/json_last-member-query-count
pim6d: Adding last member query count field in "show ipv6 mld interface [ifname] json" command.
2022-09-27 09:42:11 +03:00
Donald Sharp
b2328784cb
Merge pull request #12002 from opensourcerouting/fix/add_doc_missing_bgp_implemented_rf
doc: Update supported BGP RFC list
2022-09-26 09:07:22 -04:00
Donald Sharp
d8cb344c36
Merge pull request #12000 from opensourcerouting/fix/remove_deprecated_ospf_command
ospfd: Remove deprecated command `graceful-restart helper-only`
2022-09-26 08:44:40 -04:00
Donald Sharp
1e7602aa9b
Merge pull request #12003 from anlancs/fix/fpm-crash
zebra: fix fpm crash
2022-09-26 08:43:40 -04:00
Donatas Abraitis
4c17bee53f lib: Fix show route-map NAME json command and memory leak
JSON object was generated, but not printed, because the function returned
immediatelly, even without freeing the memory.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26 14:56:20 +03:00
Donatas Abraitis
58e111f65c bgpd: Print hostname for peer as well when marking as stale for route-refresh
Before:

```
2022/09/26 10:13:35.261 BGP: [QCZ1W-VKS36] 192.168.0.1(r0) sending REFRESH_REQ for afi/safi: IPv4/unicast
2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 172.16.1.1/32 as stale
2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 192.168.0.0/24 as stale
2022/09/26 10:13:35.262 BGP: [SDZS7-XVC4W] 192.168.0.1(r0) rcvd route-refresh (BoRR) for IPv4/unicast, triggering timer for 360 seconds
2022/09/26 10:13:35.362 BGP: [Y6XKR-PF89P] 192.168.0.1(r0) rcvd route-refresh (EoRR) for IPv4/unicast, stopping BoRR timer
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26 11:13:40 +03:00
Abhishek N R
6b94500dba pim6d: Adding last member query count field in "show ipv6 mld interface [ifname] json" command.
Fixes: #12004

Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-26 00:10:58 -07:00
Donatas Abraitis
1311166751 doc: Add neighbor PEER extended-optional-parameters command
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25 21:43:41 +03:00
Donatas Abraitis
2a3a758533 doc: Update supported BGP RFC list
Added such RFCs (missing):

https://datatracker.ietf.org/doc/html/rfc2385
https://datatracker.ietf.org/doc/html/rfc2918
https://datatracker.ietf.org/doc/html/rfc4360
https://datatracker.ietf.org/doc/html/rfc4456
https://datatracker.ietf.org/doc/html/rfc4724
https://datatracker.ietf.org/doc/html/rfc4760
https://datatracker.ietf.org/doc/html/rfc5065
https://datatracker.ietf.org/doc/html/rfc5291
https://datatracker.ietf.org/doc/html/rfc5292
https://datatracker.ietf.org/doc/html/rfc6472
https://datatracker.ietf.org/doc/html/rfc5492
https://datatracker.ietf.org/doc/html/rfc7911
https://datatracker.ietf.org/doc/html/rfc6996
https://datatracker.ietf.org/doc/html/rfc6938
https://datatracker.ietf.org/doc/html/rfc8093
https://datatracker.ietf.org/doc/html/rfc7947
https://datatracker.ietf.org/doc/html/rfc9012
https://datatracker.ietf.org/doc/html/rfc8669
https://datatracker.ietf.org/doc/html/rfc8050

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25 11:58:10 +03:00
Donatas Abraitis
760863701e
Merge pull request #12001 from donaldsharp/use_integrated
doc: Align docs to recommend integrated config
2022-09-25 11:44:42 +03:00
Madhuri Kuruganti
b9fdddb83b bgpd: conditional advertise-map unset on peer fixing warning messages
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25 11:48:47 +05:30
Madhuri Kuruganti
1285c4ace9 bgpd: conditional advertise-map unset on peer not re-advertising withdrawn routes
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25 11:48:47 +05:30
anlan_cs
0d0f516c76 zebra: fix fpm crash
Fix issue#11996.

When removing VRF ( all routes of this VRF), zebra mistakenly forgot to check
whether its routes are in update queue of FPM.  So FPM module will crash during
its dealing with these routes, which are already freed.

Add a new HOOK `rib_shutdown()`, `zebra_rtable_node_cleanup()` will use it
to remove these routes from update queue of FPM module before freeing them.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-09-24 19:39:58 -04:00
Donald Sharp
9b953119b4 doc: Align docs to recommend integrated config
Docs were recommending both integrated and non-integrated
config in different sections.  Remove the recommendation
for non-integrated config from vtysh.rst.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-23 15:16:40 -04:00
Donatas Abraitis
083e241235 ospfd: Remove deprecated command graceful-restart helper-only
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-23 22:10:44 +03:00
Donatas Abraitis
344d81ceed
Merge pull request #11982 from samanvithab/bgp_mem_fix
bgpd: multiple memory leak issue fixes
2022-09-23 17:54:33 +03:00
Samanvitha B Bhargav
b96b4f1c5f bgpd: Cleanup memory leaks associated with t_deferral_timer
We are allocating temporary memory for information about
what to process in this thread, which is not being cleaned
up on thread cancelling.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-23 00:14:12 -07:00
Donatas Abraitis
f731266e95
Merge pull request #11997 from sri-mohan1/sri-zebra-dbg1
zebra: changes for code maintainability
2022-09-23 10:04:25 +03:00
sri-mohan1
a843c5ba2a zebra: changes for code maintainability
these changes are for improving the code maintainability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2022-09-23 09:57:35 +05:30
Donald Sharp
9e3b5187b7
Merge pull request #11993 from opensourcerouting/feature/printfrr_pRD
bgpd: Use %pRD for prefix_rd2str()
2022-09-22 09:30:51 -04:00
Donald Sharp
f25d47d2ef
Merge pull request #11979 from opensourcerouting/fix/stop_conditional_adv_thread
bgpd: Stop conditional advertisements thread when terminating
2022-09-22 09:30:01 -04:00
Donatas Abraitis
c4f64ea94d bgpd: Use %pRD for prefix_rd2str()
Convert a bunch of prefix_rd2str() for json/vty stuff.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-22 13:12:11 +03:00
Donatas Abraitis
c0539ff458 bgpd: Stop conditional advertisements thread when terminating
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-22 10:30:13 +03:00
Donald Sharp
447d0fc290
Merge pull request #11986 from opensourcerouting/fix/drop_outdated_files
bgpd: Drop out-of-date files
2022-09-21 12:56:25 -04:00
Donatas Abraitis
bdc33d0b13 bgpd: Drop out-of-date files
Just not maintained for > 18 years.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21 17:21:31 +03:00
Donald Sharp
6db5e4c11a
Merge pull request #11977 from opensourcerouting/fix/docker_alpine_apk
docker: Keep and copy .apk files after they are built
2022-09-21 10:15:49 -04:00
Samanvitha B Bhargav
2305e3e460 bgpd: memory leak issue fix
Memory allocated when 'import vrf route maps <>' is configured,
wasn't being freed when the entire bgp config
was deleted through 'no router bgp'.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:57:09 -07:00
Samanvitha B Bhargav
92d537611b bgpd: memory leak issue fix
In ecommunity_del_val(), ecommunity was not being freed
when the last value in the ecommunity was being deleted.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:45:41 -07:00
Samanvitha B Bhargav
f6a460f982 bgpd: memory leak issue fix
When router id is changed through config, new RD is auto generated.
However new export RT was being assigned without freeing
the older RT from VRF.

Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21 01:44:14 -07:00
Donatas Abraitis
383a873495
Merge pull request #11802 from AbhishekNR/ttable_pim_state
pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command output.
2022-09-21 11:00:40 +03:00
Donatas Abraitis
96e8d5fb04
Merge pull request #11918 from patrasar/show_ipv6_mld_interface_fix
pim6d: "show ipv6 mld interface" command
2022-09-21 10:19:33 +03:00
mobash-rasool
ea59d5e08d
Merge pull request #11968 from donaldsharp/isis_plist_mem_leak
isisd: Fix memory leak on shutdown with prefix lists
2022-09-21 08:22:33 +05:30
Donatas Abraitis
7be59f7b7c docker: Keep and copy .apk files after they are built
For debugging purposes and/or to distribute them somewhere else.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-20 23:23:55 +03:00
Donald Sharp
22432f22da
Merge pull request #11972 from pguibert6WIND/mpls_te_on
pathd: 'no mpls-te on' command was not working
2022-09-20 12:16:56 -04:00
Russ White
78c108ced7
Merge pull request #11952 from anlancs/fix/cleanup-20
include: clean up some white spaces
2022-09-20 11:17:32 -04:00
Russ White
6f42ff7691
Merge pull request #11956 from opensourcerouting/fix/bgpd_unlocks
bgpd: Don't forget bgp_dest_unlock_node before return
2022-09-20 11:17:03 -04:00
Donald Sharp
dcfe3c1611 isisd: Fix memory leak on shutdown with prefix lists
==2623619==
==2623619== 6 bytes in 1 blocks are definitely lost in loss record 3 of 75
==2623619==    at 0x483877F: malloc (vg_replace_malloc.c:307)
==2623619==    by 0x4B55E4A: strdup (strdup.c:42)
==2623619==    by 0x493C992: qstrdup (memory.c:128)
==2623619==    by 0x1A9212: isis_instance_fast_reroute_level_1_remote_lfa_prefix_list_modify (isis_nb_config.c:1599)
==2623619==    by 0x494837C: nb_callback_modify (northbound.c:1083)
==2623619==    by 0x4948C6E: nb_callback_configuration (northbound.c:1352)
==2623619==    by 0x494919D: nb_transaction_process (northbound.c:1473)
==2623619==    by 0x4947DA9: nb_candidate_commit_apply (northbound.c:906)
==2623619==    by 0x4947EBA: nb_candidate_commit (northbound.c:938)
==2623619==    by 0x494EB9E: nb_cli_classic_commit (northbound_cli.c:64)
==2623619==    by 0x494F3DC: nb_cli_apply_changes_internal (northbound_cli.c:250)
==2623619==    by 0x494F4E2: nb_cli_apply_changes (northbound_cli.c:268)
==2623619==    by 0x1BEF0F: isis_frr_remote_lfa_plist_magic (isis_cli.c:1899)
==2623619==    by 0x1B7636: isis_frr_remote_lfa_plist (isis_cli_clippy.c:3406)
==2623619==    by 0x48EBA75: cmd_execute_command_real (command.c:997)
==2623619==    by 0x48EBD4E: cmd_execute_command_strict (command.c:1108)
==2623619==    by 0x48EC1E6: command_config_read_one_line (command.c:1268)
==2623619==    by 0x48EC35B: config_from_file (command.c:1313)
==2623619==    by 0x4999CC1: vty_read_file (vty.c:2347)
==2623619==    by 0x499A4AF: vty_read_config (vty.c:2567)
==2623619==    by 0x4924B12: frr_config_read_in (libfrr.c:984)
==2623619==    by 0x498F5E3: thread_call (thread.c:2008)
==2623619==    by 0x49253DA: frr_run (libfrr.c:1198)
==2623619==    by 0x14FC53: main (isis_main.c:273)

Fix this memory leak

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-20 10:44:42 -04:00
Donald Sharp
fbd3e84531
Merge pull request #11954 from opensourcerouting/fix/ecommunity_memory_leak
bgpd: Free ecommunity before returning on warning/error
2022-09-20 08:18:47 -04:00
Philippe Guibert
cab69e3f3d pathd: 'no mpls-te on' command was not working
Fix the 'no mpls-te on' command.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2022-09-20 14:10:42 +02:00
Donald Sharp
0be32df16e
Merge pull request #11971 from opensourcerouting/fix/coccinelle_route_map_apply
bgpd: Use route_map_result_t for route_map_apply() as return type
2022-09-20 07:32:22 -04:00
Donatas Abraitis
fd283bd250 bgpd: Use route_map_result_t for route_map_apply() as return type
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-20 10:45:02 +03:00
Donatas Abraitis
c4d75d0275
Merge pull request #11958 from AbhishekNR/ttable_show
pimd, pim6d: Using ttable for displaying show command outputs
2022-09-20 09:47:09 +03:00
Donatas Abraitis
e09ce4b894
Merge pull request #11872 from AbhishekNR/const_igmp_gm
pimd, pim6d: Changing IGMP to GM in few macro's.
2022-09-19 17:48:24 +03:00
Mark Stapp
173bdac44b
Merge pull request #11940 from sri-mohan1/sri-zebra-dbg1
zebra: changes for code maintainability
2022-09-19 10:43:38 -04:00
Donatas Abraitis
7877eaf65b
Merge pull request #11953 from AbhishekNR/issue_11925
pim6d: (*,G) mroutes not learnt after pim6d daemon restart
2022-09-19 17:37:04 +03:00