Quentin Young
03ca8d3dff
lib: Check match level when calculating completions
...
Adds a missing check that resulted in partial token
matches being accepted as exact matches when calculating
input completions.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-06 00:03:39 +00:00
Quentin Young
b4f56274fa
lib: Add tracing capabilities to command matcher
...
Compile with -DTRACE_MATCHER to enable matcher
debugging to stdout.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-05 23:56:17 +00:00
Quentin Young
3871154b72
lib: Invalid commands are errors, fix msg formatting
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-05 23:50:49 +00:00
Quentin Young
49d73233c3
zebra: Fix typo in zebra command desc
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-05 23:02:57 +00:00
Quentin Young
cc0a8be633
lib: Allow / and . to match VARIABLE_TKN, fix range matches
...
Range matching function was returning 0 instead of no_match
on failed match, causing all input to match ranges.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 20:56:30 +00:00
Quentin Young
42debbb43d
lib: Add logging for invalid commands
...
Ticket: CM-6855
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 20:41:52 +00:00
Quentin Young
12dcf78e0b
all: Fix various syntax errors
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 19:21:45 +00:00
Quentin Young
98463e0ab7
lib: fix password and enable password syntax
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 18:47:17 +00:00
Quentin Young
ccb8e0c7fb
ospfd, ospf6d, ripd: Fix miscellaneous syntax errors
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 01:13:44 +00:00
Quentin Young
5daa3e5e59
bgpd: Fix off-by-one in clear [ip] bgp...
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-04 00:22:15 +00:00
Quentin Young
268316d185
lib: Clean up completions code, fix segfault on no match
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-03 23:21:11 +00:00
Quentin Young
73baf6a3a6
tools: add copyright header & usage to permutations
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-02 19:30:08 +00:00
Quentin Young
4d12266b80
lib: allow nesting selectors
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-02 19:14:40 +00:00
Quentin Young
96dcc565e6
tools: add command permutations generator
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-02 19:13:59 +00:00
Quentin Young
a78596c42d
lib: explicitly support the case of empty input for completions
...
When the user tab- or ?-completes when the character prior to
the position of the cursor is a space, completion logic is
passed null. Explicitly handle this case instead of using
partly_match, which has special logic associated with it to
allow abbreviating certain tokens.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-02 04:47:31 +00:00
Quentin Young
51d41d759b
lib: Null-terminate tab completions char*[]
...
vtysh expects the result of a tab completion to
have a null pointer as the last element
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-02 03:27:58 +00:00
Quentin Young
c5bd4620b0
lib: Fix command execution npe
...
Caller may pass NULL if it does not care about what
command was matched.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-01 20:05:10 +00:00
Daniel Walton
8de197ce04
bgpd: fix << in command strings
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-10-01 05:45:58 +00:00
Quentin Young
e83a94147f
all: fix sundry syntax errors
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-01 04:20:30 +00:00
Quentin Young
c3f24f0653
lib: Fix '?'-completion dereferences in vtysh
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-10-01 01:03:24 +00:00
Quentin Young
f66625df51
lib: fix double free in parser
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-30 23:16:29 +00:00
Quentin Young
a98d33ab20
lib, vtysh: refactor vtysh.c, allow parser continuance
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-30 23:03:05 +00:00
Quentin Young
76b6abb95a
lib: initialize cmd_vector and add a root node to graph
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-30 19:33:11 +00:00
Daniel Walton
bfbc035bd0
vtysh: fixed compile errors
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 16:10:28 +00:00
Daniel Walton
22b27e9530
ospfd: added some missing <>s
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 16:05:55 +00:00
Daniel Walton
6de69f8305
all: added some missing <>s within []s
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 15:31:48 +00:00
root
7a7be51923
ospfd: resolve argc CHECK MEs in ospf_vty.c
...
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2016-09-30 11:18:14 -04:00
Daniel Walton
273f77435b
bgpd: combine special cases for vrf "all"
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 14:37:36 +00:00
Daniel Walton
4fb25c53b8
bgpd: combine special cases for vrf "all"
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 14:27:04 +00:00
Daniel Walton
8749a04cc2
ospf6d: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 13:39:56 +00:00
Daniel Walton
093d7a3a34
ospf6d: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 13:38:08 +00:00
Daniel Walton
14b16482c4
ospf6d: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 05:09:42 +00:00
Daniel Walton
4e626c014a
ospf6d: clean up command string in CHECK ME comments
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 02:48:58 +00:00
Daniel Walton
1d68dbfe66
ospf6d: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 01:27:05 +00:00
Daniel Walton
58749582a9
all: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-30 00:16:31 +00:00
Quentin Young
d8bd2affd3
isisd: scrub argc CHECK ME's, refactor general
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-29 23:24:52 +00:00
Daniel Walton
abddf07563
all: scrubbed some argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-29 19:51:56 +00:00
Daniel Walton
00d7d2d345
bgpd and zebra: scrubbed argc CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-29 18:21:36 +00:00
Daniel Walton
67656e9b65
all: added CHECK ME for DEFUNs that look at argc
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-29 17:48:57 +00:00
Daniel Walton
ff788d089a
ospfd: minor parser fixes
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-29 17:37:07 +00:00
Quentin Young
692b4c6594
ospfd: resolve CHECK ME's
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-29 01:26:55 +00:00
Daniel Walton
d04c479dd9
bgpd: change some <1-10> to (1-10>
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-28 05:07:45 +00:00
Quentin Young
b62ecea584
zebra: finish all zebra CHECK ME's
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-28 04:47:43 +00:00
Quentin Young
c8952fc122
ripngd: finish CHECK ME's in ripngd
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-27 21:13:29 +00:00
Quentin Young
481af2edcb
ripngd: dispose of some CHECK ME's for ripng
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-27 21:02:42 +00:00
Quentin Young
4f026db15a
ripd: argv not argc
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-27 17:51:06 +00:00
Quentin Young
8b57682576
ripd: resolve rip_routemap.c CHECK ME's
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-27 17:48:05 +00:00
Quentin Young
0157c32771
lib: reformat vty.h
...
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2016-09-27 17:14:07 +00:00
Daniel Walton
a4b2b61027
bgpd: fixed some bgp_routemap CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-27 13:24:19 +00:00
Daniel Walton
4c9bd27548
bgpd: fixed some bgp_routemap CHECK MEs
...
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2016-09-27 05:05:12 +00:00