proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-06 06:14:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
19,965 Commits 4 Branches 191 Tags 125 MiB
00580dacb4
Commit Graph

19965 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mark Stapp
00580dacb4 zebra: fix SA warning in zebra_rnh.c 
Fix an SA warning... that I introduced while resolving
a different SA warning.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2020-06-10 14:57:30 -04:00
Donald Sharp
10658ad30b
Merge pull request #6528 from mjstapp/fix_zebra_mpls_sa 
zebra: fix coverity SA warnings
 2020-06-10 13:57:02 -04:00
Donald Sharp
05e0e7dddc
Merge pull request #6555 from mjstapp/fix_ebgp_policy_topo_timeout 
tests: raise convergence timeout in bgp_ebgp_requires_policy
 2020-06-10 13:56:38 -04:00
Donald Sharp
e76f591d54
Merge pull request #6543 from volta-networks/fix_isis_afset_noarea 
isisd: fix segfault in isis_circuit_af_set
 2020-06-10 13:56:00 -04:00
Santosh P K
57dd2f0097
Merge pull request #6414 from opensourcerouting/nb-error-handling 
NB context + enhanced error handling
 2020-06-10 22:47:07 +05:30
Stephen Worley
5e0494b38a
Merge pull request #6465 from xThaid/iprules 
zebra: move ip rule installation to use dplane thread
 2020-06-10 12:35:36 -04:00
Donald Sharp
b71ca5ae42
Merge pull request #6460 from rgirada/ospf_external_lsa 
ospfd: External LSA lookup in LSDB failed in a specific scenario
 2020-06-10 12:35:17 -04:00
Mark Stapp
8e0991305d tests: raise convergence timeout in bgp_ebgp_requires_policy 
Timeout was 30 seconds, raise it to 130.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2020-06-10 11:01:47 -04:00
Emanuele Di Pascale
e8cff6d14c isisd: prevent segfault in isis_circuit_af_set 
before the last commit, it was possible under some
circumstances to call isis_circuit_af_set on a circuit
with a NULL area, e.g. if the circuit was deconfigured
due to a validation error. While this should not happen
now, let's add an explicit check to avoid crashing if
a regression is introduced.

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
 2020-06-10 16:34:33 +02:00
Emanuele Di Pascale
f6d9207dc9 isisd: keep circuit config on conf->up failure 
if we are not able to bring a circuit up due to some config
issue, e.g. a low MTU compared to the area lsp-mtu, we should
not remove the configuration, as this will push out of sync
with the YANG state and create more issues down the line.
Instead, keeping the circuit state at C_STATE_CONF should be
sufficient.

For the specific case of the MTU mismatch above, this also means
that when we receive a new IF_UP_FROM_Z when the MTU is changed
we will be able to bring the circuit up as we should.

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
 2020-06-10 16:34:33 +02:00
Jakub Urbańczyk
99e387d583 zebra: separate code encoding netlink msg 
Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
 2020-06-10 16:29:14 +02:00
Jakub Urbańczyk
9b7decf28e topotest: add pbr test suite 
Add some basic tests for installing PBR rules into the kernel.

Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
 2020-06-10 16:29:14 +02:00
Jakub Urbańczyk
f62e5480ec zebra: convert ip rule installation to use dplane thread 
* Implement new dataplane operations
 * Convert existing code to use dataplane context object
 * Modify function preparing netlink message to use dataplane
   context object

Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
 2020-06-10 16:18:45 +02:00
Jakub Urbańczyk
60d8d43be4 zebra: prepare dplane to deal with pbr rules 
This commit is the first step to convert IP rule installation to
use dplane thread.
 * Add dataplane's internal representation of a pbr rule
 * Add dplane stats related to rules
 * Introduce a new type of dplane operation

Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
 2020-06-10 16:18:45 +02:00
Donald Sharp
71af56b190
Merge pull request #6544 from mjstapp/fix_topo_lib_bgp_timeout 
tests: include lib/bgp.py convergence timeout to 130
 2020-06-10 09:19:26 -04:00
Donald Sharp
c78307d68d
Merge pull request #6493 from opensourcerouting/workflow-debian 
doc/workflow: write down debian/* branch semantics
 2020-06-10 08:15:35 -04:00
Mark Stapp
6bb1a16f83
Merge pull request #6532 from wesleycoakley/pbrd-moretopo 
tests: Expand pbrd topology tests
 2020-06-10 08:14:39 -04:00
Mark Stapp
bfab324148 tests: include lib/bgp.py convergence timeout to 130 
The convergence timeout in lib/bgp.py was something like 40 secs;
that's not really long enough for the CI. Raise the timeout to
40 x 3 secs.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2020-06-10 08:14:08 -04:00
Donald Sharp
44c10b1f49
Merge pull request #6537 from volta-networks/fix_isis_adj_up_init 
isisd: fix adj up->init transition
 2020-06-10 08:13:34 -04:00
Donald Sharp
5c83709171
Merge pull request #6550 from ton31337/fix/bgp_dampening_vty_bug 
bgpd: Duplicate `bgp dampening ...` stuff
 2020-06-10 08:12:01 -04:00
Mark Stapp
2896f40e69 zebra: fix coverity SA warnings 
Fix a few coverity warnings.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2020-06-10 08:11:54 -04:00
Mark Stapp
bdabd4b958
Merge pull request #6546 from opensourcerouting/topofixes-2 
topotests: stabilize ospf-sr
 2020-06-10 07:57:31 -04:00
Donald Sharp
2d8c1bc235
Merge pull request #5323 from opensourcerouting/filter-nb 
lib: migrate FRR filter to northbound
 2020-06-10 06:59:32 -04:00
Donatas Abraitis
ef5f4b2373 bgpd: Allow setting dampening for more address families 
Until now, it was possible to set only for ipv4 unicast/multicast.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2020-06-10 10:23:18 +03:00
Donatas Abraitis
8a4e7fe661 bgpd: Print dampening configuration per AF, not per neighbor 
This caused duplicate `bgp dampening ...` to be printed per neighbor.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2020-06-10 10:23:16 +03:00
Donatas Abraitis
c98fc35e6d
Merge pull request #6548 from qlyoung/alpine-chown 
docker: don't fail on chown /etc/frr
 2020-06-10 09:49:12 +03:00
Quentin Young
f44c7cde33 docker: don't fail on chown /etc/frr 
If we can chown /etc/frr then fine, but there's circumstances where we
won't be able to - for instance, if running FRR in Kubernetes where
/etc/frr/* is actually a virtual filesystem.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2020-06-10 00:20:04 -04:00
Rafael Zalamena
7f3197922e topotests: MPLS table output is not ordered 
Don't expect ordered output from `show mpls table json`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-09 18:45:29 -03:00
Emanuele Di Pascale
8cea006522 isisd: fix adj up->init transition 
there are some paths, e.g. when an established neighbor
sends us hellos with a different IS level, where we go
from adj_state UP to INIT. In such cases we might not
update our SPFs or the circuit state, as the state change
function was only testing for the UP and DOWN cases.

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
 2020-06-09 22:56:43 +02:00
Mark Stapp
fe171b4e1a
Merge pull request #6510 from donaldsharp/useful_timings 
tests: Allow a useful amount of time for bgp to converge
 2020-06-09 15:15:04 -04:00
Quentin Young
90a6646c01
Merge pull request #6332 from kssoman/fix 
bgpd: Avoid extra copy of received data to buffer
 2020-06-09 13:09:19 -04:00
Stephen Worley
3b99806d7f
Merge pull request #6494 from mjstapp/fix_if_del_addr 
zebra: include dest addr when deleting p2p from interface
 2020-06-09 12:04:33 -04:00
Donald Sharp
0da93db878
Merge pull request #6533 from opensourcerouting/topofixes 
topotests: stabilize ospf-sr-topo1
 2020-06-09 10:29:18 -04:00
Russ White
a631911458
Merge pull request #6512 from donaldsharp/pim_missed_merge 
Pim missed merge
 2020-06-09 08:01:16 -04:00
Russ White
58ef49eb43
Merge pull request #6529 from ton31337/fix/refcnt_check_for_dep_data_route-map 
lib: Make sure route_map_dep_data is not NULL before decrementing refcount
 2020-06-09 08:00:00 -04:00
Russ White
e5f51bc579
Merge pull request #6536 from NaveenThanikachalam/gr 
bgpd: Update GR flags when peer is bound to group
 2020-06-09 07:40:27 -04:00
Naveen Thanikachalam
0c0b85b502 bgpd: Update GR flags when peer is bound to group 
When a peer is bound to a peer-group, the GR flags set on the
peer are over-written.
Update the GR flags for the peer after it has been bound to a
peer-group.

Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
 2020-06-09 02:08:51 -07:00
Rafael Zalamena
19d4fe6566 topotests: stabilize ospf-sr-topo1 run 
Use `json_cmp` instead of raw text comparison. It should fix some of the
ordering problems we are seeing in CI runs.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-08 16:14:41 -03:00
Rafael Zalamena
c2088e52fc topotests: remove old FRR version check 
Topotest is now part of FRR repo and the code is versioned with the
tests.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-08 16:13:25 -03:00
Wesley Coakley
11e33e0075 tests: pbr topotest verifying vrf functionality 
Creates a VRF in the kernel and tests areas of pbrd not covered before

Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
 2020-06-08 14:27:29 -04:00
Wesley Coakley
b046dc8716 tests: pbr topotest flaps ifaces, maps, nh-groups 
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
 2020-06-08 14:27:21 -04:00
Wesley Coakley
38b5ed4b42 tests: pbr topotests variety of maps and nh-groups 
Signed-off-by: Wesley Coakley <wcoakley@cumulusnetworks.com>
 2020-06-08 14:12:46 -04:00
Donatas Abraitis
c415a4dcd4 lib: Make sure route_map_dep_data is not NULL before decrementing refcount 
```
2  0x00007fb9adb07a10 in core_handler (signo=11, siginfo=0x7ffe1414a630, context=<optimized out>) at lib/sigevent.c:228
        sa_default = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0}, sa_mask = {__val = {0 <repeats 16 times>}}, sa_flags = 0, sa_restorer = 0x0}
        sigset = {__val = {8192, 0 <repeats 15 times>}}
3  <signal handler called>
No locals.
4  route_map_dep_update (type=RMAP_EVENT_CLIST_DELETED, rmap_name=0x55d807ddd410 "export4-as49917", dep_name=<optimized out>, dephash=0x55d807adf170) at lib/routemap.c:2750
        dep = 0x55d807d35b00
        dname = 0x55d8081ba560 "123:124"
        rname = 0x55d8081ba540 "export4-as49917"
        ret = 0
        dep_data = 0x0
        ret_dep_data = 0x0
        tmp_dep_data = {rname = 0x55d8081ba540 "export4-as49917", refcnt = 0}
5  route_map_upd8_dependency (type=RMAP_EVENT_CLIST_DELETED, arg=<optimized out>, rmap_name=0x55d807ddd410 "export4-as49917") at lib/routemap.c:2865
        upd8_hash = 0x55d807adf170
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2020-06-08 16:15:43 +03:00
Renato Westphal
993db04388
Merge pull request #6182 from Orange-OpenSource/dev_ospf_sr 
OSPF: Add ECMP support to Segment Routing
 2020-06-06 21:29:43 -03:00
Sri Mohana Singamsetty
1163ddbfec
Merge pull request #6507 from donaldsharp/extcommunity_bgp 
bgpd: Actually find the sequence number for `bgp extcommunity-list...`
 2020-06-06 14:13:29 -07:00
Renato Westphal
a6d5dfe8ef
Merge pull request #6521 from donaldsharp/memory_wumps 
zebra: nhlfe_alloc should not fail
 2020-06-05 20:03:35 -03:00
Renato Westphal
7f4985f6e3
Merge pull request #6516 from qlyoung/fix-northbound-userdata-disappearance 
lib: move all userdata when changing node xpath
 2020-06-05 20:00:38 -03:00
Rafael Zalamena
49e3e49d72 lib: use relative XPath to filter entry attributes 
We can avoid a big amount of `snprintf` by using relative XPath in
`nb_cli_apply_changes`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-05 16:42:16 -03:00
Rafael Zalamena
84fdeb2015 lib: filter remove extra CLI transaction 
`acl_get_seq` should be able to get the sequence number from candidate
configuration without needing to commit anything midway.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-05 16:42:16 -03:00
Rafael Zalamena
664ae7953a lib: filter remove unused variable 
Remove variable that is not being used.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2020-06-05 16:42:16 -03:00