proxmox-mirrors/mirror_corosync
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_corosync synced 2025-08-14 15:02:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,917 Commits 1 Branch 64 Tags 16 MiB
fd20c4e799
Commit Graph

1917 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jim Meyering
fd20c4e799 logsys.c: avoid possibility of buffer overrun 
* exec/logsys.c (strcpy_cutoff): Add buf_len parameter, and never
write more than this number of bytes into "dest".
Change type of "cutoff" parameter from int to size_t.
Sentinel value changes from -1 to 0.
(log_printf_to_logs): Adapt to those changes.
Reverse condition of test so the much-shorter block is the "if-block".
Factor out a common subexpression for readability.
Exit the loop if output_buffer_idx ever reaches sizeof(output_buffer).

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2178 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-12 08:35:17 +00:00
Jim Meyering
d04702854b logsys.c: avoid redundant strlen in else-block 
* exec/logsys.c (strcpy_cutoff): Also, with a field width (aka cutoff),
and a shorter-than-field-width string, don't write the same memory
twice: once with strncpy using NUL bytes, then again with spaces
via the memset.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2177 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-12 08:35:09 +00:00
Jim Meyering
fbbc934196 logsys.c: factor out some duplication 
* exec/logsys.c (log_printf_to_logs): Factor out repeated calls to
strcpy_cutoff.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2176 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-12 08:35:01 +00:00
Fabio M. Di Nitto
6a9ebd8297 Add debugging code to logsys. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2175 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-12 05:36:09 +00:00
Jim Meyering
f6de37231d totemnet.c: Make totemnet_initialize definition match just-changed decl. 
* exec/totemnet.c (totemnet_initialize): Declare deliver_fn's msg_len
parameter to be of type "unsigned int" (not size_t) to match decl.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2174 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-11 17:40:42 +00:00
Fabio M. Di Nitto
4572f1124a Fix logging date format and add missing daemon name 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2173 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-11 08:17:53 +00:00
Steven Dake
20d1d5faf7 Remove most iovector-ized functionality from totem and only make one malloc 
and memory copy call in totemsrp_mcast.  The rest of the stack minus totempg
then uses zero copies.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2172 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-09 17:23:17 +00:00
Jim Meyering
6cee2d234d fix missing-dependency bug, so as not to install bogus .pc files 
* pkgconfig/Makefile.am (all .pc files): Depend on Makefile, so that
a change in $(prefix) there provokes regeneration of these files.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2170 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-06 06:54:07 +00:00
Jim Meyering
29c015615d votequorum.c: avoid a new warning and add a comment in cpg.h 
* votequorum.c: Avoid declaration of unused: ‘votequorum_instance_destructor’
* include/corosync/cpg.h (cpg_deliver_fn_t) [msg]: Add a comment explaining
why this member is not const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2169 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-04 12:45:45 +00:00
Jim Meyering
621d734e7c avoid 'incompatible pointer type' compiler warning 
* test/cpgverify.c (cpg_deliver_fn): Remove const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2168 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-04 12:37:27 +00:00
Angus Salkeld
24797e6623 add NTF_SERVICE to the service list 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2167 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-05-04 08:56:24 +00:00
Steven Dake
19a49ecdce Do checking of handle code after we verify that handle could actually be 
in the handle database.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2166 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-30 00:14:08 +00:00
Steven Dake
bf624c727d Implement thread saftey in corosync trunk. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2165 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-29 07:21:21 +00:00
Steven Dake
73cb3ae590 Fix leak caused by invalid put in hdb_handle_destroy. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2164 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-29 07:14:36 +00:00
Andrew Beekhof
28df983127 Call all configured exec_dump_fn's when SIGUSR2 is received 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2163 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-28 14:05:52 +00:00
Steven Dake
2274c6c961 Add cpgverify program to test directory. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2162 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-28 06:45:26 +00:00
Andrew Beekhof
ed836321a4 Minor fixes to the build process on OSX 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2161 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-27 14:51:05 +00:00
Fabio M. Di Nitto
490c262b3e Fix debug: on option for logging purposes 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2160 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-27 11:37:59 +00:00
Fabio M. Di Nitto
21902efa1b add max limit error checks in logsys 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2159 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-27 11:36:53 +00:00
Steven Dake
0d5a6e83b4 Add mechanism to use logsysrec from inside totem stack. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2157 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-27 05:17:40 +00:00
Steven Dake
695ed267af Improve security of NSS implementation in totem. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2156 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-27 05:01:25 +00:00
Steven Dake
aac910832c Fix evsverify failure. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2155 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 12:39:54 +00:00
Fabio M. Di Nitto
8edb8c61ad Fix --enable-nss default in configure.ac 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2154 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 06:26:12 +00:00
Steven Dake
3074491eb9 Make libnss detection work properly. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2153 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 05:22:24 +00:00
Fabio M. Di Nitto
a9aff82b56 Fix pkgconfig file inclusion into release and pass distcheck 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2152 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 04:52:26 +00:00
Steven Dake
9182da81a6 add Chrissie as author of totem NSS implementation. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2151 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 02:42:05 +00:00
Steven Dake
d72f0cc03c Remove const from delivery callback to allow inplace endian changes of 
message contents.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2150 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 02:38:46 +00:00
Steven Dake
bba93f5402 remove "AIS" from cfg.h header file. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2149 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 02:24:43 +00:00
Steven Dake
380b7e8b7b Allow CPP linkage by adding extern "C" {} to external header files. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2148 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 02:08:18 +00:00
Steven Dake
d18ff2aeef remove config.h from public header file. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2147 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 01:58:49 +00:00
Steven Dake
0986c30320 Remove useless APIs from coroipcs.c related to handling of overload 
conditions.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2146 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-26 01:20:09 +00:00
Christine Caulfield
e9660ee62f Add libnss security support to corosync. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2145 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-25 14:05:27 +00:00
Fabio M. Di Nitto
bc7939d8de Bump SONAME to 4.0.0 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2144 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-24 10:06:57 +00:00
Jim Meyering
0b264ba292 logsys.c: avoid an unnecessary strlen call 
* exec/logsys.c (strcpy_cutoff): Use strlen, then memcpy,
not strcpy, then strlen.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2143 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-24 09:55:21 +00:00
Jan Friesse
8abcce36f6 Add Jan Friesse (me) to the list of Corosync authors 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2142 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-24 07:06:30 +00:00
Steven Dake
e9d718d01d Remove mempool since it is unused and isn't going to be a feature in 
this release.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2141 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 19:39:20 +00:00
Steven Dake
bc636acac7 add request_shutdown call to coroapi. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2140 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 19:34:26 +00:00
Steven Dake
2505b53703 Add logsys yield counter for the logsys thread. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2139 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 19:21:35 +00:00
Jim Meyering
32f115e924 corosync.pc.in: Define Cflags 
* pkgconfig/corosync.pc.in (Cflags): Define.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2138 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 18:55:15 +00:00
Jim Meyering
17a3979ba9 pkgconfig: correct and clean up Makefile.am 
* pkgconfig/Makefile.am: Factor, add missing deps.
(pkgconf_LIBS): Remove unused var.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2137 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 18:55:06 +00:00
Steven Dake
f5c3bcad46 Modify property of loc script to be executable. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2136 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 17:37:32 +00:00
Steven Dake
e5c721e381 remove rmd.h header file. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2135 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 17:32:57 +00:00
Steven Dake
51ef3b5c00 Include file cleanups. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2134 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 17:03:21 +00:00
Steven Dake
97f49b8557 Cleanup coroipcc.h header file to remove saHandleXXX and friends. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2133 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 16:19:49 +00:00
Steven Dake
589d2ae1af coroipcs.h cleanup. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2132 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 16:13:24 +00:00
Christine Caulfield
4bfbee7dd8 This patch removes the (now redundant) call to sync_primary_callback_fn 
when quorum changes.

As we established a while ago, quorum is independent of sync and all
this code does is segfault when called!



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2131 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 15:51:41 +00:00
Steven Dake
ed7d054e55 Remove priority inversion in logsys. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2130 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 15:24:29 +00:00
Jim Meyering
e512d1f811 exec/Makefile.am: require that copied code stays in sync 
* exec/Makefile.am (check_logsys_log_printf_functions): New rule.
(check): Depend on check_logsys_log_printf_functions.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2129 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 14:16:01 +00:00
Jim Meyering
85d1e26bb1 logsys.c: indent consistently 
* exec/logsys.c (_logsys_log_printf): Indent with TABs to be
consistent with copied-from function, _logsys_log_vprintf.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2128 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 14:15:53 +00:00
Jan Friesse
0dc4aed441 Make ipc_log_printf function working by adding _logsys_log_vprintf, which 
is mostly same as _logsys_log_printf but takes va_list as argument.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2127 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-04-23 12:29:26 +00:00