Steven Dake
e94b3dd811
Patch from Honza:
...
Send CPG_REASON_PROCDOWN on process left
Our manual pages are clear:
CPG_REASON_PROCDOWN - the process left a group without calling
cpg_leave().
Currently, we are sending CPG_REASON_LEAVE in such situation.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2946 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-15 19:35:32 +00:00
Christine Caulfield
bc1cca69b3
object_key_iter() calls object_key_iter_typed() and then always tries to
...
dereference the string it returns, even if the call fails. The attached
patch fixes this.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2944 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-15 15:48:58 +00:00
Steven Dake
583eb6aea5
changes to corosync.spec.in template:
...
Move configure to %build section
don't set corosync's init levels during an upgrade of the corosync package
Patch from Vadym Chepkov
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2943 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-10 01:18:27 +00:00
Steven Dake
d5ba2d38c1
update version to 1.2.4.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2939 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-09 21:56:37 +00:00
Steven Dake
402c553dd2
Update logsys to use proper ring buffer on file backed map
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2922 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-09 20:14:50 +00:00
Angus Salkeld
f113c5b130
Disable test while I fix it.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2921 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-06 22:17:51 +00:00
Steven Dake
b8af7c3764
sem_wait can be interrupted by signal. Handle interruption properly.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2920 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-03 22:05:17 +00:00
Steven Dake
22471e113d
Fix fail to receive logic which occurs very rarely on high loss networks with
...
software based multicast.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2919 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-03 21:36:21 +00:00
Angus Salkeld
5e1bac5877
temporarily remove a cts test case.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2918 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-02 03:18:10 +00:00
Steven Dake
79c60fd0ad
Totem spec is clear:
...
reject retransmitted tokens
if token.aru = aru in token on last rotation ... do some logic
Here is how the current code works:
last_aru = instance->my_last_aru;
instance->my_last_aru = token->aru;
reject retransmitted tokens
if token.aru = aru in token on last rotation ... do some logic
The issue is last_aru will be set to token->aru when a token retransmission
occurs before a new token arrives.
This results in the "do some logic" part happening more often then it should.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2917 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-01 20:35:53 +00:00
Steven Dake
3b457d30c7
Fix problem where callbacks are not delivered to evs service.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2916 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-06-01 15:36:08 +00:00
Steven Dake
c3a6b98bdc
The static function 'decode_mode()' is used by the static function
...
'dump_subsys_config()' which is is turn used by the static function
'dump_full_config()' which is never used.
Are these functions used by someone using some magic? I did not find
any reference and even the flag LOGSYS_DEBUG, which prevents them from
compiling, does not exist at some other point.
If these functions are really not used, please remove them (because at
least one of them has a buffer overflow). Patch against 1.2.3
is attached.
If there is a need for these functions, I'll send a patch to fix
the 'decode_mode()' function.
Kind regards
Andreas Florath
Signed-off-by: Andreas Florath <gnu4u at flonatel dot org>
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2915 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-28 20:39:58 +00:00
Angus Salkeld
d655a79c6c
Add a man page for corosync-quorumtool
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2914 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:56:38 +00:00
Angus Salkeld
3a2771d012
Add a man page for corosync-pload
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2913 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:55:55 +00:00
Angus Salkeld
54fe60a608
Add man page for corosync-fplay.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2912 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:55:22 +00:00
Angus Salkeld
b7ed806439
Add man page for corosync-cpgtool
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2911 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:54:32 +00:00
Angus Salkeld
de317d57e2
Add man page for corosync-cfgtool
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2910 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:52:53 +00:00
Angus Salkeld
fe4f55846a
Really corosync-keygen.8
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2909 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:51:52 +00:00
Angus Salkeld
52632075ed
Add a man page for corosync-keygen and update corosync_overview
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2908 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 23:49:00 +00:00
Jan Friesse
1d1c3059ad
coroipcc - don't loop forever on EINTR
...
This patch unify behaviour of SYS V semaphores and POSIX semaphores.
POSIX semaphores never return CS_ERR_TRY_AGAIN on EINTR and keeps
waiting. This was fixed for SYS V semaphores in rev. 2303.
Another change is to remove very small probability of hung forever in
coroipcc_dispatch_put.
Last change is removal of duplicate code by adding ipc_sem_wait function.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2907 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-27 08:05:31 +00:00
Steven Dake
4561c6dcf6
Fix problem where memcpy operation occurs incorrectly to copy schedule
...
parameter data resulting in priority inversion deadlocks on single cpu systems.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2906 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-26 17:47:39 +00:00
Angus Salkeld
a5d6c5f151
makefile: add -lquorum -lcoroipcc to sam test programs
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2905 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-21 08:53:52 +00:00
Angus Salkeld
bed7002213
Autobuild: add -v option to mock
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2904 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-21 08:53:17 +00:00
Steven Dake
68c580fc54
Bump revision to 1.2.3.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2901 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 14:01:06 +00:00
Steven Dake
d209f7bb27
Fix leak in error path in nss encryption.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2857 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 05:30:18 +00:00
Steven Dake
9ad14156c6
This patch updates the wording for the bindnetaddr option
...
in corosync.conf to explicitly state that you need to use
the network address, as opposed to "should always end in
zero", which is only correct for class C networks.
Regards,
Tim
--
Tim Serong <tserong@novell.com>
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2856 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 05:26:13 +00:00
Steven Dake
0e9f0bfeb4
Make cpg_membership_get() functional.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2855 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 05:03:52 +00:00
Angus Salkeld
7999995273
cov 10412: fix mem leak in encrypt_and_sign_nss()
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2854 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 04:35:25 +00:00
Angus Salkeld
4ff33854ad
add __attribute__((noreturn)) to functions that always exit.
...
we had some __attribute__((__noreturn__))
and some __attribute__((noreturn))
I made them all: __attribute__((noreturn))
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2853 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-19 04:34:53 +00:00
Steven Dake
02cddf6854
Fix free of ring status information when memory allocation fails during
...
allocation of the ring status information.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2852 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 17:20:05 +00:00
Steven Dake
6d79a218e2
Fix signed comparison with unsigned value in mainconfig.c
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2851 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 16:44:59 +00:00
Angus Salkeld
0c790c067a
cov 10388: fix check for no mcast address
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2850 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:46:35 +00:00
Angus Salkeld
ad71b66c7b
cov (many): make sure all _set() functions return a signed int
...
in the body it can return -1, and callers check for -1.
but the return type is unsigned int?
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2849 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:46:08 +00:00
Angus Salkeld
2a23dfc585
cov 10391: allow assert to check for a negative number
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2848 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:43:41 +00:00
Angus Salkeld
8236a0873e
cov 10404: don't assign loc pointer when not used.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2847 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:14:02 +00:00
Steven Dake
d4f92c864a
Fix problem where logsys messages are not flushed at exit before worker thread
...
is created.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2846 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:13:54 +00:00
Angus Salkeld
92985c31d9
cov 10405: remove unused pointer from totemsrp.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2845 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-18 00:12:52 +00:00
Angus Salkeld
b1d84f9ecc
cov 10373: check poll return value
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2844 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 23:35:45 +00:00
Angus Salkeld
18a1ea648b
Fix compile error in services/cfg.c
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2843 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 22:23:25 +00:00
Angus Salkeld
18326ad242
cov 10392: remove pointless assert
...
backlog is unsigned
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2842 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:40:19 +00:00
Angus Salkeld
71a09466e4
cov 10413: crypto init a variable.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2841 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:36:51 +00:00
Angus Salkeld
b2a304d8f8
cov (10387, 10397): cleanup memory mapping functions
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2840 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:35:52 +00:00
Angus Salkeld
0886c03881
cov 10374: check sam_hc_send() before counter++
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2839 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:34:41 +00:00
Angus Salkeld
d08c6d577f
cov 10399: set the msg_flags to 0 in coroipcs.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2838 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:33:32 +00:00
Angus Salkeld
25a3d310ac
cov 10390: remove pointless assert.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2837 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:32:21 +00:00
Angus Salkeld
43d4f9d040
cov 10389: remove unneccessary check.
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2836 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:31:28 +00:00
Angus Salkeld
2f21e126be
cov 10371: check return of lcr_ifact_reference
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2835 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:29:30 +00:00
Angus Salkeld
5eba844916
cov 10401: error_string never set
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2834 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:28:13 +00:00
Angus Salkeld
202de1b8e2
cov 10411: fix leak in totemudp.c
...
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2833 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:26:15 +00:00
Angus Salkeld
ff8d0084cb
cov 10400: unit'ed variable.
...
not important, easy to fix.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2832 fd59a12c-fef9-0310-b244-a6a79926bd2f
2010-05-16 21:25:33 +00:00