proxmox-mirrors/mirror_corosync
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_corosync synced 2025-10-27 22:57:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

config: Handle totem_set_volatile_defaults errors

Browse Source 
When totem_set_volatile_defaults is called from totem_config_validate
return code is unchecked.

It's then perfectly possible to set (for example) join timeout to very
small value (1) and consensus value is then set to 0 making corosync
unable to create membership.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
This commit is contained in:
Jan Friesse 2014-03-12 12:59:30 +01:00
parent e1801ba497
commit 2f0cad20a9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
exec/totemconfig.c
View File

@ -1007,7 +1007,9 @@ int totem_config_validate (
goto parse_error;
}
totem_set_volatile_defaults(totem_config, error_string);
if (totem_set_volatile_defaults(totem_config, error_string) == -1) {
return (-1);
}
/*
* RRP values validation