From 2f0cad20a9a368683fd59a869b2cb360bd31f95b Mon Sep 17 00:00:00 2001 From: Jan Friesse Date: Wed, 12 Mar 2014 12:59:30 +0100 Subject: [PATCH] config: Handle totem_set_volatile_defaults errors When totem_set_volatile_defaults is called from totem_config_validate return code is unchecked. It's then perfectly possible to set (for example) join timeout to very small value (1) and consensus value is then set to 0 making corosync unable to create membership. Signed-off-by: Jan Friesse Reviewed-by: Christine Caulfield --- exec/totemconfig.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index c17c6735..7180646d 100644 --- a/exec/totemconfig.c +++ b/exec/totemconfig.c @@ -1007,7 +1007,9 @@ int totem_config_validate ( goto parse_error; } - totem_set_volatile_defaults(totem_config, error_string); + if (totem_set_volatile_defaults(totem_config, error_string) == -1) { + return (-1); + } /* * RRP values validation