proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-05 20:33:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

submodule: don't double free during load failure

Browse Source 
When we fail to load submodules, don't free the list; it is later freed
unconditionally.
This commit is contained in:
Edward Thomson 2017-01-22 00:30:02 +00:00
parent 1196807380
commit 0fbff82b57
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/submodule.c
View File

@ -188,8 +188,7 @@ static int load_submodule_names(git_strmap *out, git_config *cfg)
git_buf_put(&buf, fdot + 1, ldot - fdot - 1); git_buf_put(&buf, fdot + 1, ldot - fdot - 1);
git_strmap_insert(out, entry->value, git_buf_detach(&buf), rval); git_strmap_insert(out, entry->value, git_buf_detach(&buf), rval);
if (rval < 0) { if (rval < 0) {
giterr_set(GITERR_NOMEMORY, "Error inserting submodule into hash table"); giterr_set(GITERR_NOMEMORY, "error inserting submodule into hash table");
free_submodule_names(out);
return -1; return -1;
} }
} }