From 0fbff82b579ae4bb764a293e9f4ef543c549ba2b Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Sun, 22 Jan 2017 00:30:02 +0000 Subject: [PATCH] submodule: don't double free during load failure When we fail to load submodules, don't free the list; it is later freed unconditionally. --- src/submodule.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/submodule.c b/src/submodule.c index e1f59b88e..9e007df2b 100644 --- a/src/submodule.c +++ b/src/submodule.c @@ -188,8 +188,7 @@ static int load_submodule_names(git_strmap *out, git_config *cfg) git_buf_put(&buf, fdot + 1, ldot - fdot - 1); git_strmap_insert(out, entry->value, git_buf_detach(&buf), rval); if (rval < 0) { - giterr_set(GITERR_NOMEMORY, "Error inserting submodule into hash table"); - free_submodule_names(out); + giterr_set(GITERR_NOMEMORY, "error inserting submodule into hash table"); return -1; } }